[Lldb-commits] [PATCH] D120690: [PDB] Add char8_t type
ljmf00 added a comment. Thanks for adding this, I ended up forgoting, since I don't use PDB. Comment at: lldb/include/lldb/lldb-enumerations.h:752 eBasicTypeChar32, + eBasicTypeChar8, eBasicTypeShort, You forgot to add it to the Python API. It should also be added at the end to avoid user-code breakage. See D116136 . I can rebase my change and correct this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120690/new/ https://reviews.llvm.org/D120690 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D121064: [lldb] Add a setting to change the autosuggestion ANSI escape codes
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! FWIW, if you have `fish` installed you might wanna check what they are doing on your terminal for its autosuggestions (and we might wanna steal their default, even though I thought this was 'faint'). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121064/new/ https://reviews.llvm.org/D121064 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
