[Lldb-commits] [lldb] 05cd79d - [lldb] Fix some accidental IntervalMap copies

[Benjamin Kramer via lldb-commits]

Author: Benjamin Kramer
Date: 2022-02-19T20:56:03+01:00
New Revision: 05cd79d59900ac57a94a0699594163689606b336

URL: 
https://github.com/llvm/llvm-project/commit/05cd79d59900ac57a94a0699594163689606b336
DIFF: 
https://github.com/llvm/llvm-project/commit/05cd79d59900ac57a94a0699594163689606b336.diff

LOG: [lldb] Fix some accidental IntervalMap copies

I made that type non-copyable in some cases in dc4f9f0368cd

Added: 


Modified: 
lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

Removed: 




diff  --git a/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp 
b/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
index a1ff6adea1202..f9929aed06ecf 100644
--- a/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
+++ b/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
@@ -1679,8 +1679,8 @@ class VMAddressProvider {
   ObjectFile::Type ObjectType;
   addr_t NextVMAddress = 0;
   VMMap::Allocator Alloc;
-  VMMap Segments = VMMap(Alloc);
-  VMMap Sections = VMMap(Alloc);
+  VMMap Segments{Alloc};
+  VMMap Sections{Alloc};
   lldb_private::Log *Log = GetLog(LLDBLog::Modules);
   size_t SegmentCount = 0;
   std::string SegmentName;



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

[serge via Phabricator via lldb-commits]

serge-sans-paille created this revision.
serge-sans-paille added reviewers: RKSimon, MaskRay, lenary.
Herald added a subscriber: hiraditya.
serge-sans-paille requested review of this revision.
Herald added projects: LLDB, LLVM.
Herald added subscribers: llvm-commits, lldb-commits.

accumulated preprocessed size:
before: 1065515095
after: 1065629059

Discourse thread: 
https://discourse.llvm.org/t/include-what-you-use-include-cleanup


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D120195

Files:
  lld/COFF/PDB.cpp
  lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
  lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
  llvm/include/llvm/DebugInfo/MSF/MSFBuilder.h
  llvm/include/llvm/DebugInfo/PDB/Native/DbiModuleDescriptorBuilder.h
  llvm/include/llvm/DebugInfo/PDB/Native/DbiStreamBuilder.h
  llvm/include/llvm/DebugInfo/PDB/Native/GSIStreamBuilder.h
  llvm/include/llvm/DebugInfo/PDB/Native/InfoStreamBuilder.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeEnumGlobals.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeEnumLineNumbers.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeEnumSymbols.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeEnumTypes.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeExeSymbol.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeFunctionSymbol.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeInlineSiteSymbol.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeLineNumber.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativePublicSymbol.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeSession.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeSourceFile.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeSymbolEnumerator.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeTypeEnum.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeTypeFunctionSig.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeTypePointer.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeTypeTypedef.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeTypeUDT.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeTypeVTShape.h
  llvm/include/llvm/DebugInfo/PDB/Native/PDBFileBuilder.h
  llvm/include/llvm/DebugInfo/PDB/Native/SymbolCache.h
  llvm/include/llvm/DebugInfo/PDB/Native/TpiStreamBuilder.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbol.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolAnnotation.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolBlock.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolCompilandDetails.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolCompilandEnv.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolCustom.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolData.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolFunc.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolFuncDebugEnd.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolFuncDebugStart.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolLabel.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolPublicSymbol.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolThunk.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeArray.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeBaseClass.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeBuiltin.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeCustom.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeDimension.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeEnum.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeFriend.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeFunctionArg.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeManaged.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypePointer.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeTypedef.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeUDT.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeVTable.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeVTableShape.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolUnknown.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolUsingNamespace.h
  llvm/include/llvm/DebugInfo/PDB/UDTLayout.h
  llvm/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp
  llvm/lib/DebugInfo/MSF/MappedBlockStream.cpp
  llvm/lib/DebugInfo/PDB/Native/DbiModuleDescriptorBuilder.cpp
  llvm/lib/DebugInfo/PDB/Native/DbiStreamBuilder.cpp
  llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp
  llvm/lib/DebugInfo/PDB/Native/InfoStreamBuilder.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeCompilandSymbol.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeEnumGlobals.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeEnumLineNumbers.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeEnumModules.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeEnumSymbols.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeEnumTypes.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeExeSymbol.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeInlineSiteSymbol.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeLineNumber.cpp
  llvm/lib/DebugInfo/PDB/Native/NativePublicSymbol.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeRawSymbol.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeSession.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeSourceFile.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeS

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

[Fangrui Song via Phabricator via lldb-commits]

MaskRay added a comment.

  before: 1065515095
  after: 1065629059

An increase?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120195/new/

https://reviews.llvm.org/D120195

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

[Fangrui Song via Phabricator via lldb-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

It'd be good to test `-DLLVM_ENABLE_MODULES=on` build.

Some files get pure new headers. I still think it is good thing to do it 
separately. There is a risk that someone may revert the change if it breaks 
some build modes.
Splitting the change can be mechanical, perhaps with some git commands to 
detect what files get pure addition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120195/new/

https://reviews.llvm.org/D120195

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits