[Lldb-commits] [PATCH] D102544: [lldb] Document ctrl-f for completing show-autosuggestion

[Dave Lee via Phabricator via lldb-commits]

kastiglione updated this revision to Diff 345642.
kastiglione added a comment.

use "accepted" as the verb


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102544/new/

https://reviews.llvm.org/D102544

Files:
  lldb/source/Core/CoreProperties.td


Index: lldb/source/Core/CoreProperties.td
===
--- lldb/source/Core/CoreProperties.td
+++ lldb/source/Core/CoreProperties.td
@@ -138,5 +138,5 @@
   def ShowAutosuggestion: Property<"show-autosuggestion", "Boolean">,
 Global,
 DefaultFalse,
-Desc<"If true, LLDB will show suggestions to complete the command the user 
typed.">;
+Desc<"If true, LLDB will show suggestions to complete the command the user 
typed. Suggestions may be accepted using Ctrl-F.">;
 }


Index: lldb/source/Core/CoreProperties.td
===
--- lldb/source/Core/CoreProperties.td
+++ lldb/source/Core/CoreProperties.td
@@ -138,5 +138,5 @@
   def ShowAutosuggestion: Property<"show-autosuggestion", "Boolean">,
 Global,
 DefaultFalse,
-Desc<"If true, LLDB will show suggestions to complete the command the user typed.">;
+Desc<"If true, LLDB will show suggestions to complete the command the user typed. Suggestions may be accepted using Ctrl-F.">;
 }
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D102562: Fix to the interrupt timeout handling: reset the timeout on re-entry

[Jim Ingham via Phabricator via lldb-commits]

jingham created this revision.
jingham added reviewers: clayborg, JDevlieghere.
jingham requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

The new timeout handling missed one case where we need to reset the computed 
timeout: when a packet interrupts the Continue wait, but asks to re-enter the 
wait loop when done.

This is the only other way to get back to the ReadPacket call, so this is the 
only other place that requires reset.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102562

Files:
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp


Index: lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
===
--- lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
+++ lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
@@ -152,6 +152,10 @@
   OnRunPacketSent(false);
   break;
 }
+// If we get here, we were interrupted asynchronously, and told to resume
+// and continue waiting.  Reset the computed_timeout, since it might have
+// gotten shortened in waiting for the interrupt.
+computed_timeout = std::min(interrupt_timeout, kWakeupInterval);
   }
 }
 


Index: lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
===
--- lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
+++ lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
@@ -152,6 +152,10 @@
   OnRunPacketSent(false);
   break;
 }
+// If we get here, we were interrupted asynchronously, and told to resume
+// and continue waiting.  Reset the computed_timeout, since it might have
+// gotten shortened in waiting for the interrupt.
+computed_timeout = std::min(interrupt_timeout, kWakeupInterval);
   }
 }
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D102562: Fix to the interrupt timeout handling: reset the timeout on re-entry

[Jim Ingham via Phabricator via lldb-commits]

jingham updated this revision to Diff 345654.
jingham added a comment.

It's less error-prone if we just reset the timeout to the default when we wake 
up from ReadPacket.  This isn't an expensive operation...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102562/new/

https://reviews.llvm.org/D102562

Files:
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp


Index: lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
===
--- lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
+++ lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
@@ -61,6 +61,9 @@
kWakeupInterval);
   for (;;) {
 PacketResult read_result = ReadPacket(response, computed_timeout, false);
+// Reset the computed_timeout to the default value in case we are going
+// round again.
+computed_timeout = std::min(interrupt_timeout, kWakeupInterval);
 switch (read_result) {
 case PacketResult::ErrorReplyTimeout: {
   std::lock_guard lock(m_mutex);


Index: lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
===
--- lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
+++ lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
@@ -61,6 +61,9 @@
kWakeupInterval);
   for (;;) {
 PacketResult read_result = ReadPacket(response, computed_timeout, false);
+// Reset the computed_timeout to the default value in case we are going
+// round again.
+computed_timeout = std::min(interrupt_timeout, kWakeupInterval);
 switch (read_result) {
 case PacketResult::ErrorReplyTimeout: {
   std::lock_guard lock(m_mutex);
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits