[Lldb-commits] [lldb] db457e6 - [lldb] [Process/FreeBSD] Fix arm64 build after RegisterInfoPOSIX_arm64 changes

[Michał Górny via lldb-commits]

Author: Michał Górny
Date: 2021-05-01T22:50:49+02:00
New Revision: db457e64794ccbc248236c10333db9e13c082a78

URL: 
https://github.com/llvm/llvm-project/commit/db457e64794ccbc248236c10333db9e13c082a78
DIFF: 
https://github.com/llvm/llvm-project/commit/db457e64794ccbc248236c10333db9e13c082a78.diff

LOG: [lldb] [Process/FreeBSD] Fix arm64 build after RegisterInfoPOSIX_arm64 
changes

Commit 88a5b35d63f927db69ec953ff487a7ba2504a610 changed the API
of RegisterInfoPOSIX_arm64 and effectively broke the FreeBSD plugin.
Update it to work with the new API.

Differential Revision: https://reviews.llvm.org/D101521

Added: 


Modified: 
lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp

Removed: 




diff  --git 
a/lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp 
b/lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp
index e98e0a8a0caa7..4578138a89b39 100644
--- a/lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp
@@ -37,14 +37,12 @@ 
NativeRegisterContextFreeBSD::CreateHostNativeRegisterContextFreeBSD(
 NativeRegisterContextFreeBSD_arm64::NativeRegisterContextFreeBSD_arm64(
 const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
 : NativeRegisterContextRegisterInfo(
-  native_thread, new RegisterInfoPOSIX_arm64(target_arch))
+  native_thread, new RegisterInfoPOSIX_arm64(target_arch, 0))
 #ifdef LLDB_HAS_FREEBSD_WATCHPOINT
   ,
   m_read_dbreg(false)
 #endif
 {
-  GetRegisterInfo().ConfigureVectorRegisterInfos(
-  RegisterInfoPOSIX_arm64::eVectorQuadwordAArch64);
   ::memset(&m_hwp_regs, 0, sizeof(m_hwp_regs));
   ::memset(&m_hbp_regs, 0, sizeof(m_hbp_regs));
 }
@@ -79,8 +77,6 @@ Status 
NativeRegisterContextFreeBSD_arm64::ReadRegisterSet(uint32_t set) {
 return NativeProcessFreeBSD::PtraceWrapper(
 PT_GETFPREGS, m_thread.GetID(),
 m_reg_data.data() + sizeof(RegisterInfoPOSIX_arm64::GPR));
-  case RegisterInfoPOSIX_arm64::SVERegSet:
-return Status("not supported");
   }
   llvm_unreachable("NativeRegisterContextFreeBSD_arm64::ReadRegisterSet");
 }
@@ -94,8 +90,6 @@ Status 
NativeRegisterContextFreeBSD_arm64::WriteRegisterSet(uint32_t set) {
 return NativeProcessFreeBSD::PtraceWrapper(
 PT_SETFPREGS, m_thread.GetID(),
 m_reg_data.data() + sizeof(RegisterInfoPOSIX_arm64::GPR));
-  case RegisterInfoPOSIX_arm64::SVERegSet:
-return Status("not supported");
   }
   llvm_unreachable("NativeRegisterContextFreeBSD_arm64::WriteRegisterSet");
 }



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D101521: [lldb] [Process/FreeBSD] Fix arm64 build after RegisterInfoPOSIX_arm64 changes

[Michał Górny via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGdb457e64794c: [lldb] [Process/FreeBSD] Fix arm64 build after 
RegisterInfoPOSIX_arm64 changes (authored by mgorny).
Herald added a project: LLDB.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101521/new/

https://reviews.llvm.org/D101521

Files:
  lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp


Index: 
lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp
===
--- lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp
+++ lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp
@@ -37,14 +37,12 @@
 NativeRegisterContextFreeBSD_arm64::NativeRegisterContextFreeBSD_arm64(
 const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
 : NativeRegisterContextRegisterInfo(
-  native_thread, new RegisterInfoPOSIX_arm64(target_arch))
+  native_thread, new RegisterInfoPOSIX_arm64(target_arch, 0))
 #ifdef LLDB_HAS_FREEBSD_WATCHPOINT
   ,
   m_read_dbreg(false)
 #endif
 {
-  GetRegisterInfo().ConfigureVectorRegisterInfos(
-  RegisterInfoPOSIX_arm64::eVectorQuadwordAArch64);
   ::memset(&m_hwp_regs, 0, sizeof(m_hwp_regs));
   ::memset(&m_hbp_regs, 0, sizeof(m_hbp_regs));
 }
@@ -79,8 +77,6 @@
 return NativeProcessFreeBSD::PtraceWrapper(
 PT_GETFPREGS, m_thread.GetID(),
 m_reg_data.data() + sizeof(RegisterInfoPOSIX_arm64::GPR));
-  case RegisterInfoPOSIX_arm64::SVERegSet:
-return Status("not supported");
   }
   llvm_unreachable("NativeRegisterContextFreeBSD_arm64::ReadRegisterSet");
 }
@@ -94,8 +90,6 @@
 return NativeProcessFreeBSD::PtraceWrapper(
 PT_SETFPREGS, m_thread.GetID(),
 m_reg_data.data() + sizeof(RegisterInfoPOSIX_arm64::GPR));
-  case RegisterInfoPOSIX_arm64::SVERegSet:
-return Status("not supported");
   }
   llvm_unreachable("NativeRegisterContextFreeBSD_arm64::WriteRegisterSet");
 }


Index: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp
===
--- lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp
+++ lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp
@@ -37,14 +37,12 @@
 NativeRegisterContextFreeBSD_arm64::NativeRegisterContextFreeBSD_arm64(
 const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
 : NativeRegisterContextRegisterInfo(
-  native_thread, new RegisterInfoPOSIX_arm64(target_arch))
+  native_thread, new RegisterInfoPOSIX_arm64(target_arch, 0))
 #ifdef LLDB_HAS_FREEBSD_WATCHPOINT
   ,
   m_read_dbreg(false)
 #endif
 {
-  GetRegisterInfo().ConfigureVectorRegisterInfos(
-  RegisterInfoPOSIX_arm64::eVectorQuadwordAArch64);
   ::memset(&m_hwp_regs, 0, sizeof(m_hwp_regs));
   ::memset(&m_hbp_regs, 0, sizeof(m_hbp_regs));
 }
@@ -79,8 +77,6 @@
 return NativeProcessFreeBSD::PtraceWrapper(
 PT_GETFPREGS, m_thread.GetID(),
 m_reg_data.data() + sizeof(RegisterInfoPOSIX_arm64::GPR));
-  case RegisterInfoPOSIX_arm64::SVERegSet:
-return Status("not supported");
   }
   llvm_unreachable("NativeRegisterContextFreeBSD_arm64::ReadRegisterSet");
 }
@@ -94,8 +90,6 @@
 return NativeProcessFreeBSD::PtraceWrapper(
 PT_SETFPREGS, m_thread.GetID(),
 m_reg_data.data() + sizeof(RegisterInfoPOSIX_arm64::GPR));
-  case RegisterInfoPOSIX_arm64::SVERegSet:
-return Status("not supported");
   }
   llvm_unreachable("NativeRegisterContextFreeBSD_arm64::WriteRegisterSet");
 }
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits