[Lldb-commits] [PATCH] D99462: [lldb] Fix Error/assert.test regression with symbols

2021-03-28 Thread Jan Kratochvil via Phabricator via lldb-commits 
jankratochvil created this revision.
jankratochvil added a reviewer: JDevlieghere.
jankratochvil added a project: LLDB.
jankratochvil requested review of this revision.

  Failed Tests (1):
lldb-shell :: Error/assert.test

LLDB on Linux built with symbols is showing this error. I was not bisecting 
when it happened (my buildbot builds without symbols) but I find the fix 
obvious.
Without symbols it still PASSes:

  lldb-test: 
/home/jkratoch/redhat/llvm-monorepo/lldb/source/Utility/LLDBAssert.cpp:29: void 
lldb_private::lldb_assert(bool, const char *, const char *, const char *, 
unsigned int): Assertion `false && "lldb_assert failed"' failed.

With symbols it FAILs:

  lldb-test: 
/home/jkratoch/redhat/llvm-monorepo/lldb/tools/lldb-test/lldb-test.cpp:1086: 
int opts::assert::lldb_assert(lldb_private::Debugger &): Assertion `false && 
"lldb-test assert"' failed.

For the symbols build using:

  time cmake ../llvm-monorepo/llvm/ -DCMAKE_BUILD_TYPE=Debug 
-DLLVM_USE_LINKER=lld -DLLVM_ENABLE_PROJECTS="lldb;clang;lld" 
-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ 
-DLLVM_OPTIMIZED_TABLEGEN=ON -DLLVM_ENABLE_ASSERTIONS=ON 
-DLLVM_USE_SPLIT_DWARF=OFF -DCMAKE_CXX_FLAGS="-gsplit-dwarf=single" 
-DCMAKE_C_FLAGS="-gsplit-dwarf=single" -GNinja


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99462

Files:
  lldb/test/Shell/Error/assert.test


Index: lldb/test/Shell/Error/assert.test
===
--- lldb/test/Shell/Error/assert.test
+++ lldb/test/Shell/Error/assert.test
@@ -1,4 +1,4 @@
 # REQUIRES: asserts
 # RUN: not --crash lldb-test assert > %t.error 2>&1
 # RUN: cat %t.error | FileCheck %s
-# CHECK: "lldb_assert failed"
+# CHECK: "{{lldb_assert failed|lldb-test assert}}"' failed.


Index: lldb/test/Shell/Error/assert.test
===
--- lldb/test/Shell/Error/assert.test
+++ lldb/test/Shell/Error/assert.test
@@ -1,4 +1,4 @@
 # REQUIRES: asserts
 # RUN: not --crash lldb-test assert > %t.error 2>&1
 # RUN: cat %t.error | FileCheck %s
-# CHECK: "lldb_assert failed"
+# CHECK: "{{lldb_assert failed|lldb-test assert}}"' failed.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D99462: [lldb] Fix Error/assert.test regression with symbols

2021-03-28 Thread Jonas Devlieghere via Phabricator via lldb-commits 
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99462/new/

https://reviews.llvm.org/D99462

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6bc1e69 - [lldb] Fix Error/assert.test regression with symbols

2021-03-28 Thread Jan Kratochvil via lldb-commits 

Author: Jan Kratochvil
Date: 2021-03-29T08:16:43+02:00
New Revision: 6bc1e69de270db8d7191200f54158e4192f997ba

URL: 
https://github.com/llvm/llvm-project/commit/6bc1e69de270db8d7191200f54158e4192f997ba
DIFF: 
https://github.com/llvm/llvm-project/commit/6bc1e69de270db8d7191200f54158e4192f997ba.diff

LOG: [lldb] Fix Error/assert.test regression with symbols

LLDB on Linux built with symbols is showing this error.
Without symbols it still PASSes:
  lldb-test: .../lldb/source/Utility/LLDBAssert.cpp:29: void 
lldb_private::lldb_assert(bool, const char *, const char *, const char *, 
unsigned int): Assertion `false && "lldb_assert failed"' failed.

With symbols it FAILs:
  lldb-test: .../lldb/tools/lldb-test/lldb-test.cpp:1086: int 
opts::assert::lldb_assert(lldb_private::Debugger &): Assertion `false && 
"lldb-test assert"' failed.

Differential Revision: https://reviews.llvm.org/D99462

Added: 


Modified: 
lldb/test/Shell/Error/assert.test

Removed: 




diff  --git a/lldb/test/Shell/Error/assert.test 
b/lldb/test/Shell/Error/assert.test
index 92ccd134b92d..2585e64f3952 100644
--- a/lldb/test/Shell/Error/assert.test
+++ b/lldb/test/Shell/Error/assert.test
@@ -1,4 +1,4 @@
 # REQUIRES: asserts
 # RUN: not --crash lldb-test assert > %t.error 2>&1
 # RUN: cat %t.error | FileCheck %s
-# CHECK: "lldb_assert failed"
+# CHECK: "{{lldb_assert failed|lldb-test assert}}"' failed.



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D99462: [lldb] Fix Error/assert.test regression with symbols

2021-03-28 Thread Jan Kratochvil via Phabricator via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6bc1e69de270: [lldb] Fix Error/assert.test regression with 
symbols (authored by jankratochvil).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99462/new/

https://reviews.llvm.org/D99462

Files:
  lldb/test/Shell/Error/assert.test


Index: lldb/test/Shell/Error/assert.test
===
--- lldb/test/Shell/Error/assert.test
+++ lldb/test/Shell/Error/assert.test
@@ -1,4 +1,4 @@
 # REQUIRES: asserts
 # RUN: not --crash lldb-test assert > %t.error 2>&1
 # RUN: cat %t.error | FileCheck %s
-# CHECK: "lldb_assert failed"
+# CHECK: "{{lldb_assert failed|lldb-test assert}}"' failed.


Index: lldb/test/Shell/Error/assert.test
===
--- lldb/test/Shell/Error/assert.test
+++ lldb/test/Shell/Error/assert.test
@@ -1,4 +1,4 @@
 # REQUIRES: asserts
 # RUN: not --crash lldb-test assert > %t.error 2>&1
 # RUN: cat %t.error | FileCheck %s
-# CHECK: "lldb_assert failed"
+# CHECK: "{{lldb_assert failed|lldb-test assert}}"' failed.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits