[Lldb-commits] [lldb] 0cd8686 - [lldb] [Process/FreeBSD] Add more 'override' keywords

2020-12-13 Thread Michał Górny via lldb-commits 

Author: Michał Górny
Date: 2020-12-13T09:59:32+01:00
New Revision: 0cd8686043f962d20395fde382af3af14042d4ed

URL: 
https://github.com/llvm/llvm-project/commit/0cd8686043f962d20395fde382af3af14042d4ed
DIFF: 
https://github.com/llvm/llvm-project/commit/0cd8686043f962d20395fde382af3af14042d4ed.diff

LOG: [lldb] [Process/FreeBSD] Add more 'override' keywords

Added: 


Modified: 
lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp

Removed: 




diff  --git a/lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp 
b/lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp
index 2c7c948f1059..4637458b53c3 100644
--- a/lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp
@@ -215,7 +215,7 @@ class ReadOperation : public Operation {
   : m_addr(addr), m_buff(buff), m_size(size), m_error(error),
 m_result(result) {}
 
-  void Execute(ProcessMonitor *monitor);
+  void Execute(ProcessMonitor *monitor) override;
 
 private:
   lldb::addr_t m_addr;
@@ -240,7 +240,7 @@ class WriteOperation : public Operation {
   : m_addr(addr), m_buff(buff), m_size(size), m_error(error),
 m_result(result) {}
 
-  void Execute(ProcessMonitor *monitor);
+  void Execute(ProcessMonitor *monitor) override;
 
 private:
   lldb::addr_t m_addr;
@@ -303,7 +303,7 @@ class WriteRegOperation : public Operation {
 const RegisterValue &value, bool &result)
   : m_tid(tid), m_offset(offset), m_value(value), m_result(result) {}
 
-  void Execute(ProcessMonitor *monitor);
+  void Execute(ProcessMonitor *monitor) override;
 
 private:
   lldb::tid_t m_tid;
@@ -336,7 +336,7 @@ class ReadDebugRegOperation : public Operation {
   : m_tid(tid), m_offset(offset), m_size(size), m_value(value),
 m_result(result) {}
 
-  void Execute(ProcessMonitor *monitor);
+  void Execute(ProcessMonitor *monitor) override;
 
 private:
   lldb::tid_t m_tid;
@@ -369,7 +369,7 @@ class WriteDebugRegOperation : public Operation {
  const RegisterValue &value, bool &result)
   : m_tid(tid), m_offset(offset), m_value(value), m_result(result) {}
 
-  void Execute(ProcessMonitor *monitor);
+  void Execute(ProcessMonitor *monitor) override;
 
 private:
   lldb::tid_t m_tid;
@@ -400,7 +400,7 @@ class ReadGPROperation : public Operation {
   ReadGPROperation(lldb::tid_t tid, void *buf, bool &result)
   : m_tid(tid), m_buf(buf), m_result(result) {}
 
-  void Execute(ProcessMonitor *monitor);
+  void Execute(ProcessMonitor *monitor) override;
 
 private:
   lldb::tid_t m_tid;
@@ -426,7 +426,7 @@ class ReadFPROperation : public Operation {
   ReadFPROperation(lldb::tid_t tid, void *buf, bool &result)
   : m_tid(tid), m_buf(buf), m_result(result) {}
 
-  void Execute(ProcessMonitor *monitor);
+  void Execute(ProcessMonitor *monitor) override;
 
 private:
   lldb::tid_t m_tid;
@@ -448,7 +448,7 @@ class WriteGPROperation : public Operation {
   WriteGPROperation(lldb::tid_t tid, void *buf, bool &result)
   : m_tid(tid), m_buf(buf), m_result(result) {}
 
-  void Execute(ProcessMonitor *monitor);
+  void Execute(ProcessMonitor *monitor) override;
 
 private:
   lldb::tid_t m_tid;
@@ -470,7 +470,7 @@ class WriteFPROperation : public Operation {
   WriteFPROperation(lldb::tid_t tid, void *buf, bool &result)
   : m_tid(tid), m_buf(buf), m_result(result) {}
 
-  void Execute(ProcessMonitor *monitor);
+  void Execute(ProcessMonitor *monitor) override;
 
 private:
   lldb::tid_t m_tid;
@@ -492,7 +492,7 @@ class ResumeOperation : public Operation {
   ResumeOperation(uint32_t signo, bool &result)
   : m_signo(signo), m_result(result) {}
 
-  void Execute(ProcessMonitor *monitor);
+  void Execute(ProcessMonitor *monitor) override;
 
 private:
   uint32_t m_signo;
@@ -522,7 +522,7 @@ class SingleStepOperation : public Operation {
   SingleStepOperation(uint32_t signo, bool &result)
   : m_signo(signo), m_result(result) {}
 
-  void Execute(ProcessMonitor *monitor);
+  void Execute(ProcessMonitor *monitor) override;
 
 private:
   uint32_t m_signo;
@@ -549,7 +549,7 @@ class LwpInfoOperation : public Operation {
   LwpInfoOperation(lldb::tid_t tid, void *info, bool &result, int &ptrace_err)
   : m_tid(tid), m_info(info), m_result(result), m_err(ptrace_err) {}
 
-  void Execute(ProcessMonitor *monitor);
+  void Execute(ProcessMonitor *monitor) override;
 
 private:
   lldb::tid_t m_tid;
@@ -577,7 +577,7 @@ class ThreadSuspendOperation : public Operation {
   ThreadSuspendOperation(lldb::tid_t tid, bool suspend, bool &result)
   : m_tid(tid), m_suspend(suspend), m_result(result) {}
 
-  void Execute(ProcessMonitor *monitor);
+  void Execute(ProcessMonitor *monitor) override;
 
 private:
   lldb::tid_t m_tid;
@@ -596,7 +596,7 @@ class EventMessageOperation : public Operation {
   EventMessageOperation(lldb::tid_t tid, unsigned long *mes

[Lldb-commits] [PATCH] D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit

2020-12-13 Thread Pavel Labath via Phabricator via lldb-commits 
labath added a comment.

In D92187#2450526 , @mgorny wrote:

> Another fix: we should only unload duplicate ld.so if it's actually a 
> duplicate, i.e. the path differs. Otherwise, we've ended up unloading the 
> only copy.

Would comparing the module shared_pointers work? I think that's exactly what we 
want here. I think it's possible for `LoadModuleAtAddress` to return the same 
module, even with paths which don't match exactly. But if it does that, then we 
will still end up unloading the original interpreter module...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92187/new/

https://reviews.llvm.org/D92187

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit

2020-12-13 Thread Michał Górny via Phabricator via lldb-commits 
mgorny added a comment.

In D92187#2450976 , @labath wrote:

> In D92187#2450526 , @mgorny wrote:
>
>> Another fix: we should only unload duplicate ld.so if it's actually a 
>> duplicate, i.e. the path differs. Otherwise, we've ended up unloading the 
>> only copy.
>
> Would comparing the module shared_pointers work? I think that's exactly what 
> we want here. I think it's possible for `LoadModuleAtAddress` to return the 
> same module, even with paths which don't match exactly. But if it does that, 
> then we will still end up unloading the original interpreter module...

How do you suggest we get the shared pointer for comparison? Store in class 
instance, or search for it somehow?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92187/new/

https://reviews.llvm.org/D92187

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] Buildbot to listen main branch

2020-12-13 Thread Galina Kistanova via lldb-commits 
Hello everyone,

The buildbot listens to the "main" branch now.

Please let me know if you will see issues.

Thanks

Galina


On Tue, Dec 8, 2020 at 9:57 PM Galina Kistanova 
wrote:

> Hello everyone,
>
> To follow the main branch creation I'm going to update the buildbot to
> listen for the changes in this branch and instruct all the workers to
> checkout this branch.
>
> No work is required on the workers.
>
> Please check your annotated scripts to make sure it accepts the branch
> name from the buildbot, or change it if that's hardcoded.
>
> The staging has been updated today. I forced clean builds just to play it
> safe. Please check your bots in the staging area, to make sure everything
> is good.
>
> If everything will go well, the production buildbot will be updated on
> this Saturday, December, 12th.
>
> Thanks
>
> Galina
>
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits