[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets
aadsm requested changes to this revision. aadsm added a comment. This revision now requires changes to proceed. I'm sorry to reject but this diff breaks `install-distribution` on Darwin. Here's how to repro: $ mkdir -p ~/Projects/llvm-build/Release && cd ~/Projects/llvm-build/Release $ cmake -G Ninja \ -DLLVM_ENABLE_PROJECTS="clang;lldb" \ -DCMAKE_BUILD_TYPE=Release \ -DLLVM_ENABLE_ASSERTIONS=OFF \ -DLLDB_INCLUDE_TESTS=OFF \ -DLLVM_DISTRIBUTION_COMPONENTS="lldb;liblldb" \ -C ../../llvm-project/lldb/cmake/caches/Apple-lldb-macOS.cmake \ -S../../llvm-project/llvm $ DESTDIR=$PWD/install/usr install-distribution ninja: error: 'bin/LLDB.framework/LLDB', needed by 'bin/LLDB.framework/Resources/Python/lldb/_lldb.so', missing and no known rule to make it The reason I found this is because I was having an issue where `_lldb.so` was being generated on the build but it was not being copied to the install directory. After some mucking around I realized that the `install-liblldb` target installs the python scripts but it's `lldb` that generates the symlink as a `POST_BUILD` command (before this diff). I think in some situations the `install-liblldb` runs before that `POST_BUILD` command has run. At least I'm able to repro this quite consistently and once `ninja install-distribution` is finished `_lldb.so` exists on the build directory but not on the install one (and I can see all files in the python module being copied except that one in the ninja log when running the install step). I fixed this locally by doing this (this fix doesn't really feel good but not sure what's the best way to do it): if(LLDB_BUILD_FRAMEWORK) # When building as framework liblldb is responsible to install the python # scripts. However, we need to make sure that all swig components have been # properly finished. add_dependencies(install-liblldb finish_swig) add_dependencies(install-liblldb-stripped finish_swig) else() # Install the LLDB python module ... endif() Then I found this diff that hasn't landed yet and tried it (I think there's a race condition caused by the POST_BUILD command but not sure) out and stumbled upon this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/ https://reviews.llvm.org/D69589 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] 80bf88d - [lldb] Add trailing dots to comments in Value.cpp
Author: Raphael Isemann Date: 2019-11-04T08:35:56+01:00 New Revision: 80bf88d8bc892548aa59286306b6a1d9072a9f7a URL: https://github.com/llvm/llvm-project/commit/80bf88d8bc892548aa59286306b6a1d9072a9f7a DIFF: https://github.com/llvm/llvm-project/commit/80bf88d8bc892548aa59286306b6a1d9072a9f7a.diff LOG: [lldb] Add trailing dots to comments in Value.cpp Reviewers: JDevlieghere Reviewed By: JDevlieghere Subscribers: JDevlieghere, lldb-commits Tags: #upstreaming_lldb_s_downstream_patches, #lldb Differential Revision: https://reviews.llvm.org/D69717 Added: Modified: lldb/source/Core/Value.cpp Removed: diff --git a/lldb/source/Core/Value.cpp b/lldb/source/Core/Value.cpp index 3124b9338b36..aa713d58dace 100644 --- a/lldb/source/Core/Value.cpp +++ b/lldb/source/Core/Value.cpp @@ -507,10 +507,10 @@ Status Value::GetValueAsData(ExecutionContext *exe_ctx, DataExtractor &data, return error; } - // If we got here, we need to read the value from memory + // If we got here, we need to read the value from memory. size_t byte_size = GetValueByteSize(&error, exe_ctx); - // Bail if we encountered any errors getting the byte size + // Bail if we encountered any errors getting the byte size. if (error.Fail()) return error; ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D69717: [lldb] Add trailing dots to comments in Value.cpp
This revision was automatically updated to reflect the committed changes. Closed by commit rG80bf88d8bc89: [lldb] Add trailing dots to comments in Value.cpp (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69717/new/ https://reviews.llvm.org/D69717 Files: lldb/source/Core/Value.cpp Index: lldb/source/Core/Value.cpp === --- lldb/source/Core/Value.cpp +++ lldb/source/Core/Value.cpp @@ -507,10 +507,10 @@ return error; } - // If we got here, we need to read the value from memory + // If we got here, we need to read the value from memory. size_t byte_size = GetValueByteSize(&error, exe_ctx); - // Bail if we encountered any errors getting the byte size + // Bail if we encountered any errors getting the byte size. if (error.Fail()) return error; Index: lldb/source/Core/Value.cpp === --- lldb/source/Core/Value.cpp +++ lldb/source/Core/Value.cpp @@ -507,10 +507,10 @@ return error; } - // If we got here, we need to read the value from memory + // If we got here, we need to read the value from memory. size_t byte_size = GetValueByteSize(&error, exe_ctx); - // Bail if we encountered any errors getting the byte size + // Bail if we encountered any errors getting the byte size. if (error.Fail()) return error; ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
