[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

[Roman Lebedev via Phabricator via lldb-commits]

lebedev.ri added a comment.

The `llvm/utils/benchmark/` changes - can you please either submit them 
upstream yourself, or explicitly state that it is okay to **steal** them from 
you and submit?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63370/new/

https://reviews.llvm.org/D63370



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D63380: [lldb] [test] Skip watchpoint tests on NetBSD if userdbregs is disabled

[Michał Górny via Phabricator via lldb-commits]

mgorny created this revision.
mgorny added reviewers: labath, krytarowski.

Skip watchpoint tests if security.models.extensions.user_set_dbregs
is disabled.  This indicates that unprivileged processes are not allowed
to write to debug registers which is a prerequisite for using hardware
watchpoints.


https://reviews.llvm.org/D63380

Files:
  lldb/packages/Python/lldbsuite/test/decorators.py
  
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/multiple_threads/TestWatchpointMultipleThreads.py
  
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_commands/TestWatchpointCommands.py
  
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/TestWatchpointDisable.py
  
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_events/TestWatchpointEvents.py
  
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_on_vectors/TestValueOfVectorVariable.py


Index: 
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_on_vectors/TestValueOfVectorVariable.py
===
--- 
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_on_vectors/TestValueOfVectorVariable.py
+++ 
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_on_vectors/TestValueOfVectorVariable.py
@@ -20,6 +20,7 @@
 @expectedFailureAll(
 oslist=["windows"],
 bugnumber="llvm.org/pr24446: WINDOWS XFAIL TRIAGE - Watchpoints not 
supported on Windows")
+@skipIfDbRegsReadOnly
 def test_value_of_vector_variable_using_watchpoint_set(self):
 """Test verify displayed value of vector variable."""
 exe = self.getBuildArtifact("a.out")
Index: 
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_events/TestWatchpointEvents.py
===
--- 
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_events/TestWatchpointEvents.py
+++ 
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_events/TestWatchpointEvents.py
@@ -29,6 +29,7 @@
 @expectedFailureAll(
 oslist=["windows"],
 bugnumber="llvm.org/pr24446: WINDOWS XFAIL TRIAGE - Watchpoints not 
supported on Windows")
+@skipIfDbRegsReadOnly
 def test_with_python_api(self):
 """Test that adding, deleting and modifying watchpoints sends the 
appropriate events."""
 self.build()
Index: 
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/TestWatchpointDisable.py
===
--- 
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/TestWatchpointDisable.py
+++ 
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/TestWatchpointDisable.py
@@ -19,6 +19,7 @@
 @expectedFailureAll(
 oslist=["windows"],
 bugnumber="llvm.org/pr24446: WINDOWS XFAIL TRIAGE - Watchpoints not 
supported on Windows")
+@skipIfDbRegsReadOnly
 def test_disable_works (self):
 """Set a watchpoint, disable it, and make sure it doesn't get hit."""
 self.build()
Index: 
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_commands/TestWatchpointCommands.py
===
--- 
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_commands/TestWatchpointCommands.py
+++ 
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_commands/TestWatchpointCommands.py
@@ -113,6 +113,7 @@
 bugnumber="llvm.org/pr24446: WINDOWS XFAIL TRIAGE - Watchpoints not 
supported on Windows")
 # Read-write watchpoints not supported on SystemZ
 @expectedFailureAll(archs=['s390x'])
+@skipIfDbRegsReadOnly
 def test_rw_watchpoint_delete(self):
 """Test delete watchpoint and expect not to stop for watchpoint."""
 self.build(dictionary=self.d)
Index: 
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/multiple_threads/TestWatchpointMultipleThreads.py
===
--- 
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/multiple_threads/TestWatchpointMultipleThreads.py
+++ 
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/multiple_threads/TestWatchpointMultipleThreads.py
@@ -71,6 +71,7 @@
 @expectedFailureAll(
 oslist=["windows"],
 bugnumber="llvm.org/pr24446: WINDOWS XFAIL TRIAGE - Watchpoints not 
supported on Windows")
+@skipIfDbRegsReadOnly
 def test_watchpoint_multiple_threads_wp_set_and_then_delete(self):
 """Test that lldb watchpoint works for multiple threads, and after the 
watchpoint is deleted, the watchpoint event should no longer fires."""
 self.build()
Index: lldb/packages/Python/lldbsuite/tes

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

[Christoph Siedentop via Phabricator via lldb-commits]

siedentop added a comment.

In D63370#1544767 , @lebedev.ri wrote:

> The `llvm/utils/benchmark/` changes - can you please either submit them 
> upstream yourself, or explicitly state that it is okay to **steal** them from 
> you and submit?


Thanks, @lebedev.ri, I was not aware that `llvm/utils/benchmark` contains 
Google Benchmark.

I just checked: all three modified files in  `llvm/utils/benchmark/`  already 
have the same modifications on upstream (HEAD == 090faecb454fb).

I propose that I remove my modifications from this review. I'll go ahead with 
this -- but please let me know if you disagree.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63370/new/

https://reviews.llvm.org/D63370



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

[Roman Lebedev via Phabricator via lldb-commits]

lebedev.ri added a comment.

In D63370#1544970 , @siedentop wrote:

> In D63370#1544767 , @lebedev.ri 
> wrote:
>
> > The `llvm/utils/benchmark/` changes - can you please either submit them 
> > upstream yourself, or explicitly state that it is okay to **steal** them 
> > from you and submit?
>
>
> Thanks, @lebedev.ri, I was not aware that `llvm/utils/benchmark` contains 
> Google Benchmark.
>
> I just checked: all three modified files in  `llvm/utils/benchmark/`  already 
> have the same modifications on upstream (HEAD == 090faecb454fb).


Ah yes, apparently so, thanks for checking!
I have no further comments then.

> I propose that I remove my modifications from this review. I'll go ahead with 
> this -- but please let me know if you disagree.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63370/new/

https://reviews.llvm.org/D63370



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

[Christoph Siedentop via Phabricator via lldb-commits]

siedentop updated this revision to Diff 204935.
siedentop added a comment.

Removed changes to `llvm/utils/benchmark`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63370/new/

https://reviews.llvm.org/D63370

Files:
  compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
  lldb/cmake/modules/LLDBConfig.cmake
  lldb/cmake/modules/LLDBStandalone.cmake
  llvm/cmake/modules/LLVMInstallSymlink.cmake

Index: llvm/cmake/modules/LLVMInstallSymlink.cmake
===
--- llvm/cmake/modules/LLVMInstallSymlink.cmake
+++ llvm/cmake/modules/LLVMInstallSymlink.cmake
@@ -12,7 +12,7 @@
 
   set(bindir "${DESTDIR}${CMAKE_INSTALL_PREFIX}/${outdir}/")
 
-  message("Creating ${name}")
+  message(STATUS "Creating ${name}")
 
   execute_process(
 COMMAND "${CMAKE_COMMAND}" -E ${LINK_OR_COPY} "${target}" "${name}"
Index: lldb/cmake/modules/LLDBStandalone.cmake
===
--- lldb/cmake/modules/LLDBStandalone.cmake
+++ lldb/cmake/modules/LLDBStandalone.cmake
@@ -95,7 +95,7 @@
Please install Python or specify the PYTHON_EXECUTABLE CMake variable.")
 endif()
   else()
-message("-- Found PythonInterp: ${PYTHON_EXECUTABLE}")
+message(STATUS "-- Found PythonInterp: ${PYTHON_EXECUTABLE}")
   endif()
 
   set(PACKAGE_VERSION "${LLVM_PACKAGE_VERSION}")
Index: lldb/cmake/modules/LLDBConfig.cmake
===
--- lldb/cmake/modules/LLDBConfig.cmake
+++ lldb/cmake/modules/LLDBConfig.cmake
@@ -128,7 +128,7 @@
 # addresses them, but it can be improved and extended on an as-needed basis.
 function(find_python_libs_windows)
   if ("${PYTHON_HOME}" STREQUAL "")
-message("LLDB embedded Python on Windows requires specifying a value for PYTHON_HOME.  Python support disabled.")
+message(WARNING "LLDB embedded Python on Windows requires specifying a value for PYTHON_HOME.  Python support disabled.")
 set(LLDB_DISABLE_PYTHON 1 PARENT_SCOPE)
 return()
   endif()
@@ -140,12 +140,12 @@
  REGEX "^#define[ \t]+PY_VERSION[ \t]+\"[^\"]+\"")
 string(REGEX REPLACE "^#define[ \t]+PY_VERSION[ \t]+\"([^\"+]+)[+]?\".*" "\\1"
  PYTHONLIBS_VERSION_STRING "${python_version_str}")
-message("-- Found Python version ${PYTHONLIBS_VERSION_STRING}")
+message(STATUS "-- Found Python version ${PYTHONLIBS_VERSION_STRING}")
 string(REGEX REPLACE "([0-9]+)[.]([0-9]+)[.][0-9]+" "python\\1\\2" PYTHONLIBS_BASE_NAME "${PYTHONLIBS_VERSION_STRING}")
 unset(python_version_str)
   else()
-message("Unable to find ${PYTHON_INCLUDE_DIR}/patchlevel.h, Python installation is corrupt.")
-message("Python support will be disabled for this build.")
+message(WARNING "Unable to find ${PYTHON_INCLUDE_DIR}/patchlevel.h, Python installation is corrupt.")
+message(WARNING "Python support will be disabled for this build.")
 set(LLDB_DISABLE_PYTHON 1 PARENT_SCOPE)
 return()
   endif()
@@ -165,13 +165,13 @@
 
   foreach(component PYTHON_EXE;PYTHON_LIB;PYTHON_DLL)
 if(NOT EXISTS ${${component}})
-  message("unable to find ${component}")
+  message(WARNING "unable to find ${component}")
   unset(${component})
 endif()
   endforeach()
 
   if (NOT PYTHON_EXE OR NOT PYTHON_LIB OR NOT PYTHON_DLL)
-message("Unable to find all Python components.  Python support will be disabled for this build.")
+message(WARNING "Unable to find all Python components.  Python support will be disabled for this build.")
 set(LLDB_DISABLE_PYTHON 1 PARENT_SCOPE)
 return()
   endif()
@@ -181,10 +181,10 @@
   set (PYTHON_DLL ${PYTHON_DLL} PARENT_SCOPE)
   set (PYTHON_INCLUDE_DIR ${PYTHON_INCLUDE_DIR} PARENT_SCOPE)
 
-  message("-- LLDB Found PythonExecutable: ${PYTHON_EXE}")
-  message("-- LLDB Found PythonLibs: ${PYTHON_LIB}")
-  message("-- LLDB Found PythonDLL: ${PYTHON_DLL}")
-  message("-- LLDB Found PythonIncludeDirs: ${PYTHON_INCLUDE_DIR}")
+  message(STATUS "-- LLDB Found PythonExecutable: ${PYTHON_EXE}")
+  message(STATUS "-- LLDB Found PythonLibs: ${PYTHON_LIB}")
+  message(STATUS "-- LLDB Found PythonDLL: ${PYTHON_DLL}")
+  message(STATUS "-- LLDB Found PythonIncludeDirs: ${PYTHON_INCLUDE_DIR}")
 endfunction(find_python_libs_windows)
 
 if (NOT LLDB_DISABLE_PYTHON)
Index: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
===
--- compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
+++ compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
@@ -410,8 +410,8 @@
 INCLUDE ${arch}_FUNCTIONS
 ${${arch}_SOURCES})
   if(NOT ${arch}_filtered_sources)
-message("${arch}_SOURCES: ${${arch}_SOURCES}")
-message("${arch}_FUNCTIONS: ${${arch}_FUNCTIONS}")
+message(WARNING "${arch}_SOURCES: ${${arch}_SOURCES}")
+message(WARNING "${arch}_FUNCTIONS: ${${arch}_FUNCTIONS}")
 message(FATAL_ERROR "Empty f