[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support
amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Thanks for the changes. If the tests pass, then this LGTM. Just check the one last question I added about the `AC1D` test. (The diff in Phabricator looks very confused, as though you deleted several hundred lines. Perhaps because the original diff had context and this one didn't. If I'm interpretting the diff correctly, this looks good now.) Comment at: lit/SymbolFile/NativePDB/ast-types.cpp:22 Should this one start with FIXME rather than CHECK? Isn't this the case that's currently broken? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60817/new/ https://reviews.llvm.org/D60817 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D60588: Adjusting libc++ std::list formatter to act better with pointers and references and adding a test to cover a previous related fix
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60588/new/ https://reviews.llvm.org/D60588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r358773 - [Docs] Make Doxygen functional
Author: jdevlieghere Date: Fri Apr 19 11:02:35 2019 New Revision: 358773 URL: http://llvm.org/viewvc/llvm-project?rev=358773&view=rev Log: [Docs] Make Doxygen functional This fixes the doxygen configuration to be functional again. I removed the customer header and footer, as well as the no-longer-existent style sheet. I also widened the scope of the documentation, from just the public API to include the private interfaces as well. Added: lldb/trunk/docs/doxygen-mainpage.dox Removed: lldb/trunk/docs/doxygen.footer lldb/trunk/docs/doxygen.header lldb/trunk/docs/doxygen.intro Modified: lldb/trunk/docs/doxygen.cfg.in Added: lldb/trunk/docs/doxygen-mainpage.dox URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/docs/doxygen-mainpage.dox?rev=358773&view=auto == --- lldb/trunk/docs/doxygen-mainpage.dox (added) +++ lldb/trunk/docs/doxygen-mainpage.dox Fri Apr 19 11:02:35 2019 @@ -0,0 +1,15 @@ +/// @mainpage LLDB +/// +/// @section main_intro Introduction +/// Welcome to LLDB. +/// +/// This documentation describes both the private and public interface of LLDB. +/// There are no instructions here on how to use LLDB, only the APIs +/// that make up the software. For usage instructions, please see +/// the help command. +/// +/// @section main_caveat Caveat +/// This documentation is generated directly from the source code with doxygen. +/// Since LLDB is constantly under active development, what you're about to +/// read is out of date! However, it may still be useful since certain portions +/// of LLDB are very stable. Modified: lldb/trunk/docs/doxygen.cfg.in URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/docs/doxygen.cfg.in?rev=358773&r1=358772&r2=358773&view=diff == --- lldb/trunk/docs/doxygen.cfg.in (original) +++ lldb/trunk/docs/doxygen.cfg.in Fri Apr 19 11:02:35 2019 @@ -25,7 +25,7 @@ DOXYFILE_ENCODING = UTF-8 # The PROJECT_NAME tag is a single word (or a sequence of words surrounded # by quotes) that should identify the project. -PROJECT_NAME = LLVM +PROJECT_NAME = LLDB # The PROJECT_NUMBER tag can be used to enter a project or revision number. # This could be handy for archiving the generated documentation or @@ -581,8 +581,9 @@ WARN_LOGFILE = # directories like "/usr/src/myproject". Separate the files or directories # with spaces. -INPUT = @abs_top_srcdir@/include/lldb/API \ - @abs_top_srcdir@/docs/doxygen.intro +INPUT = @abs_top_srcdir@/include/ \ + @abs_top_srcdir@/source/ \ + @abs_top_srcdir@/docs/doxygen-mainpage.dox # This tag can be used to specify the character encoding of the source files # that doxygen parses. Internally doxygen uses the UTF-8 encoding, which is @@ -793,13 +794,13 @@ HTML_FILE_EXTENSION= .html # each generated HTML page. If it is left blank doxygen will generate a # standard header. -HTML_HEADER= @abs_top_srcdir@/docs/doxygen.header +HTML_HEADER= # The HTML_FOOTER tag can be used to specify a personal HTML footer for # each generated HTML page. If it is left blank doxygen will generate a # standard footer. -HTML_FOOTER= @abs_top_srcdir@/docs/doxygen.footer +HTML_FOOTER= # The HTML_STYLESHEET tag can be used to specify a user-defined cascading # style sheet that is used by each HTML page. It can be used to @@ -808,7 +809,7 @@ HTML_FOOTER= @abs_top_srcdir # the style sheet file to the HTML output directory, so don't put your own # stylesheet in the HTML output directory as well, or it will be erased! -HTML_STYLESHEET= @abs_top_srcdir@/../../docs/doxygen.css +HTML_STYLESHEET= # The HTML_COLORSTYLE_HUE tag controls the color of the HTML output. # Doxygen will adjust the colors in the stylesheet and background images Removed: lldb/trunk/docs/doxygen.footer URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/docs/doxygen.footer?rev=358772&view=auto == --- lldb/trunk/docs/doxygen.footer (original) +++ lldb/trunk/docs/doxygen.footer (removed) @@ -1,13 +0,0 @@ - - -Generated on $datetime for http://lldb.llvm.org/";>$projectname by -http://www.doxygen.org";>$doxygenversion -Copyright © 2003-2013 University of Illinois at Urbana-Champaign. -All Rights Reserved. - - - - - - Removed: lldb/trunk/docs/doxygen.header URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/docs/doxygen.header?rev=358772&view=auto == --- lldb/trunk/docs/doxygen.header (original) +++ lldb/trunk/docs/doxygen.header (removed) @@ -1,9 +0,0 @@ - - - - - -LLVM: $title - - -LLDB API Documentation Removed: lldb/trunk/docs/doxygen.intro U
[Lldb-commits] [lldb] r358776 - This test doesn't need to be run for all debug formats.
Author: jingham Date: Fri Apr 19 11:46:56 2019 New Revision: 358776 URL: http://llvm.org/viewvc/llvm-project?rev=358776&view=rev Log: This test doesn't need to be run for all debug formats. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py?rev=358776&r1=358775&r2=358776&view=diff == --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py (original) +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py Fri Apr 19 11:46:56 2019 @@ -16,6 +16,7 @@ import lldbsuite.test.lldbutil as lldbut class PluginPythonOSPlugin(TestBase): mydir = TestBase.compute_mydir(__file__) +NO_DEBUG_INFO_TESTCASE = True def test_python_os_plugin(self): """Test that the Python operating system plugin works correctly""" ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r358777 - [Docs] Add more info about building the docs
Author: jdevlieghere Date: Fri Apr 19 12:03:58 2019 New Revision: 358777 URL: http://llvm.org/viewvc/llvm-project?rev=358777&view=rev Log: [Docs] Add more info about building the docs Including the C++ and Python reference. Modified: lldb/trunk/docs/resources/build.rst Modified: lldb/trunk/docs/resources/build.rst URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/docs/resources/build.rst?rev=358777&r1=358776&r2=358777&view=diff == --- lldb/trunk/docs/resources/build.rst (original) +++ lldb/trunk/docs/resources/build.rst Fri Apr 19 12:03:58 2019 @@ -232,21 +232,6 @@ On NetBSD one might run: > pkgin install swig python27 cmake ninja-build -If you wish to build the optional reference documentation, additional dependencies are required: - -* Graphviz (for the 'dot' tool). -* doxygen (only if you wish to build the C++ API reference) -* epydoc (only if you wish to build the Python API reference) - - -To install the prerequisites for building the documentation (on Debian/Ubuntu) do: - -:: - - > sudo apt-get install doxygen graphviz - > sudo pip install epydoc # or install package python-epydoc - - **Building LLDB** We first need to checkout the source trees into the appropriate locations. Both @@ -514,3 +499,30 @@ arm64 build: Note that currently only lldb-server is functional on android. The lldb client is not supported and unlikely to work. + +Building The Documentation +-- + +If you wish to build the optional (reference) documentation, additional +dependencies are required: + +* Sphinx (for the website) +* Graphviz (for the 'dot' tool) +* doxygen (if you wish to build the C++ API reference) +* epydoc (if you wish to build the Python API reference) + +To install the prerequisites for building the documentation (on Debian/Ubuntu) +do: + +:: + + > sudo apt-get install doxygen graphviz python3-sphinx + > sudo pip install epydoc + +To build the documentation, build the desired target(s). + +:: + + > cmake --build . --target docs-lldb-html + > cmake --build . --target lldb-cpp-doc + > cmake --build . --target lldb-python-doc ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r358792 - [Tests] Split float test into float and doubles
Author: jdevlieghere
Date: Fri Apr 19 15:37:55 2019
New Revision: 358792
URL: http://llvm.org/viewvc/llvm-project?rev=358792&view=rev
Log:
[Tests] Split float test into float and doubles
As I was waiting for the test suite to complete at 99% I noticed this
test taking quite a bit of time. Since it's easy to split I just went
ahead and did so.
Added:
lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypes.py
lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypesExpr.py
Modified:
lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypes.py
lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypesExpr.py
Added: lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypes.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypes.py?rev=358792&view=auto
==
--- lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypes.py (added)
+++ lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypes.py Fri Apr
19 15:37:55 2019
@@ -0,0 +1,36 @@
+"""
+Test that variables of floating point types are displayed correctly.
+"""
+
+from __future__ import print_function
+
+
+import AbstractBase
+import sys
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class DoubleTypesTestCase(AbstractBase.GenericTester):
+
+mydir = AbstractBase.GenericTester.compute_mydir(__file__)
+
+def setUp(self):
+# Call super's setUp().
+AbstractBase.GenericTester.setUp(self)
+# disable "There is a running process, kill it and restart?" prompt
+self.runCmd("settings set auto-confirm true")
+self.addTearDownHook(
+lambda: self.runCmd("settings clear auto-confirm"))
+
+def test_double_type(self):
+"""Test that double-type variables are displayed correctly."""
+self.build_and_run('double.cpp', set(['double']))
+
+@skipUnlessDarwin
+def test_double_type_from_block(self):
+"""Test that double-type variables are displayed correctly from a
block."""
+self.build_and_run('double.cpp', set(['double']), bc=True)
Added: lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypesExpr.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypesExpr.py?rev=358792&view=auto
==
--- lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypesExpr.py
(added)
+++ lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypesExpr.py Fri
Apr 19 15:37:55 2019
@@ -0,0 +1,40 @@
+"""
+Test that variable expressions of floating point types are evaluated correctly.
+"""
+
+from __future__ import print_function
+
+
+import AbstractBase
+import sys
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class DoubleTypesExprTestCase(AbstractBase.GenericTester):
+
+mydir = AbstractBase.GenericTester.compute_mydir(__file__)
+
+# rdar://problem/8493023
+# test/types failures for Test*TypesExpr.py: element offset computed wrong
+# and sign error?
+
+def setUp(self):
+# Call super's setUp().
+AbstractBase.GenericTester.setUp(self)
+# disable "There is a running process, kill it and restart?" prompt
+self.runCmd("settings set auto-confirm true")
+self.addTearDownHook(
+lambda: self.runCmd("settings clear auto-confirm"))
+
+def test_double_type(self):
+"""Test that double-type variable expressions are evaluated
correctly."""
+self.build_and_run_expr('double.cpp', set(['double']))
+
+@skipUnlessDarwin
+def test_double_type_from_block(self):
+"""Test that double-type variables are displayed correctly from a
block."""
+self.build_and_run_expr('double.cpp', set(['double']), bc=True)
Modified: lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypes.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypes.py?rev=358792&r1=358791&r2=358792&view=diff
==
--- lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypes.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypes.py Fri Apr
19 15:37:55 2019
@@ -34,12 +34,3 @@ class FloatTypesTestCase(AbstractBase.Ge
def test_float_type_from_block(self):
"""Test that float-type variables are displayed correctly from a
block."""
self.build_and_run('float.cpp', set(['float']), bc=True)
-
-def test_double_type(self):
-"""Test that double-type variables are displayed correctly."""
-self.build_and_run('double.cpp', set(['double']))
-
-@skipUnlessDarwi
