[Lldb-commits] [lldb] r350479 - Fix symbols.enable-external-lookup description wording
Author: jankratochvil
Date: Sat Jan 5 13:39:03 2019
New Revision: 350479
URL: http://llvm.org/viewvc/llvm-project?rev=350479&view=rev
Log:
Fix symbols.enable-external-lookup description wording
D55859 changed "external tools or libraries" to "external sources" according to
Pavel Labath. Now it is changed sort of back to "external tools and
repositories" according to Adrian Prantl.
https://reviews.llvm.org/D55859#1345881
Modified:
lldb/trunk/source/Core/ModuleList.cpp
Modified: lldb/trunk/source/Core/ModuleList.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ModuleList.cpp?rev=350479&r1=350478&r2=350479&view=diff
==
--- lldb/trunk/source/Core/ModuleList.cpp (original)
+++ lldb/trunk/source/Core/ModuleList.cpp Sat Jan 5 13:39:03 2019
@@ -69,10 +69,10 @@ namespace {
static constexpr PropertyDefinition g_properties[] = {
{"enable-external-lookup", OptionValue::eTypeBoolean, true, true, nullptr,
{},
- "Control the use of external sources to locate symbol files. "
- "Directories listed in target.debug-file-search-paths and directory of "
- "the executable are always checked first for separate debug info files. "
- "Then depending on this setting: "
+ "Control the use of external tools and repositories to locate symbol "
+ "files. Directories listed in target.debug-file-search-paths and "
+ "directory of the executable are always checked first for separate debug "
+ "info files. Then depending on this setting: "
"On macOS, Spotlight would be also used to locate a matching .dSYM "
"bundle based on the UUID of the executable. "
"On NetBSD, directory /usr/libdata/debug would be also searched. "
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)
jankratochvil marked an inline comment as done.
jankratochvil added inline comments.
Comment at: source/Core/ModuleList.cpp:72
{},
"Control the use of external tools or libraries to locate symbol files. "
+ "Directories listed in target.debug-file-search-paths and directory of "
labath wrote:
> jankratochvil wrote:
> > aprantl wrote:
> > > jankratochvil wrote:
> > > > labath wrote:
> > > > > My main issue here was with the "tools or libraries" part of this
> > > > > description -- we're not using any special tools or libraries when
> > > > > looking in /usr/lib/debug.
> > > > >
> > > > > Maybe just say that this is controls whether we use "external
> > > > > sources" when searching for symbols. The rest of the description is
> > > > > fine (though I would just drop the ifdefs and print everything
> > > > > everywhere).
> > > > The Spotlight on OSX was a bit unclear to me what it really does.
> > > > Doesn't it use some those "tools or libraries" to access the dSYM files
> > > > downloaded from internet? But I have put there the "sources" word now
> > > > as you wish.
> > > > Also rather added `See also symbols.enable-external-lookup.` to
> > > > `target.debug-file-search-paths`.
> > > > I will check it in if there are no more replies in some time. Thanks
> > > > for the approval.
> > > >
> > > The original wording is meant for tools that download debug symbols from
> > > centralized repositories like the dsym download scripts mentioned on
> > > http://lldb.llvm.org/symbols.html + the Spotlight metadata search engine.
> > >
> > > The wording "sources" is problematic because it could be confused with
> > > source code. Does "/usr/lib..." count as an external library?
> > > Alternatively, what about "tools and repositories"?
> > GDB calls "**/usr/lib/debug**" as "**debug-file-directory**". I definitely
> > would not call it a "**library**". Would be OK for everyone to use
> > "**external tools or directories**"?
> Both "repositories" and "directories" sound fine to me. Another option might
> be to use something really generic like "facilities"?
It is now changed to "external tools and repositories" which should satisfy
everyone by: rL350479
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55859/new/
https://reviews.llvm.org/D55859
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
