[Lldb-commits] [lldb] r322472 - Fix HostInfoBase::ComputeSharedLibraryDirectory comment
Author: labath
Date: Mon Jan 15 01:56:00 2018
New Revision: 322472
URL: http://llvm.org/viewvc/llvm-project?rev=322472&view=rev
Log:
Fix HostInfoBase::ComputeSharedLibraryDirectory comment
The comment seems to indicate that this function would return the "bin"
directory on linux. I've verified that this is not the case, so I'm
updating the comment to match.
Modified:
lldb/trunk/source/Host/common/HostInfoBase.cpp
Modified: lldb/trunk/source/Host/common/HostInfoBase.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/HostInfoBase.cpp?rev=322472&r1=322471&r2=322472&view=diff
==
--- lldb/trunk/source/Host/common/HostInfoBase.cpp (original)
+++ lldb/trunk/source/Host/common/HostInfoBase.cpp Mon Jan 15 01:56:00 2018
@@ -282,10 +282,8 @@ ArchSpec HostInfoBase::GetAugmentedArchS
bool HostInfoBase::ComputeSharedLibraryDirectory(FileSpec &file_spec) {
// To get paths related to LLDB we get the path to the executable that
- // contains this function. On MacOSX this will be "LLDB.framework/.../LLDB",
- // on linux this is assumed to be the "lldb" main executable. If LLDB on
- // linux is actually in a shared library (liblldb.so) then this function will
- // need to be modified to "do the right thing".
+ // contains this function. On MacOSX this will be "LLDB.framework/.../LLDB".
+ // On other posix systems, we will get .../lib(64|32)?/liblldb.so.
FileSpec lldb_file_spec(
Host::GetModuleFileSpecForHostAddress(reinterpret_cast(
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D41997: Build virtual override tables in DWARFASTParserClang::CompleteTypeFromDWARF
labath added inline comments. Comment at: Python/lldbsuite/test/expression_command/call-overridden-method/Makefile:10 + CFLAGS_EXTRAS += -fno-limit-debug-info +endif + no-limit-debug-info handling has recently been centralized into Makefile.rules. This block here should no longer be necessary. Repository: rL LLVM https://reviews.llvm.org/D41997 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Thank you for looking at this @chmeee. @alexandreyy, could you update this plugin to handle big-endian as well, and then delete the old plugin? https://reviews.llvm.org/D41702 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le
alexandreyy added a comment. Thanks, @labath and @chmeee . I will do the merge and send the update soon. In https://reviews.llvm.org/D41702#975873, @chmeee wrote: > In https://reviews.llvm.org/D41702#972009, @labath wrote: > > > In https://reviews.llvm.org/D41702#971076, @jhibbits wrote: > > > > > > @emaste, @jhibbits: do you know what's the state of ppc64 lldb support > > > > in freebsd? > > > > > > It's broken because LLDB doesn't yet handle function descriptors, and I > > > haven't yet made the effort (ENOTIME) to fix that. I think our eventual > > > goal is to move even BE to ELFv2 on FreeBSD, to do away with function > > > descriptors, and it should then Just Work, as powerpc (32-bit) works fine > > > for most cases right now. > > > > > > That said, if anyone knows enough to add function descriptor knowledge to > > > LLDB, I think that's the only missing piece, or the biggest missing > > > piece. I do want to finish the effort, since I started it 3.5 years ago, > > > but I do need help with understanding that ABI detail and how it fits > > > with LLDB. > > > > > > Thanks for the explanation. How badly is it broken would you say? Do you > > think that using this ABI plugin for the big endian target (instead of the > > one from 2014) would make things any worse? Could you take a quick look to > > see if there is anything in this plugin that would be completely wrong for > > the big endian target ? (I couldn't find anything, apart from the obvious > > things like register constants in `CreateDefaultUnwindPlan`, but then > > again, I don't know the ABIs). > > > > I'm trying to avoid making bad design decisions now because of legacy code > > that is known to be broken and has no clear maintainer nor a plan to fix it. > > > I don't see anything glaring. I also cross-referenced with the 64-bit BE ABI > reference (http://refspecs.linuxfoundation.org/ELF/ppc64/PPC-elf64abi.html) > and didn't see anything obvious that would hinder using your plugin as a > replacement to mine (as mentioned before, symbol handling is the big problem > right now, and that's not handled within the ABI plugin), if yours is fully > tested. https://reviews.llvm.org/D41702 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r322476 - Fix NetBSD build for llvm r322475
Author: labath
Date: Mon Jan 15 03:32:43 2018
New Revision: 322476
URL: http://llvm.org/viewvc/llvm-project?rev=322476&view=rev
Log:
Fix NetBSD build for llvm r322475
Modified:
lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
Modified: lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp?rev=322476&r1=322475&r2=322476&view=diff
==
--- lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp (original)
+++ lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp Mon Jan 15
03:32:43 2018
@@ -871,13 +871,13 @@ NativeProcessNetBSD::GetAuxvData() const
*/
size_t auxv_size = 100 * sizeof(AuxInfo);
- ErrorOr> buf =
+ ErrorOr> buf =
llvm::MemoryBuffer::getNewMemBuffer(auxv_size);
struct ptrace_io_desc io;
io.piod_op = PIOD_READ_AUXV;
io.piod_offs = 0;
- io.piod_addr = const_cast(static_cast(buf.get()->getBufferStart()));
+ io.piod_addr = static_cast(buf.get()->getBufferStart());
io.piod_len = auxv_size;
Status error = NativeProcessNetBSD::PtraceWrapper(PT_IO, GetID(), &io);
@@ -888,7 +888,7 @@ NativeProcessNetBSD::GetAuxvData() const
if (io.piod_len < 1)
return std::error_code(ECANCELED, std::generic_category());
- return buf;
+ return std::move(buf);
}
Status NativeProcessNetBSD::ReinitializeThreads() {
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r322477 - One more attempt to fix NetBSD build
Author: labath Date: Mon Jan 15 03:50:05 2018 New Revision: 322477 URL: http://llvm.org/viewvc/llvm-project?rev=322477&view=rev Log: One more attempt to fix NetBSD build Modified: lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp Modified: lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp?rev=322477&r1=322476&r2=322477&view=diff == --- lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp (original) +++ lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp Mon Jan 15 03:50:05 2018 @@ -872,7 +872,7 @@ NativeProcessNetBSD::GetAuxvData() const size_t auxv_size = 100 * sizeof(AuxInfo); ErrorOr> buf = - llvm::MemoryBuffer::getNewMemBuffer(auxv_size); + llvm::WritableMemoryBuffer::getNewMemBuffer(auxv_size); struct ptrace_io_desc io; io.piod_op = PIOD_READ_AUXV; ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
