[Lldb-commits] [PATCH] D35784: [LLD][MIPS] Fix Address::GetAddressClass() to return correct AddressClass based on the load address

[Nitesh Jain via Phabricator via lldb-commits]

nitesh.jain added a comment.

ping


https://reviews.llvm.org/D35784



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D11465: Fix "process load/unload" on android

[Nitesh Jain via Phabricator via lldb-commits]

nitesh.jain added a comment.

In https://reviews.llvm.org/D11465#826132, @tberghammer wrote:

> Thanks for all of the data. Based on this I think you are using a preview 
> version of android O what reports SDK 25 but the linker works the way an SDK 
> 26 system linker would do.
>
> I think the proper fix for the problem is to do something like what Greg 
> suggested to detect the correct function name based on the list of available 
> symbols instead of based on the SDK version. I will try to create a CL to fix 
> it in the next couple of days (unless you are happy to do it), but not sure 
> when I will have time for that and it is a bit tricky to test it.
>
> Until then you can try to do either update to a newer version of the system 
> image what reports SDK 26 (and make sure you are using a sufficiently new 
> LLDB) or locally hack the "PlatformAndroid::LoadImage" function to use the 
> SDK 26 version in case of SDK 25 as well (possibly with a check for 
> ro.build.version.release)


Thanks. As suggested by Greg will submit a  patch for that


Repository:
  rL LLVM

https://reviews.llvm.org/D11465



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

[Chris Bieneman via Phabricator via lldb-commits]

beanz added a comment.

@mgorny I want to apologize here but I need to ask you not to commit this until 
@chapuni and I can come to an agreement between this solution and 
https://reviews.llvm.org/D36211. He ping'd me on IRC yesterday after I left for 
the day, I'll try and get in touch with him today to see if we can agree on the 
path forward.


Repository:
  rL LLVM

https://reviews.llvm.org/D31367



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits