Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X
stigger added a comment. Ping. https://reviews.llvm.org/D20041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X
zturner added a subscriber: zturner. zturner added a comment. I like the approach taken here in general. One thing that I wonder about, if we have the Triple, why do we even need the PathSyntax at all? In light of the fact that not all Posix filesystems are case sensitive, this calls into question the usefulness of the Path Syntax since it is both unnecessary and insufficient. I do think that `FileSpec` should be completely independent of `Host`. Any host detection code should be in `FileSystem.h` and any remote detection code should be in `Platform` somewhere. Both of those are independent of this patch though. How difficult would be it be to eliminate the `PathSyntax` enumeration entirely and update every user of `PathSyntax` to use a triple instead? https://reviews.llvm.org/D20041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X
stigger added a comment.
In https://reviews.llvm.org/D20041#533725, @zturner wrote:
> How difficult would be it be to eliminate the `PathSyntax` enumeration
> entirely and update every user of `PathSyntax` to use a triple instead?
I've attempted to do it and hit two issues which I'm not sure how to resolve:
1. SymbolFilePDB.cpp:358 uses FileSpec with explicit `ePathSyntaxWindows`. It's
possible to do something like `llvm::Triple("unknown", "unknown", "windows")`,
but that kind of smells.
2. HostInfoBase.cpp:63 has a bunch of FileSpecs with `ePathSyntaxHostNative`,
but at that moment it is not yet possible to use `HostInfo::GetArchitecture()`,
because it's being constructed.
https://reviews.llvm.org/D20041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X
For #2 you can use llvm::GetProcessTriple(), i will think about #1 when I
have a chance to look at the code
On Sat, Sep 3, 2016 at 2:38 PM Vyacheslav Karpukhin <
vyaches...@karpukhin.com> wrote:
> stigger added a comment.
>
> In https://reviews.llvm.org/D20041#533725, @zturner wrote:
>
> > How difficult would be it be to eliminate the `PathSyntax` enumeration
> entirely and update every user of `PathSyntax` to use a triple instead?
>
>
> I've attempted to do it and hit two issues which I'm not sure how to
> resolve:
>
> 1. SymbolFilePDB.cpp:358 uses FileSpec with explicit `ePathSyntaxWindows`.
> It's possible to do something like `llvm::Triple("unknown", "unknown",
> "windows")`, but that kind of smells.
> 2. HostInfoBase.cpp:63 has a bunch of FileSpecs with
> `ePathSyntaxHostNative`, but at that moment it is not yet possible to use
> `HostInfo::GetArchitecture()`, because it's being constructed.
>
>
> https://reviews.llvm.org/D20041
>
>
>
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r280606 - XFAIL TestGdbRemoteExitCode failing tests
Author: tfiala Date: Sat Sep 3 19:43:10 2016 New Revision: 280606 URL: http://llvm.org/viewvc/llvm-project?rev=280606&view=rev Log: XFAIL TestGdbRemoteExitCode failing tests Tracked by: llvm.org/pr30271 Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/exit-code/TestGdbRemoteExitCode.py Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/exit-code/TestGdbRemoteExitCode.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/exit-code/TestGdbRemoteExitCode.py?rev=280606&r1=280605&r2=280606&view=diff == --- lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/exit-code/TestGdbRemoteExitCode.py (original) +++ lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/exit-code/TestGdbRemoteExitCode.py Sat Sep 3 19:43:10 2016 @@ -59,6 +59,7 @@ class TestGdbRemoteExitCode(GdbRemoteTes self.start_inferior() @llgs_test +@expectedFailureAll(bugnumber="llvm.org/pr30271") def test_start_inferior_llgs(self): self.init_llgs_test() self.build() @@ -118,6 +119,7 @@ class TestGdbRemoteExitCode(GdbRemoteTes self.inferior_exit_42() @llgs_test +@expectedFailureAll(bugnumber="llvm.org/pr30271") def test_inferior_exit_42_llgs(self): self.init_llgs_test() self.build() ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
