date:20160726

Re: [Lldb-commits] [PATCH] D22771: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets

2016-07-26 Thread Pavel Labath via lldb-commits

labath added a comment.

It seems this was added in 2014 for cross-compilation for android. Given that 
it's in a `if ! PYTHON` block and we don't use python anymore on android, I 
think it's pretty safe to remove.

Thanks.


Repository:
  rL LLVM

https://reviews.llvm.org/D22771



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r276734 - Fix DataExtractor::PeekData for zero length peeks

2016-07-26 Thread Pavel Labath via lldb-commits

Author: labath
Date: Tue Jul 26 03:11:57 2016
New Revision: 276734

URL: http://llvm.org/viewvc/llvm-project?rev=276734&view=rev
Log:
Fix DataExtractor::PeekData for zero length peeks

Summary:
The function was returning the null pointer for peeks of size zero, which seems 
like a sensible
thing to do, but is actually pretty easy to get bitten by that if you are 
extracting a variable
length field which happens to be of zero length and then doing pointer 
arithmetic on that (which
SymbolFileDWARF does, and ended up crashing in case of empty DW_AT_location).

This changes the function to return a null pointer only when it gets queried 
for data which is
outside of the range of the extractor, which is more c++-y, as one can still do 
reasonable things
with pointers to data of size zero (think, end() iterators).

I also add a test and fix some signedness warnings in the existing data 
extractor tests.

Reviewers: clayborg

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D22755

Modified:
lldb/trunk/include/lldb/Core/DataExtractor.h
lldb/trunk/unittests/Core/DataExtractorTest.cpp

Modified: lldb/trunk/include/lldb/Core/DataExtractor.h
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/DataExtractor.h?rev=276734&r1=276733&r2=276734&view=diff
==
--- lldb/trunk/include/lldb/Core/DataExtractor.h (original)
+++ lldb/trunk/include/lldb/Core/DataExtractor.h Tue Jul 26 03:11:57 2016
@@ -1139,7 +1139,7 @@ public:
 const uint8_t*
 PeekData (lldb::offset_t offset, lldb::offset_t length) const
 {
-if (length > 0 && ValidOffsetForDataOfSize(offset, length))
+if (ValidOffsetForDataOfSize(offset, length))
 return m_start + offset;
 return nullptr;
 }

Modified: lldb/trunk/unittests/Core/DataExtractorTest.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Core/DataExtractorTest.cpp?rev=276734&r1=276733&r2=276734&view=diff
==
--- lldb/trunk/unittests/Core/DataExtractorTest.cpp (original)
+++ lldb/trunk/unittests/Core/DataExtractorTest.cpp Tue Jul 26 03:11:57 2016
@@ -21,7 +21,7 @@ using namespace lldb_private;
 
 TEST(DataExtractorTest, GetBitfield)
 {
-char buffer[] = { 0x01, 0x23, 0x45, 0x67 };
+uint8_t buffer[] = { 0x01, 0x23, 0x45, 0x67 };
 DataExtractor LE(buffer, sizeof(buffer), lldb::eByteOrderLittle, 
sizeof(void *));
 DataExtractor BE(buffer, sizeof(buffer), lldb::eByteOrderBig, sizeof(void 
*));
 
@@ -33,7 +33,24 @@ TEST(DataExtractorTest, GetBitfield)
 ASSERT_EQ(buffer[1], BE.GetMaxU64Bitfield(&offset, sizeof(buffer), 8, 8));
 
 offset = 0;
-ASSERT_EQ(buffer[1], LE.GetMaxS64Bitfield(&offset, sizeof(buffer), 8, 8));
+ASSERT_EQ(int8_t(buffer[1]), LE.GetMaxS64Bitfield(&offset, sizeof(buffer), 
8, 8));
 offset = 0;
-ASSERT_EQ(buffer[1], BE.GetMaxS64Bitfield(&offset, sizeof(buffer), 8, 8));
+ASSERT_EQ(int8_t(buffer[1]), BE.GetMaxS64Bitfield(&offset, sizeof(buffer), 
8, 8));
+}
+
+TEST(DataExtractorTest, PeekData)
+{
+uint8_t buffer[] = { 0x01, 0x02, 0x03, 0x04 };
+DataExtractor E(buffer, sizeof buffer, lldb::eByteOrderLittle, 4);
+
+EXPECT_EQ(buffer + 0, E.PeekData(0, 0));
+EXPECT_EQ(buffer + 0, E.PeekData(0, 4));
+EXPECT_EQ(nullptr, E.PeekData(0, 5));
+
+EXPECT_EQ(buffer + 2, E.PeekData(2, 0));
+EXPECT_EQ(buffer + 2, E.PeekData(2, 2));
+EXPECT_EQ(nullptr, E.PeekData(2, 3));
+
+EXPECT_EQ(buffer + 4, E.PeekData(4, 0));
+EXPECT_EQ(nullptr, E.PeekData(4, 1));
 }


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22755: Fix DataExtractor::PeekData for zero length peeks

2016-07-26 Thread Pavel Labath via lldb-commits

This revision was automatically updated to reflect the committed changes.
Closed by commit rL276734: Fix DataExtractor::PeekData for zero length peeks 
(authored by labath).

Changed prior to commit:
  https://reviews.llvm.org/D22755?vs=65339&id=65478#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D22755

Files:
  lldb/trunk/include/lldb/Core/DataExtractor.h
  lldb/trunk/unittests/Core/DataExtractorTest.cpp

Index: lldb/trunk/unittests/Core/DataExtractorTest.cpp
===
--- lldb/trunk/unittests/Core/DataExtractorTest.cpp
+++ lldb/trunk/unittests/Core/DataExtractorTest.cpp
@@ -21,7 +21,7 @@
 
 TEST(DataExtractorTest, GetBitfield)
 {
-char buffer[] = { 0x01, 0x23, 0x45, 0x67 };
+uint8_t buffer[] = { 0x01, 0x23, 0x45, 0x67 };
 DataExtractor LE(buffer, sizeof(buffer), lldb::eByteOrderLittle, 
sizeof(void *));
 DataExtractor BE(buffer, sizeof(buffer), lldb::eByteOrderBig, sizeof(void 
*));
 
@@ -33,7 +33,24 @@
 ASSERT_EQ(buffer[1], BE.GetMaxU64Bitfield(&offset, sizeof(buffer), 8, 8));
 
 offset = 0;
-ASSERT_EQ(buffer[1], LE.GetMaxS64Bitfield(&offset, sizeof(buffer), 8, 8));
+ASSERT_EQ(int8_t(buffer[1]), LE.GetMaxS64Bitfield(&offset, sizeof(buffer), 
8, 8));
 offset = 0;
-ASSERT_EQ(buffer[1], BE.GetMaxS64Bitfield(&offset, sizeof(buffer), 8, 8));
+ASSERT_EQ(int8_t(buffer[1]), BE.GetMaxS64Bitfield(&offset, sizeof(buffer), 
8, 8));
+}
+
+TEST(DataExtractorTest, PeekData)
+{
+uint8_t buffer[] = { 0x01, 0x02, 0x03, 0x04 };
+DataExtractor E(buffer, sizeof buffer, lldb::eByteOrderLittle, 4);
+
+EXPECT_EQ(buffer + 0, E.PeekData(0, 0));
+EXPECT_EQ(buffer + 0, E.PeekData(0, 4));
+EXPECT_EQ(nullptr, E.PeekData(0, 5));
+
+EXPECT_EQ(buffer + 2, E.PeekData(2, 0));
+EXPECT_EQ(buffer + 2, E.PeekData(2, 2));
+EXPECT_EQ(nullptr, E.PeekData(2, 3));
+
+EXPECT_EQ(buffer + 4, E.PeekData(4, 0));
+EXPECT_EQ(nullptr, E.PeekData(4, 1));
 }
Index: lldb/trunk/include/lldb/Core/DataExtractor.h
===
--- lldb/trunk/include/lldb/Core/DataExtractor.h
+++ lldb/trunk/include/lldb/Core/DataExtractor.h
@@ -1139,7 +1139,7 @@
 const uint8_t*
 PeekData (lldb::offset_t offset, lldb::offset_t length) const
 {
-if (length > 0 && ValidOffsetForDataOfSize(offset, length))
+if (ValidOffsetForDataOfSize(offset, length))
 return m_start + offset;
 return nullptr;
 }


Index: lldb/trunk/unittests/Core/DataExtractorTest.cpp
===
--- lldb/trunk/unittests/Core/DataExtractorTest.cpp
+++ lldb/trunk/unittests/Core/DataExtractorTest.cpp
@@ -21,7 +21,7 @@
 
 TEST(DataExtractorTest, GetBitfield)
 {
-char buffer[] = { 0x01, 0x23, 0x45, 0x67 };
+uint8_t buffer[] = { 0x01, 0x23, 0x45, 0x67 };
 DataExtractor LE(buffer, sizeof(buffer), lldb::eByteOrderLittle, sizeof(void *));
 DataExtractor BE(buffer, sizeof(buffer), lldb::eByteOrderBig, sizeof(void *));
 
@@ -33,7 +33,24 @@
 ASSERT_EQ(buffer[1], BE.GetMaxU64Bitfield(&offset, sizeof(buffer), 8, 8));
 
 offset = 0;
-ASSERT_EQ(buffer[1], LE.GetMaxS64Bitfield(&offset, sizeof(buffer), 8, 8));
+ASSERT_EQ(int8_t(buffer[1]), LE.GetMaxS64Bitfield(&offset, sizeof(buffer), 8, 8));
 offset = 0;
-ASSERT_EQ(buffer[1], BE.GetMaxS64Bitfield(&offset, sizeof(buffer), 8, 8));
+ASSERT_EQ(int8_t(buffer[1]), BE.GetMaxS64Bitfield(&offset, sizeof(buffer), 8, 8));
+}
+
+TEST(DataExtractorTest, PeekData)
+{
+uint8_t buffer[] = { 0x01, 0x02, 0x03, 0x04 };
+DataExtractor E(buffer, sizeof buffer, lldb::eByteOrderLittle, 4);
+
+EXPECT_EQ(buffer + 0, E.PeekData(0, 0));
+EXPECT_EQ(buffer + 0, E.PeekData(0, 4));
+EXPECT_EQ(nullptr, E.PeekData(0, 5));
+
+EXPECT_EQ(buffer + 2, E.PeekData(2, 0));
+EXPECT_EQ(buffer + 2, E.PeekData(2, 2));
+EXPECT_EQ(nullptr, E.PeekData(2, 3));
+
+EXPECT_EQ(buffer + 4, E.PeekData(4, 0));
+EXPECT_EQ(nullptr, E.PeekData(4, 1));
 }
Index: lldb/trunk/include/lldb/Core/DataExtractor.h
===
--- lldb/trunk/include/lldb/Core/DataExtractor.h
+++ lldb/trunk/include/lldb/Core/DataExtractor.h
@@ -1139,7 +1139,7 @@
 const uint8_t*
 PeekData (lldb::offset_t offset, lldb::offset_t length) const
 {
-if (length > 0 && ValidOffsetForDataOfSize(offset, length))
+if (ValidOffsetForDataOfSize(offset, length))
 return m_start + offset;
 return nullptr;
 }
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22756: Fix incorrect form test in SymbolFileDWARF

2016-07-26 Thread Pavel Labath via lldb-commits

This revision was automatically updated to reflect the committed changes.
Closed by commit rL276735: Fix incorrect form test in SymbolFileDWARF (authored 
by labath).

Changed prior to commit:
  https://reviews.llvm.org/D22756?vs=65340&id=65479#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D22756

Files:
  lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
  lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

Index: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
===
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
@@ -4292,7 +4292,7 @@
 {
 location_is_const_value_data = false;
 has_explicit_location = true;
-if (form_value.BlockData())
+if (DWARFFormValue::IsBlockForm(form_value.Form()))
 {
 const DWARFDataExtractor& debug_info_data = 
get_debug_info_data();
 
Index: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
===
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
@@ -556,6 +556,7 @@
 {
 switch (form)
 {
+case DW_FORM_exprloc:
 case DW_FORM_block:
 case DW_FORM_block1:
 case DW_FORM_block2:


Index: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
===
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
@@ -4292,7 +4292,7 @@
 {
 location_is_const_value_data = false;
 has_explicit_location = true;
-if (form_value.BlockData())
+if (DWARFFormValue::IsBlockForm(form_value.Form()))
 {
 const DWARFDataExtractor& debug_info_data = get_debug_info_data();
 
Index: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
===
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
@@ -556,6 +556,7 @@
 {
 switch (form)
 {
+case DW_FORM_exprloc:
 case DW_FORM_block:
 case DW_FORM_block1:
 case DW_FORM_block2:
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r276735 - Fix incorrect form test in SymbolFileDWARF

2016-07-26 Thread Pavel Labath via lldb-commits

Author: labath
Date: Tue Jul 26 03:16:19 2016
New Revision: 276735

URL: http://llvm.org/viewvc/llvm-project?rev=276735&view=rev
Log:
Fix incorrect form test in SymbolFileDWARF

Summary:
We were checking whether an attribute is in block form by getting the block 
data pointer, which
was not correct as the pointer be null even if the attribute is in block form. 
Other places in
the file already use the correct test.

To make this work, I've needed to add DW_FORM_exprlock to the list of "block" 
forms, which seems
correct as that is how we are parsing it.

Reviewers: clayborg

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D22756

Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp?rev=276735&r1=276734&r2=276735&view=diff
==
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp Tue Jul 26 
03:16:19 2016
@@ -556,6 +556,7 @@ DWARFFormValue::IsBlockForm(const dw_for
 {
 switch (form)
 {
+case DW_FORM_exprloc:
 case DW_FORM_block:
 case DW_FORM_block1:
 case DW_FORM_block2:

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp?rev=276735&r1=276734&r2=276735&view=diff
==
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Tue Jul 26 
03:16:19 2016
@@ -4292,7 +4292,7 @@ SymbolFileDWARF::ParseVariableDIE
 {
 location_is_const_value_data = false;
 has_explicit_location = true;
-if (form_value.BlockData())
+if (DWARFFormValue::IsBlockForm(form_value.Form()))
 {
 const DWARFDataExtractor& debug_info_data = 
get_debug_info_data();
 


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22132: Support for OCaml native debugging

2016-07-26 Thread Elias Boutaleb via lldb-commits

ebtaleb added a comment.

What's left for commiting this revision? I did setup git-svn accordingly, but I 
don't have a commit bit.


https://reviews.llvm.org/D22132



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r276760 - reduce Green Dragon macOS build session filename length

2016-07-26 Thread Todd Fiala via lldb-commits

Author: tfiala
Date: Tue Jul 26 11:08:26 2016
New Revision: 276760

URL: http://llvm.org/viewvc/llvm-project?rev=276760&view=rev
Log:
reduce Green Dragon macOS build session filename length

The Green Dragon builder for macOS started failing yesterday with
session filenames that were too long.  This change modifies the
Xcode target that runs the test suite and specifies a shorter
session filename format.

rdar://27539818

Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=276760&r1=276759&r2=276760&view=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Tue Jul 26 11:08:26 2016
@@ -6096,7 +6096,7 @@
 /* Begin PBXLegacyTarget section */
2387551E1C24974600CCE8C3 /* lldb-python-test-suite */ = {
isa = PBXLegacyTarget;
-   buildArgumentsString = "-u $(SRCROOT)/test/dotest.py 
--apple-sdk $(PLATFORM_NAME) 
--executable=$(BUILD_DIR)/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lldb -C 
$(LLDB_PYTHON_TESTSUITE_CC) --results-formatter 
lldbsuite.test_event.formatter.xunit.XunitFormatter --results-file 
$(BUILD_DIR)/test-results.xml --rerun-all-issues --env TERM=vt100 
-O--xpass=ignore";
+   buildArgumentsString = "-u $(SRCROOT)/test/dotest.py 
--apple-sdk $(PLATFORM_NAME) 
--executable=$(BUILD_DIR)/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lldb -C 
$(LLDB_PYTHON_TESTSUITE_CC) --session-file-format fm --results-formatter 
lldbsuite.test_event.formatter.xunit.XunitFormatter --results-file 
$(BUILD_DIR)/test-results.xml --rerun-all-issues --env TERM=vt100 
-O--xpass=ignore";
buildConfigurationList = 238755241C24974600CCE8C3 /* 
Build configuration list for PBXLegacyTarget "lldb-python-test-suite" */;
buildPhases = (
);


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r276795 - Check both private & public states to decide if you need to halt before killing.

2016-07-26 Thread Jim Ingham via lldb-commits

Author: jingham
Date: Tue Jul 26 14:47:45 2016
New Revision: 276795

URL: http://llvm.org/viewvc/llvm-project?rev=276795&view=rev
Log:
Check both private & public states to decide if you need to halt before killing.

We were just checking the public state, but that meant if you were hung in a 
long
running hand-called function, we wouldn't know to interrupt the process, and we 
would
not succeed in killing it.



Modified:
lldb/trunk/source/Target/Process.cpp

Modified: lldb/trunk/source/Target/Process.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Process.cpp?rev=276795&r1=276794&r2=276795&view=diff
==
--- lldb/trunk/source/Target/Process.cpp (original)
+++ lldb/trunk/source/Target/Process.cpp Tue Jul 26 14:47:45 2016
@@ -3634,7 +3634,10 @@ Error
 Process::StopForDestroyOrDetach(lldb::EventSP &exit_event_sp)
 {
 Error error;
-if (m_public_state.GetValue() == eStateRunning)
+
+// Check both the public & private states here.  If we're hung evaluating 
an expression, for instance, then
+// the public state will be stopped, but we still need to interrupt.
+if (m_public_state.GetValue() == eStateRunning || 
m_private_state.GetValue() == eStateRunning)
 {
 Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_PROCESS));
 if (log)


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r276796 - The ARM single-step handling needs to look for breakpoint on the next instruction.

2016-07-26 Thread Jim Ingham via lldb-commits

Author: jingham
Date: Tue Jul 26 14:50:25 2016
New Revision: 276796

URL: http://llvm.org/viewvc/llvm-project?rev=276796&view=rev
Log:
The ARM single-step handling needs to look for breakpoint on the next 
instruction.



Modified:
lldb/trunk/source/Plugins/Process/Utility/StopInfoMachException.cpp

Modified: lldb/trunk/source/Plugins/Process/Utility/StopInfoMachException.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/StopInfoMachException.cpp?rev=276796&r1=276795&r2=276796&view=diff
==
--- lldb/trunk/source/Plugins/Process/Utility/StopInfoMachException.cpp 
(original)
+++ lldb/trunk/source/Plugins/Process/Utility/StopInfoMachException.cpp Tue Jul 
26 14:50:25 2016
@@ -450,7 +450,8 @@ StopInfoMachException::CreateStopReasonW
 if (exc_code == 1 && exc_sub_code == 0) // 
EXC_ARM_BREAKPOINT
 {
 // This is hit when we single instruction step aka 
MDSCR_EL1 SS bit 0 is set
-return StopInfo::CreateStopReasonToTrace(thread);
+is_actual_breakpoint = false;
+is_trace_if_actual_breakpoint_missing = true;
 }
 if (exc_code == 0x102) // EXC_ARM_DA_DEBUG
 {


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r276814 - Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets

2016-07-26 Thread Omair Javaid via lldb-commits

Author: omjavaid
Date: Tue Jul 26 16:43:02 2016
New Revision: 276814

URL: http://llvm.org/viewvc/llvm-project?rev=276814&view=rev
Log:
Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets

Differential revision: https://reviews.llvm.org/D22771


Modified:
lldb/trunk/cmake/modules/LLDBConfig.cmake

Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules/LLDBConfig.cmake?rev=276814&r1=276813&r2=276814&view=diff
==
--- lldb/trunk/cmake/modules/LLDBConfig.cmake (original)
+++ lldb/trunk/cmake/modules/LLDBConfig.cmake Tue Jul 26 16:43:02 2016
@@ -167,12 +167,6 @@ function(find_python_libs_windows)
 endfunction(find_python_libs_windows)
 
 if (NOT LLDB_DISABLE_PYTHON)
-  if(UNIX)
-# This is necessary for crosscompile on Ubuntu 14.04 64bit. Need a proper 
fix.
-if(CMAKE_SIZEOF_VOID_P EQUAL 8)
-  set(CMAKE_LIBRARY_ARCHITECTURE "x86_64-linux-gnu")
-endif()
-  endif()
 
   if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
 find_python_libs_windows()


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22771: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets

2016-07-26 Thread Muhammad Omair Javaid via lldb-commits

omjavaid added a comment.

I am going ahead and committing this patch. If it breaks any build please 
revert it.


Repository:
  rL LLVM

https://reviews.llvm.org/D22771



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22771: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets

2016-07-26 Thread Muhammad Omair Javaid via lldb-commits

This revision was automatically updated to reflect the committed changes.
Closed by commit rL276814: Fix LLDBConfig.cmake to enable python enabled build 
for all 64 bit lldb targets (authored by omjavaid).

Changed prior to commit:
  https://reviews.llvm.org/D22771?vs=65397&id=65612#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D22771

Files:
  lldb/trunk/cmake/modules/LLDBConfig.cmake

Index: lldb/trunk/cmake/modules/LLDBConfig.cmake
===
--- lldb/trunk/cmake/modules/LLDBConfig.cmake
+++ lldb/trunk/cmake/modules/LLDBConfig.cmake
@@ -167,12 +167,6 @@
 endfunction(find_python_libs_windows)
 
 if (NOT LLDB_DISABLE_PYTHON)
-  if(UNIX)
-# This is necessary for crosscompile on Ubuntu 14.04 64bit. Need a proper 
fix.
-if(CMAKE_SIZEOF_VOID_P EQUAL 8)
-  set(CMAKE_LIBRARY_ARCHITECTURE "x86_64-linux-gnu")
-endif()
-  endif()
 
   if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
 find_python_libs_windows()


Index: lldb/trunk/cmake/modules/LLDBConfig.cmake
===
--- lldb/trunk/cmake/modules/LLDBConfig.cmake
+++ lldb/trunk/cmake/modules/LLDBConfig.cmake
@@ -167,12 +167,6 @@
 endfunction(find_python_libs_windows)
 
 if (NOT LLDB_DISABLE_PYTHON)
-  if(UNIX)
-# This is necessary for crosscompile on Ubuntu 14.04 64bit. Need a proper fix.
-if(CMAKE_SIZEOF_VOID_P EQUAL 8)
-  set(CMAKE_LIBRARY_ARCHITECTURE "x86_64-linux-gnu")
-endif()
-  endif()
 
   if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
 find_python_libs_windows()
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] Buildbot numbers for the week of 7/10/2016 - 7/16/2016

2016-07-26 Thread Galina Kistanova via lldb-commits

Hello everyone,

Below are some buildbot numbers for the week of 7/10/2016 - 7/16/2016.

Please see the same data in attached csv files:

The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green);
Count of commits by project;
Number of completed builds, failed builds and average build time for
successful builds per active builder;
Average waiting time for a revision to get build result per active builder
(response time);

Thanks

Galina


The longest time each builder was red during the last week:

 buildername|  was_red
+---
 clang-sphinx-docs  | 122:54:15
 sanitizer-x86_64-linux-fuzzer  | 58:12:52
 perf-x86_64-penryn-O3-polly-before-vectorizer  | 39:52:18
 clang-native-aarch64-full  | 31:59:05
 sanitizer-x86_64-linux-bootstrap   | 27:37:36
 perf-x86_64-penryn-O3-polly-before-vectorizer-unprofitable | 25:34:19
 clang-cmake-armv7-a15-selfhost | 24:00:48
 clang-x86_64-linux-selfhost-modules| 23:57:52
 polly-amd64-linux  | 23:29:30
 clang-cmake-thumbv7-a15-full-sh| 23:23:52
 lldb-windows7-android  | 22:15:39
 clang-cmake-aarch64-quick  | 21:54:32
 clang-3stage-ubuntu| 21:39:52
 clang-x86-win2008-selfhost | 19:02:47
 perf-x86_64-penryn-O3-polly-unprofitable   | 18:50:41
 perf-x86_64-penryn-O3  | 18:03:53
 clang-x64-ninja-win7   | 17:19:40
 lldb-x86_64-ubuntu-14.04-android   | 17:09:21
 clang-cmake-armv7-a15-selfhost-neon| 16:35:10
 perf-x86_64-penryn-O3-polly-before-vectorizer-detect-only  | 16:34:08
 clang-cmake-aarch64-full   | 16:11:16
 clang-native-arm-lnt   | 16:00:43
 lldb-x86_64-ubuntu-14.04-cmake | 13:02:12
 clang-ppc64be-linux-multistage | 11:36:28
 sanitizer-x86_64-linux-fast| 10:24:56
 perf-x86_64-penryn-O3-polly-fast   | 10:22:11
 sanitizer-x86_64-linux | 09:52:43
 clang-cmake-mipsel | 09:38:52
 clang-atom-d525-fedora-rel | 09:33:56
 perf-x86_64-penryn-O3-polly| 08:11:16
 clang-ppc64le-linux-multistage | 06:07:25
 sanitizer-ppc64le-linux| 04:21:05
 llvm-clang-lld-x86_64-debian-fast  | 04:16:01
 clang-cuda-build   | 04:13:46
 clang-x86_64-debian-fast   | 04:11:41
 llvm-mips-linux| 04:01:44
 llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast   | 04:01:03
 clang-ppc64le-linux-lnt| 04:00:27
 clang-s390x-linux  | 03:50:24
 clang-ppc64be-linux| 03:46:53
 clang-ppc64be-linux-lnt| 03:46:29
 perf-x86_64-penryn-O3-polly-parallel-fast  | 03:46:14
 lld-x86_64-freebsd | 03:39:34
 sanitizer-windows  | 03:32:27
 lld-x86_64-darwin13| 03:27:07
 llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast | 03:23:57
 lld-x86_64-win7| 03:22:32
 clang-cmake-aarch64-42vma  | 03:20:10
 clang-ppc64le-linux| 03:00:31
 clang-cmake-armv7-a15  | 02:27:04
 clang-cmake-thumbv7-a15| 02:22:23
 lldb-x86_64-ubuntu-14.04-buildserver   | 02:15:55
 clang-x86_64-linux-abi-test| 01:46:08
 clang-cmake-armv7-a15-full | 01:35:45
 lldb-amd64-ninja-netbsd7   | 01:35:32
 sanitizer-x86_64-linux-autoconf| 01:14:04
 llvm-hexagon-elf   | 01:04:58
 clang-hexagon-elf  | 00:57:35
(58 rows)


"Status change ratio" by active builder (percent of builds that changed the
builder status f

[Lldb-commits] Buildbot numbers for the last week of 7/17/2016 - 7/23/2016

2016-07-26 Thread Galina Kistanova via lldb-commits

Hello everyone,

Below are some buildbot numbers for the last week of 7/17/2016 - 7/23/2016.

Please see the same data in attached csv files:

The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green);
Count of commits by project;
Number of completed builds, failed builds and average build time for
successful builds per active builder;
Average waiting time for a revision to get build result per active builder
(response time);

Thanks

Galina


The longest time each builder was red during the last week:

 buildername|  was_red
+---
 lld-sphinx-docs| 91:31:43
 sanitizer-x86_64-linux | 87:21:09
 clang-ppc64le-linux-multistage | 86:00:46
 clang-x86_64-linux-selfhost-modules| 83:49:54
 llvm-sphinx-docs   | 76:46:33
 sanitizer-windows  | 56:59:53
 clang-cmake-mips   | 47:42:46
 sanitizer-x86_64-linux-bootstrap   | 26:15:39
 libcxx-libcxxabi-x86_64-linux-ubuntu-ubsan | 25:10:32
 sanitizer-x86_64-linux-fast| 23:49:35
 perf-x86_64-penryn-O3  | 23:35:44
 clang-x64-ninja-win7   | 23:00:15
 llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast   | 21:45:58
 libcxx-libcxxabi-x86_64-linux-ubuntu-cxx1z | 20:54:33
 libcxx-libcxxabi-x86_64-linux-ubuntu-cxx14 | 20:40:47
 libcxx-libcxxabi-x86_64-linux-ubuntu-cxx11 | 20:40:40
 lld-x86_64-win7| 17:16:34
 clang-cmake-thumbv7-a15-full-sh| 14:51:50
 perf-x86_64-penryn-O3-polly-before-vectorizer  | 12:33:20
 perf-x86_64-penryn-O3-polly-before-vectorizer-detect-only  | 12:06:37
 libcxx-libcxxabi-libunwind-arm-linux-noexceptions  | 10:16:46
 libcxx-libcxxabi-libunwind-arm-linux   | 10:16:02
 clang-native-arm-lnt   | 08:45:57
 libcxx-libcxxabi-x86_64-linux-debian-noexceptions  | 08:10:30
 clang-atom-d525-fedora-rel | 08:03:38
 sanitizer-x86_64-linux-autoconf| 07:46:16
 clang-cmake-armv7-a15-selfhost-neon| 06:47:47
 libcxx-libcxxabi-x86_64-linux-ubuntu-asan  | 06:24:43
 clang-cmake-aarch64-full   | 05:58:51
 lldb-x86_64-ubuntu-14.04-android   | 05:18:47
 clang-cmake-armv7-a15-full | 04:29:19
 clang-ppc64be-linux-multistage | 04:18:44
 lldb-windows7-android  | 04:12:40
 sanitizer-ppc64le-linux| 04:10:15
 llvm-mips-linux| 04:04:33
 clang-cmake-mipsel | 04:03:48
 clang-ppc64le-linux-lnt| 03:45:08
 libcxx-libcxxabi-x86_64-linux-debian   | 03:44:43
 polly-amd64-linux  | 03:37:34
 clang-cmake-aarch64-quick  | 03:28:50
 llvm-clang-lld-x86_64-debian-fast  | 03:24:44
 sanitizer-ppc64be-linux| 03:11:02
 libcxx-libcxxabi-x86_64-linux-ubuntu-msan  | 03:02:30
 clang-ppc64le-linux| 02:54:14
 clang-x86_64-debian-fast   | 02:52:14
 clang-ppc64be-linux-lnt| 02:49:48
 clang-cmake-armv7-a15  | 02:43:00
 clang-cmake-thumbv7-a15| 02:38:30
 lldb-x86_64-ubuntu-14.04-buildserver   | 02:36:04
 lldb-amd64-ninja-netbsd7   | 02:34:58
 libcxx-libcxxabi-x86_64-linux-ubuntu-gcc49-cxx11   | 02:32:33
 clang-3stage-ubuntu| 02:29:47
 perf-x86_64-penryn-O3-polly-before-vectorizer-unprofitable | 02:27:16
 clang-hexagon-elf  | 02:18:34
 libcxx-libcxxabi-x86_64-linux-ubuntu-unstable-abi  | 02:18:17
 libcxx-libcxxabi-x86_64-linux-ubuntu-tsan  | 02:17:22
 lldb-x86_64-ubuntu-14.04-cmake | 02:17:01
 clang-cuda-build   | 02:16:16
 clang-ppc64be-linux| 02:15:41
 libcxx-libcxxabi-x86_64

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-07-26 Thread Saleem Abdulrasool via lldb-commits

compnerd added a subscriber: sas.
compnerd added a comment.

@emaste I think so.  I was hoping that @zturner or @sas would be able to get a 
windows run.  However, Linux and FreeBSD should give us some assurance that 
this is good.  How about I go ahead and commit this tomorrow?


https://reviews.llvm.org/D20436



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22771: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets

[Lldb-commits] [lldb] r276734 - Fix DataExtractor::PeekData for zero length peeks

Re: [Lldb-commits] [PATCH] D22755: Fix DataExtractor::PeekData for zero length peeks

Re: [Lldb-commits] [PATCH] D22756: Fix incorrect form test in SymbolFileDWARF

[Lldb-commits] [lldb] r276735 - Fix incorrect form test in SymbolFileDWARF

Re: [Lldb-commits] [PATCH] D22132: Support for OCaml native debugging

[Lldb-commits] [lldb] r276760 - reduce Green Dragon macOS build session filename length

[Lldb-commits] [lldb] r276795 - Check both private & public states to decide if you need to halt before killing.

[Lldb-commits] [lldb] r276796 - The ARM single-step handling needs to look for breakpoint on the next instruction.

[Lldb-commits] [lldb] r276814 - Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets

Re: [Lldb-commits] [PATCH] D22771: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets

Re: [Lldb-commits] [PATCH] D22771: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets

[Lldb-commits] Buildbot numbers for the week of 7/10/2016 - 7/16/2016

[Lldb-commits] Buildbot numbers for the last week of 7/17/2016 - 7/23/2016

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

15 matches

Site Navigation

Mail list logo

Footer information