[Lldb-commits] [PATCH] D14488: Add --curses shortcut for specifying the curses-based test results formatter.
tfiala created this revision. tfiala added a reviewer: clayborg. tfiala added a subscriber: lldb-commits. This shortcut is equivalent to specifying: --results-formatter lldbsuite.test.curses_results.Curses --results-file stdout (or --results-file /dev/stdout on some systems) The change adds the --curses shortcut, documenting in the test results argument group. It also ensures the --curses option is removed when running the dotest.py inferiors. The change also removes a duplicate 'import sys' found while I prepared this. http://reviews.llvm.org/D14488 Files: packages/Python/lldbsuite/test/dosep.py packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/dotest_args.py Index: packages/Python/lldbsuite/test/dotest_args.py === --- packages/Python/lldbsuite/test/dotest_args.py +++ packages/Python/lldbsuite/test/dotest_args.py @@ -151,6 +151,10 @@ # Test results support. group = parser.add_argument_group('Test results options') group.add_argument( +'--curses', +action='store_true', +help='Shortcut for specifying test results using the curses formatter') +group.add_argument( '--results-file', action='store', help=('Specifies the file where test results will be written ' Index: packages/Python/lldbsuite/test/dotest.py === --- packages/Python/lldbsuite/test/dotest.py +++ packages/Python/lldbsuite/test/dotest.py @@ -22,7 +22,6 @@ from __future__ import print_function # System modules -import sys import atexit import importlib import os @@ -751,6 +750,11 @@ test_runner_name = args.test_runner_name # Capture test results-related args. +if args.curses and not args.inferior: +# Act as if the following args were set. +args.results_formatter = "lldbsuite.test.curses_results.Curses" +args.results_file = "stdout" + if args.results_file: results_filename = args.results_file Index: packages/Python/lldbsuite/test/dosep.py === --- packages/Python/lldbsuite/test/dosep.py +++ packages/Python/lldbsuite/test/dosep.py @@ -1227,6 +1227,10 @@ _remove_option(dotest_argv, "--results-formatter-option", "-O", True) +# Remove the --curses shortcut if specified. +if dotest_options.curses: +_remove_option(dotest_argv, "--curses", None, False) + # Remove test runner name if present. if dotest_options.test_runner_name is not None: _remove_option(dotest_argv, "--test-runner-name", None, True) Index: packages/Python/lldbsuite/test/dotest_args.py === --- packages/Python/lldbsuite/test/dotest_args.py +++ packages/Python/lldbsuite/test/dotest_args.py @@ -151,6 +151,10 @@ # Test results support. group = parser.add_argument_group('Test results options') group.add_argument( +'--curses', +action='store_true', +help='Shortcut for specifying test results using the curses formatter') +group.add_argument( '--results-file', action='store', help=('Specifies the file where test results will be written ' Index: packages/Python/lldbsuite/test/dotest.py === --- packages/Python/lldbsuite/test/dotest.py +++ packages/Python/lldbsuite/test/dotest.py @@ -22,7 +22,6 @@ from __future__ import print_function # System modules -import sys import atexit import importlib import os @@ -751,6 +750,11 @@ test_runner_name = args.test_runner_name # Capture test results-related args. +if args.curses and not args.inferior: +# Act as if the following args were set. +args.results_formatter = "lldbsuite.test.curses_results.Curses" +args.results_file = "stdout" + if args.results_file: results_filename = args.results_file Index: packages/Python/lldbsuite/test/dosep.py === --- packages/Python/lldbsuite/test/dosep.py +++ packages/Python/lldbsuite/test/dosep.py @@ -1227,6 +1227,10 @@ _remove_option(dotest_argv, "--results-formatter-option", "-O", True) +# Remove the --curses shortcut if specified. +if dotest_options.curses: +_remove_option(dotest_argv, "--curses", None, False) + # Remove test runner name if present. if dotest_options.test_runner_name is not None: _remove_option(dotest_argv, "--test-runner-name", None, True) ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252429 - autotools: Also link the new go libraries
Author: sylvestre Date: Sun Nov 8 16:30:34 2015 New Revision: 252429 URL: http://llvm.org/viewvc/llvm-project?rev=252429&view=rev Log: autotools: Also link the new go libraries Modified: lldb/trunk/lib/Makefile lldb/trunk/source/Plugins/Makefile Modified: lldb/trunk/lib/Makefile URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lib/Makefile?rev=252429&r1=252428&r2=252429&view=diff == --- lldb/trunk/lib/Makefile (original) +++ lldb/trunk/lib/Makefile Sun Nov 8 16:30:34 2015 @@ -51,6 +51,7 @@ USEDLIBS = lldbAPI.a \ lldbPluginDynamicLoaderMacOSXDYLD.a \ lldbPluginDynamicLoaderWindowsDYLD.a \ lldbPluginExpressionParserClang.a \ + lldbPluginExpressionParserGo.a \ lldbPluginInstructionARM.a \ lldbPluginInstructionARM64.a \ lldbPluginInstructionMIPS.a \ @@ -64,6 +65,7 @@ USEDLIBS = lldbAPI.a \ lldbPluginLanguageRuntimeGo.a \ lldbPluginObjCLanguage.a \ lldbPluginObjCPlusPlusLanguage.a \ + lldbPluginGoLanguage.a \ lldbPluginObjectContainerBSDArchive.a \ lldbPluginObjectContainerMachOArchive.a \ lldbPluginObjectFileELF.a \ Modified: lldb/trunk/source/Plugins/Makefile URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Makefile?rev=252429&r1=252428&r2=252429&view=diff == --- lldb/trunk/source/Plugins/Makefile (original) +++ lldb/trunk/source/Plugins/Makefile Sun Nov 8 16:30:34 2015 @@ -35,6 +35,7 @@ PARALLEL_DIRS := ABI/MacOSX-arm ABI/MacO DynamicLoader/Windows-DYLD \ JITLoader/GDB \ ExpressionParser/Clang \ + ExpressionParser/Go \ OperatingSystem/Go \ OperatingSystem/Python \ SystemRuntime/MacOSX \ ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252438 - Fix up curses_results.py for new package specification requirement.
Author: tfiala Date: Sun Nov 8 18:23:01 2015 New Revision: 252438 URL: http://llvm.org/viewvc/llvm-project?rev=252438&view=rev Log: Fix up curses_results.py for new package specification requirement. This was breaking but probably missed since it is currently infrequently used. Modified: lldb/trunk/packages/Python/lldbsuite/test/curses_results.py Modified: lldb/trunk/packages/Python/lldbsuite/test/curses_results.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/curses_results.py?rev=252438&r1=252437&r2=252438&view=diff == --- lldb/trunk/packages/Python/lldbsuite/test/curses_results.py (original) +++ lldb/trunk/packages/Python/lldbsuite/test/curses_results.py Sun Nov 8 18:23:01 2015 @@ -17,13 +17,13 @@ import curses import datetime import math import sys -import test_results import time # Third-party modules # LLDB modules from . import lldbcurses +from . import test_results class Curses(test_results.ResultsFormatter): """Receives live results from tests that are running and reports them to the terminal in a curses GUI""" ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252441 - Added myself to the CODE_OWNERS.txt list for a few subsystems.
Author: tfiala Date: Sun Nov 8 19:24:36 2015 New Revision: 252441 URL: http://llvm.org/viewvc/llvm-project?rev=252441&view=rev Log: Added myself to the CODE_OWNERS.txt list for a few subsystems. I'm primarily testing my git-svn setup. Modified: lldb/trunk/CODE_OWNERS.txt Modified: lldb/trunk/CODE_OWNERS.txt URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/CODE_OWNERS.txt?rev=252441&r1=252440&r2=252441&view=diff == --- lldb/trunk/CODE_OWNERS.txt (original) +++ lldb/trunk/CODE_OWNERS.txt Sun Nov 8 19:24:36 2015 @@ -52,3 +52,8 @@ D: CMake build, Host (common+windows), P N: Oleksiy Vyalov E: ovya...@google.com D: Linux, Android + +N: Todd Fiala +E: todd.fi...@gmail.com +D: Test Suite subsystems (concurrent test runners, test events, TestResults system), gdb-remote protocol tests + ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits