Re: [Lldb-commits] [PATCH] D14042: Add more NetBSD platform glue for lldb

2015-11-01 Thread youri mouton via lldb-commits 
youri added a subscriber: youri.
youri added a comment.

This builds on OS X:

Darwin mac.local 15.0.0 Darwin Kernel Version 15.0.0: Wed Aug 26 16:57:32 PDT 
2015; root:xnu-3247.1.106~1/RELEASE_X86_64 x86_64


Repository:
  rL LLVM

http://reviews.llvm.org/D14042



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14037: Reuse native curses(8) library on NetBSD

2015-11-01 Thread youri mouton via lldb-commits 
youri added a subscriber: youri.
youri added a comment.

Builds on OS X:

  Darwin mac.local 15.0.0 Darwin Kernel Version 15.0.0: Wed Aug 26 16:57:32 PDT 
2015; root:xnu-3247.1.106~1/RELEASE_X86_64 x86_64


Repository:
  rL LLVM

http://reviews.llvm.org/D14037



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

2015-11-01 Thread Mohit Bhakkad via lldb-commits 
mohit.bhakkad added a comment.

Is it okay to commit now?


Repository:
  rL LLVM

http://reviews.llvm.org/D13296



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14111: Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation

2015-11-01 Thread Bhushan Attarde via lldb-commits 
bhushan added a comment.

Hi Sean/Jim

Could you please find some time to review this?

Thanks.


Repository:
  rL LLVM

http://reviews.llvm.org/D14111



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14197: Handle the options and parameters separator in every MI command

2015-11-01 Thread Ilia K via lldb-commits 
ki.stfu requested changes to this revision.
This revision now requires changes to proceed.


Comment at: tools/lldb-mi/MICmdBase.cpp:102
@@ -99,2 +101,3 @@
 m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgFrame, 
m_FrameArgMandatory, true, CMICmdArgValListBase::eArgValType_Number, 1));
+m_setCmdArgs.Add(new CMICmdArgValConsume(m_constStrArgConsume, false));
 }

The -data-disassemble command has '--' mandatory argument, but now it's always 
optional argument. Should it use m_ConsumeArgMandatory as it works for 
--thread/--frame etc?


Comment at: tools/lldb-mi/MICmdCmdData.cpp:280
@@ -279,3 +278,2 @@
 new CMICmdArgValOptionShort(m_constStrArgAddrEnd, true, true, 
CMICmdArgValListBase::eArgValType_StringQuotedNumber, 1));
-m_setCmdArgs.Add(new CMICmdArgValConsume(m_constStrArgConsume, true));
 m_setCmdArgs.Add(new CMICmdArgValNumber(m_constStrArgMode, true, true));

Please expand MiDataTestCase.test_lldbmi_data_disassemble test to check that it 
still gives an error without '--' argument.


http://reviews.llvm.org/D14197



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits