[Lldb-commits] [PATCH] D13636: Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in /usr/lib/debug on Windows

[Vadim Macagon via lldb-commits]

enlight created this revision.
enlight added reviewers: zturner, clayborg.
enlight added a subscriber: lldb-commits.
enlight set the repository for this revision to rL LLVM.

`/usr/lib/debug` doesn't exist on Windows so there's no point even attempting 
to look for symbol files in there.

Repository:
  rL LLVM

http://reviews.llvm.org/D13636

Files:
  source/Host/common/Symbols.cpp

Index: source/Host/common/Symbols.cpp
===
--- source/Host/common/Symbols.cpp
+++ source/Host/common/Symbols.cpp
@@ -235,8 +235,10 @@
 // Add current working directory.
 debug_file_search_paths.AppendIfUnique (FileSpec(".", true));
 
+#ifndef LLVM_ON_WIN32
 // Add /usr/lib/debug directory.
 debug_file_search_paths.AppendIfUnique (FileSpec("/usr/lib/debug", 
true));
+#endif // LLVM_ON_WIN32
 
 std::string uuid_str;
 const UUID &module_uuid = module_spec.GetUUID();


Index: source/Host/common/Symbols.cpp
===
--- source/Host/common/Symbols.cpp
+++ source/Host/common/Symbols.cpp
@@ -235,8 +235,10 @@
 // Add current working directory.
 debug_file_search_paths.AppendIfUnique (FileSpec(".", true));
 
+#ifndef LLVM_ON_WIN32
 // Add /usr/lib/debug directory.
 debug_file_search_paths.AppendIfUnique (FileSpec("/usr/lib/debug", true));
+#endif // LLVM_ON_WIN32
 
 std::string uuid_str;
 const UUID &module_uuid = module_spec.GetUUID();
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13636: Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in /usr/lib/debug on Windows

[Vadim Macagon via lldb-commits]

enlight added a comment.

Zach,

I've looked at the path separator issue you've mentioned earlier in D13201 
, and I think it's fine 
as is. All those paths with the forward slashes end up in a FileSpec, which 
converts forward slashes to backward slashes before passing them through to any 
Win32 APIs, and `FileSpec::GetPath()` also converts slashes by default.


Repository:
  rL LLVM

http://reviews.llvm.org/D13636



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13448: Update swig generation shell scripts to run under Python 3.x

[Zachary Turner via lldb-commits]

Yes this went in

On Sat, Oct 10, 2015 at 9:20 PM Todd Fiala  wrote:

> tfiala added a comment.
>
> Hey Zachary, I think this one went in, didn't it?  Can you close it out if
> so?  Thanks!
>
>
> http://reviews.llvm.org/D13448
>
>
>
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13636: Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in /usr/lib/debug on Windows

[Zachary Turner via lldb-commits]

Ok, sounds good then.  Thanks for checking

On Sun, Oct 11, 2015 at 9:23 AM Vadim Macagon 
wrote:

> enlight added a comment.
>
> Zach,
>
> I've looked at the path separator issue you've mentioned earlier in D13201
> , and I think it's
> fine as is. All those paths with the forward slashes end up in a FileSpec,
> which converts forward slashes to backward slashes before passing them
> through to any Win32 APIs, and `FileSpec::GetPath()` also converts slashes
> by default.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D13636
>
>
>
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12612: Fix dotest on Windows after multiprocessing refactor

[Zachary Turner via lldb-commits]

Yes

On Sat, Oct 10, 2015 at 9:18 PM Todd Fiala  wrote:

> tfiala added a comment.
>
> Did this go in, Zachary?  I'm just looking to clear out my reviews and
> this one seems to still be open.
>
>
> http://reviews.llvm.org/D12612
>
>
>
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13448: Update swig generation shell scripts to run under Python 3.x

[Todd Fiala via lldb-commits]

tfiala closed this revision.
tfiala added a comment.

Great!  Closing out.


http://reviews.llvm.org/D13448



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12612: Fix dotest on Windows after multiprocessing refactor

[Todd Fiala via lldb-commits]

tfiala closed this revision.
tfiala added a comment.

Great, thanks!


http://reviews.llvm.org/D12612



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D13638: Add a missing Mutex Locker in ResetCurrentInlinedDepth

[Keno Fischer via lldb-commits]

loladiro created this revision.
loladiro added reviewers: clayborg, jingham.
loladiro added a subscriber: lldb-commits.
loladiro set the repository for this revision to rL LLVM.

This function reads m_frames, so it needs to lock the mutex like all other 
function that access m_frames. Found using AddressSanitizer.

Repository:
  rL LLVM

http://reviews.llvm.org/D13638

Files:
  source/Target/StackFrameList.cpp

Index: source/Target/StackFrameList.cpp
===
--- source/Target/StackFrameList.cpp
+++ source/Target/StackFrameList.cpp
@@ -105,6 +105,8 @@
 void
 StackFrameList::ResetCurrentInlinedDepth ()
 {
+Mutex::Locker locker (m_mutex);
+
 if (m_show_inlined_frames)
 {
 GetFramesUpTo(0);


Index: source/Target/StackFrameList.cpp
===
--- source/Target/StackFrameList.cpp
+++ source/Target/StackFrameList.cpp
@@ -105,6 +105,8 @@
 void
 StackFrameList::ResetCurrentInlinedDepth ()
 {
+Mutex::Locker locker (m_mutex);
+
 if (m_show_inlined_frames)
 {
 GetFramesUpTo(0);
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

[Kamil Rytarowski via lldb-commits]

krytarowski updated this revision to Diff 37077.

Repository:
  rL LLVM

http://reviews.llvm.org/D13334

Files:
  include/lldb/Host/Config.h
  include/lldb/Host/HostInfo.h
  include/lldb/Host/HostNativeThread.h
  include/lldb/Host/HostNativeThreadForward.h
  include/lldb/Host/netbsd/Config.h
  include/lldb/Host/netbsd/HostInfoNetBSD.h
  include/lldb/Host/netbsd/HostThreadNetBSD.h
  source/Host/netbsd/Host.cpp
  source/Host/netbsd/HostInfoNetBSD.cpp
  source/Host/netbsd/HostThreadNetBSD.cpp
  source/Host/netbsd/ThisThread.cpp
  source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
  source/Plugins/Platform/NetBSD/PlatformNetBSD.h

Index: source/Plugins/Platform/NetBSD/PlatformNetBSD.h
===
--- /dev/null
+++ source/Plugins/Platform/NetBSD/PlatformNetBSD.h
@@ -0,0 +1,182 @@
+//===-- PlatformNetBSD.h ---*- C++ -*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===--===//
+
+#ifndef liblldb_PlatformNetBSD_h_
+#define liblldb_PlatformNetBSD_h_
+
+// C Includes
+// C++ Includes
+// Other libraries and framework includes
+// Project includes
+#include "lldb/Target/Platform.h"
+
+namespace lldb_private {
+namespace platform_netbsd {
+
+class PlatformNetBSD : public Platform
+{
+public:
+
+//
+// Class functions
+//
+static lldb::PlatformSP
+CreateInstance(bool force, const ArchSpec *arch);
+
+static void
+Initialize ();
+
+static void
+Terminate ();
+
+static ConstString
+GetPluginNameStatic (bool is_host);
+
+static const char *
+GetDescriptionStatic (bool is_host);
+
+//
+// Class Methods
+//
+PlatformNetBSD (bool is_host);
+
+virtual
+~PlatformNetBSD() override = default;
+
+//
+// lldb_private::PluginInterface functions
+//
+ConstString
+GetPluginName() override
+{
+return GetPluginNameStatic (IsHost());
+}
+
+uint32_t
+GetPluginVersion() override
+{
+return 1;
+}
+
+const char *
+GetDescription () override
+{
+return GetDescriptionStatic(IsHost());
+}
+
+//
+// lldb_private::Platform functions
+//
+bool
+GetModuleSpec(const FileSpec& module_file_spec,
+  const ArchSpec& arch,
+  ModuleSpec &module_spec) override;
+
+Error
+RunShellCommand(const char *command,
+const FileSpec &working_dir,
+int *status_ptr,
+int *signo_ptr,
+std::string *command_output,
+uint32_t timeout_sec) override;
+
+Error
+ResolveExecutable(const ModuleSpec &module_spec,
+  lldb::ModuleSP &module_sp,
+  const FileSpecList *module_search_paths_ptr) override;
+
+size_t
+GetSoftwareBreakpointTrapOpcode(Target &target,
+BreakpointSite *bp_site) override;
+
+bool
+GetRemoteOSVersion () override;
+
+bool
+GetRemoteOSBuildString (std::string &s) override;
+
+bool
+GetRemoteOSKernelDescription (std::string &s) override;
+
+// Remote Platform subclasses need to override this function
+ArchSpec
+GetRemoteSystemArchitecture() override;
+
+bool
+IsConnected () const override;
+
+Error
+ConnectRemote(Args& args) override;
+
+Error
+DisconnectRemote() override;
+
+const char *
+GetHostname () override;
+
+const char *
+GetUserName (uint32_t uid) override;
+
+const char *
+GetGroupName (uint32_t gid) override;
+
+bool
+GetProcessInfo(lldb::pid_t pid,
+   ProcessInstanceInfo &proc_info) override;
+
+uint32_t
+FindProcesses(const ProcessInstanceInfoMatch &match_info,
+  ProcessInstanceInfoList &process_infos) override;
+
+Error
+LaunchProcess(ProcessLaunchInfo &launch_info) override;
+
+

Re: [Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

[Mohit Bhakkad via lldb-commits]

mohit.bhakkad added a subscriber: clayborg.
mohit.bhakkad added a comment.

In http://reviews.llvm.org/D13296#260030, @clayborg wrote:

> I will defer to Jim Ingham on this one.


@jingham could you please review this.


Repository:
  rL LLVM

http://reviews.llvm.org/D13296



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits