Re: [PATCH] kbuild: make modules_install copy modules.builtin(.modinfo)

[Josh Triplett]

On Thu, Jun 15, 2023 at 08:17:43PM +0900, Masahiro Yamada wrote:
> Josh Triplett reports that initramfs-tools needs modules.builtin and
> modules.builtin.modinfo to create a working initramfs for a non-modular
> kernel.
> 
> If this is a general tooling issue not limited to Debian, I think it
> makes sense to change modules_install.
> 
> This commit changes the targets as follows when CONFIG_MODULES=n.
> 
> In-tree builds:
>   make modules  -> no-op
>   make modules_install  -> install modules.builtin(.modinfo)
> 
> External module builds:
>   make modules  -> show error message like before
>   make modules_install  -> show error message like before
> 
> Link: 
> https://lore.kernel.org/lkml/36a4014c73a52af27d930d3ca31d362b60f4461c.1686356364.git.j...@joshtriplett.org/
> Reported-by: Josh Triplett 
> Signed-off-by: Masahiro Yamada 

Reviewed-by: Josh Triplett 
Tested-by: Josh Triplett 

I'll send a followup patch that makes the Debian packaging script use
`make modules_install` unconditionally.

___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

[PATCH] kbuild: builddeb: always make modules_install, to install modules.builtin*

[Josh Triplett]

Even for a non-modular kernel, the kernel builds modules.builtin and
modules.builtin.modinfo, with information about the built-in modules.
Tools such as initramfs-tools need these files to build a working
initramfs on some systems, such as those requiring firmware.

Now that `make modules_install` works even in non-modular kernels and
installs these files, unconditionally invoke it when building a Debian
package.

Signed-off-by: Josh Triplett 
---

This patch depends on
https://lore.kernel.org/lkml/20230615111743.883891-1-masahi...@kernel.org/

 scripts/package/builddeb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 252faaa5561c..f500e3910158 100755
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -62,8 +62,8 @@ install_linux_image () {
${MAKE} -f ${srctree}/Makefile 
INSTALL_DTBS_PATH="${pdir}/usr/lib/linux-image-${KERNELRELEASE}" dtbs_install
fi
 
+   ${MAKE} -f ${srctree}/Makefile INSTALL_MOD_PATH="${pdir}" 
modules_install
if is_enabled CONFIG_MODULES; then
-   ${MAKE} -f ${srctree}/Makefile INSTALL_MOD_PATH="${pdir}" 
modules_install
rm -f "${pdir}/lib/modules/${KERNELRELEASE}/build"
rm -f "${pdir}/lib/modules/${KERNELRELEASE}/source"
if [ "${SRCARCH}" = um ] ; then
-- 
2.40.1


___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc