Re: [PATCH 2/3] mm: replace __HAVE_ARCH_PTE_SPECIAL
On Mon, 9 Apr 2018, Christoph Hellwig wrote: > > -#ifdef __HAVE_ARCH_PTE_SPECIAL > > +#ifdef CONFIG_ARCH_HAS_PTE_SPECIAL > > # define HAVE_PTE_SPECIAL 1 > > #else > > # define HAVE_PTE_SPECIAL 0 > > I'd say kill this odd indirection and just use the > CONFIG_ARCH_HAS_PTE_SPECIAL symbol directly. > > Agree, and I think it would be easier to audit/review if patches 1 and 3 were folded together to see the relationship between the newly added selects and what #define's it is replacing. Otherwise, looks good! ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH v2 1/2] mm: introduce ARCH_HAS_PTE_SPECIAL
On Tue, 10 Apr 2018, Laurent Dufour wrote: > > On Tue, Apr 10, 2018 at 05:25:50PM +0200, Laurent Dufour wrote: > >> arch/powerpc/include/asm/pte-common.h | 3 --- > >> arch/riscv/Kconfig | 1 + > >> arch/s390/Kconfig | 1 + > > > > You forgot to delete __HAVE_ARCH_PTE_SPECIAL from > > arch/riscv/include/asm/pgtable-bits.h > > Damned ! > Thanks for catching it. > Squashing the two patches together at least allowed it to be caught easily. After it's fixed, feel free to add Acked-by: David Rientjes Thanks for doing this! ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH v4] mm: remove odd HAVE_PTE_SPECIAL
On Thu, 12 Apr 2018, Laurent Dufour wrote: > Remove the additional define HAVE_PTE_SPECIAL and rely directly on > CONFIG_ARCH_HAS_PTE_SPECIAL. > > There is no functional change introduced by this patch > > Signed-off-by: Laurent Dufour Acked-by: David Rientjes ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH] mm/slab: rename CONFIG_SLAB to CONFIG_SLAB_DEPRECATED
On Tue, 23 May 2023, Vlastimil Babka wrote: > As discussed at LSF/MM [1] [2] and with no objections raised there, > deprecate the SLAB allocator. Rename the user-visible option so that > users with CONFIG_SLAB=y get a new prompt with explanation during make > oldconfig, while make olddefconfig will just switch to SLUB. > > In all defconfigs with CONFIG_SLAB=y remove the line so those also > switch to SLUB. Regressions due to the switch should be reported to > linux-mm and slab maintainers. > > [1] https://lore.kernel.org/all/4b9fc9c6-b48c-198f-5f80-811a44737...@suse.cz/ > [2] https://lwn.net/Articles/932201/ > > Signed-off-by: Vlastimil Babka Acked-by: David Rientjes The Kconfig option says that SLAB will be removed in a few cycles. I think we should wait until at least the next LTS kernel is forked at the end of the year so that users who upgrade to only the LTS releases can be prompted for this change and surface any concerns. Slab allocation is a critical subsystem, so I presume this is the safest and most responsible way to do the SLAB deprecation. Hopefully that timeline works for everybody. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
