[kbuild] Re: [PATCH] ARC: [plat-eznps]: Drop support for EZChip NPS platform
Hi Vineet, I love your patch! Yet something to improve: url: https://github.com/0day-ci/linux/commits/Vineet-Gupta/ARC-plat-eznps-Drop-support-for-EZChip-NPS-platform/20200909-121133 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 34d4ddd359dbcdf6c5fb3f85a179243d7a1cb7f8 config: arc-randconfig-r026-20200909 compiler: arc-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc randconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> arch/arc/Kconfig:100: can't open file "arch/arc/plat-eznps/Kconfig" make[2]: *** [scripts/kconfig/Makefile:71: oldconfig] Error 1 make[1]: *** [Makefile:606: oldconfig] Error 2 make: *** [Makefile:185: __sub-make] Error 2 make: Target 'oldconfig' not remade because of errors. -- >> arch/arc/Kconfig:100: can't open file "arch/arc/plat-eznps/Kconfig" make[2]: *** [scripts/kconfig/Makefile:71: olddefconfig] Error 1 make[1]: *** [Makefile:606: olddefconfig] Error 2 make: *** [Makefile:185: __sub-make] Error 2 make: Target 'olddefconfig' not remade because of errors. # https://github.com/0day-ci/linux/commit/80d11f778086417bae2b58423840deaa2e527ce6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Vineet-Gupta/ARC-plat-eznps-Drop-support-for-EZChip-NPS-platform/20200909-121133 git checkout 80d11f778086417bae2b58423840deaa2e527ce6 vim +100 arch/arc/Kconfig cfdbc2e16e65c1e Vineet Gupta 2013-01-18 96 072eb693904a52d Christian Ruppert 2013-04-12 97 source "arch/arc/plat-tb10x/Kconfig" 556cc1c5f528dcc Alexey Brodkin2014-01-27 98 source "arch/arc/plat-axs10x/Kconfig" cfdbc2e16e65c1e Vineet Gupta 2013-01-18 99 #New platform adds here 966657890e874d3 Noam Camus2015-10-16 @100 source "arch/arc/plat-eznps/Kconfig" a518d63777a4e94 Alexey Brodkin2017-08-15 101 source "arch/arc/plat-hsdk/Kconfig" 93ad700de2abc11 Vineet Gupta 2013-01-22 102 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ kbuild mailing list -- kbu...@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [linux-next:master] BUILD REGRESSION 2a2aa3f05338270aecbe2492fda910d6c17e0102
If I had to guess, I'd say it was probably the recent changes in linux-next with bitops. Those things messed up Smatch as well and the timing fits. But I don't have a way to test. Anyway, let's ask the kbuild devs. On Wed, Jul 06, 2022 at 11:09:13AM -0700, Vineet Gupta wrote: > > > On 7/5/22 23:49, Dan Carpenter wrote: > > [ trimmed massive CC list (see below) ] > > > > What's going on with all the arch/arc build breakage on linux-next? > > > > regards, > > dan carpenter > > linux-snps-arc is not there, does one need to subscribe to these ? I don't know how the CC list for BUILD REGRESSIONs is made. > > > Unverified Error/Warning (likely false positive, please contact us if > > > interested): > > > > > > block/partitions/efi.c:223:1: internal compiler error: in arc_ifcvt, at > > > config/arc/arc.c:9637 > > > block/sed-opal.c:427:1: internal compiler error: in arc_ifcvt, at > > > config/arc/arc.c:9637 > > > crypto/asymmetric_keys/pkcs7_verify.c:311:1: internal compiler error: in > > > arc_ifcvt, at config/arc/arc.c:9637 > > > drivers/ata/libata-core.c:2802:1: internal compiler error: in arc_ifcvt, > > > at config/arc/arc.c:9637 > > > drivers/ata/libata-eh.c:2842:1: internal compiler error: in arc_ifcvt, at > > > config/arc/arc.c:9637 > > > drivers/ata/sata_dwc_460ex.c:691:1: internal compiler error: in > > > arc_ifcvt, at config/arc/arc.c:9637 > > > drivers/base/power/runtime.c:1570:1: internal compiler error: in > > > arc_ifcvt, at config/arc/arc.c:9637 > > > drivers/block/rbd.c:6142:1: internal compiler error: in arc_ifcvt, at > > > config/arc/arc.c:9637 > > [snip..] > > We would need more specifics: what compiler version is this ? > Thx for bringing this to our attention. Hey LTP devs, which GCC are you using and which .config is generating these "internal compiler error" issues? regards, dan carpenter ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH] bit_spinlock: Include
On Sun, Jan 08, 2023 at 08:04:44PM +0100, Christophe JAILLET wrote: > In an attempt to simplify some includes in , it > appeared, when compiling fs/ecryptfs/dentry.c, that > was relying on other includes to get the definition of cpu_relax(). > (see [1]) > > It broke on arc. > > Include in to fix the issue. > This will help remove some un-needed includes from . > > [1]: https://lore.kernel.org/all/202301082130.lxmj5qkd-...@intel.com/ > > Signed-off-by: Christophe JAILLET > --- > Not sure who to send this to. > get_maintainer.pl is of no help, and the file is untouched from a too long > time. > > Greg? Dan? Any pointer? Andrew Morton is the maintainer of last resort. Plus spinlocks seem like something he would be interested in. Otherwise Ingo, Peter Z and the x86 team. regards, dan carpenter ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
arch/arc/kernel/setup.c:203 arcv2_mumbojumbo() error: uninitialized symbol 'release'.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 2cc14f52aeb78ce3f29677c2de1f06c0e91471ab
commit: fad84e39f116035ae8d550c6020107b8ac113b45 ARC: boot log: eliminate
struct cpuinfo_arc #4: boot log per ISA
config: arc-randconfig-r071-20231128
(https://download.01.org/0day-ci/archive/20231128/202311280906.vaiweaft-...@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce:
(https://download.01.org/0day-ci/archive/20231128/202311280906.vaiweaft-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202311280906.vaiweaft-...@intel.com/
New smatch warnings:
arch/arc/kernel/setup.c:203 arcv2_mumbojumbo() error: uninitialized symbol
'release'.
Old smatch warnings:
arch/arc/include/asm/thread_info.h:62 current_thread_info() error:
uninitialized symbol 'sp'.
vim +/release +203 arch/arc/kernel/setup.c
fad84e39f11603 Vineet Gupta 2020-06-11 150 static int arcv2_mumbojumbo(int c,
struct cpuinfo_arc *info, char *buf, int len)
fad84e39f11603 Vineet Gupta 2020-06-11 151 {
fad84e39f11603 Vineet Gupta 2020-06-11 152 int n = 0;
fad84e39f11603 Vineet Gupta 2020-06-11 153 #ifdef CONFIG_ISA_ARCV2
fad84e39f11603 Vineet Gupta 2020-06-11 154 const char *release, *cpu_nm,
*isa_nm = "ARCv2";
fad84e39f11603 Vineet Gupta 2020-06-11 155 int dual_issue = 0, dual_enb =
0, mpy_opt, present;
fad84e39f11603 Vineet Gupta 2020-06-11 156 int bpu_full, bpu_cache,
bpu_pred, bpu_ret_stk;
fad84e39f11603 Vineet Gupta 2020-06-11 157 char mpy_nm[16], lpb_nm[32];
fad84e39f11603 Vineet Gupta 2020-06-11 158 struct bcr_isa_arcv2 isa;
fad84e39f11603 Vineet Gupta 2020-06-11 159 struct bcr_mpy mpy;
fad84e39f11603 Vineet Gupta 2020-06-11 160 struct bcr_fp_arcv2 fpu;
fad84e39f11603 Vineet Gupta 2020-06-11 161 struct bcr_bpu_arcv2 bpu;
fad84e39f11603 Vineet Gupta 2020-06-11 162 struct bcr_lpb lpb;
fad84e39f11603 Vineet Gupta 2020-06-11 163 struct bcr_iccm_arcv2 iccm;
fad84e39f11603 Vineet Gupta 2020-06-11 164 struct bcr_dccm_arcv2 dccm;
fad84e39f11603 Vineet Gupta 2020-06-11 165 struct bcr_erp erp;
00a4ae65cc600b Vineet Gupta 2019-02-25 166
00a4ae65cc600b Vineet Gupta 2019-02-25 167 /*
97d0b5d0b5a998 Vineet Gupta 2020-06-10 168 * Initial HS cores bumped AUX
IDENTITY.ARCVER for each release until
97d0b5d0b5a998 Vineet Gupta 2020-06-10 169 * ARCVER 0x54 which introduced
AUX MICRO_ARCH_BUILD and subsequent
97d0b5d0b5a998 Vineet Gupta 2020-06-10 170 * releases only update it.
00a4ae65cc600b Vineet Gupta 2019-02-25 171 */
00a4ae65cc600b Vineet Gupta 2019-02-25 172
fad84e39f11603 Vineet Gupta 2020-06-11 173 cpu_nm = "HS38";
00a4ae65cc600b Vineet Gupta 2019-02-25 174
fad84e39f11603 Vineet Gupta 2020-06-11 175 if (info->arcver > 0x50 &&
info->arcver <= 0x53) {
fad84e39f11603 Vineet Gupta 2020-06-11 176 release =
arc_hs_rel[info->arcver - 0x51].str;
00a4ae65cc600b Vineet Gupta 2019-02-25 177 } else {
fad84e39f11603 Vineet Gupta 2020-06-11 178 const struct id_to_str
*tbl;
fad84e39f11603 Vineet Gupta 2020-06-11 179 struct bcr_uarch_build
uarch;
fad84e39f11603 Vineet Gupta 2020-06-11 180
fad84e39f11603 Vineet Gupta 2020-06-11 181
READ_BCR(ARC_REG_MICRO_ARCH_BCR, uarch);
00a4ae65cc600b Vineet Gupta 2019-02-25 182
97d0b5d0b5a998 Vineet Gupta 2020-06-10 183 for (tbl =
&arc_hs_ver54_rel[0]; tbl->id != 0xFF; tbl++) {
00a4ae65cc600b Vineet Gupta 2019-02-25 184 if (uarch.maj
== tbl->id) {
fad84e39f11603 Vineet Gupta 2020-06-11 185 release
= tbl->str;
Will we always hit this assignment?
d975cbc8acb6f4 Vineet Gupta 2016-10-27 186 break;
d975cbc8acb6f4 Vineet Gupta 2016-10-27 187 }
00a4ae65cc600b Vineet Gupta 2019-02-25 188 }
fad84e39f11603 Vineet Gupta 2020-06-11 189 if (uarch.prod == 4) {
fad84e39f11603 Vineet Gupta 2020-06-11 190 unsigned int
exec_ctrl;
00a4ae65cc600b Vineet Gupta 2019-02-25 191
fad84e39f11603 Vineet Gupta 2020-06-11 192 cpu_nm = "HS48";
fad84e39f11603 Vineet Gupta 2020-06-11 193 dual_issue = 1;
fad84e39f11603 Vineet Gupta 2020-06-11 194 /* if dual
issue hardware, is it enabled ? */
fad84e39f11603 Vineet Gupta 2020-06-11 195
READ_BCR(AUX_EXEC_CTRL, exec_ctrl);
fad84e39f11603 Vineet Gupta 2020-06-11 196 dual_enb =
!(exec_ctrl & 1);
fad84e39f11603 Vineet Gupta 2020-06-11 197 }
fad84e39f11603 Vineet Gupta 2020-06-11 198 }
73e284d25725
Re: arch/arc/kernel/setup.c:203 arcv2_mumbojumbo() error: uninitialized symbol 'release'.
On Fri, Dec 08, 2023 at 04:33:44PM -0800, Vineet Gupta wrote: > On 11/27/23 22:22, Dan Carpenter wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > > head: 2cc14f52aeb78ce3f29677c2de1f06c0e91471ab > > commit: fad84e39f116035ae8d550c6020107b8ac113b45 ARC: boot log: eliminate > > struct cpuinfo_arc #4: boot log per ISA > > config: arc-randconfig-r071-20231128 > > (https://download.01.org/0day-ci/archive/20231128/202311280906.vaiweaft-...@intel.com/config) > > compiler: arceb-elf-gcc (GCC) 13.2.0 > > reproduce: > > (https://download.01.org/0day-ci/archive/20231128/202311280906.vaiweaft-...@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new > > version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Reported-by: Dan Carpenter > > | Closes: https://lore.kernel.org/r/202311280906.vaiweaft-...@intel.com/ > > > > New smatch warnings: > > arch/arc/kernel/setup.c:203 arcv2_mumbojumbo() error: uninitialized symbol > > 'release'. > > Thx, I've posted a fix. > > > Old smatch warnings: > > arch/arc/include/asm/thread_info.h:62 current_thread_info() error: > > uninitialized symbol 'sp'. > > This seems like a false warning. Its a register variable and thus can't > possibly be initialized. Yeah. Sorry, I normally delete these but I somehow forgot this time. regards, dan carpenter ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
