[PATCH] ARC: Remove a redundant memset()
disasm_instr() already call memset(0) on its 2nd argument, so there is no
need to clear it explicitly before calling this function.
Remove the redundant memset().
Signed-off-by: Christophe JAILLET
---
arch/arc/kernel/disasm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arc/kernel/disasm.c b/arch/arc/kernel/disasm.c
index 03f8b1be0c3a..e9f16d9e113f 100644
--- a/arch/arc/kernel/disasm.c
+++ b/arch/arc/kernel/disasm.c
@@ -503,7 +503,6 @@ int __kprobes disasm_next_pc(unsigned long pc, struct
pt_regs *regs,
{
struct disasm_state instr;
- memset(&instr, 0, sizeof(struct disasm_state));
disasm_instr(pc, &instr, 0, regs, cregs);
*next_pc = pc + instr.instr_len;
--
2.32.0
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
[PATCH] bit_spinlock: Include
In an attempt to simplify some includes in , it appeared, when compiling fs/ecryptfs/dentry.c, that was relying on other includes to get the definition of cpu_relax(). (see [1]) It broke on arc. Include in to fix the issue. This will help remove some un-needed includes from . [1]: https://lore.kernel.org/all/202301082130.lxmj5qkd-...@intel.com/ Signed-off-by: Christophe JAILLET --- Not sure who to send this to. get_maintainer.pl is of no help, and the file is untouched from a too long time. Greg? Dan? Any pointer? --- include/linux/bit_spinlock.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/bit_spinlock.h b/include/linux/bit_spinlock.h index bbc4730a6505..d0fd2a7afca2 100644 --- a/include/linux/bit_spinlock.h +++ b/include/linux/bit_spinlock.h @@ -2,6 +2,7 @@ #ifndef __LINUX_BIT_SPINLOCK_H #define __LINUX_BIT_SPINLOCK_H +#include #include #include #include -- 2.34.1 ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH] bit_spinlock: Include
Le 10/01/2023 à 08:19, Vineet Gupta a écrit : On 1/8/23 11:04, Christophe JAILLET wrote: In an attempt to simplify some includes in , it appeared, when compiling fs/ecryptfs/dentry.c, that was relying on other includes to get the definition of cpu_relax(). (see [1]) It broke on arc. It its just ARC that broke, maybe we can do something there ? Hi, It is all what build-bots have spotted so far :) I don't think that "fixing" it in ARC is the right approach, unless I missed something. does use cpu_relax(), so it should include what is need for that, and not rely on other black magic. CJ Include in to fix the issue. This will help remove some un-needed includes from . [1]: https://lore.kernel.org/all/202301082130.lxmj5qkd-...@intel.com/ Signed-off-by: Christophe JAILLET --- Not sure who to send this to. get_maintainer.pl is of no help, and the file is untouched from a too long time. Greg? Dan? Any pointer? --- include/linux/bit_spinlock.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/bit_spinlock.h b/include/linux/bit_spinlock.h index bbc4730a6505..d0fd2a7afca2 100644 --- a/include/linux/bit_spinlock.h +++ b/include/linux/bit_spinlock.h @@ -2,6 +2,7 @@ #ifndef __LINUX_BIT_SPINLOCK_H #define __LINUX_BIT_SPINLOCK_H +#include #include #include #include ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
[PATCH v2] bit_spinlock: Include
In an attempt to simplify some includes in , it appeared, when compiling fs/ecryptfs/dentry.c, that was relying on other includes to get the definition of cpu_relax(). (see [1]) It broke on ARC. Include in to fix the issue. This will help to remove some un-needed includes from . [1]: https://lore.kernel.org/all/202301082130.lxmj5qkd-...@intel.com/ Signed-off-by: Christophe JAILLET --- Change in v2: - include instead of(Andrew Morton) v1: https://lore.kernel.org/all/8b81101d59a31f4927016c17e49be96754a23380.1673204461.git.christophe.jail...@wanadoo.fr/ --- include/linux/bit_spinlock.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/bit_spinlock.h b/include/linux/bit_spinlock.h index bbc4730a6505..4e3b407963f6 100644 --- a/include/linux/bit_spinlock.h +++ b/include/linux/bit_spinlock.h @@ -4,9 +4,9 @@ #include #include +#include #include #include - /* * bit-based spin_lock() * -- 2.34.1 ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
