Re: [PATCH 10/17] arm64: generate 64-bit syscall.tbl
On Tue, Jul 9, 2024, at 19:23, Mark Brown wrote: > On Thu, Jul 04, 2024 at 04:36:04PM +0200, Arnd Bergmann wrote: > >> #define __ARCH_WANT_SYS_CLONE >> +#define __ARCH_WANT_NEW_STAT >> >> -#ifndef __COMPAT_SYSCALL_NR >> -#include >> -#endif >> +#include > > It looks like this is causing widespread build breakage in kselftest in > -next for arm64, there are *many* errors in the form: > > In file included from test_signals_utils.c:14: > /build/stage/build-work/usr/include/asm/unistd.h:2:10: fatal error: > unistd_64.h: No such file or directory > 2 | #include > | ^ > > which obviously looks like it's tied to the above but I've not fully > understood the patch/series yet. Build log at: > Thanks for the report! I just panicked a bit and thought I had done something entirely wrong here, but after having a closer look it turned out to be a silly typo: diff --git a/arch/arm64/include/uapi/asm/unistd.h b/arch/arm64/include/uapi/asm/unistd.h index 038dddf8f554..df36f23876e8 100644 --- a/arch/arm64/include/uapi/asm/unistd.h +++ b/arch/arm64/include/uapi/asm/unistd.h @@ -1,2 +1,2 @@ /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ -#include +#include I'm folding the fix into the tree now, in addition to the Acks I received and another small fixup. I checked that arm64 is the only architecture that has this particular bug, and I tried building kselftest now, which seems to work better. There are still a few warnings and errors I get doing that, but I suspect those are all preexisting issues. Arnd ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 12/17] csky: convert to generic syscall table
On Thu, Jul 4, 2024, at 16:36, Arnd Bergmann wrote: > - > -#define __NR_set_thread_area (__NR_arch_specific_syscall + 0) > -__SYSCALL(__NR_set_thread_area, sys_set_thread_area) > -#define __NR_cacheflush (__NR_arch_specific_syscall + 1) > -__SYSCALL(__NR_cacheflush, sys_cacheflush) > +#include > +#define __NR_sync_file_range2 __NR_sync_file_range A small update: I have folded this fixup into this patch and the hexagon one, to ensure we don't define both __NR_sync_file_range2 and __NR_sync_file_range. I already have patches to clean this up further to avoid both the #undef and #define, but that is part of a larger rework that is not ready before the merge window. Arnd diff --git a/arch/csky/include/uapi/asm/unistd.h b/arch/csky/include/uapi/asm/unistd.h index 794adbc04e48..44882179a6e1 100644 --- a/arch/csky/include/uapi/asm/unistd.h +++ b/arch/csky/include/uapi/asm/unistd.h @@ -1,4 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ #include -#define __NR_sync_file_range2 __NR_sync_file_range + +#define __NR_sync_file_range2 84 +#undef __NR_sync_file_range diff --git a/arch/hexagon/include/uapi/asm/unistd.h b/arch/hexagon/include/uapi/asm/unistd.h index 6f670347dd61..a3b0cac25580 100644 --- a/arch/hexagon/include/uapi/asm/unistd.h +++ b/arch/hexagon/include/uapi/asm/unistd.h @@ -29,4 +29,5 @@ #include -#define __NR_sync_file_range2 __NR_sync_file_range +#define __NR_sync_file_range2 84 +#undef __NR_sync_file_range ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 10/17] arm64: generate 64-bit syscall.tbl
On Wed, Jul 10, 2024 at 10:57:25AM +0200, Arnd Bergmann wrote: > Thanks for the report! I just panicked a bit and thought I had > done something entirely wrong here, but after having a closer > look it turned out to be a silly typo: > -#include > +#include Doh, I should've spotted that even from the very quick look I gave it! Thanks for the quick fix. > I checked that arm64 is the only architecture that has this > particular bug, and I tried building kselftest now, which seems > to work better. There are still a few warnings and errors > I get doing that, but I suspect those are all preexisting > issues. Yeah, not everything there builds cleanly (and there's a bunch of external deps you need for many of the suites). signature.asc Description: PGP signature ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
