Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Hi Randy,
On Wed, Aug 16, 2023 at 7:50 AM Randy Dunlap wrote:
> There is only one Kconfig user of CONFIG_EMBEDDED and it can be
> switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd).
>
> Signed-off-by: Randy Dunlap
Makes perfect sense to me.
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
On Wed, Aug 16, 2023, at 07:50, Randy Dunlap wrote: > There is only one Kconfig user of CONFIG_EMBEDDED and it can be > switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). > > Signed-off-by: Randy Dunlap > Cc: Russell King > Cc: linux-arm-ker...@lists.infradead.org > Cc: Arnd Bergmann > Cc: Jason A. Donenfeld Acked-by: Arnd Bergmann ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
On Tue, 15 Aug 2023 22:50:10 PDT (-0700), rdun...@infradead.org wrote: There is only one Kconfig user of CONFIG_EMBEDDED and it can be switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). Signed-off-by: Randy Dunlap Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org Cc: Arnd Bergmann Cc: Jason A. Donenfeld Cc: wiregu...@lists.zx2c4.com Cc: linux-a...@vger.kernel.org Cc: linux-snps-arc@lists.infradead.org Cc: Vineet Gupta Cc: Brian Cain Cc: linux-hexa...@vger.kernel.org Cc: Greg Ungerer Cc: Geert Uytterhoeven Cc: linux-m...@lists.linux-m68k.org Cc: Michal Simek Cc: Thomas Bogendoerfer Cc: Dinh Nguyen Cc: Jonas Bonn Cc: Stefan Kristiansson Cc: Stafford Horne Cc: linux-openr...@vger.kernel.org Cc: linux-m...@vger.kernel.org Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: linuxppc-...@lists.ozlabs.org Cc: linux-ri...@lists.infradead.org Cc: Paul Walmsley Cc: Palmer Dabbelt Cc: Albert Ou Cc: Yoshinori Sato Cc: Rich Felker Cc: John Paul Adrian Glaubitz Cc: linux...@vger.kernel.org Cc: Max Filippov Cc: Josh Triplett Cc: Masahiro Yamada Cc: linux-kbu...@vger.kernel.org Cc: Andrew Morton --- arch/arc/configs/axs101_defconfig|2 +- arch/arc/configs/axs103_defconfig|2 +- arch/arc/configs/axs103_smp_defconfig|2 +- arch/arc/configs/haps_hs_smp_defconfig |2 +- arch/arc/configs/hsdk_defconfig |2 +- arch/arc/configs/nsim_700_defconfig |2 +- arch/arc/configs/nsimosci_defconfig |2 +- arch/arc/configs/nsimosci_hs_defconfig |2 +- arch/arc/configs/tb10x_defconfig |2 +- arch/arc/configs/vdk_hs38_defconfig |2 +- arch/arc/configs/vdk_hs38_smp_defconfig |2 +- arch/arm/Kconfig |2 +- arch/arm/configs/aspeed_g4_defconfig |2 +- arch/arm/configs/aspeed_g5_defconfig |2 +- arch/arm/configs/at91_dt_defconfig |2 +- arch/arm/configs/axm55xx_defconfig |2 +- arch/arm/configs/bcm2835_defconfig |2 +- arch/arm/configs/clps711x_defconfig |2 +- arch/arm/configs/keystone_defconfig |2 +- arch/arm/configs/lpc18xx_defconfig |2 +- arch/arm/configs/lpc32xx_defconfig |2 +- arch/arm/configs/milbeaut_m10v_defconfig |2 +- arch/arm/configs/moxart_defconfig|2 +- arch/arm/configs/multi_v4t_defconfig |2 +- arch/arm/configs/multi_v7_defconfig |2 +- arch/arm/configs/pxa_defconfig |2 +- arch/arm/configs/qcom_defconfig |2 +- arch/arm/configs/sama5_defconfig |2 +- arch/arm/configs/sama7_defconfig |2 +- arch/arm/configs/socfpga_defconfig |2 +- arch/arm/configs/stm32_defconfig |2 +- arch/arm/configs/tegra_defconfig |2 +- arch/arm/configs/vf610m4_defconfig |2 +- arch/hexagon/configs/comet_defconfig |2 +- arch/m68k/configs/amcore_defconfig |2 +- arch/m68k/configs/m5475evb_defconfig |2 +- arch/m68k/configs/stmark2_defconfig |2 +- arch/microblaze/configs/mmu_defconfig|2 +- arch/mips/configs/ath25_defconfig|2 +- arch/mips/configs/ath79_defconfig|2 +- arch/mips/configs/bcm47xx_defconfig |2 +- arch/mips/configs/ci20_defconfig |2 +- arch/mips/configs/cu1000-neo_defconfig |2 +- arch/mips/configs/cu1830-neo_defconfig |2 +- arch/mips/configs/db1xxx_defconfig |2 +- arch/mips/configs/gcw0_defconfig |2 +- arch/mips/configs/generic_defconfig |2 +- arch/mips/configs/loongson2k_defconfig |2 +- arch/mips/configs/loongson3_defconfig|2 +- arch/mips/configs/malta_qemu_32r6_defconfig |2 +- arch/mips/configs/maltaaprp_defconfig|2 +- arch/mips/configs/maltasmvp_defconfig|2 +- arch/mips/configs/maltasmvp_eva_defconfig|2 +- arch/mips/configs/maltaup_defconfig |2 +- arch/mips/configs/omega2p_defconfig |2 +- arch/mips/configs/pic32mzda_defconfig|2 +- arch/mips/configs/qi_lb60_defconfig |2 +- arch/mips/configs/rs90_defconfig |2 +- arch/mips/configs/rt305x_defconfig |2 +- arch/mips/configs/vocore2_defconfig
Re: [PATCH 00/17] -Wmissing-prototype warning fixes
On Thu, 10 Aug 2023 07:19:18 PDT (-0700), a...@kernel.org wrote: From: Arnd Bergmann Most of the patches I sent so far for the -Wmissing-prototype warnings have made it into linux-next now. There are a few that I'm resending now as nobody has picked them up, and then a number of fixes that I found while test-building across all architectures rather than just the ones I usually test. The first 15 patches in this series should be uncontroversial, so I expect that either a subsystem maintainer or Andrew Morton can apply these directly. For the last two patches, these might still need some debate about how to handle them. I added a Kconfig option to turn off most of the missing prototype warnings in the architectures that nobody has fixed yet, see patch 16 for those. The last patch does cause some known warnings and likely unknown ones for architectures other than x86 and arm, so applying it now will bring new problems, but not applying it also means that new warnings creep in, so I think this is mainly a question of what the best timing is for having this in linux-next. Arnd Bergmann (17): [RESEND] jffs2: mark __jffs2_dbg_superblock_counts() static [RESEND] irq_work: consolidate arch_irq_work_raise prototypes [RESEND] ida: make 'ida_dump' static pci: sysfs: move declarations to linux/pci.h swim3: mark swim3_init() static macintosh/ams: mark ams_init() static scsi: qlogicpti: mark qlogicpti_info() static microblaze: mark flush_dcache_folio() inline parport: gsc: mark init function static zorro: include zorro.h in names.c scsi: gvp11: remove unused gvp11_setup() function time: make sysfs_get_uname() function visible in header stackleak: add declarations for global functions kprobes: unify kprobes_exceptions_nofify() prototypes arch: fix asm-offsets.c building with -Wmissing-prototypes [RFC] arch: turn -Wmissing-prototypes off conditionally [RFC] Makefile.extrawarn: turn on missing-prototypes again arch/alpha/Kbuild| 2 ++ arch/alpha/include/asm/pci.h | 3 --- arch/alpha/kernel/asm-offsets.c | 2 +- arch/alpha/lib/Makefile | 1 + arch/arc/Kbuild | 2 ++ arch/arc/include/asm/kprobes.h | 3 --- arch/arm/include/asm/irq_work.h | 2 -- arch/arm/include/asm/kprobes.h | 2 -- arch/arm64/include/asm/irq_work.h| 2 -- arch/arm64/include/asm/kprobes.h | 2 -- arch/csky/Kbuild | 2 ++ arch/csky/include/asm/irq_work.h | 2 +- arch/hexagon/Kbuild | 2 ++ arch/ia64/Kbuild | 2 ++ arch/ia64/include/asm/kprobes.h | 2 -- arch/ia64/kernel/asm-offsets.c | 2 +- arch/ia64/lib/Makefile | 1 + arch/loongarch/Kbuild| 2 ++ arch/loongarch/kernel/asm-offsets.c | 12 arch/m68k/Kbuild | 2 ++ arch/m68k/lib/Makefile | 1 + arch/microblaze/Kbuild | 2 ++ arch/microblaze/include/asm/cacheflush.h | 2 +- arch/mips/Kbuild | 2 ++ arch/mips/boot/compressed/Makefile | 3 ++- arch/mips/include/asm/kprobes.h | 2 -- arch/nios2/Kbuild| 2 ++ arch/nios2/lib/Makefile | 1 + arch/openrisc/Kbuild | 2 ++ arch/parisc/Kbuild | 2 ++ arch/parisc/lib/Makefile | 1 + arch/powerpc/include/asm/irq_work.h | 1 - arch/powerpc/include/asm/kprobes.h | 2 -- arch/riscv/include/asm/irq_work.h| 2 +- arch/s390/include/asm/irq_work.h | 2 -- arch/s390/include/asm/kprobes.h | 2 -- arch/sh/Kbuild | 2 ++ arch/sh/boot/compressed/Makefile | 1 + arch/sh/include/asm/kprobes.h| 2 -- arch/sparc/Kbuild| 2 ++ arch/sparc/include/asm/kprobes.h | 2 -- arch/sparc/kernel/asm-offsets.c | 13 ++--- arch/sparc/lib/Makefile | 1 + arch/sparc/prom/Makefile | 1 + arch/x86/include/asm/irq_work.h | 1 - arch/x86/include/asm/kprobes.h | 2 -- arch/xtensa/Kbuild | 2 ++ arch/xtensa/boot/lib/Makefile| 2 ++ drivers/block/swim3.c| 2 +- drivers/macintosh/ams/ams-core.c | 2 +- drivers/parport/parport_gsc.c| 2 +- drivers/scsi/gvp11.c | 5 - drivers/scsi/qlogicpti.c | 2 +- drivers/zorro/names.c| 1 + fs/jffs2/debug.c | 2 +- include/linux/irq_work.h | 3 +++ include/linux/kprobes.h | 4 include/linux/pci.h | 5 + include/linux/stackleak.h| 6 ++ init/Kconfig | 10
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
On 16/8/23 15:50, Randy Dunlap wrote: There is only one Kconfig user of CONFIG_EMBEDDED and it can be switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). Signed-off-by: Randy Dunlap Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org Cc: Arnd Bergmann Cc: Jason A. Donenfeld Cc: wiregu...@lists.zx2c4.com Cc: linux-a...@vger.kernel.org Cc: linux-snps-arc@lists.infradead.org Cc: Vineet Gupta Cc: Brian Cain Cc: linux-hexa...@vger.kernel.org Cc: Greg Ungerer Acked-by: Greg Ungerer Cc: Geert Uytterhoeven Cc: linux-m...@lists.linux-m68k.org Cc: Michal Simek Cc: Thomas Bogendoerfer Cc: Dinh Nguyen Cc: Jonas Bonn Cc: Stefan Kristiansson Cc: Stafford Horne Cc: linux-openr...@vger.kernel.org Cc: linux-m...@vger.kernel.org Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: linuxppc-...@lists.ozlabs.org Cc: linux-ri...@lists.infradead.org Cc: Paul Walmsley Cc: Palmer Dabbelt Cc: Albert Ou Cc: Yoshinori Sato Cc: Rich Felker Cc: John Paul Adrian Glaubitz Cc: linux...@vger.kernel.org Cc: Max Filippov Cc: Josh Triplett Cc: Masahiro Yamada Cc: linux-kbu...@vger.kernel.org Cc: Andrew Morton --- arch/arc/configs/axs101_defconfig|2 +- arch/arc/configs/axs103_defconfig|2 +- arch/arc/configs/axs103_smp_defconfig|2 +- arch/arc/configs/haps_hs_smp_defconfig |2 +- arch/arc/configs/hsdk_defconfig |2 +- arch/arc/configs/nsim_700_defconfig |2 +- arch/arc/configs/nsimosci_defconfig |2 +- arch/arc/configs/nsimosci_hs_defconfig |2 +- arch/arc/configs/tb10x_defconfig |2 +- arch/arc/configs/vdk_hs38_defconfig |2 +- arch/arc/configs/vdk_hs38_smp_defconfig |2 +- arch/arm/Kconfig |2 +- arch/arm/configs/aspeed_g4_defconfig |2 +- arch/arm/configs/aspeed_g5_defconfig |2 +- arch/arm/configs/at91_dt_defconfig |2 +- arch/arm/configs/axm55xx_defconfig |2 +- arch/arm/configs/bcm2835_defconfig |2 +- arch/arm/configs/clps711x_defconfig |2 +- arch/arm/configs/keystone_defconfig |2 +- arch/arm/configs/lpc18xx_defconfig |2 +- arch/arm/configs/lpc32xx_defconfig |2 +- arch/arm/configs/milbeaut_m10v_defconfig |2 +- arch/arm/configs/moxart_defconfig|2 +- arch/arm/configs/multi_v4t_defconfig |2 +- arch/arm/configs/multi_v7_defconfig |2 +- arch/arm/configs/pxa_defconfig |2 +- arch/arm/configs/qcom_defconfig |2 +- arch/arm/configs/sama5_defconfig |2 +- arch/arm/configs/sama7_defconfig |2 +- arch/arm/configs/socfpga_defconfig |2 +- arch/arm/configs/stm32_defconfig |2 +- arch/arm/configs/tegra_defconfig |2 +- arch/arm/configs/vf610m4_defconfig |2 +- arch/hexagon/configs/comet_defconfig |2 +- arch/m68k/configs/amcore_defconfig |2 +- arch/m68k/configs/m5475evb_defconfig |2 +- arch/m68k/configs/stmark2_defconfig |2 +- arch/microblaze/configs/mmu_defconfig|2 +- arch/mips/configs/ath25_defconfig|2 +- arch/mips/configs/ath79_defconfig|2 +- arch/mips/configs/bcm47xx_defconfig |2 +- arch/mips/configs/ci20_defconfig |2 +- arch/mips/configs/cu1000-neo_defconfig |2 +- arch/mips/configs/cu1830-neo_defconfig |2 +- arch/mips/configs/db1xxx_defconfig |2 +- arch/mips/configs/gcw0_defconfig |2 +- arch/mips/configs/generic_defconfig |2 +- arch/mips/configs/loongson2k_defconfig |2 +- arch/mips/configs/loongson3_defconfig|2 +- arch/mips/configs/malta_qemu_32r6_defconfig |2 +- arch/mips/configs/maltaaprp_defconfig|2 +- arch/mips/configs/maltasmvp_defconfig|2 +- arch/mips/configs/maltasmvp_eva_defconfig|2 +- arch/mips/configs/maltaup_defconfig |2 +- arch/mips/configs/omega2p_defconfig |2 +- arch/mips/configs/pic32mzda_defconfig|2 +- arch/mips/configs/qi_lb60_defconfig |2 +- arch/mips/configs/rs90_defconfig |2 +- arch/mips/configs/rt305x_defconfig |2
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
On Wed, Aug 16, 2023 at 7:50 AM Randy Dunlap wrote: > > There is only one Kconfig user of CONFIG_EMBEDDED and it can be > switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). > > Signed-off-by: Randy Dunlap > Cc: Russell King > Cc: linux-arm-ker...@lists.infradead.org > Cc: Arnd Bergmann > Cc: Jason A. Donenfeld > Cc: wiregu...@lists.zx2c4.com > Cc: linux-a...@vger.kernel.org > Cc: linux-snps-arc@lists.infradead.org > Cc: Vineet Gupta > Cc: Brian Cain > Cc: linux-hexa...@vger.kernel.org > Cc: Greg Ungerer > Cc: Geert Uytterhoeven > Cc: linux-m...@lists.linux-m68k.org > Cc: Michal Simek > Cc: Thomas Bogendoerfer > Cc: Dinh Nguyen > Cc: Jonas Bonn > Cc: Stefan Kristiansson > Cc: Stafford Horne > Cc: linux-openr...@vger.kernel.org > Cc: linux-m...@vger.kernel.org > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: Christophe Leroy > Cc: linuxppc-...@lists.ozlabs.org > Cc: linux-ri...@lists.infradead.org > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: John Paul Adrian Glaubitz > Cc: linux...@vger.kernel.org > Cc: Max Filippov > Cc: Josh Triplett > Cc: Masahiro Yamada > Cc: linux-kbu...@vger.kernel.org > Cc: Andrew Morton > --- > diff -- a/tools/testing/selftests/wireguard/qemu/kernel.config > b/tools/testing/selftests/wireguard/qemu/kernel.config > --- a/tools/testing/selftests/wireguard/qemu/kernel.config > +++ b/tools/testing/selftests/wireguard/qemu/kernel.config > @@ -41,7 +41,6 @@ CONFIG_KALLSYMS=y > CONFIG_BUG=y > CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE=y > CONFIG_JUMP_LABEL=y > -CONFIG_EMBEDDED=n > CONFIG_BASE_FULL=y > CONFIG_FUTEX=y > CONFIG_SHMEM=y Acked-by: Jason A. Donenfeld ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Hi Jesse, On 8/16/23 15:45, Jesse Taube wrote: > Hi, Randy > >> diff -- a/init/Kconfig b/init/Kconfig >> --- a/init/Kconfig >> +++ b/init/Kconfig >> @@ -1790,14 +1790,6 @@ config DEBUG_RSEQ >> >> If unsure, say N. >> >> -config EMBEDDED >> - bool "Embedded system" >> - select EXPERT >> - help >> - This option should be enabled if compiling the kernel for >> - an embedded system so certain expert options are available >> - for configuration. > > Wouldn't removing this break many out of tree configs? I'm not familiar with out-of-tree configs. Do you have some examples of some that use CONFIG_EMBEDDED? (not distros) > Should there be a warning here to update change it instead of removal? kconfig doesn't have a warning mechanism AFAIK. Do you have an idea of how this would work? We could make a smaller change to init/Kconfig, like so: config EMBEDDED - bool "Embedded system" + bool "Embedded system (DEPRECATED)" select EXPERT help - This option should be enabled if compiling the kernel for - an embedded system so certain expert options are available - for configuration. + This option is being removed after Linux 6.6. + Use EXPERT instead of EMBEDDED. but there is no way to produce a warning message. I.e., even with this change, the message will probably be overlooked. --- ~Randy ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Randy Dunlap writes: > There is only one Kconfig user of CONFIG_EMBEDDED and it can be > switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). > > Signed-off-by: Randy Dunlap ... > arch/powerpc/configs/40x/klondike_defconfig |2 +- > arch/powerpc/configs/44x/fsp2_defconfig |2 +- > arch/powerpc/configs/52xx/tqm5200_defconfig |2 +- > arch/powerpc/configs/mgcoge_defconfig|2 +- > arch/powerpc/configs/microwatt_defconfig |2 +- > arch/powerpc/configs/ps3_defconfig |2 +- Acked-by: Michael Ellerman (powerpc) ... > diff -- a/init/Kconfig b/init/Kconfig > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -1790,14 +1790,6 @@ config DEBUG_RSEQ > > If unsure, say N. > > -config EMBEDDED > - bool "Embedded system" > - select EXPERT This is a crucial detail that could be mentioned in the change log. ie. that all defconfigs that currently have EMBEDDED=y are currently selecting EXPERT already. cheers ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
