[PATCH/next] ARC: disasm: fix gp name for arc700
Fixes: b08a66fb680018b6 ("ARC: disasm: handle ARCv2 case in kprobe
get/set functions").
Signed-off-by: Sergey Matyukevich
Reported-by: kernel test robot
---
arch/arc/kernel/disasm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arc/kernel/disasm.c b/arch/arc/kernel/disasm.c
index 42a9e48698b0..ccc7e8c39eb3 100644
--- a/arch/arc/kernel/disasm.c
+++ b/arch/arc/kernel/disasm.c
@@ -491,7 +491,7 @@ void __kprobes set_reg(int reg, long val, struct pt_regs
*regs,
}
break;
case 26:
- regs->gp = val;
+ regs->r26 = val;
break;
case 27:
regs->fp = val;
--
2.35.1
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [vgupta-arc:for-next 3/4] arch/arc/kernel/disasm.c:494:23: error: 'struct pt_regs' has no member named 'gp'; did you mean 'fp'?
Hello Vineet,
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git
> for-next
> head: e88856183749fd59759cd4c617f9ecec8280d8fa
> commit: b08a66fb680018b621fd8be641c537c625132ab3 [3/4] ARC: disasm: handle
> ARCv2 case in kprobe get/set functions
> config: arc-randconfig-r012-20220425
> (https://download.01.org/0day-ci/archive/20220426/202204260826.d9fdltjm-...@intel.com/config)
> compiler: arceb-elf-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
> ~/bin/make.cross
> chmod +x ~/bin/make.cross
> #
> https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git/commit/?id=b08a66fb680018b621fd8be641c537c625132ab3
> git remote add vgupta-arc
> https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git
> git fetch --no-tags vgupta-arc for-next
> git checkout b08a66fb680018b621fd8be641c537c625132ab3
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1
> O=build_dir ARCH=arc SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot
>
> All errors (new ones prefixed by >>):
>
>arch/arc/kernel/disasm.c: In function 'disasm_instr':
>arch/arc/kernel/disasm.c:28:19: warning: variable 'ins_ptr' set but not
> used [-Wunused-but-set-variable]
> 28 | uint16_t *ins_ptr;
> | ^~~
>arch/arc/kernel/disasm.c: In function 'set_reg':
> >> arch/arc/kernel/disasm.c:494:23: error: 'struct pt_regs' has no member
> >> named 'gp'; did you mean 'fp'?
> 494 | regs->gp = val;
> | ^~
> | fp
I have just sent a fixup for this snafu:
https://lore.kernel.org/linux-snps-arc/20220426072447.125975-1-geoma...@gmail.com/T/#u
IIUC, you have not yet sent a pull-request for next release. So probably
it makes sense to squash this commit with b08a66fb680018b6 ("ARC: disasm:
handle ARCv2 case in kprobe get/set functions").
Regards,
Sergey
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [vgupta-arc:for-next 3/4] arch/arc/kernel/disasm.c:494:23: error: 'struct pt_regs' has no member named 'gp'; did you mean 'fp'?
On 4/26/22 00:31, Sergey Matyukevich wrote:
I have just sent a fixup for this snafu:
https://lore.kernel.org/linux-snps-arc/20220426072447.125975-1-geoma...@gmail.com/T/#u
IIUC, you have not yet sent a pull-request for next release. So probably
it makes sense to squash this commit with b08a66fb680018b6 ("ARC: disasm:
handle ARCv2 case in kprobe get/set functions").
Yes this is merge-window stuff so will go in next cycle.
I've added a fixup and push for-next.
Thx,
-Vineet
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
