[PATCH] ARC: SMP: fix typo and use "come up" instead of "comeup"

2020-10-05 Thread Mike Rapoport 
From: Mike Rapoport 

When a secondary CPU fails to come up, there is a missing space in the
log:

Timeout: CPU1 FAILED to comeup !!!

Fix it.

Signed-off-by: Mike Rapoport 
---
 arch/arc/kernel/smp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c
index eca35e02ce06..52906d314537 100644
--- a/arch/arc/kernel/smp.c
+++ b/arch/arc/kernel/smp.c
@@ -226,7 +226,7 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)
}
 
if (!cpu_online(cpu)) {
-   pr_info("Timeout: CPU%u FAILED to comeup !!!\n", cpu);
+   pr_info("Timeout: CPU%u FAILED to come up !!!\n", cpu);
return -1;
}
 
-- 
2.25.4


___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

[PATCH] arc: include/asm: fix typos of "themselves"

2020-10-05 Thread Randy Dunlap 
From: Randy Dunlap 

Fix copy/paste spello of "themselves" in 3 places.

Signed-off-by: Randy Dunlap 
Cc: Vineet Gupta 
Cc: linux-snps-arc@lists.infradead.org
---
 arch/arc/include/asm/atomic.h  |4 ++--
 arch/arc/include/asm/cmpxchg.h |2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

--- lnx-59-rc7.orig/arch/arc/include/asm/atomic.h
+++ lnx-59-rc7/arch/arc/include/asm/atomic.h
@@ -45,7 +45,7 @@ static inline int atomic_##op##_return(i
\
/*  \
 * Explicit full memory barrier needed before/after as  \
-* LLOCK/SCOND thmeselves don't provide any such semantics  \
+* LLOCK/SCOND themselves don't provide any such semantics  \
 */ \
smp_mb();   \
\
@@ -71,7 +71,7 @@ static inline int atomic_fetch_##op(int
\
/*  \
 * Explicit full memory barrier needed before/after as  \
-* LLOCK/SCOND thmeselves don't provide any such semantics  \
+* LLOCK/SCOND themselves don't provide any such semantics  \
 */ \
smp_mb();   \
\
--- lnx-59-rc7.orig/arch/arc/include/asm/cmpxchg.h
+++ lnx-59-rc7/arch/arc/include/asm/cmpxchg.h
@@ -20,7 +20,7 @@ __cmpxchg(volatile void *ptr, unsigned l
 
/*
 * Explicit full memory barrier needed before/after as
-* LLOCK/SCOND thmeselves don't provide any such semantics
+* LLOCK/SCOND themselves don't provide any such semantics
 */
smp_mb();
 


___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH] ARC: SMP: fix typo and use "come up" instead of "comeup"

2020-10-05 Thread Vineet Gupta 
On 10/5/20 9:12 AM, Mike Rapoport wrote:
> From: Mike Rapoport 
> 
> When a secondary CPU fails to come up, there is a missing space in the
> log:
> 
>   Timeout: CPU1 FAILED to comeup !!!
> 
> Fix it.
> 
> Signed-off-by: Mike Rapoport 

Thx for the fix Mike. Added to for-curr.
-Vineet

> ---
>  arch/arc/kernel/smp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c
> index eca35e02ce06..52906d314537 100644
> --- a/arch/arc/kernel/smp.c
> +++ b/arch/arc/kernel/smp.c
> @@ -226,7 +226,7 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)
>   }
>  
>   if (!cpu_online(cpu)) {
> - pr_info("Timeout: CPU%u FAILED to comeup !!!\n", cpu);
> + pr_info("Timeout: CPU%u FAILED to come up !!!\n", cpu);
>   return -1;
>   }
>  
> 

___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH] arc: include/asm: fix typos of "themselves"

2020-10-05 Thread Vineet Gupta 
On 10/5/20 8:30 PM, Randy Dunlap wrote:
> From: Randy Dunlap 
> 
> Fix copy/paste spello of "themselves" in 3 places.
> 
> Signed-off-by: Randy Dunlap 
> Cc: Vineet Gupta 
> Cc: linux-snps-arc@lists.infradead.org

Thx for the fix Randy. Added to for-curr.
-Vineet

> ---
>  arch/arc/include/asm/atomic.h  |4 ++--
>  arch/arc/include/asm/cmpxchg.h |2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> --- lnx-59-rc7.orig/arch/arc/include/asm/atomic.h
> +++ lnx-59-rc7/arch/arc/include/asm/atomic.h
> @@ -45,7 +45,7 @@ static inline int atomic_##op##_return(i
>   \
>   /*  \
>* Explicit full memory barrier needed before/after as  \
> -  * LLOCK/SCOND thmeselves don't provide any such semantics  \
> +  * LLOCK/SCOND themselves don't provide any such semantics  \
>*/ \
>   smp_mb();   \
>   \
> @@ -71,7 +71,7 @@ static inline int atomic_fetch_##op(int
>   \
>   /*  \
>* Explicit full memory barrier needed before/after as  \
> -  * LLOCK/SCOND thmeselves don't provide any such semantics  \
> +  * LLOCK/SCOND themselves don't provide any such semantics  \
>*/ \
>   smp_mb();   \
>   \
> --- lnx-59-rc7.orig/arch/arc/include/asm/cmpxchg.h
> +++ lnx-59-rc7/arch/arc/include/asm/cmpxchg.h
> @@ -20,7 +20,7 @@ __cmpxchg(volatile void *ptr, unsigned l
>  
>   /*
>* Explicit full memory barrier needed before/after as
> -  * LLOCK/SCOND thmeselves don't provide any such semantics
> +  * LLOCK/SCOND themselves don't provide any such semantics
>*/
>   smp_mb();
>  
> 
> 

___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

[RFC PATCH] DRM: amd: powerplay: don't undef pr_warn() {causes ARC build errors}

2020-10-05 Thread Randy Dunlap 
From: Randy Dunlap 

arch/arc/ implements BUG_ON() with BUG(). ARC has its own BUG()
function and that function uses pr_warn() as part of its implementation.

Several (8) files in amd/powerplay/ #undef various pr_xyz() functions so
that they won't be used by these drivers, since dev_() functions are
preferred here and the #undefs make the pr_() functions unavailable.

Hence the following build errors are reported in ARC builds:

../drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c: In function 
'navi10_fill_i2c_req':
../arch/arc/include/asm/bug.h:24:2: error: implicit declaration of function 
'pr_warn'; did you mean 'drm_warn'? [-Werror=implicit-function-declaration]

../drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c: In function 
'sienna_cichlid_fill_i2c_req':
../arch/arc/include/asm/bug.h:24:2: error: implicit declaration of function 
'pr_warn'; did you mean 'drm_warn'? [-Werror=implicit-function-declaration]

Fixes: 55084d7f4022 ("drm/amd/powerplay: forbid to use pr_err/warn/info/debug")
Reported-by: kernel test robot 
Signed-off-by: Randy Dunlap 
Cc: Evan Quan 
Cc: amd-...@lists.freedesktop.org
Cc: Alex Deucher 
Cc: Vineet Gupta 
Cc: linux-snps-arc@lists.infradead.org
---
Another alternative is for amd/powerplay/ drivers not to use BUG()
or BUG_ON().
A third alternative is to ask the ARC developers to implement BUG()
without using any pr_() functions.

 drivers/gpu/drm/amd/powerplay/navi10_ppt.c |2 +-
 drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--- lnx-59-rc7.orig/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
+++ lnx-59-rc7/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
@@ -52,7 +52,7 @@
  * They are more MGPU friendly.
  */
 #undef pr_err
-#undef pr_warn
+//#undef pr_warn
 #undef pr_info
 #undef pr_debug
 
--- lnx-59-rc7.orig/drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c
+++ lnx-59-rc7/drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c
@@ -54,7 +54,7 @@
  * They are more MGPU friendly.
  */
 #undef pr_err
-#undef pr_warn
+//#undef pr_warn
 #undef pr_info
 #undef pr_debug
 


___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [RFC PATCH] DRM: amd: powerplay: don't undef pr_warn() {causes ARC build errors}

2020-10-05 Thread Joe Perches 
On Mon, 2020-10-05 at 21:50 -0700, Randy Dunlap wrote:
> From: Randy Dunlap 
> 
> arch/arc/ implements BUG_ON() with BUG(). ARC has its own BUG()
> function and that function uses pr_warn() as part of its implementation.
> 
> Several (8) files in amd/powerplay/ #undef various pr_xyz() functions so
> that they won't be used by these drivers, since dev_() functions are
> preferred here and the #undefs make the pr_() functions unavailable.
[]
> --- lnx-59-rc7.orig/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
> +++ lnx-59-rc7/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
> @@ -52,7 +52,7 @@
>   * They are more MGPU friendly.
>   */
>  #undef pr_err
> -#undef pr_warn
> +//#undef pr_warn
>  #undef pr_info
>  #undef pr_debug
>  
> --- lnx-59-rc7.orig/drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c
> +++ lnx-59-rc7/drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c
> @@ -54,7 +54,7 @@
>   * They are more MGPU friendly.
>   */
>  #undef pr_err
> -#undef pr_warn
> +//#undef pr_warn
>  #undef pr_info
>  #undef pr_debug 

These are bad ideas as all of these pr_ entries
may become functions in a near-term future.



___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc