Re: [PATCH v2 19/21] treewide: add checks for the return value of memblock_alloc*()
On Mon, Jan 21, 2019 at 12:06 AM Mike Rapoport wrote:
>
> Add check for the return value of memblock_alloc*() functions and call
> panic() in case of error.
> The panic message repeats the one used by panicing memblock allocators with
> adjustment of parameters to include only relevant ones.
>
> The replacement was mostly automated with semantic patches like the one
> below with manual massaging of format strings.
>
> @@
> expression ptr, size, align;
> @@
> ptr = memblock_alloc(size, align);
> + if (!ptr)
> + panic("%s: Failed to allocate %lu bytes align=0x%lx\n", __func__,
> size, align);
>
> Signed-off-by: Mike Rapoport
> Reviewed-by: Guo Ren # c-sky
> Acked-by: Paul Burton # MIPS
> Acked-by: Heiko Carstens # s390
> Reviewed-by: Juergen Gross # Xen
> ---
> arch/xtensa/mm/kasan_init.c | 4
> arch/xtensa/mm/mmu.c | 3 +++
For xtensa:
Acked-by: Max Filippov
--
Thanks.
-- Max
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
[PATCH] make-syscalls.sh: fix comment referencing syscall-template
spotted when started working on ARC port to glibc --- ChangeLog | 5 + sysdeps/unix/make-syscalls.sh | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 93201b76a26b..8438f93e13a2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2019-01-31 Vineet Gupta + + * sysdeps/unix/make-syscalls.sh: Fix comment referencing + syscall-template file. + 2019-01-31 Paul Pluzhnikov [BZ #24051] diff --git a/sysdeps/unix/make-syscalls.sh b/sysdeps/unix/make-syscalls.sh index e39b2d6d5214..6a5c10d54e87 100644 --- a/sysdeps/unix/make-syscalls.sh +++ b/sysdeps/unix/make-syscalls.sh @@ -7,7 +7,7 @@ # # This script is used to process the syscall data encoded in the various # syscalls.list files to produce thin assembly syscall wrappers around the -# appropriate OS syscall. See syscall-template.s for more details on the +# appropriate OS syscall. See syscall-template.S for more details on the # actual wrapper. # # Syscall Signature Prefixes: -- 2.7.4 ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH] make-syscalls.sh: fix comment referencing syscall-template
On 1/31/19 7:16 PM, Vineet Gupta wrote: > spotted when started working on ARC port to glibc > > --- > ChangeLog | 5 + > sysdeps/unix/make-syscalls.sh | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > Obviously correct :-) Please commit to master which is open for development. Reviewed-by: Carlos O'Donell > diff --git a/ChangeLog b/ChangeLog > index 93201b76a26b..8438f93e13a2 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2019-01-31 Vineet Gupta > + > + * sysdeps/unix/make-syscalls.sh: Fix comment referencing > + syscall-template file. > + > 2019-01-31 Paul Pluzhnikov > > [BZ #24051] > diff --git a/sysdeps/unix/make-syscalls.sh b/sysdeps/unix/make-syscalls.sh > index e39b2d6d5214..6a5c10d54e87 100644 > --- a/sysdeps/unix/make-syscalls.sh > +++ b/sysdeps/unix/make-syscalls.sh > @@ -7,7 +7,7 @@ > # > # This script is used to process the syscall data encoded in the various > # syscalls.list files to produce thin assembly syscall wrappers around the > -# appropriate OS syscall. See syscall-template.s for more details on the > +# appropriate OS syscall. See syscall-template.S for more details on the > # actual wrapper. > # > # Syscall Signature Prefixes: > -- Cheers, Carlos. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH] make-syscalls.sh: fix comment referencing syscall-template
On 1/31/19 5:45 PM, Carlos O'Donell wrote: > On 1/31/19 7:16 PM, Vineet Gupta wrote: >> spotted when started working on ARC port to glibc >> >> --- >> ChangeLog | 5 + >> sysdeps/unix/make-syscalls.sh | 2 +- >> 2 files changed, 6 insertions(+), 1 deletion(-) >> > Obviously correct :-) Changelog is bigger than the fix ;-) > Please commit to master which is open for development. > > Reviewed-by: Carlos O'Donell I'm not sure if I have access credentials to commit to *the* glibc repo ? ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Need for arch pthread-offsets.h (was Re: [PATCH v2 05/15] ARC: Atomics and Locking primitives)
On 1/30/19 9:40 AM, Vineet Gupta wrote:
> On 1/30/19 12:28 AM, Andreas Schwab wrote:
>> On Jan 29 2019, Vineet Gupta wrote:
>>
>>> +#define __PTHREAD_MUTEX_NUSERS_AFTER_KIND 1
>>> +#define __PTHREAD_MUTEX_USE_UNION 1
>> New ports should use the preferred values for these macros.
>
> OK, changed to 0 and 0 per commit 06be6368da16104 ("nptl: Define
> __PTHREAD_MUTEX_{NUSERS_AFTER_KIND,USE_UNION}")
So this required a bunch of tricking changes to _SIZEOF_PTHREAD_*.
However what was not obvious is adjustment to
sysdeps//nptl/pthread-offsets.h to __PTHREAD_MUTEX_*_OFFSET. But these
don't
seem to be *actually* used anywhere. Sure there are assert checks in
pthread_mutext_init.c but what's the point: the struct is generic anyways. IOW
I'm
not sure what port specific errors/inconsistency they are catching, other than
the
fact that they need to be hand calculating when starting a new port.
Am I missing something ?
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH] make-syscalls.sh: fix comment referencing syscall-template
On 1/31/19 8:48 PM, Vineet Gupta wrote: > On 1/31/19 5:45 PM, Carlos O'Donell wrote: >> On 1/31/19 7:16 PM, Vineet Gupta wrote: >>> spotted when started working on ARC port to glibc >>> >>> --- >>> ChangeLog | 5 + >>> sysdeps/unix/make-syscalls.sh | 2 +- >>> 2 files changed, 6 insertions(+), 1 deletion(-) >>> >> Obviously correct :-) > > Changelog is bigger than the fix ;-) > >> Please commit to master which is open for development. >> >> Reviewed-by: Carlos O'Donell > > > I'm not sure if I have access credentials to commit to *the* glibc repo ? > Pushed. Thank you :-) commit d5627550ae99d10dfad216910ffa774f60460123 (HEAD -> master, origin/master, origin/HEAD) Author: Vineet Gupta Date: Thu Jan 31 22:45:10 2019 -0500 make-syscalls.sh: fix comment referencing syscall-template -- Cheers, Carlos. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
