kisskb: OK linux-next/axs103_smp_defconfig/arcv2 Fri Jun 03, 19:58
OK linux-next/axs103_smp_defconfig/arcv2 Fri Jun 03, 19:58 http://kisskb.ellerman.id.au/kisskb/buildresult/12706367/ Commit: Add linux-next specific files for 20160531 05f29d5380397c1748ae2aeed9eeb268ee47dff1 Compiler: arc-buildroot-linux-uclibc-gcc (Buildroot 2015.08.1) 4.8.4 No errors found in log Possible warnings (17) -- kernel/sched/core.c:3210:1: warning: control reaches end of non-void function [-Wreturn-type] arch/arc/include/asm/elf.h:58:29: warning: integer overflow in expression [-Woverflow] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] include/linux/kernel.h:742:17: warning: comparison of distinct pointer types lacks a cast [enabled by default] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] block/cfq-iosched.c:3793:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] lib/cpumask.c:179:1: warning: control reaches end of non-void function [-Wreturn-type] net/core/ethtool.c:299:1: warning: control reaches end of non-void function [-Wreturn-type] net/ipv4/tcp_input.c:4273:49: warning: array subscript is above array bounds [-Warray-bounds] include/linux/sunrpc/svc_xprt.h:176:1: warning: control reaches end of non-void function [-Wreturn-type] ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
kisskb: OK linus/axs103_smp_defconfig/arcv2 Fri Jun 03, 20:02
OK linus/axs103_smp_defconfig/arcv2 Fri Jun 03, 20:02 http://kisskb.ellerman.id.au/kisskb/buildresult/12708906/ Commit: Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm 4340fa55298d17049e71c7a34e04647379c269f3 Compiler: arc-buildroot-linux-uclibc-gcc (Buildroot 2015.08.1) 4.8.4 No errors found in log Possible warnings (18) -- kvm: x86: avoid warning on repeated KVM_SET_TSS_ADDR kernel/sched/core.c:3210:1: warning: control reaches end of non-void function [-Wreturn-type] include/linux/kernel.h:742:17: warning: comparison of distinct pointer types lacks a cast [enabled by default] block/cfq-iosched.c:3793:1: warning: control reaches end of non-void function [-Wreturn-type] lib/cpumask.c:179:1: warning: control reaches end of non-void function [-Wreturn-type] arch/arc/include/asm/elf.h:58:29: warning: integer overflow in expression [-Woverflow] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] net/core/ethtool.c:299:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] net/ipv4/tcp_input.c:4273:49: warning: array subscript is above array bounds [-Warray-bounds] include/linux/sunrpc/svc_xprt.h:175:1: warning: control reaches end of non-void function [-Wreturn-type] ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
kisskb: OK linus/axs101_defconfig/arcompact Fri Jun 03, 19:56
OK linus/axs101_defconfig/arcompact Fri Jun 03, 19:56 http://kisskb.ellerman.id.au/kisskb/buildresult/12708907/ Commit: Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm 4340fa55298d17049e71c7a34e04647379c269f3 Compiler: arc-buildroot-linux-uclibc-gcc (Buildroot 2015.08.1) 4.8.4 No errors found in log Possible warnings (17) -- kvm: x86: avoid warning on repeated KVM_SET_TSS_ADDR kernel/sched/core.c:3210:1: warning: control reaches end of non-void function [-Wreturn-type] arch/arc/include/asm/elf.h:58:29: warning: integer overflow in expression [-Woverflow] include/linux/kernel.h:742:17: warning: comparison of distinct pointer types lacks a cast [enabled by default] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] block/cfq-iosched.c:3793:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] net/core/ethtool.c:299:1: warning: control reaches end of non-void function [-Wreturn-type] include/linux/sunrpc/svc_xprt.h:175:1: warning: control reaches end of non-void function [-Wreturn-type] net/ipv4/tcp_input.c:4273:49: warning: array subscript is above array bounds [-Warray-bounds] ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
kisskb: OK linus/axs103_smp_defconfig/arcv2 Fri Jun 03, 19:56
OK linus/axs103_smp_defconfig/arcv2 Fri Jun 03, 19:56 http://kisskb.ellerman.id.au/kisskb/buildresult/12708906/ Commit: Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm 4340fa55298d17049e71c7a34e04647379c269f3 Compiler: arc-buildroot-linux-uclibc-gcc (Buildroot 2015.08.1) 4.8.4 No errors found in log Possible warnings (18) -- kvm: x86: avoid warning on repeated KVM_SET_TSS_ADDR kernel/sched/core.c:3210:1: warning: control reaches end of non-void function [-Wreturn-type] include/linux/kernel.h:742:17: warning: comparison of distinct pointer types lacks a cast [enabled by default] block/cfq-iosched.c:3793:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] net/core/ethtool.c:299:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] lib/cpumask.c:179:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] net/ipv4/tcp_input.c:4273:49: warning: array subscript is above array bounds [-Warray-bounds] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] include/linux/sunrpc/svc_xprt.h:175:1: warning: control reaches end of non-void function [-Wreturn-type] arch/arc/include/asm/elf.h:58:29: warning: integer overflow in expression [-Woverflow] ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
kisskb: OK linux-next/axs101_defconfig/arcompact Fri Jun 03, 20:00
OK linux-next/axs101_defconfig/arcompact Fri Jun 03, 20:00 http://kisskb.ellerman.id.au/kisskb/buildresult/12707485/ Commit: Add linux-next specific files for 20160601 e98f2ba41687651055312e0ae617604dd6f7f200 Compiler: arc-buildroot-linux-uclibc-gcc (Buildroot 2015.08.1) 4.8.4 No errors found in log Possible warnings (16) -- kernel/sched/core.c:3210:1: warning: control reaches end of non-void function [-Wreturn-type] include/linux/kernel.h:742:17: warning: comparison of distinct pointer types lacks a cast [enabled by default] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] block/cfq-iosched.c:3793:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] net/core/ethtool.c:299:1: warning: control reaches end of non-void function [-Wreturn-type] net/ipv4/tcp_input.c:4273:49: warning: array subscript is above array bounds [-Warray-bounds] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] include/linux/sunrpc/svc_xprt.h:176:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function [-Wreturn-type] arch/arc/include/asm/elf.h:58:29: warning: integer overflow in expression [-Woverflow] ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [RFC v3 10/45] cris: dma-mapping: Use unsigned long for dma_attrs
On Thu, Jun 02, 2016 at 05:39:12PM +0200, Krzysztof Kozlowski wrote: > Split out subsystem specific changes for easier reviews. This will be > squashed with main commit. Acked-by: Jesper Nilsson > Signed-off-by: Krzysztof Kozlowski /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nils...@axis.com ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [RFC v3 29/45] m68k: dma-mapping: Use unsigned long for dma_attrs
On Thu, Jun 2, 2016 at 5:39 PM, Krzysztof Kozlowski
wrote:
> Split out subsystem specific changes for easier reviews. This will be
> squashed with main commit.
>
> Signed-off-by: Krzysztof Kozlowski
Looks good.
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [RFC v3 02/45] dma-mapping: Use unsigned long for dma_attrs
On 06/03/2016 09:17 AM, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Thu, Jun 2, 2016 at 5:39 PM, Krzysztof Kozlowski > wrote: >> --- a/include/linux/dma-mapping.h >> +++ b/include/linux/dma-mapping.h >> @@ -5,13 +5,25 @@ > >> +/** >> + * List of possible attributes associated with a DMA mapping. The semantics >> + * of each attribute should be defined in Documentation/DMA-attributes.txt. >> + */ >> +#define DMA_ATTR_WRITE_BARRIER (1UL << 1) > > Any particular reason they start at 2, not 1? No reason. I'll fix this in next version (and trim Cc-list). Anyway the values of constants won't match old ones but that should not be problem (unless they are hard-coded somewhere). Best regards, Krzysztof ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [RFC v3 02/45] dma-mapping: Use unsigned long for dma_attrs
Hi Krzysztof,
On Thu, Jun 2, 2016 at 5:39 PM, Krzysztof Kozlowski
wrote:
> --- a/include/linux/dma-mapping.h
> +++ b/include/linux/dma-mapping.h
> @@ -5,13 +5,25 @@
> +/**
> + * List of possible attributes associated with a DMA mapping. The semantics
> + * of each attribute should be defined in Documentation/DMA-attributes.txt.
> + */
> +#define DMA_ATTR_WRITE_BARRIER (1UL << 1)
Any particular reason they start at 2, not 1?
> +#define DMA_ATTR_WEAK_ORDERING (1UL << 2)
> +#define DMA_ATTR_WRITE_COMBINE (1UL << 3)
> +#define DMA_ATTR_NON_CONSISTENT(1UL << 4)
> +#define DMA_ATTR_NO_KERNEL_MAPPING (1UL << 5)
> +#define DMA_ATTR_SKIP_CPU_SYNC (1UL << 6)
> +#define DMA_ATTR_FORCE_CONTIGUOUS (1UL << 7)
> +#define DMA_ATTR_ALLOC_SINGLE_PAGES(1UL << 8)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
[RFC v3 19/45] [media] dma-mapping: Use unsigned long for dma_attrs
Split out subsystem specific changes for easier reviews. This will be
squashed with main commit.
Signed-off-by: Krzysztof Kozlowski
---
drivers/media/platform/sti/bdisp/bdisp-hw.c| 26 +++---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 30 +++---
drivers/media/v4l2-core/videobuf2-dma-sg.c | 19
include/media/videobuf2-dma-contig.h | 7 ++
4 files changed, 26 insertions(+), 56 deletions(-)
diff --git a/drivers/media/platform/sti/bdisp/bdisp-hw.c
b/drivers/media/platform/sti/bdisp/bdisp-hw.c
index 052c932ac942..1600958939a5 100644
--- a/drivers/media/platform/sti/bdisp/bdisp-hw.c
+++ b/drivers/media/platform/sti/bdisp/bdisp-hw.c
@@ -125,14 +125,11 @@ int bdisp_hw_get_and_clear_irq(struct bdisp_dev *bdisp)
*/
void bdisp_hw_free_nodes(struct bdisp_ctx *ctx)
{
- if (ctx && ctx->node[0]) {
- DEFINE_DMA_ATTRS(attrs);
-
- dma_set_attr(DMA_ATTR_WRITE_COMBINE, &attrs);
+ if (ctx && ctx->node[0])
dma_free_attrs(ctx->bdisp_dev->dev,
sizeof(struct bdisp_node) * MAX_NB_NODE,
- ctx->node[0], ctx->node_paddr[0], &attrs);
- }
+ ctx->node[0], ctx->node_paddr[0],
+ DMA_ATTR_WRITE_COMBINE);
}
/**
@@ -150,12 +147,10 @@ int bdisp_hw_alloc_nodes(struct bdisp_ctx *ctx)
unsigned int i, node_size = sizeof(struct bdisp_node);
void *base;
dma_addr_t paddr;
- DEFINE_DMA_ATTRS(attrs);
/* Allocate all the nodes within a single memory page */
- dma_set_attr(DMA_ATTR_WRITE_COMBINE, &attrs);
base = dma_alloc_attrs(dev, node_size * MAX_NB_NODE, &paddr,
- GFP_KERNEL | GFP_DMA, &attrs);
+ GFP_KERNEL | GFP_DMA, DMA_ATTR_WRITE_COMBINE);
if (!base) {
dev_err(dev, "%s no mem\n", __func__);
return -ENOMEM;
@@ -188,13 +183,9 @@ void bdisp_hw_free_filters(struct device *dev)
{
int size = (BDISP_HF_NB * NB_H_FILTER) + (BDISP_VF_NB * NB_V_FILTER);
- if (bdisp_h_filter[0].virt) {
- DEFINE_DMA_ATTRS(attrs);
-
- dma_set_attr(DMA_ATTR_WRITE_COMBINE, &attrs);
+ if (bdisp_h_filter[0].virt)
dma_free_attrs(dev, size, bdisp_h_filter[0].virt,
- bdisp_h_filter[0].paddr, &attrs);
- }
+ bdisp_h_filter[0].paddr,DMA_ATTR_WRITE_COMBINE);
}
/**
@@ -211,12 +202,11 @@ int bdisp_hw_alloc_filters(struct device *dev)
unsigned int i, size;
void *base;
dma_addr_t paddr;
- DEFINE_DMA_ATTRS(attrs);
/* Allocate all the filters within a single memory page */
size = (BDISP_HF_NB * NB_H_FILTER) + (BDISP_VF_NB * NB_V_FILTER);
- dma_set_attr(DMA_ATTR_WRITE_COMBINE, &attrs);
- base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL | GFP_DMA, &attrs);
+ base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL | GFP_DMA,
+ DMA_ATTR_WRITE_COMBINE);
if (!base)
return -ENOMEM;
diff --git a/drivers/media/v4l2-core/videobuf2-dma-contig.c
b/drivers/media/v4l2-core/videobuf2-dma-contig.c
index 5361197f3e57..8009a582326b 100644
--- a/drivers/media/v4l2-core/videobuf2-dma-contig.c
+++ b/drivers/media/v4l2-core/videobuf2-dma-contig.c
@@ -23,7 +23,7 @@
struct vb2_dc_conf {
struct device *dev;
- struct dma_attrsattrs;
+ unsigned long attrs;
};
struct vb2_dc_buf {
@@ -32,7 +32,7 @@ struct vb2_dc_buf {
unsigned long size;
void*cookie;
dma_addr_t dma_addr;
- struct dma_attrsattrs;
+ unsigned long attrs;
enum dma_data_direction dma_dir;
struct sg_table *dma_sgt;
struct frame_vector *vec;
@@ -135,7 +135,7 @@ static void vb2_dc_put(void *buf_priv)
kfree(buf->sgt_base);
}
dma_free_attrs(buf->dev, buf->size, buf->cookie, buf->dma_addr,
- &buf->attrs);
+ buf->attrs);
put_device(buf->dev);
kfree(buf);
}
@@ -153,14 +153,14 @@ static void *vb2_dc_alloc(void *alloc_ctx, unsigned long
size,
buf->attrs = conf->attrs;
buf->cookie = dma_alloc_attrs(dev, size, &buf->dma_addr,
- GFP_KERNEL | gfp_flags, &buf->attrs);
+ GFP_KERNEL | gfp_flags, buf->attrs);
if (!buf->cookie) {
dev_err(dev, "dma_alloc_coherent of size %ld failed\n", size);
kfree(buf);
return ERR_PTR(-ENOMEM);
}
- if (!dma_get_attr(DMA_ATTR_NO_KERNEL_MAPPING, &buf->attrs))
+ if (!dma
Re: [RFC v3 01/45] powerpc: dma-mapping: Don't hard-code the value of DMA_ATTR_WEAK_ORDERING
On 06/02/2016 05:39 PM, Krzysztof Kozlowski wrote: > Hard-coded value of DMA_ATTR_WEAK_ORDERING is then compared with the > symbol. This will stop matching if the value of symbol is changed (when > switching DMA attributes to unsigned long). > > Signed-off-by: Krzysztof Kozlowski > --- > arch/powerpc/platforms/cell/iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/cell/iommu.c > b/arch/powerpc/platforms/cell/iommu.c > index 14a582b21274..0c2794d2b6c0 100644 > --- a/arch/powerpc/platforms/cell/iommu.c > +++ b/arch/powerpc/platforms/cell/iommu.c > @@ -1162,7 +1162,7 @@ static int __init setup_iommu_fixed(char *str) > pciep = of_find_node_by_type(NULL, "pcie-endpoint"); > > if (strcmp(str, "weak") == 0 || (pciep && strcmp(str, "strong") != 0)) > - iommu_fixed_is_weak = 1; > + iommu_fixed_is_weak = DMA_ATTR_WEAK_ORDERING; After some more thoughts given to this, I think my fix is not correct. The 'iommu_fixed_is_weak' stores the bool and it is used to compare with result of test_bit(). Please ignore this patch. Best regards, Krzysztof ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
[tip:perf/core] tools/perf: Handle -EOPNOTSUPP for sampling events
Commit-ID: dc89e75a9412db5b1105a140182ec1e35a8351b4 Gitweb: http://git.kernel.org/tip/dc89e75a9412db5b1105a140182ec1e35a8351b4 Author: Vineet Gupta AuthorDate: Mon, 9 May 2016 15:07:39 +0530 Committer: Ingo Molnar CommitDate: Fri, 3 Jun 2016 09:41:11 +0200 tools/perf: Handle -EOPNOTSUPP for sampling events This allows (with a previous change to the perf error return ABI) for calling out in userspace the exact reason for perf record failing when PMU doesn't support overflow interrupts. Note that this needs to be put ahead of existing precise_ip check as that gets hit otherwise for the sampling fail case as well. Signed-off-by: Vineet Gupta Signed-off-by: Peter Zijlstra (Intel) Cc: Cc: Cc: Cc: Alexander Shishkin Cc: Arnaldo Carvalho de Melo Cc: Jiri Olsa Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Stephane Eranian Cc: Thomas Gleixner Cc: Vince Weaver Cc: Vineet Gupta Link: http://lkml.kernel.org/r/1462786660-2900-2-git-send-email-vgu...@synopsys.com Signed-off-by: Ingo Molnar --- tools/perf/util/evsel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 245ac50..8d30cbd 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -2384,6 +2384,9 @@ int perf_evsel__open_strerror(struct perf_evsel *evsel, struct target *target, "No such device - did you specify an out-of-range profile CPU?"); break; case EOPNOTSUPP: + if (evsel->attr.sample_period != 0) + return scnprintf(msg, size, "%s", + "PMU Hardware doesn't support sampling/overflow-interrupts."); if (evsel->attr.precise_ip) return scnprintf(msg, size, "%s", "\'precise\' request may not be supported. Try removing 'p' modifier."); ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
[tip:perf/core] perf/abi: Change the errno for sampling event not supported in hardware
Commit-ID: a1396555abff9ff9b74c2e4da13e27e81fd094b2
Gitweb: http://git.kernel.org/tip/a1396555abff9ff9b74c2e4da13e27e81fd094b2
Author: Vineet Gupta
AuthorDate: Mon, 9 May 2016 15:07:40 +0530
Committer: Ingo Molnar
CommitDate: Fri, 3 Jun 2016 09:40:42 +0200
perf/abi: Change the errno for sampling event not supported in hardware
Change the return code for sampling event not supported from -ENOTSUPP
to -EOPNOTSUPP.
This allows userspace to identify this case specifically, instead of
printing the catch-all error message it did previously.
Technically this is an ABI change, but we think we can get away
with it.
Old behavior:
---
| # perf record ls
| Error:
| The sys_perf_event_open() syscall returned with 524 (Unknown error 524)
| for event (cycles:ppp).
| /bin/dmesg may provide additional information.
| No CONFIG_PERF_EVENTS=y kernel support configured?
New behavior:
---
| # perf record ls
| Error:
| PMU Hardware doesn't support sampling/overflow-interrupts.
Signed-off-by: Vineet Gupta
Signed-off-by: Peter Zijlstra (Intel)
Cc:
Cc:
Cc:
Cc: Alexander Shishkin
Cc: Arnaldo Carvalho de Melo
Cc: Jiri Olsa
Cc: Linus Torvalds
Cc: Peter Zijlstra
Cc: Stephane Eranian
Cc: Thomas Gleixner
Cc: Vince Weaver
Cc: Vineet Gupta
Link:
http://lkml.kernel.org/r/1462786660-2900-3-git-send-email-vgu...@synopsys.com
Signed-off-by: Ingo Molnar
---
kernel/events/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index f94f164..5d48306 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9309,7 +9309,7 @@ SYSCALL_DEFINE5(perf_event_open,
if (is_sampling_event(event)) {
if (event->pmu->capabilities & PERF_PMU_CAP_NO_INTERRUPT) {
- err = -ENOTSUPP;
+ err = -EOPNOTSUPP;
goto err_alloc;
}
}
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
