[PATCH 02/23] arc: select GPIOLIB directly
Instead of indirectly selecting GPIOLIB via the ARCH_REQUIRE_GPIOLIB symbol, just select GPIOLIB. Cc: Michael Büsch Cc: Vineet Gupta Cc: linux-snps-arc@lists.infradead.org Signed-off-by: Linus Walleij --- Various arch maintainers: either ACK this and I will merge it into the GPIO tree for v4.7 anticipating no clashes, or you wait until I have the enabling patch upstream (patch 1 in this series, removing deps on ARCH_[WANTS_OPTIONAL|REQUIRES]_GPIOLIB), and you will be able to merge it to your arch trees yourselves for late v4.7 (post GPIO tree merge) or for v4.8. You can also ask me for an immutable branch if you prefer that, I will put the enabling patch on a branch and the patch for your arch on top and ask you to pull it. Select your option from the menu, silence probably means I will merge it to the GPIO tree. Unless you are X86 or ARM in which case I will be cautious. --- arch/arc/plat-axs10x/Kconfig | 2 +- arch/arc/plat-tb10x/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arc/plat-axs10x/Kconfig b/arch/arc/plat-axs10x/Kconfig index 426ac4b8bb39..c54d1ae57fe0 100644 --- a/arch/arc/plat-axs10x/Kconfig +++ b/arch/arc/plat-axs10x/Kconfig @@ -13,7 +13,7 @@ menuconfig ARC_PLAT_AXS10X select OF_GPIO select MIGHT_HAVE_PCI select GENERIC_IRQ_CHIP - select ARCH_REQUIRE_GPIOLIB + select GPIOLIB help Support for the ARC AXS10x Software Development Platforms. diff --git a/arch/arc/plat-tb10x/Kconfig b/arch/arc/plat-tb10x/Kconfig index d14b3d3c5dfd..149e0917645d 100644 --- a/arch/arc/plat-tb10x/Kconfig +++ b/arch/arc/plat-tb10x/Kconfig @@ -21,7 +21,7 @@ menuconfig ARC_PLAT_TB10X select PINCTRL select PINCTRL_TB10X select PINMUX - select ARCH_REQUIRE_GPIOLIB + select GPIOLIB select GPIO_TB10X select TB10X_IRQC help -- 2.4.11 ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver
Hi Stephen,
On 20-04-2016 02:54, Stephen Boyd wrote:
> On 04/19, Jose Abreu wrote:
>> @Stephen: can you give some input so that I can submit a v6?
>>
> I don't prefer putting the second register in the same DT node,
> but that's really up to the DT reviewers to approve such a
> design. The current binding has been acked by Rob right?
Yes.
> Assuming the new binding is acked/reviewed then that solution is
> fine.
Ok, will then use the DT to pass the FPGA version register.
> Otherwise, I still prefer two DTS files for the two different FPGA
> versions. At the least, please use ioremap for any pointers that
> you readl/writel here.
>
> Beyond that, we should have a fixed rate source clk somewhere in
> the software view of the clk tree, because that reflects reality.
> Hardcoding the parent rate in the structure works, but doesn't
> properly express the clk tree.
>
Can I use a property in the DT to pass this reference clock? something like
this:
snps,parent-freq = <0xFBED9 2700>, <0x0 28224000>; /* Tuple
, fpga-version = 0 is default */
Or use a parent clock? like:
clk {
compatible = "fixed-clock";
clock-frequency = <2700>;
#clock-cells = <0>;
snps,fpga-version = <0xFBED9>;
}
It is important to distinguish between the different versions automatically, is
any of these solutions ok?
Best regards,
Jose Miguel Abreu
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver
Hi Jose, Stephen,
On Wed, 2016-04-20 at 10:47 +0100, Jose Abreu wrote:
> Hi Stephen,
>
>
> On 20-04-2016 02:54, Stephen Boyd wrote:
> >
> > On 04/19, Jose Abreu wrote:
> > >
> > > @Stephen: can you give some input so that I can submit a v6?
> > >
> > I don't prefer putting the second register in the same DT node,
> > but that's really up to the DT reviewers to approve such a
> > design. The current binding has been acked by Rob right?
> Yes.
>
> >
> > Assuming the new binding is acked/reviewed then that solution is
> > fine.
> Ok, will then use the DT to pass the FPGA version register.
We won't need to know FPGA version at all I think.
Read my comment below.
> >
> > Otherwise, I still prefer two DTS files for the two different FPGA
> > versions. At the least, please use ioremap for any pointers that
> > you readl/writel here.
> >
> > Beyond that, we should have a fixed rate source clk somewhere in
> > the software view of the clk tree, because that reflects reality.
> > Hardcoding the parent rate in the structure works, but doesn't
> > properly express the clk tree.
> >
> Can I use a property in the DT to pass this reference clock? something like
> this:
> snps,parent-freq = <0xFBED9 2700>, <0x0 28224000>; /* Tuple
> , fpga-version = 0 is default */
>
> Or use a parent clock? like:
> clk {
> compatible = "fixed-clock";
> clock-frequency = <2700>;
> #clock-cells = <0>;
> snps,fpga-version = <0xFBED9>;
> }
>
> It is important to distinguish between the different versions automatically,
> is
> any of these solutions ok?
I do like that solution with a master clock but with some fine-tuning
for simplification.
We'll add master clock node for I2S as a fixed clock like that:
--->8--
i2s_master_clock: clk {
#clock-cells = <0>;
compatible = "fixed-clock";
clock-frequency = <2700>;
};
--->8--
Note there's no mention of MB version, just a value of the frequency.
And in the driver itself value of that master clock will be used for
population of "pll_clk->ref_clk" directly.
These are benefits we'll get with that approach:
[1] We escape any IOs not related to our clock device (I mean
"snps,i2s-pll-clock") itself.
[2] We'll use whatever reference clock value is given.
I.e. we'll be able to do a fix-up of that reference clock
value early in platform code depending on HW we're running on.
That's what people do here and there.
[3] Remember another clock driver for AXS10x board is right around
the corner. I mean the one for ARC PGU which uses exactly the same
master clock. So one fixup as mentioned above will work
at once for 2 clock drivers.
Let me know if above makes sense.
-Alexey
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
