Re: [Linaro-TCWG-CI] gcc-15-7765-g3866ca796d5: 8 regressions on master-thumb_m7_hard_eabi
On Fri, 7 Mar 2025 at 12:53, Christophe Lyon
wrote:
> On Wed, 5 Mar 2025 at 23:32, Jonathan Wakely wrote:
> >
> > On Mon, 3 Mar 2025 at 09:27, Jonathan Wakely wrote:
> > >
> > > On Mon, 3 Mar 2025 at 09:10, Christophe Lyon <
> christophe.l...@linaro.org> wrote:
> > > >
> > > > Hi Jonathan,
> > > >
> > > > On Sun, 2 Mar 2025 at 23:28, Jonathan Wakely via Gcc-regression
> > > > wrote:
> > > > >
> > > > > On Sun, 2 Mar 2025 at 02:42, wrote:
> > > > > >
> > > > > > Dear contributor,
> > > > > >
> > > > > > Our automatic CI has detected problems related to your
> patch(es). Please find some details below.
> > > > > >
> > > > > > In arm-eabi cortex-m7 hard, after:
> > > > > > | commit gcc-15-7765-g3866ca796d5
> > > > > > | Author: Jonathan Wakely
> > > > > > | Date: Thu Feb 27 13:27:17 2025 +
> > > > > > |
> > > > > > | libstdc++: Fix ranges::move and ranges::move_backward to
> use iter_move [PR105609]
> > > > > > |
> > > > > > | The ranges::move and ranges::move_backward algorithms
> are supposed to
> > > > > > | use ranges::iter_move(iter) instead of std::move(*iter),
> which matters
> > > > > > | for an iterator type with an iter_move overload findable
> by ADL.
> > > > > > | ... 16 lines of the commit log omitted.
> > > > > >
> > > > > > Produces 8 regressions:
> > > > > > |
> > > > > > | regressions.sum:
> > > > > > | Running libstdc++:libstdc++-dg/conformance.exp ...
> > > > > > | FAIL: 25_algorithms/move/constrained.cc -std=gnu++20 (test
> for excess errors)
> > > > > > | UNRESOLVED: 25_algorithms/move/constrained.cc -std=gnu++20
> compilation failed to produce executable
> > > > > > | FAIL: 25_algorithms/move/constrained.cc -std=gnu++26 (test
> for excess errors)
> > > > > > | UNRESOLVED: 25_algorithms/move/constrained.cc -std=gnu++26
> compilation failed to produce executable
> > > > > > | ... and 4 more
> > > > >
> > > > > It looks like thumb has some unusual linking requirements that I'm
> not
> > > > > familiar with, so undefined functions (which are never actually
> called
> > > > > in the test) cause linker errors:
> > > > >
> > > > >
> /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/arm-eabi/gcc-gcc.git~master-stage2/arm-eabi/libstdc++-v3/include/bits/iterator_concepts.h:155:(.text._Z6test06N8pr1056091IE+0x6):
> > > > > undefined reference to `pr105609::iter_move(pr105609::I const&)'
> > > > >
> /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/destdir/x86_64-pc-linux-gnu/arm-eabi/bin/ld:
> > > > > (_ZN8pr1056099iter_moveERKNS_1IE): Unknown destination type
> > > > > (ARM/Thumb) in /tmp/ccqKQGzN.o
> > > >
> > > > This is a "recent" linker warning, which I added sometime during last
> > > > year (so you need recent binutils if you want to try to reproduce the
> > > > problem).
> > > > It means that for some reason the destination symbol lacks a tag (asm
> > > > directive) saying whether it's a thumb or an arm function. This is
> > > > used by the linker when deciding which type of stub to insert (if
> > > > any).
> > > > For instance: ".type myfunc, %function"
> > > > but normally the compiler adds this for you.
> > > >
> > > > But you mention "undefined functions", so that would probably be the
> > > > reason, but how can the link succeed? Are you linking with "-z
> undefs"
> > > > ?
> > >
> > > See e.g. libstdc++-v3/testsuite/25_algorithms/move/constrained.cc
> > > The test06 function uses undefined member functions such as
> > > I::operator== but because test06 is never called, it shouldn't matter.
> > >
> > > I can move test06 to a separate { dg-do compile } test, where the
> > > linker isn't involved at all.
> >
> > I hope this is fixed at
> >
> > r15-7842-gc21d5a3591fd761872e18278e1cd8ec18e36d4cb
> >
>
> Indeed, the tests now pass.
>
Great, thanks for confirming it.
>
> I still haven't understood why the original version passed on some
> targets? (I assume so, I suppose you tested the patch before
> committing ;-) )
>
I did! :-)
> Even if not called, test06 would still have references I::operator==
> whatever the target?
>
Maybe the whole of test06 was optimized away as dead code.
___
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org
To unsubscribe send an email to linaro-toolchain-le...@lists.linaro.org
[Linaro-TCWG-CI] glibc-2.41.9000-149-g77261698b4e: 8 regressions on aarch64
Dear contributor, Our automatic CI has detected problems related to your patch(es). Please find some details below. In glibc_check master-aarch64, after: | commit glibc-2.41.9000-149-g77261698b4e | Author: Joseph Myers | Date: Fri Mar 7 19:15:26 2025 + | | Implement C23 rsqrt | | C23 adds various function families originally defined in TS | 18661-4. Add the rsqrt functions (1/sqrt(x)). The test inputs are | taken from those for sqrt. | ... 2 lines of the commit log omitted. Produces 8 regressions: | | regressions.sum: | Running glibc:math ... | FAIL: math/test-double-rsqrt | FAIL: math/test-float-rsqrt | FAIL: math/test-float128-rsqrt | FAIL: math/test-float32-rsqrt | ... and 4 more Used configuration : *CI config* tcwg_glibc_check master-aarch64 *configure and test flags:* none, autodetected on aarch64-unknown-linux-gnu We track this bug report under https://linaro.atlassian.net/browse/GNU-1533. Please let us know if you have a fix. If you have any questions regarding this report, please ask on linaro-toolchain@lists.linaro.org mailing list. -8<--8<--8<-- The information below contains the details of the failures, and the ways to reproduce a debug environment: You can find the failure logs in *.log.1.xz files in * https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-build/2559/artifact/artifacts/00-sumfiles/ The full lists of regressions and improvements as well as configure and make commands are in * https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-build/2559/artifact/artifacts/notify/ The list of [ignored] baseline and flaky failures are in * https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-build/2559/artifact/artifacts/sumfiles/xfails.xfail Current build : https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-build/2559/artifact/artifacts Reference build : https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-build/2557/artifact/artifacts Instruction to reproduce the build : https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/glibc/sha1/77261698b4e938020a1b2032709a54d942ba330f/tcwg_glibc_check/master-aarch64/reproduction_instructions.txt Full commit : https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=77261698b4e938020a1b2032709a54d942ba330f ___ linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org To unsubscribe send an email to linaro-toolchain-le...@lists.linaro.org
Re: [Linaro-TCWG-CI] gcc-15-7853-gde231924b73: 1 regressions on aarch64
On Thu, 6 Mar 2025 at 23:55, Giuseppe D'Angelo via Gcc-regression wrote: > > On 06/03/2025 20:29, ci_not...@linaro.org wrote: > > Dear contributor, > > > > Our automatic CI has detected problems related to your patch(es). Please > > find some details below. > > This has been fixed on trunk by r15-7863-gd2b022e38a778d. > Indeed I can see the test now passes. Thanks, Christophe > Thank you, > -- > Giuseppe D'Angelo ___ linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org To unsubscribe send an email to linaro-toolchain-le...@lists.linaro.org
Re: [Linaro-TCWG-CI] gcc-15-7765-g3866ca796d5: 8 regressions on master-thumb_m7_hard_eabi
On Wed, 5 Mar 2025 at 23:32, Jonathan Wakely wrote:
>
> On Mon, 3 Mar 2025 at 09:27, Jonathan Wakely wrote:
> >
> > On Mon, 3 Mar 2025 at 09:10, Christophe Lyon
> > wrote:
> > >
> > > Hi Jonathan,
> > >
> > > On Sun, 2 Mar 2025 at 23:28, Jonathan Wakely via Gcc-regression
> > > wrote:
> > > >
> > > > On Sun, 2 Mar 2025 at 02:42, wrote:
> > > > >
> > > > > Dear contributor,
> > > > >
> > > > > Our automatic CI has detected problems related to your patch(es).
> > > > > Please find some details below.
> > > > >
> > > > > In arm-eabi cortex-m7 hard, after:
> > > > > | commit gcc-15-7765-g3866ca796d5
> > > > > | Author: Jonathan Wakely
> > > > > | Date: Thu Feb 27 13:27:17 2025 +
> > > > > |
> > > > > | libstdc++: Fix ranges::move and ranges::move_backward to use
> > > > > iter_move [PR105609]
> > > > > |
> > > > > | The ranges::move and ranges::move_backward algorithms are
> > > > > supposed to
> > > > > | use ranges::iter_move(iter) instead of std::move(*iter),
> > > > > which matters
> > > > > | for an iterator type with an iter_move overload findable by
> > > > > ADL.
> > > > > | ... 16 lines of the commit log omitted.
> > > > >
> > > > > Produces 8 regressions:
> > > > > |
> > > > > | regressions.sum:
> > > > > | Running libstdc++:libstdc++-dg/conformance.exp ...
> > > > > | FAIL: 25_algorithms/move/constrained.cc -std=gnu++20 (test for
> > > > > excess errors)
> > > > > | UNRESOLVED: 25_algorithms/move/constrained.cc -std=gnu++20
> > > > > compilation failed to produce executable
> > > > > | FAIL: 25_algorithms/move/constrained.cc -std=gnu++26 (test for
> > > > > excess errors)
> > > > > | UNRESOLVED: 25_algorithms/move/constrained.cc -std=gnu++26
> > > > > compilation failed to produce executable
> > > > > | ... and 4 more
> > > >
> > > > It looks like thumb has some unusual linking requirements that I'm not
> > > > familiar with, so undefined functions (which are never actually called
> > > > in the test) cause linker errors:
> > > >
> > > > /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/arm-eabi/gcc-gcc.git~master-stage2/arm-eabi/libstdc++-v3/include/bits/iterator_concepts.h:155:(.text._Z6test06N8pr1056091IE+0x6):
> > > > undefined reference to `pr105609::iter_move(pr105609::I const&)'
> > > > /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/destdir/x86_64-pc-linux-gnu/arm-eabi/bin/ld:
> > > > (_ZN8pr1056099iter_moveERKNS_1IE): Unknown destination type
> > > > (ARM/Thumb) in /tmp/ccqKQGzN.o
> > >
> > > This is a "recent" linker warning, which I added sometime during last
> > > year (so you need recent binutils if you want to try to reproduce the
> > > problem).
> > > It means that for some reason the destination symbol lacks a tag (asm
> > > directive) saying whether it's a thumb or an arm function. This is
> > > used by the linker when deciding which type of stub to insert (if
> > > any).
> > > For instance: ".type myfunc, %function"
> > > but normally the compiler adds this for you.
> > >
> > > But you mention "undefined functions", so that would probably be the
> > > reason, but how can the link succeed? Are you linking with "-z undefs"
> > > ?
> >
> > See e.g. libstdc++-v3/testsuite/25_algorithms/move/constrained.cc
> > The test06 function uses undefined member functions such as
> > I::operator== but because test06 is never called, it shouldn't matter.
> >
> > I can move test06 to a separate { dg-do compile } test, where the
> > linker isn't involved at all.
>
> I hope this is fixed at
>
> r15-7842-gc21d5a3591fd761872e18278e1cd8ec18e36d4cb
>
Indeed, the tests now pass.
I still haven't understood why the original version passed on some
targets? (I assume so, I suppose you tested the patch before
committing ;-) )
Even if not called, test06 would still have references I::operator==
whatever the target?
Thanks,
Christophe
___
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org
To unsubscribe send an email to linaro-toolchain-le...@lists.linaro.org
