Re: [Linaro-TCWG-CI] 3 patches in gcc: FAIL: 260 regressions on arm

2024-04-23 Thread Qing Zhao 



On Apr 23, 2024, at 02:57, Maxim Kuvyrkov  wrote:

Hi Qing,

On Apr 22, 2024, at 17:53, Qing Zhao  wrote:

Hi, Maxim,

Thanks for your quick reply.

Yes, I see now.

However, my patch set includes 4 patches, and the last one is the testing case 
adjustment patch that should fix all the testing failures. I am not sure 
whether the last patch was applied or not (from my understanding, the last 
patch was not applied).

Correct.  The report says ...
| 3 patches in gcc
| Patchwork URL: https://patchwork.sourceware.org/patch/88759
| da63cf36d84 Add testing cases for flexible array members in unions and alone 
in structures.
| 9a83cd642a0 C and C++ FE changes to support flexible array members in unions 
and alone in structures.
| 513291ec443 Documentation change
| ... applied on top of baseline commit:
| 9f10005dbc9 RISC-V: Add xfail test case for wv insn register overlap
... which means the results are for the first 3 patches.

You can also see at [1] that results when all 4 patches are applied are OK.

It's fine for review purposes to separate test-case adjustments into a 
standalone patch, but please squash them with the main patch when merging, so 
that GCC history does not include unnecessary regressions.

This is good to know. Will merge the patches before I commit the whole patch 
set.



Another question is, are all the patches posted to GNU toolchain mailing lists 
tested by Linaro?

We aim to test all patches processed by patchwork.  However, patchwork can 
process only patches that follow standard git patch rules.  Also, some patches 
fail to apply to current mainline, so we skip them.  See [2] for more details.

Okay, I see.

Thanks for all these information.

Qing

[1] https://patchwork.sourceware.org/project/gcc/list/?series=33005
[2] https://patchwork.sourceware.org/project/gcc/list/

Kind regards,

--
Maxim Kuvyrkov
https://www.linaro.org



Qing

On Apr 22, 2024, at 09:45, Maxim Kuvyrkov  wrote:

Hi Qing,

Linaro runs pre-commit CI in which we test patches posted to GNU toolchain 
mailing lists.  Your patch series showed regressions in our pre-commit testing, 
and CI sent you below report.

The goal of pre-commit CI is catch problematic patches before they are merged.

Does this answer your question?

Kind regards,

--
Maxim Kuvyrkov
https://www.linaro.org

On Apr 22, 2024, at 17:33, Qing Zhao  wrote:

Hi,

I am wondering why I got the following message?

I only sent patch review request to 
gcc-patc...@gcc.gnu.org, never committed the 
patches to any public repository.
Are there anyone else applied the patches to sourceware and tested them?
I have posted many patch review request to 
gcc-patc...@gcc.gnu.org, this is the first time 
I got such message.

Thanks a lot for your help.

Qing


On Apr 20, 2024, at 00:27, ci_not...@linaro.org wrote:

Dear contributor, our automatic CI has detected problems related to your 
patch(es).  Please find some details below.  If you have any questions, please 
follow up on linaro-toolchain@lists.linaro.org mailing list, Libera's 
#linaro-tcwg channel, or ping your favourite Linaro toolchain developer on the 
usual project channel.

We appreciate that it might be difficult to find the necessary logs or 
reproduce the issue locally. If you can't get what you need from our CI within 
minutes, let us know and we will be happy to help.

In gcc_check master-arm after:

| 3 patches in gcc
| Patchwork URL: https://patchwork.sourceware.org/patch/88759
| da63cf36d84 Add testing cases for flexible array members in unions and alone 
in structures.
| 9a83cd642a0 C and C++ FE changes to support flexible array members in unions 
and alone in structures.
| 513291ec443 Documentation change
| ... applied on top of baseline commit:
| 9f10005dbc9 RISC-V: Add xfail test case for wv insn register overlap

FAIL: 260 regressions

regressions.sum:
=== g++ tests ===

Running g++:g++.dg/dg.exp ...
FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++14  (test for errors, 
line 5)
FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++14 (test for excess 
errors)
FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++17  (test for errors, 
line 5)
FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++17 (test for excess 
errors)
FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++20  (test for errors, 
line 5)
FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++20 (test for excess 
errors)
FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++98  (test for errors, 
line 5)
... and 259 more entries

You can find the failure logs in *.log.1.xz files in
- 
https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/6897/artifact/artifacts/artifacts.precommit/00-sumfiles/
The full lists of regressions and progressions as well as configure and make 
commands are in
- 
https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/6897/artifact/artifacts/artifacts.precommit/notify/
The list

gcc patch #88922: FAIL: 1 regressions on aarch64

2024-04-23 Thread Paul Richard Thomas 
Hi,

Executing on host:
/home/tcwg-build/workspace/tcwg_gnu_4/abe/builds/destdir/aarch64-unknown-linux-gnu/bin/aarch64-unknown-linux-gnu-gfortran

/home/tcwg-build/workspace/tcwg_gnu_4/abe/snapshots/gcc.git~master/gcc/testsuite/gfortran.dg/pr89462.f90
   -fdiagnostics-plain-output  -fdiagnostics-plain-output-O
-pedantic-errors -S -o pr89462.s(timeout = 600)
spawn -ignore SIGHUP
/home/tcwg-build/workspace/tcwg_gnu_4/abe/builds/destdir/aarch64-unknown-linux-gnu/bin/aarch64-unknown-linux-gnu-gfortran
/home/tcwg-build/workspace/tcwg_gnu_4/abe/snapshots/gcc.git~master/gcc/testsuite/gfortran.dg/pr89462.f90
-fdiagnostics-plain-output -fdiagnostics-plain-output -O -pedantic-errors
-S -o pr89462.s
/home/tcwg-build/workspace/tcwg_gnu_4/abe/snapshots/gcc.git~master/gcc/testsuite/gfortran.dg/pr89462.f90:6:14:
Warning: Obsolescent feature: Old-style character length at (1)
/home/tcwg-build/workspace/tcwg_gnu_4/abe/snapshots/gcc.git~master/gcc/testsuite/gfortran.dg/pr89462.f90:7:17:
Warning: Obsolescent feature: Old-style character length at (1)

As far as I can see, adding -pedantic-errors and the warning fixes the
regression.

Do you only run the pre-commit regression tests with -pedantic-errors?

Thanks

Paul
___
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org
To unsubscribe send an email to linaro-toolchain-le...@lists.linaro.org

Re: gcc patch #88922: FAIL: 1 regressions on aarch64

2024-04-23 Thread Maxim Kuvyrkov 
> On Apr 24, 2024, at 09:55, Paul Richard Thomas 
>  wrote:
> 
> Hi,
> 
> Executing on host:
> /home/tcwg-build/workspace/tcwg_gnu_4/abe/builds/destdir/aarch64-unknown-linux-gnu/bin/aarch64-unknown-linux-gnu-gfortran
> 
> /home/tcwg-build/workspace/tcwg_gnu_4/abe/snapshots/gcc.git~master/gcc/testsuite/gfortran.dg/pr89462.f90
>   -fdiagnostics-plain-output  -fdiagnostics-plain-output-O
> -pedantic-errors -S -o pr89462.s(timeout = 600)
> spawn -ignore SIGHUP
> /home/tcwg-build/workspace/tcwg_gnu_4/abe/builds/destdir/aarch64-unknown-linux-gnu/bin/aarch64-unknown-linux-gnu-gfortran
> /home/tcwg-build/workspace/tcwg_gnu_4/abe/snapshots/gcc.git~master/gcc/testsuite/gfortran.dg/pr89462.f90
> -fdiagnostics-plain-output -fdiagnostics-plain-output -O -pedantic-errors
> -S -o pr89462.s
> /home/tcwg-build/workspace/tcwg_gnu_4/abe/snapshots/gcc.git~master/gcc/testsuite/gfortran.dg/pr89462.f90:6:14:
> Warning: Obsolescent feature: Old-style character length at (1)
> /home/tcwg-build/workspace/tcwg_gnu_4/abe/snapshots/gcc.git~master/gcc/testsuite/gfortran.dg/pr89462.f90:7:17:
> Warning: Obsolescent feature: Old-style character length at (1)
> 
> As far as I can see, adding -pedantic-errors and the warning fixes the
> regression.

Hi Paul,

I don't quite understand the above comment.  Could you elaborate, please?

> 
> Do you only run the pre-commit regression tests with -pedantic-errors?

We run both post-commit and pre-commit tests with the same flags -- the default 
ones.  I'm guessing the -pedantic-errors is coming from 
gcc/testsuite/gfortran.dg/dg.exp via DEFAULT_FFLAGS.

Does this answer your question?

King regards,

--
Maxim Kuvyrkov
https://www.linaro.org

___
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org
To unsubscribe send an email to linaro-toolchain-le...@lists.linaro.org