Re: [Linaro-TCWG-CI] FAIL: 6 regressions after basepoints/gcc-14-3441-ga1558e9ad85 tree-optimization/111115 - SLP of masked stores

2023-08-25 Thread Adhemerval Zanella Netto
I just tested with 470da3b27e6dbeb3286b09dcb1c1b810ac75b276 and the issues
still happens.  I have opened 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56

On 24/08/23 16:12, Maxim Kuvyrkov wrote:
> Hi Richard,
> 
> Your patch below ICEs on aarch64-linux-gnu.  Should reproduce easily on 
> native or cross aarch64-linux-gnu build.
> 
> Let me know if you need any assistance in reproducing this.
> 
> Thanks,
> 
> --
> Maxim Kuvyrkov
> https://www.linaro.org
> 
>> On Aug 24, 2023, at 22:03, ci_not...@linaro.org wrote:
>>
>> Dear contributor, our automatic CI has detected problems related to your 
>> patch.
>> Please find below some details about it.  If you have any questions, please
>> follow up on linaro-toolchain@lists.linaro.org mailing list.
>>
>> In CI config tcwg_gcc_check/master-aarch64 after:
>>
>>  | commit a1558e9ad856938f165f838733955b331ebbec09
>>  | Author: Richard Biener 
>>  | Date:   Wed Aug 23 14:28:26 2023 +0200
>>  | 
>>  | tree-optimization/15 - SLP of masked stores
>>  | 
>>  | The following adds the capability to do SLP on .MASK_STORE, I do not
>>  | plan to add interleaving support.
>>  | 
>>  | PR tree-optimization/15
>>  | ... 21 lines of the commit log omitted.
>>
>> FAIL: 6 regressions
>>
>> regressions.sum:
>> === gcc tests ===
>>
>> Running gcc:gcc.target/aarch64/sve/aarch64-sve.exp ...
>> FAIL: gcc.target/aarch64/sve/mask_struct_store_4.c (internal compiler error: 
>> in get_group_load_store_type, at tree-vect-stmts.cc:2121)
>> FAIL: gcc.target/aarch64/sve/mask_struct_store_4.c (test for excess errors)
>> UNRESOLVED: gcc.target/aarch64/sve/mask_struct_store_4.c scan-assembler-not 
>> \\tst2b\\t.z[0-9]
>> UNRESOLVED: gcc.target/aarch64/sve/mask_struct_store_4.c scan-assembler-not 
>> \\tst2d\\t.z[0-9]
>> UNRESOLVED: gcc.target/aarch64/sve/mask_struct_store_4.c scan-assembler-not 
>> \\tst2h\\t.z[0-9]
>> UNRESOLVED: gcc.target/aarch64/sve/mask_struct_store_4.c scan-assembler-not 
>> \\tst2w\\t.z[0-9]
>>
>> ... and 1 more entries
>>
>>
>>
>> -8<--8<--8<--
>> The information below can be used to reproduce a debug environment:
>>
>> Current build   : 
>> https://ci.linaro.org/job/tcwg_gcc_check--master-aarch64-build/857/artifact/artifacts
>> Reference build : 
>> https://ci.linaro.org/job/tcwg_gcc_check--master-aarch64-build/856/artifact/artifacts
>>
>> Reproduce last good and first bad builds: 
>> https://git.linaro.org/toolchain/ci/interesting-commits.git/plain/gcc/sha1/a1558e9ad856938f165f838733955b331ebbec09/reproduction_instructions.txt
>>
>> Full commit : 
>> https://github.com/gcc-mirror/gcc/commit/a1558e9ad856938f165f838733955b331ebbec09
>>
>> Latest bug report status : https://linaro.atlassian.net/browse/GNU-893
>>
>> List of configurations that regressed due to this commit :
>> * tcwg_gcc_check
>> ** master-aarch64
>> *** FAIL: 6 regressions
>> *** https://ci.linaro.org/job/tcwg_gcc_check--master-aarch64-build/857/
> 
> 
___
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org
To unsubscribe send an email to linaro-toolchain-le...@lists.linaro.org


Re: [Linaro-TCWG-CI] FAIL: 1 regressions after glibc-2.38.9000-71-g7086332e06 elf: Check that --list-diagnostics output has the expected syntax

2023-08-25 Thread Maxim Kuvyrkov
> On Aug 25, 2023, at 19:18, ci_not...@linaro.org wrote:
> 
> Dear contributor, our automatic CI has detected problems related to your 
> patch.
> Please find below some details about it.  If you have any questions, please
> follow up on linaro-toolchain@lists.linaro.org mailing list.
> 
> In CI config tcwg_glibc_check/master-aarch64 after:
> 
>  | Patchwork URL: 
> https://patchwork.sourceware.org/project/glibc/patch/871qfr9te6@oldenburg.str.redhat.com/
>  | commit 7086332e068cbe778cb47a9baf23cd1d2401444a
>  | Author: Florian Weimer 
>  | Date:   Fri Aug 25 14:52:01 2023 +0200
>  | 
>  | elf: Check that --list-diagnostics output has the expected syntax
>  | 
>  | Parts of elf/tst-rtld-list-diagnostics.py have been copied from
>  | scripts/tst-ld-trace.py.
>  | 
>  | The abnf module is entirely optional and used to verify the
>  | ... 3 lines of the commit log omitted.
> 
> FAIL: 1 regressions
> 
> regressions.sum:
> === glibc tests ===
> 
> Running glibc:elf ...
> FAIL: elf/tst-rtld-list-diagnostics 


Hi Florian,

Output of failed test is in [1].

[1] 
https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-precommit/597/artifact/artifacts/artifacts.precommit/00-sumfiles/tests.log.1.xz
 .

Regards,

--
Maxim Kuvyrkov
https://www.linaro.org

> 
> === Results Summary ===
> 
> 
> 
> -8<--8<--8<--
> The information below can be used to reproduce a debug environment:
> 
> Current build   : 
> https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-precommit/597/artifact/artifacts
> Reference build : 
> https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-build/622/artifact/artifacts
> 
> Reproduce last good and first bad builds: 
> https://git.linaro.org/toolchain/ci/interesting-commits.git/plain/glibc/sha1/7086332e068cbe778cb47a9baf23cd1d2401444a/reproduction_instructions.txt
> 
> Full commit : 
> https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=7086332e068cbe778cb47a9baf23cd1d2401444a
> 
> Latest bug report status : https://linaro.atlassian.net/browse/GNU-692
> 
> List of configurations that regressed due to this commit :
> * tcwg_glibc_check
> ** master-aarch64
> *** FAIL: 1 regressions
> *** https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-precommit/597/


___
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org
To unsubscribe send an email to linaro-toolchain-le...@lists.linaro.org


Re: [Linaro-TCWG-CI] FAIL: 1 regressions after glibc-2.38.9000-71-g7086332e06 elf: Check that --list-diagnostics output has the expected syntax

2023-08-25 Thread Florian Weimer
* Maxim Kuvyrkov:

>> On Aug 25, 2023, at 19:18, ci_not...@linaro.org wrote:
>> 
>> Dear contributor, our automatic CI has detected problems related to your 
>> patch.
>> Please find below some details about it.  If you have any questions, please
>> follow up on linaro-toolchain@lists.linaro.org mailing list.
>> 
>> In CI config tcwg_glibc_check/master-aarch64 after:
>> 
>>  | Patchwork URL: 
>> https://patchwork.sourceware.org/project/glibc/patch/871qfr9te6@oldenburg.str.redhat.com/
>>  | commit 7086332e068cbe778cb47a9baf23cd1d2401444a
>>  | Author: Florian Weimer 
>>  | Date:   Fri Aug 25 14:52:01 2023 +0200
>>  | 
>>  | elf: Check that --list-diagnostics output has the expected syntax
>>  | 
>>  | Parts of elf/tst-rtld-list-diagnostics.py have been copied from
>>  | scripts/tst-ld-trace.py.
>>  | 
>>  | The abnf module is entirely optional and used to verify the
>>  | ... 3 lines of the commit log omitted.
>> 
>> FAIL: 1 regressions
>> 
>> regressions.sum:
>> === glibc tests ===
>> 
>> Running glibc:elf ...
>> FAIL: elf/tst-rtld-list-diagnostics 
>
>
> Hi Florian,
>
> Output of failed test is in [1].
>
> [1] 
> https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-precommit/597/artifact/artifacts/artifacts.precommit/00-sumfiles/tests.log.1.xz
>  .

Nope:

| FAIL: elf/tst-rtld-list-diagnostics
| original exit status 1
| info: skipping ABNF validation because the abnf module is missing

The failure is in the “make check” logs:

| Traceback (most recent call last):
|   File 
"/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", 
line 303, in 
| main(sys.argv[1:])
|   File 
"/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", 
line 294, in main
| check_consistency_with_manual(opts.manual)
|   File 
"/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", 
line 188, in check_consistency_with_manual
| manual_abnf = extract_lines(manual_path,
|   File 
"/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", 
line 172, in extract_lines
| raise ValueError('{!r} not found in {!r}'.format(start_line, path))
| ValueError: '@c ABNF-START' not found in '../manual/dynlink.texi'

Arguably this is a problem in the test/test machinery (we do not
redirect standard error with the Python exceptions).

This likely means that

commit f21962ddfc8bb23e92597da1f98e313dbde11cc1
Author: Florian Weimer 
Date:   Fri Aug 25 14:15:28 2023 +0200

manual: Document ld.so --list-diagnostics output

Reviewed-by: Adhemerval Zanella  

was missing during the build.  The original notification said that it
was against this commit:

| Full commit : 
https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=7086332e068cbe778cb47a9baf23cd1d2401444a

But that's not a commit hash I can find anywhere else.

Thanks,
Florian

___
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org
To unsubscribe send an email to linaro-toolchain-le...@lists.linaro.org


Re: [Linaro-TCWG-CI] FAIL: 1 regressions after gcc commit

2023-08-25 Thread Adhemerval Zanella Netto
Hi Andrew,

Your patch caused a regression [1] on aarch64-linux-gnu.  Would you
please investigate? I did a quick analysis and it seems that the
expected 18 for aarch64 is now 17:

$ grep "Jumps threaded" a-ssa-dom-thread-7.c.197t.thread2
Jumps threaded: 17

Let me know if you need any assistance in reproducing these.

Thanks!

[1] 
https://ci.linaro.org/job/tcwg_gnu_native_check_gcc--master-aarch64-build/567/artifact/artifacts/notify/mail-body.txt/*view*/
___
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org
To unsubscribe send an email to linaro-toolchain-le...@lists.linaro.org


Re: [Linaro-TCWG-CI] FAIL: 1 regressions after gcc commit

2023-08-25 Thread Andrew MacLeod

Copying Aldy for the jump threading expertise.

This change can cause improvements much earlier in the optimization 
pipeline, especially when it comes to PHI nodes. Many of those threading 
tests are finicky about the IL coming in. If we do a better job 
optimizing earlier, an opportunity that use to exist may not any more, 
so it may not be surprising that we only have 17 now instead of 18.


That said, maybe he can have a look to make sure its not something too 
out of whack and adjust the testcase if so.  I seem to recall a nuber of 
them were adjusted to allow a range of threading opportunities instead 
of a specific number.


Andrew

On 8/25/23 13:31, Adhemerval Zanella Netto wrote:Copying

Hi Andrew,

Your patch caused a regression [1] on aarch64-linux-gnu.  Would you
please investigate? I did a quick analysis and it seems that the
expected 18 for aarch64 is now 17:

$ grep "Jumps threaded" a-ssa-dom-thread-7.c.197t.thread2
Jumps threaded: 17

Let me know if you need any assistance in reproducing these.

Thanks!

[1] 
https://ci.linaro.org/job/tcwg_gnu_native_check_gcc--master-aarch64-build/567/artifact/artifacts/notify/mail-body.txt/*view*/



___
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org
To unsubscribe send an email to linaro-toolchain-le...@lists.linaro.org


[ACTIVITY] Report for week #34

2023-08-25 Thread Thiago Jung Bauermann


Hello,

# TCWG CI

- GCC regression GNU-884: Prathamesh confirmed that the new generated
  code is better so I posted a patch adjusting the testcase.

- GCC regression GNU-885: Confirmed that the problem is still present in
  trunk as of commit 829c0c06fe7b from yesterday, so opened bugzilla
  25 and copied the patch author. He fixed the regression.

- Posted Gerrit review request to increase timeout for GDB check jobs to
  accommodate longer times for Armv8l builds.

# GDB Upstream

- Reviewed v4 of Luis' patch series adding SME support to GDB and
  gdbserver.

-- 
Thiago
___
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org
To unsubscribe send an email to linaro-toolchain-le...@lists.linaro.org