[CI-NOTIFY]: TCWG Bisect tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
Successfully identified regression in *linux* in CI configuration tcwg_kernel/gnu-master-arm-mainline-allmodconfig. So far, this commit has regressed CI configurations: - tcwg_kernel/gnu-master-arm-mainline-allmodconfig Culprit: commit 3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151 Author: Linus Torvalds Date: Sun Sep 5 11:24:05 2021 -0700 Enable '-Werror' by default for all kernel builds ... but make it a config option so that broken environments can disable it when required. We really should always have a clean build, and will disable specific over-eager warnings as required, if we can't fix them. But while I fairly religiously enforce that in my own tree, it doesn't get enforced by various build robots that don't necessarily report warnings. So this just makes '-Werror' a default compiler flag, but allows people to disable it for their configuration if they have some particular issues. Occasionally, new compiler versions end up enabling new warnings, and it can take a while before we have them fixed (or the warnings disabled if that is what it takes), so the config option allows for that situation. Hopefully this will mean that I get fewer pull requests that have new warnings that were not noticed by various automation we have in place. Knock wood. Signed-off-by: Linus Torvalds Results regressed to (for first_bad == 3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1: -5 # build_abe qemu: -2 # linux_n_obj: 21769 # First few build errors in logs: from (for last_good == fd47ff55c9c31101fcc06d20cb381da3d4089bd5) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1: -5 # build_abe qemu: -2 # linux_n_obj: 29880 # linux build successful: all Artifacts of last_good build: https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-master-arm-mainline-allmodconfig/28/artifact/artifacts/build-fd47ff55c9c31101fcc06d20cb381da3d4089bd5/ Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-master-arm-mainline-allmodconfig/28/artifact/artifacts/build-3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151/ Build top page/logs: https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-master-arm-mainline-allmodconfig/28/ Configuration details: Reproduce builds: mkdir investigate-linux-3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151 cd investigate-linux-3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-master-arm-mainline-allmodconfig/28/artifact/artifacts/manifests/build-baseline.sh --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-master-arm-mainline-allmodconfig/28/artifact/artifacts/manifests/build-parameters.sh --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-master-arm-mainline-allmodconfig/28/artifact/artifacts/test.sh --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_kernel-build.sh @@ artifacts/manifests/build-baseline.sh # Save baseline build state (which is then restored in artifacts/test.sh) mkdir -p ./bisect rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /linux/ ./ ./bisect/baseline/ cd linux # Reproduce first_bad build git checkout --detach 3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151 ../artifacts/test.sh # Reproduce last_good build git checkout --detach fd47ff55c9c31101fcc06d20cb381da3d4089bd5 ../artifacts/test.sh cd .. History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/ci/tcwg_kernel/gnu-master-arm-mainline-allmodconfig Artifacts: https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-master-arm-mainline-allmodconfig/28/artifact/artifacts/ Build log: https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-master-arm-mainline-allmodconfig/28/consoleText Full commit (up to 1000 lines): commit 3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151 Author: Linus Torvalds Date: Sun Sep 5 11:24:05 2021 -0700 Enable '-Werror' by default for all kernel builds ... but make it a config option so that broken environments can disable it when required. We really should always have a clean build, and will disable specific over-eager warnings as required, if we can't fix them. But while I fairly religiously enforce that in my own tree, it doesn't get enforced by various build robots that don't necessarily report warnings. So this just makes '-Werror' a default compiler flag, but allows people to disable it for their configuration if they have some particular issues. Occasionally, new compiler versions end up enabling new warnings, a
Re: [CI-NOTIFY]: TCWG Bisect tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
Hi Linus, As expected, kernel builds started failing in less-common configurations. In this particular case the culprit is amdgpu driver when built for 32-bit ARM in allmodconfig configuration using tip-of-trunk GCC. Hi Alex, [picking your name from “git log drivers/gpu/drm/amd/amdgpu/amdgpu.h”], Would you please take a look? Let me know if the problem doesn’t reproduce for you, and I’ll help to investigate. 00:22:45 In file included from drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:29: 00:22:45 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c: In function ‘gmc_v6_0_set_prt’: 00:22:45 drivers/gpu/drm/amd/amdgpu/amdgpu.h:1227:53: error: ‘<<’ in boolean context, did you mean ‘<’? [-Werror=int-in-bool-context] 00:22:45 1227 | (REG_FIELD_MASK(reg, field) & ((field_val) << REG_FIELD_SHIFT(reg, field 00:22:45 | ~^~~ 00:22:45 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:430:15: note: in expansion of macro ‘REG_SET_FIELD’ 00:22:45 430 | tmp = REG_SET_FIELD(tmp, VM_PRT_CNTL, 00:22:45 | ^ 00:22:45 cc1: all warnings being treated as errors 00:22:45 make[4]: *** [scripts/Makefile.build:277: drivers/gpu/drm/amd/amdgpu/gmc_v6_0.o] Error 1 00:40:28 make[4]: Target '__build' not remade because of errors. 00:40:28 make[3]: *** [scripts/Makefile.build:540: drivers/gpu/drm/amd/amdgpu] Error 2 00:41:17 make[3]: Target '__build' not remade because of errors. 00:41:17 make[2]: *** [scripts/Makefile.build:540: drivers/gpu/drm] Error 2 00:41:17 make[2]: Target '__build' not remade because of errors. 00:41:17 make[1]: *** [scripts/Makefile.build:540: drivers/gpu] Error 2 00:41:17 make[1]: Target '__build' not remade because of errors. 00:41:17 make: *** [Makefile:1872: drivers] Error 2 00:41:17 make: Target '__all' not remade because of errors. Regards, -- Maxim Kuvyrkov https://www.linaro.org > On 8 Sep 2021, at 11:40, ci_not...@linaro.org wrote: > > Successfully identified regression in *linux* in CI configuration > tcwg_kernel/gnu-master-arm-mainline-allmodconfig. So far, this commit has > regressed CI configurations: > - tcwg_kernel/gnu-master-arm-mainline-allmodconfig > > Culprit: > > commit 3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151 > Author: Linus Torvalds > Date: Sun Sep 5 11:24:05 2021 -0700 > >Enable '-Werror' by default for all kernel builds > >... but make it a config option so that broken environments can disable >it when required. > >We really should always have a clean build, and will disable specific >over-eager warnings as required, if we can't fix them. But while I >fairly religiously enforce that in my own tree, it doesn't get enforced >by various build robots that don't necessarily report warnings. > >So this just makes '-Werror' a default compiler flag, but allows people >to disable it for their configuration if they have some particular >issues. > >Occasionally, new compiler versions end up enabling new warnings, and it >can take a while before we have them fixed (or the warnings disabled if >that is what it takes), so the config option allows for that situation. > >Hopefully this will mean that I get fewer pull requests that have new >warnings that were not noticed by various automation we have in place. > >Knock wood. > >Signed-off-by: Linus Torvalds > > > Results regressed to (for first_bad == > 3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151) > # reset_artifacts: > -10 > # build_abe binutils: > -9 > # build_abe stage1: > -5 > # build_abe qemu: > -2 > # linux_n_obj: > 21769 > # First few build errors in logs: > > from (for last_good == fd47ff55c9c31101fcc06d20cb381da3d4089bd5) > # reset_artifacts: > -10 > # build_abe binutils: > -9 > # build_abe stage1: > -5 > # build_abe qemu: > -2 > # linux_n_obj: > 29880 > # linux build successful: > all > > Artifacts of last_good build: > https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-master-arm-mainline-allmodconfig/28/artifact/artifacts/build-fd47ff55c9c31101fcc06d20cb381da3d4089bd5/ > Artifacts of first_bad build: > https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-master-arm-mainline-allmodconfig/28/artifact/artifacts/build-3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151/ > Build top page/logs: > https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-master-arm-mainline-allmodconfig/28/ > > Configuration details: > > > Reproduce builds: > > mkdir investigate-linux-3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151 > cd investigate-linux-3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151 > > git clone https://git.linaro.org/toolchain/jenkins-scripts > > mkdir -p artifacts/manifests > curl -o artifacts/manifests/build-baseline.sh > https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-master-arm-mainline-allmodconfig/28/artifact/artifacts/manifests/build-baseline.sh > --fail > curl -o artifacts/manifests/build-parameters.sh > https://ci.linaro.org/job/tcwg_kerne
[CI-NOTIFY]: TCWG Bisect tcwg_bmk_apm/llvm-master-aarch64-spec2k6-Oz_LTO - Build # 6 - Successful!
Successfully identified regression in *llvm* in CI configuration
tcwg_bmk_llvm_apm/llvm-master-aarch64-spec2k6-Oz_LTO. So far, this commit has
regressed CI configurations:
- tcwg_bmk_llvm_apm/llvm-master-aarch64-spec2k6-Oz_LTO
Culprit:
commit 131b4620ee7847102479f399ce3e35a3c1cb5461
Author: Corentin Jabot
Date: Fri Aug 6 10:29:28 2021 -0400
Implement P1937 consteval in unevaluated contexts
In an unevaluated contexts, consteval functions should not be
immediately evaluated.
Results regressed to (for first_bad == 131b4620ee7847102479f399ce3e35a3c1cb5461)
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer:
-8
# build_abe linux:
-7
# build_abe glibc:
-6
# build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer:
-5
# build_llvm true:
-3
# true:
0
# benchmark -- -Oz_LTO
artifacts/build-131b4620ee7847102479f399ce3e35a3c1cb5461/results_id:
1
# 470.lbm,lbm_base.default regressed by 104
from (for last_good == 3c8e94bc20e5829ab5167d21d242b6b624dd934e)
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer:
-8
# build_abe linux:
-7
# build_abe glibc:
-6
# build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer:
-5
# build_llvm true:
-3
# true:
0
# benchmark -- -Oz_LTO
artifacts/build-3c8e94bc20e5829ab5167d21d242b6b624dd934e/results_id:
1
Artifacts of last_good build:
https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-aarch64-spec2k6-Oz_LTO/6/artifact/artifacts/build-3c8e94bc20e5829ab5167d21d242b6b624dd934e/
Results ID of last_good:
apm_64/tcwg_bmk_llvm_apm/bisect-llvm-master-aarch64-spec2k6-Oz_LTO/4879
Artifacts of first_bad build:
https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-aarch64-spec2k6-Oz_LTO/6/artifact/artifacts/build-131b4620ee7847102479f399ce3e35a3c1cb5461/
Results ID of first_bad:
apm_64/tcwg_bmk_llvm_apm/bisect-llvm-master-aarch64-spec2k6-Oz_LTO/4868
Build top page/logs:
https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-aarch64-spec2k6-Oz_LTO/6/
Configuration details:
Reproduce builds:
mkdir investigate-llvm-131b4620ee7847102479f399ce3e35a3c1cb5461
cd investigate-llvm-131b4620ee7847102479f399ce3e35a3c1cb5461
git clone https://git.linaro.org/toolchain/jenkins-scripts
mkdir -p artifacts/manifests
curl -o artifacts/manifests/build-baseline.sh
https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-aarch64-spec2k6-Oz_LTO/6/artifact/artifacts/manifests/build-baseline.sh
--fail
curl -o artifacts/manifests/build-parameters.sh
https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-aarch64-spec2k6-Oz_LTO/6/artifact/artifacts/manifests/build-parameters.sh
--fail
curl -o artifacts/test.sh
https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-aarch64-spec2k6-Oz_LTO/6/artifact/artifacts/test.sh
--fail
chmod +x artifacts/test.sh
# Reproduce the baseline build (build all pre-requisites)
./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh
# Save baseline build state (which is then restored in artifacts/test.sh)
mkdir -p ./bisect
rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/
--exclude /llvm/ ./ ./bisect/baseline/
cd llvm
# Reproduce first_bad build
git checkout --detach 131b4620ee7847102479f399ce3e35a3c1cb5461
../artifacts/test.sh
# Reproduce last_good build
git checkout --detach 3c8e94bc20e5829ab5167d21d242b6b624dd934e
../artifacts/test.sh
cd ..
History of pending regressions and results:
https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/ci/tcwg_bmk_llvm_apm/llvm-master-aarch64-spec2k6-Oz_LTO
Artifacts:
https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-aarch64-spec2k6-Oz_LTO/6/artifact/artifacts/
Build log:
https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-aarch64-spec2k6-Oz_LTO/6/consoleText
Full commit (up to 1000 lines):
commit 131b4620ee7847102479f399ce3e35a3c1cb5461
Author: Corentin Jabot
Date: Fri Aug 6 10:29:28 2021 -0400
Implement P1937 consteval in unevaluated contexts
In an unevaluated contexts, consteval functions should not be
immediately evaluated.
---
clang/lib/Sema/SemaExpr.cpp | 7 ++---
clang/test/CXX/basic/basic.def.odr/p2-typeid.cpp | 33 +++-
clang/test/SemaCXX/cxx2a-consteval.cpp | 18 +
clang/www/cxx_status.html| 3 ++-
4 files changed, 56 insertions(+), 5 deletions(-)
diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp
index d316687c4cd8..8ef4a9d96320 100644
--- a/clang/lib/Sema/SemaExpr.cpp
+++ b/clang/lib/Sema/SemaExpr.cpp
@@ -16641,7 +16641,8 @@ void Sema::CheckUnusedVolatileAssignment(Expr *E) {
}
ExprResult Sema::CheckForImmediateInvo
[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tx1/llvm-release-aarch64-spec2k6-O3 - Build # 8 - Successful!
Successfully identified regression in *llvm* in CI configuration tcwg_bmk_llvm_tx1/llvm-release-aarch64-spec2k6-O3. So far, this commit has regressed CI configurations: - tcwg_bmk_llvm_tx1/llvm-release-aarch64-spec2k6-O3 Culprit: commit 34f839fc9d4c0638e09c81e9981d4dacf69c3ed6 Author: Zahira Ammarguellat Date: Fri Aug 6 12:01:47 2021 -0700 Revert "[clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp-contract=on" This reverts commit 48ad446a0fb2c9b98cb7047e4daf8a84c29cef8f. (cherry picked from commit 4389a413e2129d7d55ee779638b649aa852b6f8a) Results regressed to (for first_bad == 34f839fc9d4c0638e09c81e9981d4dacf69c3ed6) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -- -O3 artifacts/build-34f839fc9d4c0638e09c81e9981d4dacf69c3ed6/results_id: 1 # 470.lbm,lbm_base.default regressed by 109 # 444.namd,namd_base.defaultregressed by 104 # 447.dealII,dealII_base.defaultregressed by 106 # 447.dealII,[.] _ZNK12SparseMatrixIdE5vmultI6VectorIdES3_EEvRT regressed by 115 # 447.dealII,[.] _ZN16ConstraintMatrix8add_lineEj regressed by 112 # 433.milc,milc_base.defaultregressed by 104 # 433.milc,[.] mult_su3_mat_vec regressed by 115 from (for last_good == b643ee1b9c1a8e0b81e31908a066c71851292890) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -- -O3 artifacts/build-b643ee1b9c1a8e0b81e31908a066c71851292890/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release-aarch64-spec2k6-O3/8/artifact/artifacts/build-b643ee1b9c1a8e0b81e31908a066c71851292890/ Results ID of last_good: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-release-aarch64-spec2k6-O3/4881 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release-aarch64-spec2k6-O3/8/artifact/artifacts/build-34f839fc9d4c0638e09c81e9981d4dacf69c3ed6/ Results ID of first_bad: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-release-aarch64-spec2k6-O3/4887 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release-aarch64-spec2k6-O3/8/ Configuration details: Reproduce builds: mkdir investigate-llvm-34f839fc9d4c0638e09c81e9981d4dacf69c3ed6 cd investigate-llvm-34f839fc9d4c0638e09c81e9981d4dacf69c3ed6 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release-aarch64-spec2k6-O3/8/artifact/artifacts/manifests/build-baseline.sh --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release-aarch64-spec2k6-O3/8/artifact/artifacts/manifests/build-parameters.sh --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release-aarch64-spec2k6-O3/8/artifact/artifacts/test.sh --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh # Save baseline build state (which is then restored in artifacts/test.sh) mkdir -p ./bisect rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /llvm/ ./ ./bisect/baseline/ cd llvm # Reproduce first_bad build git checkout --detach 34f839fc9d4c0638e09c81e9981d4dacf69c3ed6 ../artifacts/test.sh # Reproduce last_good build git checkout --detach b643ee1b9c1a8e0b81e31908a066c71851292890 ../artifacts/test.sh cd .. History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/ci/tcwg_bmk_llvm_tx1/llvm-release-aarch64-spec2k6-O3 Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release-aarch64-spec2k6-O3/8/artifact/artifacts/ Build log: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release-aarch64-spec2k6-O3/8/consoleText Full commit (up to 1000 lines): commit 34f839fc9d4c0638e09c81e9981d4dacf69c3ed6 Author: Zahira Ammarguellat Date: Fri Aug 6 12:01:47 2021 -0700 Revert "[clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp-contract=on" This reverts commit 48ad446a0fb2c9b98cb7047e4daf8a84c29cef8f. (cherry picked from commit 4389a413e2129d7d55ee7
[CI-NOTIFY]: TCWG Bisect tcwg_kernel/gnu-release-arm-next-allmodconfig - Build # 20 - Successful!
Successfully identified regression in *linux* in CI configuration tcwg_kernel/gnu-release-arm-next-allmodconfig. So far, this commit has regressed CI configurations: - tcwg_kernel/gnu-release-arm-next-allmodconfig Culprit: commit 4d3b252a0a3aed2f6fc70aec3c37275a9ca179a4 Merge: 907f2745370d 6f65d2319f21 Author: Stephen Rothwell Date: Tue Sep 7 10:00:35 2021 +1000 Merge remote-tracking branch 'pm/linux-next' Results regressed to (for first_bad == 4d3b252a0a3aed2f6fc70aec3c37275a9ca179a4) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1: -5 # build_abe qemu: -2 # linux_n_obj: 21778 # First few build errors in logs: from (for last_good == 907f2745370d3cfcc6efe7772def37c4eee4b960) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1: -5 # build_abe qemu: -2 # linux_n_obj: 29889 # linux build successful: all Artifacts of last_good build: https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-release-arm-next-allmodconfig/20/artifact/artifacts/build-907f2745370d3cfcc6efe7772def37c4eee4b960/ Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-release-arm-next-allmodconfig/20/artifact/artifacts/build-4d3b252a0a3aed2f6fc70aec3c37275a9ca179a4/ Build top page/logs: https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-release-arm-next-allmodconfig/20/ Configuration details: rr[linux_git]="https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git#4b93c544e90e2b28326182d31ee008eb80e02074"; Reproduce builds: mkdir investigate-linux-4d3b252a0a3aed2f6fc70aec3c37275a9ca179a4 cd investigate-linux-4d3b252a0a3aed2f6fc70aec3c37275a9ca179a4 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-release-arm-next-allmodconfig/20/artifact/artifacts/manifests/build-baseline.sh --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-release-arm-next-allmodconfig/20/artifact/artifacts/manifests/build-parameters.sh --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-release-arm-next-allmodconfig/20/artifact/artifacts/test.sh --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_kernel-build.sh @@ artifacts/manifests/build-baseline.sh # Save baseline build state (which is then restored in artifacts/test.sh) mkdir -p ./bisect rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /linux/ ./ ./bisect/baseline/ cd linux # Reproduce first_bad build git checkout --detach 4d3b252a0a3aed2f6fc70aec3c37275a9ca179a4 ../artifacts/test.sh # Reproduce last_good build git checkout --detach 907f2745370d3cfcc6efe7772def37c4eee4b960 ../artifacts/test.sh cd .. History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/ci/tcwg_kernel/gnu-release-arm-next-allmodconfig Artifacts: https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-release-arm-next-allmodconfig/20/artifact/artifacts/ Build log: https://ci.linaro.org/job/tcwg_kernel-gnu-bisect-gnu-release-arm-next-allmodconfig/20/consoleText Full commit (up to 1000 lines): commit 4d3b252a0a3aed2f6fc70aec3c37275a9ca179a4 Merge: 907f2745370d 6f65d2319f21 Author: Stephen Rothwell Date: Tue Sep 7 10:00:35 2021 +1000 Merge remote-tracking branch 'pm/linux-next' Documentation/admin-guide/acpi/ssdt-overlays.rst | 49 +- Documentation/cpu-freq/cpu-drivers.rst | 3 - .../devicetree/bindings/cpufreq/cpufreq-dt.txt | 2 +- .../bindings/cpufreq/cpufreq-mediatek.txt | 2 +- .../devicetree/bindings/cpufreq/cpufreq-st.txt | 6 +- .../bindings/cpufreq/nvidia,tegra20-cpufreq.txt| 2 +- .../devicetree/bindings/devfreq/rk3399_dmc.txt | 2 +- .../devicetree/bindings/gpu/arm,mali-bifrost.yaml | 2 +- .../devicetree/bindings/gpu/arm,mali-midgard.yaml | 2 +- .../bindings/interconnect/fsl,imx8m-noc.yaml | 4 +- .../opp/allwinner,sun50i-h6-operating-points.yaml | 4 + Documentation/devicetree/bindings/opp/opp-v1.yaml | 51 ++ .../devicetree/bindings/opp/opp-v2-base.yaml | 214 +++ Documentation/devicetree/bindings/opp/opp-v2.yaml | 475 Documentation/devicetree/bindings/opp/opp.txt | 622 - Documentation/devicetree/bindings/opp/qcom-opp.txt | 2 +- .../bindings/opp/ti-omap5-opp-supply.txt | 2 +- .../devicetree/bindings/power/power-domain.yaml| 2 +- .../translations/zh_CN/cpu-freq/cpu-drivers.rst| 2 - arch/arm/boot/dts/omap34xx.dtsi| 1 - arch/arm/boot/dts/omap36xx.dtsi| 1 - drivers/acpi/x86/s2idle.c | 67 ++- drivers/base/arch_topology.c | 2 + drivers/cpufreq/acpi-cpufreq.c | 14 +-
Re: [EXT] Re: [CI-NOTIFY]: TCWG Bisect tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
I think this is a false positive.
It is doing:
#define shift 2
#define mask (1ul<<(shift))
#define REG_FIELD_MASK(a,b) (mask)
#define REG_FIELD_SHIFT(a,b) (shift)
#define REG_SET_FIELD(orig_val, reg, field, field_val) \
(((orig_val) & ~REG_FIELD_MASK(reg, field)) | \
(REG_FIELD_MASK(reg, field) & ((field_val) << REG_FIELD_SHIFT(reg,
field
int f(_Bool enable)
{
int tmp = 0;
tmp = REG_SET_FIELD(tmp, VM_PRT_CNTL,
CB_DISABLE_FAULT_ON_UNMAPPED_ACCESS,
enable);
return tmp;
}
But I could not get GCC to warn. I think a toolchain person should look at the
preprocessed source to see what is happening.
Thanks,
Andrew Pinski
From: linaro-toolchain on behalf of
Maxim Kuvyrkov
Sent: Wednesday, September 8, 2021 2:30 AM
To: Linus Torvalds; Alex Deucher
Cc: linaro-toolchain
Subject: [EXT] Re: [CI-NOTIFY]: TCWG Bisect
tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
External Email
--
Hi Linus,
As expected, kernel builds started failing in less-common configurations. In
this particular case the culprit is amdgpu driver when built for 32-bit ARM in
allmodconfig configuration using tip-of-trunk GCC.
Hi Alex, [picking your name from “git log drivers/gpu/drm/amd/amdgpu/amdgpu.h”],
Would you please take a look? Let me know if the problem doesn’t reproduce for
you, and I’ll help to investigate.
00:22:45 In file included from drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:29:
00:22:45 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c: In function ‘gmc_v6_0_set_prt’:
00:22:45 drivers/gpu/drm/amd/amdgpu/amdgpu.h:1227:53: error: ‘<<’ in boolean
context, did you mean ‘<’? [-Werror=int-in-bool-context]
00:22:45 1227 | (REG_FIELD_MASK(reg, field) & ((field_val) <<
REG_FIELD_SHIFT(reg, field
00:22:45 |
~^~~
00:22:45 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:430:15: note: in expansion of
macro ‘REG_SET_FIELD’
00:22:45 430 | tmp = REG_SET_FIELD(tmp, VM_PRT_CNTL,
00:22:45 | ^
00:22:45 cc1: all warnings being treated as errors
00:22:45 make[4]: *** [scripts/Makefile.build:277:
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.o] Error 1
00:40:28 make[4]: Target '__build' not remade because of errors.
00:40:28 make[3]: *** [scripts/Makefile.build:540: drivers/gpu/drm/amd/amdgpu]
Error 2
00:41:17 make[3]: Target '__build' not remade because of errors.
00:41:17 make[2]: *** [scripts/Makefile.build:540: drivers/gpu/drm] Error 2
00:41:17 make[2]: Target '__build' not remade because of errors.
00:41:17 make[1]: *** [scripts/Makefile.build:540: drivers/gpu] Error 2
00:41:17 make[1]: Target '__build' not remade because of errors.
00:41:17 make: *** [Makefile:1872: drivers] Error 2
00:41:17 make: Target '__all' not remade because of errors.
Regards,
--
Maxim Kuvyrkov
https://urldefense.proofpoint.com/v2/url?u=https-3A__www.linaro.org&d=DwIGaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=L_uAQMgirzaBwiEk05NHY-AMcNfJzugOS_xTjrtS94k&m=3SIswy3Zze4DQV1eWknNsMoyQcvNDjLb6bESKfKZOlA&s=bcbggZZWC56u4q8MITx_3s-oLHlmtyzcI3FltbGjFlI&e=
> On 8 Sep 2021, at 11:40, ci_not...@linaro.org wrote:
>
> Successfully identified regression in *linux* in CI configuration
> tcwg_kernel/gnu-master-arm-mainline-allmodconfig. So far, this commit has
> regressed CI configurations:
> - tcwg_kernel/gnu-master-arm-mainline-allmodconfig
>
> Culprit:
>
> commit 3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151
> Author: Linus Torvalds
> Date: Sun Sep 5 11:24:05 2021 -0700
>
>Enable '-Werror' by default for all kernel builds
>
>... but make it a config option so that broken environments can disable
>it when required.
>
>We really should always have a clean build, and will disable specific
>over-eager warnings as required, if we can't fix them. But while I
>fairly religiously enforce that in my own tree, it doesn't get enforced
>by various build robots that don't necessarily report warnings.
>
>So this just makes '-Werror' a default compiler flag, but allows people
>to disable it for their configuration if they have some particular
>issues.
>
>Occasionally, new compiler versions end up enabling new warnings, and it
>can take a while before we have them fixed (or the warnings disabled if
>that is what it takes), so the config option allows for that situation.
>
>Hopefully this will mean that I get fewer pull requests that have new
>warnings that were not noticed by various automation we have in place.
>
>Knock wood.
>
>Signed-off-by: Linus Torvalds
>
>
> Results regressed to (for first_bad ==
> 3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151)
> # reset_artifacts:
> -10
> # build_abe binutils:
> -9
> # build_abe stage1:
> -5
> # build_abe qemu:
> -2
> # linux_n_obj:
> 21
[CI-NOTIFY]: TCWG Bisect tcwg_bmk_apm/llvm-master-arm-spec2k6-Oz - Build # 7 - Successful!
Successfully identified regression in *binutils* in CI configuration tcwg_bmk_llvm_apm/llvm-master-arm-spec2k6-Oz. So far, this commit has regressed CI configurations: - tcwg_bmk_llvm_apm/llvm-master-arm-spec2k6-Oz Culprit: commit f947f96797f8ec33aabf9cd7234c850778068445 Author: Tom de Vries Date: Mon Aug 30 14:34:03 2021 +0200 [gdb/cli] Don't assert on empty string for core-file With current gdb we run into: ... $ gdb -batch '' '' : No such file or directory. pathstuff.cc:132: internal-error: \ gdb::unique_xmalloc_ptr gdb_abspath(const char*): \ Assertion `path != NULL && path[0] != '\0'' failed. ... Fix this by skipping the call to gdb_abspath in core_target_open in the empty-string case, such that we have instead: ... $ gdb -batch '' '' : No such file or directory. : No such file or directory. $ ... Tested on x86_64-linux. gdb/ChangeLog: 2021-08-30 Tom de Vries PR cli/28290 * gdb/corelow.c (core_target_open): Skip call to gdb_abspath in the empty-string case. gdb/testsuite/ChangeLog: 2021-08-30 Tom de Vries PR cli/28290 * gdb.base/batch-exit-status.exp: Add gdb '' and gdb '' '' tests. Results regressed to (for first_bad == f947f96797f8ec33aabf9cd7234c850778068445) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -- -Oz_mthumb artifacts/build-f947f96797f8ec33aabf9cd7234c850778068445/results_id: 1 # 447.dealII,[.] contract<3>regressed by 200 from (for last_good == 9b9b1092f0a8e6b7d240ea05a74968a883b8a05c) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -- -Oz_mthumb artifacts/build-9b9b1092f0a8e6b7d240ea05a74968a883b8a05c/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-arm-spec2k6-Oz/7/artifact/artifacts/build-9b9b1092f0a8e6b7d240ea05a74968a883b8a05c/ Results ID of last_good: apm_32/tcwg_bmk_llvm_apm/bisect-llvm-master-arm-spec2k6-Oz/4909 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-arm-spec2k6-Oz/7/artifact/artifacts/build-f947f96797f8ec33aabf9cd7234c850778068445/ Results ID of first_bad: apm_32/tcwg_bmk_llvm_apm/bisect-llvm-master-arm-spec2k6-Oz/4905 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-arm-spec2k6-Oz/7/ Configuration details: Reproduce builds: mkdir investigate-binutils-f947f96797f8ec33aabf9cd7234c850778068445 cd investigate-binutils-f947f96797f8ec33aabf9cd7234c850778068445 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-arm-spec2k6-Oz/7/artifact/artifacts/manifests/build-baseline.sh --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-arm-spec2k6-Oz/7/artifact/artifacts/manifests/build-parameters.sh --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-arm-spec2k6-Oz/7/artifact/artifacts/test.sh --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh # Save baseline build state (which is then restored in artifacts/test.sh) mkdir -p ./bisect rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /binutils/ ./ ./bisect/baseline/ cd binutils # Reproduce first_bad build git checkout --detach f947f96797f8ec33aabf9cd7234c850778068445 ../artifacts/test.sh # Reproduce last_good build git checkout --detach 9b9b1092f0a8e6b7d240ea05a74968a883b8a05c ../artifacts/test.sh cd .. History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/ci/tcwg_bmk_llvm_apm/llvm-master-arm-spec2k6-Oz Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-arm-spec2k6-Oz/7/artifact/artifacts/ Build log: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_apm-llvm-master-arm-spec2k6
Re: [EXT] Re: [CI-NOTIFY]: TCWG Bisect tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
Ok, I am now able to reproduce it with:
#define shiftCB_DISABLE_FAULT_ON_UNMAPPED_ACCESS1 0
#define maskCB_DISABLE_FAULT_ON_UNMAPPED_ACCESS1 1L
#define REG_FIELD_MASK(a,b) (mask##b)
#define REG_FIELD_SHIFT(a,b) (shift##b)
#define REG_SET_FIELD(orig_val, reg, field, field_val) \
(((orig_val) & ~REG_FIELD_MASK(reg, field)) | \
(REG_FIELD_MASK(reg, field) & ((field_val) << REG_FIELD_SHIFT(reg,
field
int f(_Bool enable)
{
int tmp = 0;
tmp = REG_SET_FIELD(tmp, VM_PRT_CNTL,
CB_DISABLE_FAULT_ON_UNMAPPED_ACCESS1,
enable);
return tmp;
}
This is definitely a false warning. I will be filing a bug upstream in a few
minutes.
Thanks,
Andrew
From: linaro-toolchain on behalf of
Andrew Pinski
Sent: Wednesday, September 8, 2021 1:29 PM
To: Maxim Kuvyrkov; Linus Torvalds; Alex Deucher
Cc: linaro-toolchain
Subject: Re: [EXT] Re: [CI-NOTIFY]: TCWG Bisect
tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
I think this is a false positive.
It is doing:
#define shift 2
#define mask (1ul<<(shift))
#define REG_FIELD_MASK(a,b) (mask)
#define REG_FIELD_SHIFT(a,b) (shift)
#define REG_SET_FIELD(orig_val, reg, field, field_val) \
(((orig_val) & ~REG_FIELD_MASK(reg, field)) | \
(REG_FIELD_MASK(reg, field) & ((field_val) << REG_FIELD_SHIFT(reg,
field
int f(_Bool enable)
{
int tmp = 0;
tmp = REG_SET_FIELD(tmp, VM_PRT_CNTL,
CB_DISABLE_FAULT_ON_UNMAPPED_ACCESS,
enable);
return tmp;
}
But I could not get GCC to warn. I think a toolchain person should look at the
preprocessed source to see what is happening.
Thanks,
Andrew Pinski
From: linaro-toolchain on behalf of
Maxim Kuvyrkov
Sent: Wednesday, September 8, 2021 2:30 AM
To: Linus Torvalds; Alex Deucher
Cc: linaro-toolchain
Subject: [EXT] Re: [CI-NOTIFY]: TCWG Bisect
tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
External Email
--
Hi Linus,
As expected, kernel builds started failing in less-common configurations. In
this particular case the culprit is amdgpu driver when built for 32-bit ARM in
allmodconfig configuration using tip-of-trunk GCC.
Hi Alex, [picking your name from “git log drivers/gpu/drm/amd/amdgpu/amdgpu.h”],
Would you please take a look? Let me know if the problem doesn’t reproduce for
you, and I’ll help to investigate.
00:22:45 In file included from drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:29:
00:22:45 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c: In function ‘gmc_v6_0_set_prt’:
00:22:45 drivers/gpu/drm/amd/amdgpu/amdgpu.h:1227:53: error: ‘<<’ in boolean
context, did you mean ‘<’? [-Werror=int-in-bool-context]
00:22:45 1227 | (REG_FIELD_MASK(reg, field) & ((field_val) <<
REG_FIELD_SHIFT(reg, field
00:22:45 |
~^~~
00:22:45 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:430:15: note: in expansion of
macro ‘REG_SET_FIELD’
00:22:45 430 | tmp = REG_SET_FIELD(tmp, VM_PRT_CNTL,
00:22:45 | ^
00:22:45 cc1: all warnings being treated as errors
00:22:45 make[4]: *** [scripts/Makefile.build:277:
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.o] Error 1
00:40:28 make[4]: Target '__build' not remade because of errors.
00:40:28 make[3]: *** [scripts/Makefile.build:540: drivers/gpu/drm/amd/amdgpu]
Error 2
00:41:17 make[3]: Target '__build' not remade because of errors.
00:41:17 make[2]: *** [scripts/Makefile.build:540: drivers/gpu/drm] Error 2
00:41:17 make[2]: Target '__build' not remade because of errors.
00:41:17 make[1]: *** [scripts/Makefile.build:540: drivers/gpu] Error 2
00:41:17 make[1]: Target '__build' not remade because of errors.
00:41:17 make: *** [Makefile:1872: drivers] Error 2
00:41:17 make: Target '__all' not remade because of errors.
Regards,
--
Maxim Kuvyrkov
https://urldefense.proofpoint.com/v2/url?u=https-3A__www.linaro.org&d=DwIGaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=L_uAQMgirzaBwiEk05NHY-AMcNfJzugOS_xTjrtS94k&m=3SIswy3Zze4DQV1eWknNsMoyQcvNDjLb6bESKfKZOlA&s=bcbggZZWC56u4q8MITx_3s-oLHlmtyzcI3FltbGjFlI&e=
> On 8 Sep 2021, at 11:40, ci_not...@linaro.org wrote:
>
> Successfully identified regression in *linux* in CI configuration
> tcwg_kernel/gnu-master-arm-mainline-allmodconfig. So far, this commit has
> regressed CI configurations:
> - tcwg_kernel/gnu-master-arm-mainline-allmodconfig
>
> Culprit:
>
> commit 3fe617ccafd6f5bb33c2391d6f4eeb41c1fd0151
> Author: Linus Torvalds
> Date: Sun Sep 5 11:24:05 2021 -0700
>
>Enable '-Werror' by default for all kernel builds
>
>... but make it a config option so that broken environments can disable
>it when required.
>
>We really should always have a c
Re: [EXT] Re: [CI-NOTIFY]: TCWG Bisect tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
Filed as https://gcc.gnu.org/PR102245 .
From: linaro-toolchain on behalf of
Andrew Pinski
Sent: Wednesday, September 8, 2021 2:31 PM
To: Maxim Kuvyrkov; Linus Torvalds; Alex Deucher
Cc: linaro-toolchain
Subject: Re: [EXT] Re: [CI-NOTIFY]: TCWG Bisect
tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
Ok, I am now able to reproduce it with:
#define shiftCB_DISABLE_FAULT_ON_UNMAPPED_ACCESS1 0
#define maskCB_DISABLE_FAULT_ON_UNMAPPED_ACCESS1 1L
#define REG_FIELD_MASK(a,b) (mask##b)
#define REG_FIELD_SHIFT(a,b) (shift##b)
#define REG_SET_FIELD(orig_val, reg, field, field_val) \
(((orig_val) & ~REG_FIELD_MASK(reg, field)) | \
(REG_FIELD_MASK(reg, field) & ((field_val) << REG_FIELD_SHIFT(reg,
field
int f(_Bool enable)
{
int tmp = 0;
tmp = REG_SET_FIELD(tmp, VM_PRT_CNTL,
CB_DISABLE_FAULT_ON_UNMAPPED_ACCESS1,
enable);
return tmp;
}
This is definitely a false warning. I will be filing a bug upstream in a few
minutes.
Thanks,
Andrew
From: linaro-toolchain on behalf of
Andrew Pinski
Sent: Wednesday, September 8, 2021 1:29 PM
To: Maxim Kuvyrkov; Linus Torvalds; Alex Deucher
Cc: linaro-toolchain
Subject: Re: [EXT] Re: [CI-NOTIFY]: TCWG Bisect
tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
I think this is a false positive.
It is doing:
#define shift 2
#define mask (1ul<<(shift))
#define REG_FIELD_MASK(a,b) (mask)
#define REG_FIELD_SHIFT(a,b) (shift)
#define REG_SET_FIELD(orig_val, reg, field, field_val) \
(((orig_val) & ~REG_FIELD_MASK(reg, field)) | \
(REG_FIELD_MASK(reg, field) & ((field_val) << REG_FIELD_SHIFT(reg,
field
int f(_Bool enable)
{
int tmp = 0;
tmp = REG_SET_FIELD(tmp, VM_PRT_CNTL,
CB_DISABLE_FAULT_ON_UNMAPPED_ACCESS,
enable);
return tmp;
}
But I could not get GCC to warn. I think a toolchain person should look at the
preprocessed source to see what is happening.
Thanks,
Andrew Pinski
From: linaro-toolchain on behalf of
Maxim Kuvyrkov
Sent: Wednesday, September 8, 2021 2:30 AM
To: Linus Torvalds; Alex Deucher
Cc: linaro-toolchain
Subject: [EXT] Re: [CI-NOTIFY]: TCWG Bisect
tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
External Email
--
Hi Linus,
As expected, kernel builds started failing in less-common configurations. In
this particular case the culprit is amdgpu driver when built for 32-bit ARM in
allmodconfig configuration using tip-of-trunk GCC.
Hi Alex, [picking your name from “git log drivers/gpu/drm/amd/amdgpu/amdgpu.h”],
Would you please take a look? Let me know if the problem doesn’t reproduce for
you, and I’ll help to investigate.
00:22:45 In file included from drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:29:
00:22:45 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c: In function ‘gmc_v6_0_set_prt’:
00:22:45 drivers/gpu/drm/amd/amdgpu/amdgpu.h:1227:53: error: ‘<<’ in boolean
context, did you mean ‘<’? [-Werror=int-in-bool-context]
00:22:45 1227 | (REG_FIELD_MASK(reg, field) & ((field_val) <<
REG_FIELD_SHIFT(reg, field
00:22:45 |
~^~~
00:22:45 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:430:15: note: in expansion of
macro ‘REG_SET_FIELD’
00:22:45 430 | tmp = REG_SET_FIELD(tmp, VM_PRT_CNTL,
00:22:45 | ^
00:22:45 cc1: all warnings being treated as errors
00:22:45 make[4]: *** [scripts/Makefile.build:277:
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.o] Error 1
00:40:28 make[4]: Target '__build' not remade because of errors.
00:40:28 make[3]: *** [scripts/Makefile.build:540: drivers/gpu/drm/amd/amdgpu]
Error 2
00:41:17 make[3]: Target '__build' not remade because of errors.
00:41:17 make[2]: *** [scripts/Makefile.build:540: drivers/gpu/drm] Error 2
00:41:17 make[2]: Target '__build' not remade because of errors.
00:41:17 make[1]: *** [scripts/Makefile.build:540: drivers/gpu] Error 2
00:41:17 make[1]: Target '__build' not remade because of errors.
00:41:17 make: *** [Makefile:1872: drivers] Error 2
00:41:17 make: Target '__all' not remade because of errors.
Regards,
--
Maxim Kuvyrkov
https://urldefense.proofpoint.com/v2/url?u=https-3A__www.linaro.org&d=DwIGaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=L_uAQMgirzaBwiEk05NHY-AMcNfJzugOS_xTjrtS94k&m=3SIswy3Zze4DQV1eWknNsMoyQcvNDjLb6bESKfKZOlA&s=bcbggZZWC56u4q8MITx_3s-oLHlmtyzcI3FltbGjFlI&e=
> On 8 Sep 2021, at 11:40, ci_not...@linaro.org wrote:
>
> Successfully identified regression in *linux* in CI configuration
> tcwg_kernel/gnu-master-arm-mainline-allmodconfig. So far, this commit has
> regressed CI configurations:
> - tcwg_
Re: [EXT] Re: [CI-NOTIFY]: TCWG Bisect tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
Oh it is only on the trunk of GCC so to some extend it caught a regression in
GCC :).
From: linaro-toolchain on behalf of
Andrew Pinski
Sent: Wednesday, September 8, 2021 2:36 PM
To: Maxim Kuvyrkov; Linus Torvalds; Alex Deucher
Cc: linaro-toolchain
Subject: Re: [EXT] Re: [CI-NOTIFY]: TCWG Bisect
tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
Filed as
https://urldefense.proofpoint.com/v2/url?u=https-3A__gcc.gnu.org_PR102245&d=DwIF-g&c=nKjWec2b6R0mOyPaz7xtfQ&r=L_uAQMgirzaBwiEk05NHY-AMcNfJzugOS_xTjrtS94k&m=Q4Md2buFVTtZ6Y0h2OJ0uRuXgt3gqEoy7kSSvYveMRQ&s=MC8RIVMy1kXaEYsoCOZd9Xjvw2ee1luiyJOXYpocseg&e=
.
From: linaro-toolchain on behalf of
Andrew Pinski
Sent: Wednesday, September 8, 2021 2:31 PM
To: Maxim Kuvyrkov; Linus Torvalds; Alex Deucher
Cc: linaro-toolchain
Subject: Re: [EXT] Re: [CI-NOTIFY]: TCWG Bisect
tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
Ok, I am now able to reproduce it with:
#define shiftCB_DISABLE_FAULT_ON_UNMAPPED_ACCESS1 0
#define maskCB_DISABLE_FAULT_ON_UNMAPPED_ACCESS1 1L
#define REG_FIELD_MASK(a,b) (mask##b)
#define REG_FIELD_SHIFT(a,b) (shift##b)
#define REG_SET_FIELD(orig_val, reg, field, field_val) \
(((orig_val) & ~REG_FIELD_MASK(reg, field)) | \
(REG_FIELD_MASK(reg, field) & ((field_val) << REG_FIELD_SHIFT(reg,
field
int f(_Bool enable)
{
int tmp = 0;
tmp = REG_SET_FIELD(tmp, VM_PRT_CNTL,
CB_DISABLE_FAULT_ON_UNMAPPED_ACCESS1,
enable);
return tmp;
}
This is definitely a false warning. I will be filing a bug upstream in a few
minutes.
Thanks,
Andrew
From: linaro-toolchain on behalf of
Andrew Pinski
Sent: Wednesday, September 8, 2021 1:29 PM
To: Maxim Kuvyrkov; Linus Torvalds; Alex Deucher
Cc: linaro-toolchain
Subject: Re: [EXT] Re: [CI-NOTIFY]: TCWG Bisect
tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
I think this is a false positive.
It is doing:
#define shift 2
#define mask (1ul<<(shift))
#define REG_FIELD_MASK(a,b) (mask)
#define REG_FIELD_SHIFT(a,b) (shift)
#define REG_SET_FIELD(orig_val, reg, field, field_val) \
(((orig_val) & ~REG_FIELD_MASK(reg, field)) | \
(REG_FIELD_MASK(reg, field) & ((field_val) << REG_FIELD_SHIFT(reg,
field
int f(_Bool enable)
{
int tmp = 0;
tmp = REG_SET_FIELD(tmp, VM_PRT_CNTL,
CB_DISABLE_FAULT_ON_UNMAPPED_ACCESS,
enable);
return tmp;
}
But I could not get GCC to warn. I think a toolchain person should look at the
preprocessed source to see what is happening.
Thanks,
Andrew Pinski
From: linaro-toolchain on behalf of
Maxim Kuvyrkov
Sent: Wednesday, September 8, 2021 2:30 AM
To: Linus Torvalds; Alex Deucher
Cc: linaro-toolchain
Subject: [EXT] Re: [CI-NOTIFY]: TCWG Bisect
tcwg_kernel/gnu-master-arm-mainline-allmodconfig - Build # 28 - Successful!
External Email
--
Hi Linus,
As expected, kernel builds started failing in less-common configurations. In
this particular case the culprit is amdgpu driver when built for 32-bit ARM in
allmodconfig configuration using tip-of-trunk GCC.
Hi Alex, [picking your name from “git log drivers/gpu/drm/amd/amdgpu/amdgpu.h”],
Would you please take a look? Let me know if the problem doesn’t reproduce for
you, and I’ll help to investigate.
00:22:45 In file included from drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:29:
00:22:45 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c: In function ‘gmc_v6_0_set_prt’:
00:22:45 drivers/gpu/drm/amd/amdgpu/amdgpu.h:1227:53: error: ‘<<’ in boolean
context, did you mean ‘<’? [-Werror=int-in-bool-context]
00:22:45 1227 | (REG_FIELD_MASK(reg, field) & ((field_val) <<
REG_FIELD_SHIFT(reg, field
00:22:45 |
~^~~
00:22:45 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:430:15: note: in expansion of
macro ‘REG_SET_FIELD’
00:22:45 430 | tmp = REG_SET_FIELD(tmp, VM_PRT_CNTL,
00:22:45 | ^
00:22:45 cc1: all warnings being treated as errors
00:22:45 make[4]: *** [scripts/Makefile.build:277:
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.o] Error 1
00:40:28 make[4]: Target '__build' not remade because of errors.
00:40:28 make[3]: *** [scripts/Makefile.build:540: drivers/gpu/drm/amd/amdgpu]
Error 2
00:41:17 make[3]: Target '__build' not remade because of errors.
00:41:17 make[2]: *** [scripts/Makefile.build:540: drivers/gpu/drm] Error 2
00:41:17 make[2]: Target '__build' not remade because of errors.
00:41:17 make[1]: *** [scripts/Makefile.build:540: drivers/gpu] Error 2
00:41:17 make[1]: Target '__build' not remade beca
