[kmymoney] [Bug 495821] No display of the account hierarchy for reports in the app and when printing

2024-11-05 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=495821

Ralf Habacker  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
   Version Fixed In||5.2
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/offi
   ||ce/kmymoney/-/commit/581bf7
   ||42bdccee226d7bd0f84f1797296
   ||ba70a23

--- Comment #6 from Ralf Habacker  ---
Git commit 581bf742bdccee226d7bd0f84f1797296ba70a23 by Ralf Habacker.
Committed on 05/11/2024 at 11:37.
Pushed by habacker into branch 'master'.

Fix display of reports printig and print preview

After switching to the QTextBrowser class for printing and the print
view of reports, too little space is output between the individual
columns. This is corrected by defining a left margin in front of
each column.
Related: bug 492831
FIXED-IN:5.2

M  +3-3kmymoney/misc/kmmtextbrowser.cpp

https://invent.kde.org/office/kmymoney/-/commit/581bf742bdccee226d7bd0f84f1797296ba70a23

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 492831] Account Balance Report needs HTML improvements

2024-11-05 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=492831

Ralf Habacker  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/offi |https://invent.kde.org/offi
   |ce/kmymoney/-/commit/aa472d |ce/kmymoney/-/commit/581bf7
   |77db0a3b08909e3174d184ee038 |42bdccee226d7bd0f84f1797296
   |64450c5 |ba70a23

--- Comment #23 from Ralf Habacker  ---
Git commit 581bf742bdccee226d7bd0f84f1797296ba70a23 by Ralf Habacker.
Committed on 05/11/2024 at 11:37.
Pushed by habacker into branch 'master'.

Fix display of reports printig and print preview

After switching to the QTextBrowser class for printing and the print
view of reports, too little space is output between the individual
columns. This is corrected by defining a left margin in front of
each column.
Related: bug 495821
FIXED-IN:5.2

M  +3-3kmymoney/misc/kmmtextbrowser.cpp

https://invent.kde.org/office/kmymoney/-/commit/581bf742bdccee226d7bd0f84f1797296ba70a23

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 492831] Account Balance Report needs HTML improvements

2024-11-05 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=492831

--- Comment #22 from Ralf Habacker  ---
Git commit 37de9b0a4ac298c374708631b612106e10edc6a8 by Ralf Habacker.
Committed on 05/11/2024 at 11:09.
Pushed by habacker into branch 'master'.

Fix the indentation when displaying reports in the application

The mentioned commit corrected the html export of a report, but not
the display of the report, because the HTML import of QTextDocument,
which is used here, does not support the unit “em” for the css
attribute “text-indent”. To fix this, the unit “px” is always used
in the generated HTML text.

Fixup for commit ffa7449ae

M  +3-3kmymoney/plugins/views/reports/core/pivottable.cpp

https://invent.kde.org/office/kmymoney/-/commit/37de9b0a4ac298c374708631b612106e10edc6a8

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 492831] Account Balance Report needs HTML improvements

2024-11-05 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=492831

--- Comment #25 from Ralf Habacker  ---
Git commit 3a5f40c79dfb74670f1f2adfb419b4c17d4fd1ab by Ralf Habacker.
Committed on 05/11/2024 at 15:01.
Pushed by habacker into branch 'master'.

Removed font sizes in the unit 'px' in kmymoney.css

As the unit “pt” for the size of fonts is already used elsewhere in this
stylesheet, the use of “px” makes no sense here, as it is much too small,
which is noticeable when printing or previewing larger page formats.

M  +0-3kmymoney/html/kmymoney.css

https://invent.kde.org/office/kmymoney/-/commit/3a5f40c79dfb74670f1f2adfb419b4c17d4fd1ab

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 492831] Account Balance Report needs HTML improvements

2024-11-05 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=492831

--- Comment #24 from Ralf Habacker  ---
Git commit 5ee78051fc635637a706c3e79bda5effbf6af84d by Ralf Habacker.
Committed on 05/11/2024 at 14:46.
Pushed by habacker into branch 'master'.

Add control of output settings in PDF format

When exporting to a PDF file, a dialog is now displayed for each
selected report with which various output settings can be adjusted.

M  +45   -0kmymoney/misc/kmm_printer.cpp
M  +14   -0kmymoney/misc/kmm_printer.h
M  +5-4kmymoney/plugins/views/reports/kreportsview_p.h

https://invent.kde.org/office/kmymoney/-/commit/5ee78051fc635637a706c3e79bda5effbf6af84d

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 495821] No display of the account hierarchy for reports in the app and when printing

2024-11-05 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=495821

--- Comment #2 from Ralf Habacker  ---
Created attachment 175538
  --> https://bugs.kde.org/attachment.cgi?id=175538&action=edit
Screenshot from report displayed in the app (not okay)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 495821] New: No display of the account hierarchy for reports in the app and when printing

2024-11-05 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=495821

Bug ID: 495821
   Summary: No display of the account hierarchy for reports in the
app and when printing
Classification: Applications
   Product: kmymoney
   Version: git (master)
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: reports
  Assignee: kmymoney-devel@kde.org
  Reporter: ralf.habac...@freenet.de
  Target Milestone: ---

Created attachment 175536
  --> https://bugs.kde.org/attachment.cgi?id=175536&action=edit
test file

STEPS TO REPRODUCE
1.  download kmymoney binary snapshot  from
https://cdn.kde.org/ci-builds/office/kmymoney/master/
2. start kmymoney
3. open appended file
4. Select tab "Accounts"
5. Inspect the account hierachy below "income"
6. Open report "Income and Expenses By Year (Customised)"
7. Save the report as html file
8. Inspect the generated html file
9. Save the report as pdf file or print it

OBSERVED RESULT
The hierarchy below “income” is visible in topic 5. and 8. but not in 6 and 9.

EXPECTED RESULT
The hierarchy under “Income” should be visible in the displayed report and in
the saved PDF file.

SOFTWARE/OS VERSIONS
Linux:  openSUSE_Leap_15.5
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.14

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 495821] No display of the account hierarchy for reports in the app and when printing

2024-11-05 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=495821

--- Comment #1 from Ralf Habacker  ---
Created attachment 175537
  --> https://bugs.kde.org/attachment.cgi?id=175537&action=edit
Screenshot from report exported as html (okay)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 495821] No display of the account hierarchy for reports in the app and when printing

2024-11-05 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=495821

--- Comment #5 from Ralf Habacker  ---
Git commit 37de9b0a4ac298c374708631b612106e10edc6a8 by Ralf Habacker.
Committed on 05/11/2024 at 11:09.
Pushed by habacker into branch 'master'.

Fix the indentation when displaying reports in the application

The mentioned commit corrected the html export of a report, but not
the display of the report, because the HTML import of QTextDocument,
which is used here, does not support the unit “em” for the css
attribute “text-indent”. To fix this, the unit “px” is always used
in the generated HTML text.

Fixup for commit ffa7449ae

M  +3-3kmymoney/plugins/views/reports/core/pivottable.cpp

https://invent.kde.org/office/kmymoney/-/commit/37de9b0a4ac298c374708631b612106e10edc6a8

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 492906] Adding category with different currency fails

2024-11-05 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=492906

--- Comment #4 from Ralf Habacker  ---
(In reply to Thomas Baumgart from comment #1)
> Unable to reproduce this with current master neither on Linux nor on
> Windows. Did it get resolved in the meantime?

I have currently tested this again and could not reproduce it either. Thank you
for investigating.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 495821] No display of the account hierarchy for reports in the app and when printing

2024-11-05 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=495821

--- Comment #3 from Ralf Habacker  ---
The logic used to provide the account hierarchy in HTML files (see
https://invent.kde.org/office/kmymoney/-/blob/master/kmymoney/plugins/views/reports/core/pivottable.cpp?ref_type=heads#L1879
and other places) no longer works in the display of reports in the application
after switching to QTextBrowser.

The css attribute “text-indent” is currently used, which according to the
QTextDocument documentation is only supported at the beginning of a text
(https://doc.qt.io/qt-5/richtext-html-subset.html)

text-indent px First line text indentation in pixels

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 495821] No display of the account hierarchy for reports in the app and when printing

2024-11-05 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=495821

Ralf Habacker  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #4 from Ralf Habacker  ---
(In reply to Ralf Habacker from comment #3)
> text-indent px First line text indentation in pixels

An investigation showed that this statement applies to the beginning of each
paragraph, so that the basic use is given. The actual problem lies in the fact
that the unsupported unit “em” is used in the source code for HTML generation
for pivot tables (see
https://invent.kde.org/office/kmymoney/-/blob/master/kmymoney/plugins/views/reports/core/pivottable.cpp?ref_type=heads#L1827)

-- 
You are receiving this mail because:
You are the assignee for the bug.