[kmymoney] [Bug 492791] New: Warning “qt.modeltest: Inconsistent parent() implementation detected” when starting kmymoney if compiled with cmake option -DUSE_MODELTEST=1
https://bugs.kde.org/show_bug.cgi?id=492791
Bug ID: 492791
Summary: Warning “qt.modeltest: Inconsistent parent()
implementation detected” when starting kmymoney if
compiled with cmake option -DUSE_MODELTEST=1
Classification: Applications
Product: kmymoney
Version: git (master)
Platform: Other
OS: All
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: kmymoney-devel@kde.org
Reporter: ralf.habac...@freenet.de
Target Milestone: ---
SUMMARY
Running kmymoney from master branch configured with -DUSE_MODELTEST=1 shows the
mentioned warning in the log.
STEPS TO REPRODUCE
1. build kmymoney from git master
2. start kmymoney
3. load a simple file
OBSERVED RESULT
In the log there
Open file QUrl("file:///home/xxx/new-bug.xml")
Start verifying account hierarchy
End verifying account hierarchy
qt.modeltest: Inconsistent parent() implementation detected:
qt.modeltest: index= QModelIndex(0,0,0x3174130,AccountsModel(0x2e919c0,
name = "AccountsModel")) exp. parent=
QModelIndex(1,1,0x326b0a0,AccountsModel(0x2e919c0, name = "AccountsModel"))
act. parent= QModelIndex(1,0,0x326b0a0,AccountsModel(0x2e919c0, name =
"AccountsModel"))
qt.modeltest: row= 0 col= 0 depth= 1
qt.modeltest: data for child "checking"
qt.modeltest: data for parent "Anlagen"
qt.modeltest: FAIL! Compared values are not the same:
Actual (model->parent(index)) QModelIndex(1,0,0x326b0a0,0x2e919c0)
Expected (parent) QModelIndex(1,1,0x326b0a0,0x2e919c0)
(qabstractitemmodeltester.cpp:567)
qt.modeltest: Inconsistent parent() implementation detected:
qt.modeltest: index= QModelIndex(0,0,0x3174130,AccountsModel(0x2e919c0,
name = "AccountsModel")) exp. parent=
QModelIndex(1,2,0x326b0a0,AccountsModel(0x2e919c0, name = "AccountsModel"))
act. parent= QModelIndex(1,0,0x326b0a0,AccountsModel(0x2e919c0, name =
"AccountsModel"))
qt.modeltest: row= 0 col= 0 depth= 1
qt.modeltest: data for child "checking"
qt.modeltest: data for parent ""
qt.modeltest: FAIL! Compared values are not the same:
Actual (model->parent(index)) QModelIndex(1,0,0x326b0a0,0x2e919c0)
Expected (parent) QModelIndex(1,2,0x326b0a0,0x2e919c0)
(qabstractitemmodeltester.cpp:567)
qt.modeltest: Inconsistent parent() implementation detected:
qt.modeltest: index= QModelIndex(0,0,0x3174130,AccountsModel(0x2e919c0,
name = "AccountsModel")) exp. parent=
QModelIndex(1,3,0x326b0a0,AccountsModel(0x2e919c0, name = "AccountsModel"))
act. parent= QModelIndex(1,0,0x326b0a0,AccountsModel(0x2e919c0, name =
"AccountsModel"))
qt.modeltest: row= 0 col= 0 depth= 1
qt.modeltest: data for child "checking"
qt.modeltest: data for parent ""
qt.modeltest: FAIL! Compared values are not the same:
Actual (model->parent(index)) QModelIndex(1,0,0x326b0a0,0x2e919c0)
Expected (parent) QModelIndex(1,3,0x326b0a0,0x2e919c0)
(qabstractitemmodeltester.cpp:567)
qt.modeltest: Inconsistent parent() implementation detected:
qt.modeltest: index= QModelIndex(0,0,0x3174130,AccountsModel(0x2e919c0,
name = "AccountsModel")) exp. parent=
QModelIndex(1,4,0x326b0a0,AccountsModel(0x2e919c0, name = "AccountsModel"))
act. parent= QModelIndex(1,0,0x326b0a0,AccountsModel(0x2e919c0, name =
"AccountsModel"))
qt.modeltest: row= 0 col= 0 depth= 1
qt.modeltest: data for child "checking"
qt.modeltest: data for parent ""
qt.modeltest: FAIL! Compared values are not the same:
Actual (model->parent(index)) QModelIndex(1,0,0x326b0a0,0x2e919c0)
Expected (parent) QModelIndex(1,4,0x326b0a0,0x2e919c0)
(qabstractitemmodeltester.cpp:567)
qt.modeltest: Inconsistent parent() implementation detected:
qt.modeltest: index= QModelIndex(0,0,0x3174130,AccountsModel(0x2e919c0,
name = "AccountsModel")) exp. parent=
QModelIndex(1,5,0x326b0a0,AccountsModel(0x2e919c0, name = "AccountsModel"))
act. parent= QModelIndex(1,0,0x326b0a0,AccountsModel(0x2e919c0, name =
"AccountsModel"))
qt.modeltest: row= 0 col= 0 depth= 1
qt.modeltest: data for child "checking"
qt.modeltest: data for parent ""
qt.modeltest: FAIL! Compared values are not the same:
Actual (model->parent(index)) QModelIndex(1,0,0x326b0a0,0x2e919c0)
Expected (parent) QModelIndex(1,5,0x326b0a0,0x2e919c0)
(qabstractitemmodeltester.cpp:567)
qt.modeltest: Inconsistent parent() implementation detected:
qt.modeltest: index= QModelIndex(0,0,0x3174130,AccountsModel(0x2e919c0,
name = "AccountsModel")) exp. parent=
QModelIndex(1,6,0x326b0a0,AccountsModel(0x2e919c0, name = "AccountsModel"))
act. parent= QModelIndex(1,0,0x326b0a0,AccountsModel(0x2e919c0, name =
"AccountsModel"))
qt.modeltest: row= 0 col= 0 depth= 1
qt.modeltest: data for child "checking"
qt.modeltest: data for parent ""
qt.modeltest: FAIL! Compared values are not the same:
Actual (model->parent(index)) QModelIndex(1,0,0x326b0a0,0x2e9
[kmymoney] [Bug 489274] Manual backup fails when using spaces in save path
https://bugs.kde.org/show_bug.cgi?id=489274 --- Comment #7 from Jack --- So should this remain open, or be closed again? -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492831] New: Account Balance Report needs HTML improvements
https://bugs.kde.org/show_bug.cgi?id=492831 Bug ID: 492831 Summary: Account Balance Report needs HTML improvements Classification: Applications Product: kmymoney Version: 5.1.3 Platform: Microsoft Windows OS: Microsoft Windows Status: REPORTED Severity: minor Priority: NOR Component: reports Assignee: kmymoney-devel@kde.org Reporter: gemdan...@fastem.com Target Milestone: --- SUMMARY The Net Worth -> Account Balances report has several HTML and CSS issues. This probably applies to many other reports also. STEPS TO REPRODUCE 1. Run the report Net Worth -> Account Balances by Institution 2. Export the report as HTML 3. Look at the generated HTML file with a text editor. OBSERVED RESULT 1. CSS has "background: " items with a url which points to the kmymoney installation folder. That is useless if the file is moved to any place else, and probably even when on this computer. Delete the background items entirely. 2. Account names in the report have HTML links like Bank Name These links do not work, so should not be created. No use for links in this report, so all the "A" css items can be deleted. 3. HTML DOCTYPE is specified as HTML 4.01 strict. It would be nice to update the format for HTML 5. EXPECTED RESULT No "background:" CSS items with a url No links in the HTML No A.xx items in the CSS SOFTWARE/OS VERSIONS Windows: 11 ADDITIONAL INFORMATION KMyMoney 5.1.3-eefo4f1, installed via kmymoney-5.1-3218-windows-cl-msvc2019-x86_64 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492831] Account Balance Report needs HTML improvements
https://bugs.kde.org/show_bug.cgi?id=492831 --- Comment #1 from Jack --- Are you aware that KMyMoney displays reports using HTML? There, those links actually work - taking you, for example, to the transaction in the ledger for the relevant account. I suspect it would be difficult to create different HTML/CSS for display and for export, but that is what would be required for your suggestions.. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492837] New: Income and Expenses report needs some HTML improvements
https://bugs.kde.org/show_bug.cgi?id=492837
Bug ID: 492837
Summary: Income and Expenses report needs some HTML
improvements
Classification: Applications
Product: kmymoney
Version: 5.1.3
Platform: Microsoft Windows
OS: Microsoft Windows
Status: REPORTED
Severity: minor
Priority: NOR
Component: reports
Assignee: kmymoney-devel@kde.org
Reporter: gemdan...@fastem.com
Target Milestone: ---
SUMMARY
The Income and Expenses -> Income and Expenses report has several HTML and CSS
issues.
This probably applies to many other reports also.
STEPS TO REPRODUCE
1. Run the report Income and Expenses -> Income and Expenses
2. Export the report as HTML
3. Look at the generated HTML file with a text editor, and/or run it through a
HTML validator like https://validator.w3.org/nu/
OBSERVED RESULT
1. CSS has "background: " items with a url which points to the kmymoney
installation folder.
That is useless if the file is moved to any place else, and probably even when
on this computer.
Delete the background items entirely.
2. Some of the HTML tags are missing a space between the parameters:
should be
3. The HTML contains id="xxx" many times, with the same ID (see above,
id="solo").
An id is supposed to be unique in the page, just used once.
If you want to use the same item multiple times, it should be a class instead
of an id.
4. All HTML element values should be in quotes, but some are not:
should be
Better yet for this, set a class for the color and use the class instead of
specifying the color explicitly each time.
5. Vertical alignment of some table cells needs improvement in the CSS:
td{ vertical-align: baseline }
It would be better to use "bottom" instead of "baseline".
It looks OK in a browser, but when I save the HTML page a PDF file, in the
Grand Total lines, the "Grand Total" label does not line up with the values
(see attached PDF file).
Changing the vertical-align from "baseline" to "bottom" solves the problem.
4. There are no links in the HTML, so don't need the A.xx items in the CSS.
3. HTML DOCTYPE is specified as HTML 4.01 strict.
It would be nice to update the format for HTML 5.
EXPECTED RESULT
No "background:" CSS items with a url
Spaces between all HTML attributes.
Quotes around all HTML attribute values.
No duplicate "id" values.
Good table cell vertical alignment.
No A.xx items in the CSS
SOFTWARE/OS VERSIONS
Windows: 11
ADDITIONAL INFORMATION
KMyMoney 5.1.3-eefo4f1, installed via
kmymoney-5.1-3218-windows-cl-msvc2019-x86_64
You can check the format of the HTML using this page:
https://validator.w3.org/nu/
--
You are receiving this mail because:
You are the assignee for the bug.
[kmymoney] [Bug 492837] Income and Expenses report needs some HTML improvements
https://bugs.kde.org/show_bug.cgi?id=492837 --- Comment #1 from Glenn --- Created attachment 173456 --> https://bugs.kde.org/attachment.cgi?id=173456&action=edit PDF file showing mis-alignment of Grand Total row Forgot to attach the PDF file showing mis-alignment of Grand Total row. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492831] Account Balance Report needs HTML improvements
https://bugs.kde.org/show_bug.cgi?id=492831 --- Comment #2 from Glenn --- You can validate the report HTML using the web page https://validator.w3.org/nu/ -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492831] Account Balance Report needs HTML improvements
https://bugs.kde.org/show_bug.cgi?id=492831 --- Comment #3 from Glenn --- Thanks for the quick reply! OK, the link is useful when viewing the report in KmyMoney, but it is useless in the export. No need to include it in the export. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492831] Account Balance Report needs HTML improvements
https://bugs.kde.org/show_bug.cgi?id=492831 --- Comment #4 from Jack --- First, no need for a separate but for each report or type of report, any changes can/will easily be applied wherever applicable. Feel free to point out which are affected in additional comments. Next, the report is generated. If export is requested, the already generated report is exported, it is not generated again for that purpose, thus my comment that to export something different from what is displayed is going to take extra work. I am also not sure how much of the actual HTML/CSS has been written by the KMM developers vs generated by any underlying KDE/Qt libraries, or even some combination. I suppose removing specified pieces of HTML/CSS can be done with regexp type editing, it's still extra work. As usual, patches gratefully accepted. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492831] Account Balance Report needs HTML improvements
https://bugs.kde.org/show_bug.cgi?id=492831 --- Comment #5 from Glenn --- OK, I understand better now. The displayed report is actually HTML, and the Export just outputs that same HTML to a file. It is extra work to modify the HTML during the Export. By definition, Export means it will be used outside of KyMyMoney, so it would be nice if it actually worked properly outside of KyMyMoney. You folks might want to think about that. There is a workaround: Convert the HTML to PDF. As the treasurer for an organization, I use the Export to generate reports to present to the board. HTML is not a good format for that, so I end up saving them as PDF from the web browser. Converting to PDF seems to ignore all the HTML issues and it comes out OK. I also use Quickbooks for another organization, and it generates reports directly in PDF format. Although it is an extra step in KyMyMoney to convert from HTML to PDF, it is more flexible because geeks like me can edit the HTML to customize the report. Since I don't use the HTML format directly, I guess I should not worry about correctness of the HTML, and just accept it as is. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492837] Income and Expenses report needs some HTML improvements
https://bugs.kde.org/show_bug.cgi?id=492837 --- Comment #2 from Glenn --- OK, I understand better now about reports. The displayed report is actually HTML, and the Export just outputs that same HTML to a file. It is extra work to modify the HTML during the Export. By definition, Export means it will be used outside of KyMyMoney, so it would be nice if it actually worked properly outside of KyMyMoney. You folks might want to think about that. There is a workaround: Convert the HTML to PDF. As the treasurer for an organization, I use the Export to generate reports to present to the board. HTML is not a good format for that, so I end up saving them as PDF from the web browser. Converting to PDF seems to ignore all the HTML issues and it comes out OK, EXCEPT for the Grand Total row label not lining up with the numbers. I also use Quickbooks for another organization, and it generates reports directly in PDF format. Although it is an extra step in KyMyMoney to convert from HTML to PDF, it is more flexible because geeks like me can edit the HTML to customize the report. Since I don't use the HTML format directly, I guess I should not worry about correctness of the HTML, and just accept it as is. I have been editing the HTML file to make it more correct, but it does not make much difference in the PDF output, except for that Grand Total row. I guess I can limit my editing to just that CSS vertical-align value so the Grand Total row comes out right. Maybe you can just change that, and I would not have to edit the HTML at all (leaving the other problems intact)? -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492837] Income and Expenses report needs some HTML improvements
https://bugs.kde.org/show_bug.cgi?id=492837 --- Comment #3 from Glenn --- The HTML validator at https://validator.w3.org/ has pointed out another minor issue, with the DOCTYPE declaration. Your doctype has a typo: http://www.w3.org/TR/html4/strict.dtd";> There should NOT be a space between "4.01" and "//EN". Next time somebody works on the Report module, they should validate the HTML output and correct all the simple errors, like spacing, missing quotes, etc. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492843] New: Option to turn off Reconciliation notifications in Ledger
https://bugs.kde.org/show_bug.cgi?id=492843 Bug ID: 492843 Summary: Option to turn off Reconciliation notifications in Ledger Classification: Applications Product: kmymoney Version: 5.1.3 Platform: Microsoft Windows OS: Microsoft Windows Status: REPORTED Severity: wishlist Priority: NOR Component: general Assignee: kmymoney-devel@kde.org Reporter: gemdan...@fastem.com Target Milestone: --- SUMMARY Please consider adding an option in the Ledger Settings to turn off the display of the Reconciliation Balance notices that appear in the ledger. I find them quite distracting. STEPS TO REPRODUCE 1. Open a bank account ledger than has had some Reconciliations. OBSERVED RESULT For every Reconciliation there is a yellow/brownish line in the ledger stating the date and amount of the Reconciliation. EXPECTED RESULT No such Reconciliation lines in the ledger. SOFTWARE/OS VERSIONS Windows: 11 ADDITIONAL INFORMATION -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492831] Account Balance Report needs HTML improvements
https://bugs.kde.org/show_bug.cgi?id=492831 --- Comment #6 from Jack --- I think (but am not sure) that we have a wishlist filed for being able to output reports directly to PDF. However, if the exported HTML is opened directly in a browser and then printed to PDF, the extra work is fairly minimal. One question, though, is the HTML/CSS is simply non-compliant with standards, or does it actually cause any problem in how the report looks in a browser, other than the presence of links that don't work? This bug is still valid either way, but it would likely affect the priority it receives. I am also the treasurer for a small non-profit, and I export from KMM as csv, do some further manipulation in LibrOffice, and then save as PDF for presentation, so not quite the same workflow. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492843] Option to turn off Reconciliation notifications in Ledger
https://bugs.kde.org/show_bug.cgi?id=492843 --- Comment #1 from Jack --- I'm pretty sure an option for this has been added in master branch. It will eventually be released as 5.2, but there is no definite timeline yet. You can test by using the version from master branch. Clearly, it has not yet been released, so backup early and often, but there are some folks (myself included) who have been using it in production for several months. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492837] Income and Expenses report needs some HTML improvements
https://bugs.kde.org/show_bug.cgi?id=492837 Jack changed: What|Removed |Added CC||ostroffjh@users.sourceforge ||.net --- Comment #4 from Jack --- Is the misalignment present when the report is viewed in KMM, when the exported report is viewed in a browser, or does it just show up when printed to PDF? On fixing the DOCTYPE and similar things, I have to actually look at the code, but I'm pretty sure that part of the HTML is not generated directly by KMyMoney code, but by a KDE or Qt library, so we'll probably have to pass the bug on to whichever of them is responsible. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492837] Income and Expenses report needs some HTML improvements
https://bugs.kde.org/show_bug.cgi?id=492837 --- Comment #5 from Glenn --- The mis-alignment does not show up when viewing in the browser, only when Printing from the browser. It shows up in the Print Preview, and the Printed/Saved output. BUT, the mis-alignment only shows up using Chrome and Edge. No problem in Firefox. Maybe it is not caused by KMyMoney at all, but there seems to be an easy(?) fix via KMyMoney (or manual editing, or using Firefox). -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492831] Account Balance Report needs HTML improvements
https://bugs.kde.org/show_bug.cgi?id=492831 --- Comment #7 from Glenn --- After looking at this more, it is just an issue of non-compliance with standards. The HTML output looks fine, except the Link for each Account does not work. The PDF is fine. When I open the browser Inspector, the Console does not show any errors or warnings. Very low priority, or maybe even close it with no further action. Sorry to bother you folks about something so trivial. You have been very responsive, and I really appreciate that. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 492837] Income and Expenses report needs some HTML improvements
https://bugs.kde.org/show_bug.cgi?id=492837 --- Comment #6 from Glenn --- After looking at this more, it is mostly an issue of non-compliance with standards, and maybe some quirks of the browsers. The HTML output looks fine. The PDF is fine, except for the Grand Total label mis-alignment, which is a minor issue. When I open the browser Inspector, the Console does not show any errors or warnings. Very low priority, or maybe even close it with no further action. Maybe let the KDE or Qt library folks know they should validate their HTML output. Sorry to bother you folks about something so trivial. You have been very responsive, and I really appreciate that. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 489274] Manual backup fails when using spaces in save path
https://bugs.kde.org/show_bug.cgi?id=489274 --- Comment #8 from Ralf Habacker --- I think yes, as a result of my investigation, a fix is required in source [here](https://invent.kde.org/office/kmymoney/-/blame/c195e0cda57949891207f5c7f2c817d2b6fbe298/kmymoney/kmymoney.cpp?page=3#L2409), but I haven't checked it on an installation yet, which is why I haven't set this ticket to “confirmed” status yet. -- You are receiving this mail because: You are the assignee for the bug.
