[kmymoney] [Bug 489724] New: kmymoney depends on knewstuff library but is not used when cpp macro KMM_DEBUG is not defined
https://bugs.kde.org/show_bug.cgi?id=489724 Bug ID: 489724 Summary: kmymoney depends on knewstuff library but is not used when cpp macro KMM_DEBUG is not defined Classification: Applications Product: kmymoney Version: git (master) Platform: Other OS: All Status: REPORTED Severity: normal Priority: NOR Component: packaging Assignee: kmymoney-devel@kde.org Reporter: ralf.habac...@freenet.de Blocks: 488491 Target Milestone: --- STEPS TO REPRODUCE 1. see https://invent.kde.org/office/kmymoney/-/blob/master/CMakeLists.txt#L114 - knewstuff library is added 2. see https://invent.kde.org/office/kmymoney/-/blame/master/kmymoney/kmymoney.cpp?page=5#L4002 OBSERVED RESULT The knewstuff library is requested in the cmake build system unconditionally. An api function from knewstuff is used at https://invent.kde.org/office/kmymoney/-/blame/master/kmymoney/kmymoney.cpp?page=5#L4002, but the associate support is only reachable when the cpp macro KMM_DEBUG is defined. EXPECTED RESULT If debugging is disabled, knewstuff should not be requested in the cmake build system and not be used in the c++ code. SOFTWARE/OS VERSIONS Linux: openSUSE_Leap_15.5 KDE Frameworks Version: 5.103.0 Qt Version: 5.15.4 Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=488491 [Bug 488491] Make 5.2 release -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 488491] Make 5.2 release
https://bugs.kde.org/show_bug.cgi?id=488491 Ralf Habacker changed: What|Removed |Added Depends on||489724 Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=489724 [Bug 489724] kmymoney depends on knewstuff library but is not used when cpp macro KMM_DEBUG is not defined -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 489724] kmymoney depends on knewstuff library but is not used when cpp macro KMM_DEBUG is not defined
https://bugs.kde.org/show_bug.cgi?id=489724 Thomas Baumgart changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED Version Fixed In||5.2 Latest Commit||https://invent.kde.org/offi ||ce/kmymoney/-/commit/3ea7dd ||cd1d8f9a7cfe06d5bc53c15546c ||32bc9f1 --- Comment #1 from Thomas Baumgart --- Git commit 3ea7ddcd1d8f9a7cfe06d5bc53c15546c32bc9f1 by Thomas Baumgart. Committed on 05/07/2024 at 04:25. Pushed by tbaumgart into branch 'master'. Remove dependency to knewstuff The whole "new stuff" logic for the online quotes has been moved to the alkimia library so we don't need it here anymore. FIXED-IN: 5.2 M +1-1CMakeLists.txt M +0-1kmymoney/CMakeLists.txt M +0-4kmymoney/kmymoney.cpp https://invent.kde.org/office/kmymoney/-/commit/3ea7ddcd1d8f9a7cfe06d5bc53c15546c32bc9f1 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 488491] Make 5.2 release
https://bugs.kde.org/show_bug.cgi?id=488491 Bug 488491 depends on bug 489724, which changed state. Bug 489724 Summary: kmymoney depends on knewstuff library but is not used when cpp macro KMM_DEBUG is not defined https://bugs.kde.org/show_bug.cgi?id=489724 What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
