[kmymoney4] [Bug 372254] Crash when importing CSV file

2016-11-10 Thread allan
https://bugs.kde.org/show_bug.cgi?id=372254

--- Comment #2 from allan  ---
I think I can see what has happened.
I have created a profile for one of my banks, but I have more than one account
there.  The checking account has one column for the Amount, whereas the savings
account has columns for both credits and debits.  The latter therefore has more
columns, and the column numbers from this account were saved in the resource
file.

If now a checking account is loaded, the saved column details will include more
columns than in the checking file.  Therefore, the result is that an attempt is
made to access a nonexistent column, and an out-of-bounds index is generated.

This happens circa line 576-578 in bankingwizardpage.cpp -

if (!memo.isEmpty())
memo.append(QChar(QLatin1Char('\n')));
  memo.append(m_columnList[m_wiz->m_memoColList[i]]);

I have inserted

if (m_wiz->m_memoColList[i] < m_columnList.count())  // avoid out of bounds

before the last line to avoid it going out of bounds.

This avoids the problem, but an additional profile will be needed to cover the
different formats.  Has anyone else a more elegant solution?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 274021] Transaction attachments

2016-11-10 Thread Clive Riches
https://bugs.kde.org/show_bug.cgi?id=274021

--- Comment #5 from Clive Riches  ---
Ok Thank you Jack.  I just assumed it had been forgotten about as it was raised
over 5 years ago. Even a clickable link would be good - at the moment you cant
even select text in a transaction unless your editing it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Review Request 129371: Use GpgME++ if possible, QGpgme from kdepimlibs-4 as fallback

2016-11-10 Thread Andreas Sturmlechner

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129371/
---

Review request for KMymoney.


Repository: kmymoney


Description
---

Gives kmymoney-4 some extended life on systems that upgrade to KDE Applications 
16.12 and are required to upgrade to kdepimlibs-conflicting GpgME-1.7.0 by the 
latest version of KDE PIM.

Remove bogus qgpgme include.
Make kdepimlibs optional (based on b5de50ccaa1571c4feb0c17ea8016554e3b822d7 
from master)


Diffs
-

  CMakeLists.txt 22515185dcb2bdb6a9027101270ff97d445008b6 
  kmymoney/dialogs/settings/ksettingsschedules.cpp 
da138a7ab138d2f5ef1e8f5b7ad636f9a1964343 
  kmymoney/kmymoney.cpp a4251f031cee280983aa67c55447d3f97865dcbd 
  libkdchart/kdablibfakes/src/KDABLibFakes.h 
f47ec24423a2ca61b04a98069351539e738fe572 
  libkgpgfile/CMakeLists.txt a41a6a408e3da8769308dae75d4f514aa969dc87 
  libkgpgfile/kgpgfile.cpp b1870be92edb833ed30f369e3e0ca0f320fe147b 

Diff: https://git.reviewboard.kde.org/r/129371/diff/


Testing
---

Built successfully (so far only tested with GpgME++ 1.7.1 and without 
kdepimlibs-4).


Thanks,

Andreas Sturmlechner



[kmymoney4] [Bug 372254] Crash when importing CSV file

2016-11-10 Thread allan
https://bugs.kde.org/show_bug.cgi?id=372254

--- Comment #3 from allan  ---
Totally unconnected, but I previously reported that I'd noticed the following -

"QObject::connect: No such signal
FormatsPage::statementReady(MyMoneyStatement&)
QObject::connect:  (sender name:   'FormatsPage')
QObject::connect:  (receiver name: 'csvimport')
KMyMoneyPlugin::KMMStatementInterface::import start
Updating account in MyMoneyStatementReader::startImport failed
Importing statement for ''
Importing statement for '' done
QObject::connect: No such signal
FormatsPage::statementReady(MyMoneyStatement&)
QObject::connect:  (sender name:   'FormatsPage')
QObject::connect:  (receiver name: 'csvimport')
KMyMoneyPlugin::KMMStatementInterface::import start"

A single line needed to be edited, which I've done in the code for this bug.
Do I need to raise a separate bug or add it to this one?

I can add the two fixes as an attachment here.

-- 
You are receiving this mail because:
You are the assignee for the bug.