[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2019-01-24 Thread Vadim Vygonets
Hui Wang,

After applying the patch to 4.20.4 (and even after removing hda-verb on
module load and wake-up from sleep / hibernation), there's no noise,
neither after boot nor after S3 sleep or hibernation.  Yes!!!

The quiet sound still remains.  After testing it again (mplayer,
http://www.vygo.net/hda/11-Ultimatum.ogg 4:00-4:30) I'm pretty sure the
EQ is different.  The bass is about 10dB lower; the middles also lower
but not by as much.

Thanks for your hard work,
Vadim.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed
Status in linux source package in Bionic:
  Fix Committed
Status in linux source package in Cosmic:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2018-12-08 Thread Vadim Vygonets
Awesome fix, Hui Wang, thank you!

I'm on Lenovo ThinkPad X1 Carbon 6th, model 20KH006JGE.  After upgrading
to Linux 4.19.7, the audio mute and microphone mute LEDs (on F1 and F4
keys) stopped working.  They do work if I remove the line:

{0x12, 0x90a60130},

Just removing it doesn't sound like the greatest idea, but I couldn't
find the ALC285 datasheet online.  If you could direct me to information
about ALC285 registers so that I can fix the issue, or provide me with
another value for the register so that I can test it, it will be greatly
appreciated.

Many thanks,
Vadim.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2018-12-08 Thread Vadim Vygonets
Hi Hui Wang,

I added the lines and now everything works perfectly.  Thank you!

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2018-12-14 Thread Vadim Vygonets
Hi Hui Wang,

While waiting for your patch to reach the mainline, I just insert these
two lines myself.

However, I still have issues with the sound.

Scenario: laptop is off, headphones are inserted, sound (both mic and
output) is muted; I turn it on, log in etc., unmute the output and play
something.

The sound is often too quiet (maybe 10 to 15 dB weaker than expected).
If I unplug the headphones and plug them back in, the sound level rises
to expected levels, but I start hearing noise reminiscent of cheap
soundcards (with grounding problems?), where the noise characteristics
change with the activity of other devices (e.g., mouse movements).  The
noise is stronger if I touch the touchpad.  If I mute the sound, the
noise disappears.

This does not happen if I remove the "0x12" line, whether or not I add
the .chained/.chain_id lines.  Interestingly, init_pin_configs in sysfs
shows the same value for 0x12:

$ cat /sys/class/sound/hwC0D0/init_pin_configs 
0x12 0x90a60130
0x13 0x4000
0x14 0x90170110
0x16 0x41f0
0x17 0x41f0
0x18 0x41f0
0x19 0x04a11040
0x1a 0x41f0
0x1b 0x41f0
0x1d 0x4061
0x1e 0x41f0
0x21 0x04211020

(driver_pin_configs and user_pin_configs are empty.)

Thank you,
Vadim.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2018-12-14 Thread Vadim Vygonets
Awesome, thank you.  Let me know if you want me to run particular tests
or provide information.  I'm not sure if the issue manifests every time.

On kernels before 4.19.7 I was hearing noise sometimes, especially after
waking up from S3 sleep, but S4 hibernation or reboot (possibly turning
the machine off was required) was solving it every time.  I did not have
the issue with quiet sound output.

Have a nice weekend,
Vadim.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2018-12-24 Thread Vadim Vygonets
Hui Wang,

Apologies for the slow reply.

Do you mean that you also have quiet sound after the boot?

Today I upgraded to 4.19.12, and the results seem the same.  I'm running
Funtoo Linux with "gentoo-sources" kernel, HDA and the Realtek codec as
modules and plain ALSA with no daemons.  I tried to compile them into
the main kernel image, but the results were the same, except that the
LEDs didn't work.

Here are sone more details:

The noise level I hear does not change with the playback volume.  It's
stronger when I play something (e.g., with mplayer) or touch the
touchpad.

Without the 0x12 line, alsamixer shows heasphone and speaker controls at
100%, and "alsactl store" has {Headphone,Speaker} Playback
{Volume,Switch}.  Under the standard kernel (with your patch), the
aforementioned controls in alsamixer show up as "00" in a box, and
alsactl has only "Line Out Playback Volume" (and the two Switches).  Is
it possible that "line out" is treated differently from "headphone" by
the hardware, or is it just a name?

With the standard kernel, the output of "alsactl store" is identical
whether the sound is in the "too quiet" state or in the "noisy
headphone" state.

Sometimes after I warm-reboot from a standard kernel to a kernel without
the 0x12 line, I hear clicks when muting and unmuting the output, or
noise, but they disappear after I play something.

I put my kernel config and alsactl store output under
http://www.vygo.net/hda/ but I don't know if it aids debugging in any
way.  Do you think it may help if I try your kernel config?

Thank you for your efforts and, if appropriate, merry Christmas.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2018-12-25 Thread Vadim Vygonets
The script uploaded the info under random names, but they're the same
anyway.

Quiet:
http://www.alsa-project.org/db/?f=7712362b1f31c1c142d4016983e648b99d8e5036

Not quiet:
http://www.alsa-project.org/db/?f=579cbfe2a915281a46e449a07b4f359917191943

I also generated one without the 0x12 line:
http://www.alsa-project.org/db/?f=d439ec39632f226a7c156df5373df31de28f4a53

Thank you!

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2018-12-25 Thread Vadim Vygonets
Plugging the headphones during Grub doesn't seem to matter.

thanks!

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2019-01-04 Thread Vadim Vygonets
Hui Wang,

Yes, this solves the noise issue.  Both the modprobe method from Lenovo
forum and the command you provided work perfectly.  Thank you, and thank
you James!

I still have quiet sound initially.  And, now that I compared it to the
kernel without the 0x12 line, it seems that the sound is quieter also
after replugging the headphones (which must be dome while sound is
playing).  It's about 20dB lower before replugging and about 10dB lower
after, and perhaps less bassy, though I may be imagining things here.
I'm testing it with http://www.vygo.net/hda/11-Ultimatum.ogg which has
strong bass indeed.  But I understand that you can reproduce it, so I
trust in you :)

Many thanks for solving the noise issue, and happy new year!
Vadim.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2019-01-04 Thread Vadim Vygonets
The two methods appear to do the same, except hda-verb applies the
change when run and the other method at the time the hda kernel module
is loaded.  You can run hda-verb at boot instead, but the other method
looks cleaner to me, as it applies the fix when the hardware is
configured by the driver.  I believe this fix can also be added to the
driver itself.

As I described above[0], after Hui Wang fixed this bug here that we're
commenting on[1], I started to hear noise in headphones.  This is not
occasional crackling sound, this is constant annoying noise.  Not every
gen6 Carbon has this issue, apparently.  This fixes the issue.

[0]
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/comments/8

[1] https://lkml.org/lkml/2018/12/4/520

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2019-01-07 Thread Vadim Vygonets
Thank you!

Meanwhile I use modprobe to configure the "verb", but also run hda-verb
on wakeup from sleep or hibernation.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2019-01-13 Thread Vadim Vygonets
Hui Wang,

BTW, in case the sound card distinguishes between headphone out and line
out modes, thus may be relevant: my headphones have impedance of 70Ω.

Vadim.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2019-01-20 Thread Vadim Vygonets
Hui Wang,

Do you have a patch to set the values?  I don't run Ubuntu.  Is there a
publicly accessible branch with -proposed patches?

Thank you!

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed
Status in linux source package in Bionic:
  Fix Committed
Status in linux source package in Cosmic:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2019-01-22 Thread Vadim Vygonets
Hui Wang,

Without the 0x12 line (but with the rest of your patch) there is no
noise.

Likewise, with your patch (standard kernel), running hda-verb or loading
the module with the equivalent options also stops the noise.

Additionally, with your full patch the sound is 10dB lower (or 20dB
lower before replugging the headphones) than without the 0x12 line.

Thanks,
Vadim.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed
Status in linux source package in Bionic:
  Fix Committed
Status in linux source package in Cosmic:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2019-01-22 Thread Vadim Vygonets
Hui Wang,

Apologies for the slow reply.

Do you mean that you also have quiet sound after the boot?

Today I upgraded to 4.19.12, and the results seem the same.  I'm running
Funtoo Linux with "gentoo-sources" kernel, HDA and the Realtek codec as
modules and plain ALSA with no daemons.  I tried to compile them into
the main kernel image, but the results were the same, except that the
LEDs didn't work.

Here are sone more details:

The noise level I hear does not change with the playback volume.  It's
stronger when I play something (e.g., with mplayer) or touch the
touchpad.

Without the 0x12 line, alsamixer shows heasphone and speaker controls at
100%, and "alsactl store" has {Headphone,Speaker} Playback
{Volume,Switch}.  Under the standard kernel (with your patch), the
aforementioned controls in alsamixer show up as "00" in a box, and
alsactl has only "Line Out Playback Volume" (and the two Switches).

With the standard kernel, the output of "alsactl store" is identical
whether the sound is in the "too quiet" state or in the "noisy
headphone" state.

Sometimes after I warm-reboot from a standard kernel to a kernel without
the 0x12 line, I hear clicks when muting and unmuting the output, or
noise, but they disappear after I play something (e.g., with mplayer).

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed
Status in linux source package in Bionic:
  Fix Committed
Status in linux source package in Cosmic:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1805079] Re: click/pop noise in the headphone on several lenovo laptops

2019-01-22 Thread Vadim Vygonets
(sorry about comment #34, please disregard)

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1805079

Title:
  click/pop noise in the headphone on several lenovo laptops

Status in linux package in Ubuntu:
  Fix Committed
Status in linux source package in Bionic:
  Fix Committed
Status in linux source package in Cosmic:
  Fix Committed

Bug description:
  [Impact]
  Lenovo told us that some linux uers reported headphone noise on Lenovo's
  website. After investigating, we found those Lenovo laptop mdoels all
  have the codec of alc285, and we can reproduce the noise problem too.

  [Fix]
  Don't use the DAC of headphone, let headphone share the DAC with speaker,
  the noise disappears.

  [Test Case]
  After applying this patch, we tested on Lenovo P52, P72, X1 carbon and X1
  Yoda2, no noise anymore

  [Regression Potential]
  Low. This patch only apply to several lenovo machines, and after applying
  this patch, both speaker and headphone still work very well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp