[Kernel-packages] [Bug 1925452] Re: [Ubuntu 21.04]: net/mlx5: Fix HW spec violation configuring uplink (mandatory for 20.04)
Hi Frank, I think the patch did not apply cleanly on 5.10 an earlier, so we need the backport here for groovy and focal. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1925452 Title: [Ubuntu 21.04]: net/mlx5: Fix HW spec violation configuring uplink (mandatory for 20.04) Status in Ubuntu on IBM z Systems: Triaged Status in linux package in Ubuntu: In Progress Status in linux source package in Focal: New Status in linux source package in Groovy: New Status in linux source package in Hirsute: In Progress Bug description: With the 5.4.0-48 update for Ubuntu 20.04, the commit "net/mlx5e: Modify uplink state on interface up/down" was integrated which contains a regression for mlx5 adapters with older adapter firmware. This is the second bugfix to repair the regression, required to operate the adapter in switchdev mode. The first part was integrated via Bug 192185 - LP1921104. This is the upstream fix required to be backported to Ubuntu 20.04: https://github.com/torvalds/linux/commit/1a73704c82ed4ee95532ac04645d02075bd1ce3d ---Additional Hardware Info--- Mellanox ConnectX network adapter ---uname output--- 5.4.0-73-generic ---Steps to Reproduce--- enable switchdev mode try to ping external host Backports need to be provide for 21.04, 20.10 and 20.04 (if not cleanly applyable)! To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1925452/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1925452] Re: [Ubuntu 21.04]: net/mlx5: Fix HW spec violation configuring uplink (mandatory for 20.04)
Eli Cohen from Mellanox/Nvidia had a look at the back ports and approved them: Both patches look good to me. You can add Reviewed-by: Eli Cohen -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1925452 Title: [Ubuntu 21.04]: net/mlx5: Fix HW spec violation configuring uplink (mandatory for 20.04) Status in Ubuntu on IBM z Systems: Triaged Status in linux package in Ubuntu: In Progress Status in linux source package in Focal: New Status in linux source package in Groovy: New Status in linux source package in Hirsute: In Progress Bug description: With the 5.4.0-48 update for Ubuntu 20.04, the commit "net/mlx5e: Modify uplink state on interface up/down" was integrated which contains a regression for mlx5 adapters with older adapter firmware. This is the second bugfix to repair the regression, required to operate the adapter in switchdev mode. The first part was integrated via Bug 192185 - LP1921104. This is the upstream fix required to be backported to Ubuntu 20.04: https://github.com/torvalds/linux/commit/1a73704c82ed4ee95532ac04645d02075bd1ce3d ---Additional Hardware Info--- Mellanox ConnectX network adapter ---uname output--- 5.4.0-73-generic ---Steps to Reproduce--- enable switchdev mode try to ping external host Backports need to be provide for 21.04, 20.10 and 20.04 (if not cleanly applyable)! To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1925452/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1921104] Re: net/mlx5e: Add missing capability check for uplink follow for Ubuntu 20.04
Attaching backport for groovy. repro on groovy vanilla kernel == root@pok1-qz1-sr1-rk011-s01:~# uname -a Linux pok1-qz1-sr1-rk011-s01 5.8.0-48-generic #54 SMP Thu Mar 25 06:59:15 EDT 2021 s390x s390x s390x GNU/Linux root@pok1-qz1-sr1-rk011-s01:~# ifconfig p0 172.31.22.3/31 mtu 9100 up root@pok1-qz1-sr1-rk011-s01:~# ping 172.31.22.2 PING 172.31.22.2 (172.31.22.2) 56(84) bytes of data. ^C --- 172.31.22.2 ping statistics --- 14 packets transmitted, 0 received, 100% packet loss, time 13489ms verify fix on groovy kernel with backport = root@pok1-qz1-sr1-rk011-s01:~# uname -a Linux pok1-qz1-sr1-rk011-s01 5.8.0-48-generic #54 SMP Thu Mar 25 11:16:31 EDT 2021 s390x s390x s390x GNU/Linux root@pok1-qz1-sr1-rk011-s01:~# ifconfig p0 172.31.22.3/31 mtu 9100 up root@pok1-qz1-sr1-rk011-s01:~# ping 172.31.22.2 PING 172.31.22.2 (172.31.22.2) 56(84) bytes of data. 64 bytes from 172.31.22.2: icmp_seq=2 ttl=0 time=738 ms 64 bytes from 172.31.22.2: icmp_seq=3 ttl=0 time=0.085 ms 64 bytes from 172.31.22.2: icmp_seq=4 ttl=0 time=0.073 ms 64 bytes from 172.31.22.2: icmp_seq=5 ttl=0 time=0.136 ms 64 bytes from 172.31.22.2: icmp_seq=6 ttl=0 time=0.093 ms ** Patch added: "Backport for groovy" https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1921104/+attachment/5480947/+files/0001-Backport-groovy-net-mlx5e-Add-missing-capability-che.patch -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1921104 Title: net/mlx5e: Add missing capability check for uplink follow for Ubuntu 20.04 Status in Ubuntu on IBM z Systems: Triaged Status in linux package in Ubuntu: Fix Released Status in linux source package in Focal: Triaged Status in linux source package in Groovy: New Status in linux source package in Hirsute: Fix Released Bug description: Expose firmware indication that it supports setting eswitch uplink state to follow (follow the physical link). Condition setting the eswitch uplink admin-state with this capability bit. Older FW may not support the uplink state setting. Available fix with kernel 5.11. https://github.com/torvalds/linux/commit/9c9be85f6b59d80efe4705109c0396df18d4e11d Now required for Ubuntu 20.04 via backport patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1921104/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1921104] Re: net/mlx5e: Add missing capability check for uplink follow for Ubuntu 20.04
Additional comment for the SRU description: this backport fixes a regression which was introduced with the kernel 5.4.0-48 update for Ubuntu 20.04. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1921104 Title: net/mlx5e: Add missing capability check for uplink follow for Ubuntu 20.04 Status in Ubuntu on IBM z Systems: Triaged Status in linux package in Ubuntu: Fix Released Status in linux source package in Focal: Triaged Status in linux source package in Groovy: Triaged Status in linux source package in Hirsute: Fix Released Bug description: Expose firmware indication that it supports setting eswitch uplink state to follow (follow the physical link). Condition setting the eswitch uplink admin-state with this capability bit. Older FW may not support the uplink state setting. Available fix with kernel 5.11. https://github.com/torvalds/linux/commit/9c9be85f6b59d80efe4705109c0396df18d4e11d Now required for Ubuntu 20.04 via backport patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1921104/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1921104] Re: net/mlx5e: Add missing capability check for uplink follow for Ubuntu 20.04
Hi Frank, thank you very much! -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1921104 Title: net/mlx5e: Add missing capability check for uplink follow for Ubuntu 20.04 Status in Ubuntu on IBM z Systems: Triaged Status in linux package in Ubuntu: Fix Released Status in linux source package in Focal: Triaged Status in linux source package in Groovy: Triaged Status in linux source package in Hirsute: Fix Released Bug description: SRU Justification: == [Impact] * Since older firmware may not support the uplink state setting, this can lead to problems. * Now expose firmware indication that it supports setting eswitch uplink state to follow the physical link. * If a kernel without the backport is used on an adapter which does not have the latest adapter firmware, the adapter silently drops outgoing traffic. * This is a regression which was introduced with kernel 5.4.0-48. [Fix] * upstream fix (as in 5.11): 9c9be85f6b59d80efe4705109c0396df18d4e11d 9c9be85f6b59 "net/mlx5e: Add missing capability check for uplink follow" * backport for focal: https://launchpadlibrarian.net/529543695/0001 -Backport-net-mlx5e-Add-missing-capability-check-for-.patch * backport for groovy: https://launchpadlibrarian.net/529775887/0001 -Backport-groovy-net-mlx5e-Add-missing-capability-che.patch [Test Case] * Two IBM Z or LinuxONE systems, installed with Ubuntu Server 20.04 or 20.10 on LPAR, are needed. * Each with RoCE Express 2.x adapters (Mellanox ConnectX4/5) attached and firmware 16.29.1006 or earlier. * Assign an IP address to the adapters on both systems and try to ping one node from the other. * The ping will just fail with the stock Ubuntu kernels (not having the patch), but will succeed with kernels that incl. the patches (like the test builds from the PPA mentioned below). * Due to the lack of hardware this needs to be verified by IBM. [Regression Potential] * Undesired / erroneous behavior in case the modified if condition is assembled in a wrong way. * Again wrong behavior in case the modification of the capability bits in mlx5_ifc_cmd_hca_cap_bits are wrong. * All modification are limited to the mlx5 driver only. * The changes are relatively limited with effectively two lines removed and 4 added (three of them adjustments of the capability bits only). * The modifications were done and tested by IBM and reviewed by Mellanox (see LP comments), based on a PPA test build. [Other] * The above patch/commit was upstream accepted with kernel 5.11. * Hence the patch is not needed for hirsute, just needs to be SRUed for groovy and focal. * The commit couldn't be cleanly cherry-picked, mainly due to changed context, hence the backport(s). __ Expose firmware indication that it supports setting eswitch uplink state to follow (follow the physical link). Condition setting the eswitch uplink admin-state with this capability bit. Older FW may not support the uplink state setting. Available fix with kernel 5.11. https://github.com/torvalds/linux/commit/9c9be85f6b59d80efe4705109c0396df18d4e11d Now required for Ubuntu 20.04 via backport patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1921104/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
