kio-extras
kio-extras is currently released part of Plasma 5. It's need said that it would be better to be part of applications because they're plugins used by applications and typically not by the desktop. With Plasma 5.2 about to go out shall I ask for kio-extras to be moved and if so into which module? Jonathan
Re: plasma-mediacenter in kdereview from extragear
I took at look at this today and discussed at the Plasma sprint.. - possible legal issues with youtube icon, now fixed - mockcpp pointer to obscure repository cmake message - qtmultimedia needs a "this is needed at runtime" cmake message - music and video icon are black on black - crashes, at times, probably a baloo issue, will discuss with vishesh - doesn't show any music or videos for me, probably a baloo issue - needs git plasma-workspace for login to work, cmake should tell me this - it uses qml bindings from qtmultimedia (from qt5) which uses gstreamer 0.10. gstreamer 0.10 is old and distros are dropping support for it, in Ubuntu we dropped the libav plugin so it can't play many file formats. maybe one day phonon will have qml bindings. it also leads to issues where some other part of Plasma uses phonon which uses gstreamer 1.0 so it loads libraries with clashing symbols. this is all known and is mostly sad. - there's no user docs, I don't know if this is still a requirement for inclusion, I don't think they get used much so I don't think it should be licencing looks all good I look forward to including this in Plasma 5.3 Jonathan On Thu, Feb 19, 2015 at 08:22:58PM +0530, Bhushan Shah wrote: > Hello, > > We want to move plasma-mediacenter to kde/workspace for releasing it > with Plasma 5.x release cycle, Plasma media center is living room > solution of plasma workspaces, it is integrated as shell package for > PMC. > > Current code depends upon KDE Frameworks 5 (free of kdelibs4support), > kfilemetadata, baloo, taglib and mockcpp (for tests, optional > dependancy), you can build it from master branch or you can try it out > from binary packages provided by different distributions like > kubuntu-ci, KDE:Unstable:Extra repo from opensuse, or > plasma-mediacenter-git package from AUR for archlinux. > > Looking forward to review from community > > Thanks! > > -- > Bhushan Shah > > http://bhush9.github.io > IRC Nick : bshah on Freenode > ___ > Plasma-devel mailing list > plasma-de...@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [kde-frameworks-devel] Review request: QBluez
On Mon, Feb 16, 2015 at 10:40:44AM +0100, David Rosca wrote: > Hi all, > I'd like to ask for a review of the QBluez library [1]. Looks like you've been working hard :) The name KF5BluezQt seems inelegant, is has both a prefix and a suffix, how about just KF5Bluez ? The headers get installed into /usr/include/BluezQt/, I guess that should be /usr/include/KF5/BluezQt/ ? It requires extra-cmake-modules 1.8 but seems to compile fine with 1.7. Do you expect this to be moved into KDE Frameworks? That gets tagged on April 4th. Or do you expect it to be moved into kde/workspace for release with Plasma? That gets tagged in April 9th. If it goes into Frameworks it must remain API and ABI compatible while in Plasma you only need to bump the soversion if it changes. Is it ready for that? Jonathan
Re: Review request: QBluez
Please file a sysadmin request to move it into kdereview, then after a couple of weeks if there's no objections it can be moved into kde/workspace (for plasma). Jonathan
Re: Review request: QBluez
On Thu, Mar 12, 2015 at 08:23:22PM +0100, David Rosca wrote: > Done. It's in kdereview now: > https://projects.kde.org/projects/kdereview/bluez-qt Woo, lovely. Best post to plasma-devel about that (it's been posted around lots already but best to cover all the bases I guess.) Do you expect the bluez-qt branch of bluedevil to be ready to merge before Plasma 5.3 freeze on Thu 9 April? Jonathan
Re: Moving User Manager back to playground
On Thu, Apr 09, 2015 at 10:31:41PM +0200, Vishesh Handa wrote: >On Thu, Apr 9, 2015 at 10:02 PM, Jonathan Riddell > wrote: > > Ug please don't.A It'll mess up my release scripts and the > translations.A Stuff in playground shouldn't get releases but this > does get beta releases as part of Plasma so Plasma is the obvious > place to have it.A I see no problem that gets solved by moving it. > >To make it very clear it isn't part of Plasma. >It even has a release blocking bug[1] (which was brought up during the >review) and therefore cannot be released. >[1]A https://bugs.kde.org/show_bug.cgi?id=342631 It is part of Plasma, that's why it was moved there and why it is released as part of Plasma. It's only released with betas for now in the same way as touchpad-kcm was and plasma mediacenter is. Jonathan
Re: Release Dates for August
I've put up my proposal for releases in August https://www.google.com/calendar/embed?src=031gkgqg1hjf8lcmj0em1d2sj8%40group.calendar.google.com https://techbase.kde.org/Schedules/Frameworks same format as currently, tagging on first Saturday, release on following Thursday, makes 5.13 on Thu August 6th. https://techbase.kde.org/Schedules/Plasma_5 delayed a month to not clash with Akademy and allow Baloo to move to new format incompatible with kdelibs4 format beta tagged on Thursday 6th (same day as kf5.13 release) final tagged two weeks later on thursday 20th https://techbase.kde.org/Schedules/Applications/15.08_Release_Schedule Simplified release cycle, beta 3 weeks before release, rc 2 weeks before, tagging 1 week before, all on Wednesdays. release on August 19th Any comments welcome (preferably on release-team@) Jonathan On 30 March 2015 at 17:32, Jonathan Riddell wrote: > Plasma 5.4 release schedule needs writing and keeping to our 3 months > would release in July. That puts the release during Akademy so it > needs shifting. > > Baloo wants to move from Plasma to Frameworks. At the same time it > will get a shiny new database which makes it incompatible with baloo > for kdelibs4 so Dolphin will stop working until the Qt 5 version of > Dolphin comes out. > > So here's a proposal to move Plasma to August when Applications is > presumably due to release. Aligning the schedules will allow the > move/incompatible nature of the Baloo changes to be all done together. > > See dates with question mark on August on this calendar. > > https://www.google.com/calendar/embed?src=031gkgqg1hjf8lcmj0em1d2sj8%40group.calendar.google.com&ctz=Europe/Madrid > > Comments? > > Jonathan
Plasma Applet for Audio Volume for kdereview
plasma-pa is a new volume manager and is intended to be a replacement for KMix in Plasma. We plan to ship it as a beta in Plasma 5.4 and it's currently in kdereview for your reviewing attention. https://projects.kde.org/projects/kdereview/plasma-pa Please check over it and consider if it passes review. Jonathan
kwallet-pam for kdereview
kwallet-pam is a simple PAM module to open your wallet. We'd like to ship it in Plasma 5.4. It was previously in a scratch repository but shipped by distros such as Kubuntu and Fedora. It's about to go into kdereview and we'd appreciate your considered perusal. https://projects.kde.org/projects/playground/base/kwallet-pam Jonathan
Re: Plasma Applet for Audio Volume for kdereview
On Wed, Aug 05, 2015 at 02:51:25PM +0200, Ganton wrote: > Hi, Jonathan: > > > plasma-pa is a new volume manager and is intended to be a replacement for > > KMix in Plasma. > > > > We plan to ship it as a beta in Plasma 5.4 and it's currently in kdereview > > for your reviewing attention. > > > > https://projects.kde.org/projects/kdereview/plasma-pa > > > > Please check over it and consider if it passes review. > > From that page, there's a link to > https://projects.kde.org/projects/kdereview/plasma-pa/repository > but there it's seen: > > Internal error Get it out of git git clone kde:plasma-pa Jonathan
Re: Plasma Applet for Audio Volume for kdereview
This has now been moved to kde/workspace and will be released with Plasma 5.4 On Wed, Aug 05, 2015 at 12:45:01PM +, Jonathan Riddell wrote: > plasma-pa is a new volume manager and is intended to be a replacement for > KMix in Plasma. > > We plan to ship it as a beta in Plasma 5.4 and it's currently in kdereview > for your reviewing attention. > > https://projects.kde.org/projects/kdereview/plasma-pa > > Please check over it and consider if it passes review. > > Jonathan
kwallet-pam for kdereview
This has now moved to kde/workspace and will be released with plasma 5.4 Jonathan
Re: kdesudo in git
On Thu, Aug 20, 2015 at 01:34:42PM +0200, Luigi Toscano wrote: > On Thursday 20 of August 2015 12:16:55 Jonathan Riddell wrote: > > I've just moved kdesudo into playground > > > > playground/utils/kdesudo > > > > it has a bunch of translations from its previous home on Launchpad. > > > > Could these be imported into KDE please? > > Do we really need it? I thought that kdesu can work with sudo if you > configure > it (runtime configuration, even if you can change the default with a compile > flag). Alas because of the separation that kdesu has between a backend and a frontend it can't work with sudo's password save mechanism and it asks for a password every time which gets very annoying. Arguably we don't need it since sudo isn't used much now for GUIs most things use policykit but that would need some consultation to work out. Jonathan
Re: kdesudo in git
On Thu, Aug 20, 2015 at 02:01:58PM +0200, Luigi Toscano wrote: > Maybe it's possible to change kdesu to expose a "please cache this" property > between backend and frontend (in a secure way). Better than keeping two > programs for exactly the same thing. I couldn't work out a secure and easy way to do that when I looked at it years ago, kdesudo works so we went with that. Jonathan
plasma-sdk in kdereview
Plasma SDK contains a few handy developers tools for Plasma plasmathemeexplorer, plasmoidviewer, plasmaengineexplorer and the icon browser cuttlefish It gets released with Plasma but is still in extragear. I'd like to move it to kde/workspace in git and I've just asked for it to be moved into kdereview to start that. Please have a review of it and see if it's good enough. Jonathan
Re: New repo for review: Breeze GTK
On 23 October 2015 at 14:07, David Edmundson wrote: > Repo contains GTK 2 and GTK 3 themes which are similar to Breeze. awooga :) > i18n - I've not set branches in p.k.o as there are no translations. GTK > theme names seem to be used as-is. seems sensible > licenses - we don't have a license at the top of every file. Is it needed > in this case? No just in the top directory is fine. What shall we do with gtkbreeze, the kconf update binary to set the theme? Should it be changed to set the theme to breeze? I suppose it should also be changed to set the font too. Jonathan
kde-build-metadata for beta branches
I've branched Plasma for the 5.5 beta and will make a final release in a couple of weeks. Before I make the final release I want to check in build.kde.org if it has any complaints in builds of the Plasma/5.5 branch. But build.kde.org currently uses kde-build-metadata points only to master and to current stable which is Plasma/5.4. Can I change kde-build-metadata to Plasma/5.5 while the branch is in stable or will that mess up other uses of kde-build-metadata? Jonathan
Re: kde-build-metadata for beta branches
On Sat, Nov 21, 2015 at 04:28:06PM +0530, Bhushan Shah wrote: > On Sat, Nov 21, 2015 at 4:24 PM, Jonathan Riddell wrote: > > Can I change kde-build-metadata to Plasma/5.5 while the branch is in > > stable or will that mess up other uses of kde-build-metadata? > > AFAIK, yes you can change kde-build-metadata. Given its branched and > Plasma/5.5 is new stable. but it's not stable, it's beta quality, my worry is that there is some use of this meta data for which people expect it to be released and not beta. Jonathan
Re: Product versions on bugs.kde.org
On Mon, Mar 07, 2016 at 09:25:40AM +0100, Kevin Funk wrote: > Is there a way to batch-modify those versions? Obviously noone wants to go > through the Bugzilla UI, adding versions one-by-one for each(!) framework. > /me found [1]. > > PS: It's not just the case for frameworks, same applies to KDE Applications, > etc. > > Cheers, > Kevin > > [1] > http://blog.asymptotic.co.uk/software-development-log/batch-modifying-bugzilla-milestones/ > > -- > Kevin Funk | kf...@kde.org | http://kfunk.org There's no API for this, I've no idea why not. For Plasma I wrote a shell script which takes your browser cookie and takes a load of Product names and uses curl to do the calls to add the versions. https://projects.kde.org/projects/playground/sdk/releaseme/repository/revisions/master/entry/plasma/plasma-add-bugzilla-versions kde:releaseme Jonathan
Re: announcement: plymouth-kcm in kdereview
On Thu, Dec 29, 2016 at 12:58:10PM +0100, Marco Martin wrote:
> Hi all,
> announcing a new KCM module to change the plymouth splash screen
> The repository is named plymouth-kcm and is headed for kdereview now.
> its final resting place would be the workspace area, to be released in sync
> with the rest of Plasma
Version number is hard coded
QStringLiteral("0.1")
It should rather follow Plasma practice and set these in the top cmake file
set(PROJECT_VERSION "5.8.90")
set(PROJECT_VERSION_MAJOR 5)
and use PROJECT_VERSION
same for const char version[] = "1.0"; src/kplymouththemeinstaller.cpp
The kcm is LGPL while the helper executables are GPL, probably simpler just to
make it all GPL.
The copyright headers should follow current best practice text listed at
https://community.kde.org/Policies/Licensing_Policy#GPL_Header
There's no docs, I don't know if anyone cares about these for kcms any
more, probably not. Seems a general System Settings issue, the Help
button is shown but does nothing when I click it even for
e.g. kcmshell5 colors. This works again when I install khelpcenter but
it should have sensible fallback like apps do. Except the apps launch
a web page which doesn't exist. Is it time to just give up on docs
and accept they're not actually that important?
I get quite a few warnings/errors when running kcmshell5 plymouth:
org.kde.kcoreaddons: Error loading plugin "kcm_plymouth" "The shared library
was not found."
Plugin search paths are ("/usr/lib/x86_64-linux-gnu/qt5/plugins", "/usr/bin")
The environment variable QT_PLUGIN_PATH might be not correctly set
kf5.kcoreaddons.desktopparser: Could not locate service type file
kservicetypes5/kpackage-genericqml.desktop, tried ("/home/jr/.local/share",
"/usr/share/usr/share/xsessions/plasma", "/usr/local/share", "/usr/share",
"/var/lib/snapd/desktop")
file:///usr/lib/x86_64-linux-gnu/qt5/qml/QtQuick/Controls/Button.qml:100:
TypeError: Cannot read property of null
When I run kcmshell5 plymouth and use the corners to resize the window larger
and smaller after a short while it freezes and gives output of
file:///usr/share/kpackage/kcms/kcm_plymouth/contents/ui/main.qml:48:13: QML
GridView: Binding loop detected for property "cellWidth"
The top text says "Plymouth splash screen". It should be in title case.
There's no preview pic for my pre-installed splash screens. Probably none is
available but there must be some way to make one available for breeze themes at
least?
When I click Defaults nothing much happens, what is this button supposed to do?
When I click Reset it resets back to the current setting. When I then go on to
select another theme the Reset button does not become enabled again and output
says
file:///usr/share/kpackage/kcms/kcm_plymouth/contents/ui/main.qml:136:
ReferenceError: resetCheckbox is not defined
No Product in bugzilla
https://bugs.kde.org/describecomponents.cgi
when one is added you'll need to add it to releaseme
plasma/plasma-add-bugzilla-versions
No Product in Phabricator
The terminology changes between 'System Splash', 'Plymouth Splash Screen',
'global splash screen' and '[Get New] Splash Screens'. Better to pick one I
think, I like 'Boot Splash'.
AboutData has "Configure Plymouth splash screen", as well as mixing
title case and sentence case this makes the text in the Help menu a
bit weird to read. This is systems settings, everything is
configuration, no need to use that word.
Cool, Pokemon Plymouth splash!
Re: announcement: plymouth-kcm in kdereview
On 5 January 2017 at 15:03, Marco Martin wrote: > On Thursday 05 January 2017 12:30:38 Jonathan Riddell wrote: >> It should rather follow Plasma practice and set these in the top cmake file >> set(PROJECT_VERSION "5.8.90") >> set(PROJECT_VERSION_MAJOR 5) >> >> and use PROJECT_VERSION > > would this number be automagically updated one this gets into workspace? Yes it's handled by the Plasma release scripts Jonathan
imagewriter in kdereview
Please review imagewriter which I've just had moved to kdereview. It's a simple tool to write ISO images to a USB key. It should be cross platform and work on Linux, mac, windows. It's based on ROSA Image Writer and the ROSA maintainer has agreed to maintain it in KDE. Compared to ROSA I've switched to i18n and used kauth and made the ROSA branding optional. Scarlett has started making an AppImage for it although I don't know if it'll work with KAuth https://github.com/appimage-packages/imagewriter/issues/1 Jonathan
Re: imagewriter in kdereview
On 7 April 2017 at 20:14, Luigi Toscano wrote: > Does it mean that the make-it-cool branch will be merged to master soon? > The current master has no support for KI18n (and not even for > ecm_install_po_files_as_qm). I think that it's better to wait until it's > merged before enabling the translations. Oh yes sorry I should have done that before. Merged into master now. Jonathan
Re: imagewriter in kdereview
On 8 April 2017 at 17:22, Albert Astals Cid wrote: > El divendres, 7 d’abril de 2017, a les 15:21:20 CEST, Jonathan Riddell va > escriure: >> Please review imagewriter which I've just had moved to kdereview. > > It doesn't build https://paste.kde.org/p4mj6bgms Spooky. Fixed. > Also i find that imagewriter is a bit "too generic", maybe iso-imagewriter? I've renamed it now to isoimagewriter. But now KAuth doesn't like it, sigh. Jonathan
Re: Moving AtCore to Extragear
LICENSE file is normally named COPYING in KDE repos More importantly the files are GPL 2 only, which isn't allowed in KDE's licence policy. It should be changed to GPL 2 or later (or as approved by e.v.) https://community.kde.org/Policies/Licensing_Policy LICENSE and README.md both say it uses LGPL, which isn't the case, this should be made consistent. http://techbase.kde.org/Policies/Kdelibs_Coding_Style links are out of date in scripts/* Jonathan On 23 May 2017 at 14:17, Lays Rodrigues wrote: > Good morning everyone, > For you that don't know me, I'm Lays Rodrigues, and I work with 3 more > guys(Patrick, Chris, Tomaz) on Atelier. > Atelier is a software for 3DPrinting that we are building inside KDE. So far > we have 10 months of work, and we are ready for the launch of our core, in > this case, is AtCore. > AtCore is the API responsible for all serial communication, and for > validating more of our work, we would like to launch the 0.1 version with > the next KDE Applications release. > I was told that Extragear applications don't need to follow KDE releases, > but we thought that would be better to follow the release schedule on the > first launches, so we can fix, for us, a deadline. > So for this first step, we want to move AtCore from the Playground to > Extragear, and launch it with its test client, where we can make the core > stronger, so when we launch Atelier, we know that everything will be stable. > Our targets are all Gnu/Linux distros, and we already have inside Craft a > port for Windows with packing configured and working. > > Well, so I would like to require this review and moving to Extragear. > This is my first KDE application, so I maybe kind of lost. > > P.s: You can find more info about the status of the project on my blog here. > > Thanks all, > > Ps.:2 I don't know if my first e-mail arrived, because I wasn't subscribed > to this mail list, if this is a duplicate, sorry. > > -- > Lays Rodrigues > Software Developer at KDE > Intern at Rede Globo > Computer Science student at Federal Fluminense University > laysrodriguesdev.wordpress.com > Telegram: @lays147 > IRC: lays147 > Phone: +55 22 981520012
Re: Zanshin is in kdereview
There's some GPL 2 only files in 3rdparty/kdepim, if they are used it means the applications can only be copied as GPL 2, consider contacting the copyright holders to fix this as it doesn't match the rest of the source. (And fix it in kdepim if the same files are there with the same licence.) You have a release script in scripts/release.sh, consider using kde:releaseme as extracting translations can be quite faffy and releaseme does all that for you. There's no documentation. I'm unsure how strong a requirement this is these days. Is Todo a word? I think it should be but the dictionaries I checked haven't caught up with it. Maybe KDE can be at the forefront of English linguistic development here. Use title case on actions (menu items and buttons), "Next page" should be "Next Page" etc Single key shortcut for Move item is unusual, check with usability designer types if that's ok. If I stop Akonadi it silently stops working, an error message might be informative. On my KDE neon User Edition install if I run Kontact it appears fine but on closing Kontact it crashes, this doesn't happen if I don't have Zanshin installed. Looks lovely otherwise Jonathan On 8 June 2017 at 08:36, Kevin Ottens wrote: > Hello, > > OK, this time it's the right one. :-) > > Zanshin is now in kdereview and aiming for extragear/pim. Please review away! > > Thanks in advance. > > Regards. > -- > Kévin Ottens, http://ervin.ipsquad.net > > KDAB - proud supporter of KDE, http://www.kdab.com >
Re: kio-stash is in KDE Review
In the git repo all the files are permission executable, they shouldn't be. There's no documentation. I'm unsure how hard a requirement this is these days. Use title case for name in src/iodaemon/stashnotifier.json When I use Dolphin to copy a file over I get a dialog daying "Could not copy.", some more information here might be useful. The daemon wasn't loaded. Dolphin gains a Stash button which splits the view and opens Stash kioslave. I'd expect that clicking it again would close the view but it doesn't. (Dolphin code) There's no Messages.sh to extract the strings. Consider asking VDG for a new icon for this in Dolphin, currently it uses the folder icon which isn't very informative. Copy of GPL 2 needed in top directory called COPYING. Use the GPL header with the URL in it rather than postal address so it doesn't get out of date if FSF moves https://community.kde.org/Policies/Licensing_Policy#GPL_Header Nudge the KDE neon developers to add a build to Neon Jonathan On 26 May 2017 at 18:25, Arnav Dhamija wrote: > Hi! > > I had made the kio-stash ioslave last year as part of my GSoC 2016 > Project. Now that most of the changes which I wished to make in > Dolphin relevant to the ioslave are part of master, I wish to ship the > ioslave soon. > > The project is now in KDE review and is awaiting feedback. The link > for the same can be found here: > https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672ac907b8 > > The source of the project can be found here: > https://cgit.kde.org/kio-stash.git/ > > Thanks. > > -- > arnav dhamija
Re: Zanshin is in kdereview
On 10 June 2017 at 14:08, Kevin Ottens wrote: >> You have a release script in scripts/release.sh, consider using >> kde:releaseme as extracting translations can be quite faffy and >> releaseme does all that for you. > > I tried that recently but didn't manage to get it to work at all. Failed with > a backtrace leading to some obscure Ruby dependency and got stuck. Any > guidance is welcome there, I'm especially interested because of the > translation extraction bits which I do a bad job at since the beginning... releaseme shouldn't need any external dependencies except Ruby so post us the backtrace and I'll take a look >> On my KDE neon User Edition install if I run Kontact it appears fine >> but on closing Kontact it crashes, this doesn't happen if I don't have >> Zanshin installed. http://paste.ubuntu.com/24841577/ Jonathan
Re: kio-stash is in KDE Review
Better as kio-extras in KDE Applications no? Jonathan On 19 June 2017 at 10:00, Arnav Dhamija wrote: > Thanks. I have fixed this and the kio-stash ioslave passes all the > test cases on CI here: > https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20kf5-qt5%20SUSEQt5.9/ > > The build log for the same can be found here: > https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20kf5-qt5%20SUSEQt5.9/11/timestamps/?time=HH:mm:ss&appendLog&locale=en_US > > I feel the ioslave is now ready to be shipped. The question is if it > can be included as part of KDE Frameworks for the next major release > or if it should be a separate package only in KDE Extra gear. > > On Mon, Jun 19, 2017 at 3:07 AM, Albert Astals Cid wrote: >> El dimecres, 14 de juny de 2017, a les 21:42:58 CEST, Arnav Dhamija va >> escriure: >>> Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and >>> ran the following commands after cloning the repo and creating a build >>> directory: >>> >>> cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_QT_SYS_PATHS=TRUE .. >>> make >> >> git code does not compile as of now. >> >> Cheers, >> Albert >> >>> sudo make install >>> kdeinit5 >>> >>> ..and then I ran the tests using 'ctest -v'. It passed slavetest with >>> no issues (18 out of 18 tests passed). My guess why it doesn't work >>> you is because you haven't run kdeinit5 after installing the ioslave. >>> If not that, the testdaemon process might not have been successfully >>> registered on the system D-Bus when thes test is run. >>> >>> Is there a way I can see if my test cases pass on KDE's CI >>> infrastructure to narrow down the problem? If so, I will a sysadmin to >>> do so. >>> >>> On Tue, Jun 13, 2017 at 4:16 AM, Albert Astals Cid wrote: >>> > El divendres, 9 de juny de 2017, a les 11:45:14 CEST, Arnav Dhamija va >>> > >>> > escriure: >>> >> > Do you mean i have to manually start a process for the tests to >>> >> > succeed? >>> >> >>> >> If installed correctly with kdeinit restarted and the Stash Daemon is >>> >> running in kded5, it is not required. However, I cannot recall what >>> >> steps are needed for this to happen as I think it requires a system >>> >> restart or logout to do so. >>> >> >>> >> Hence, I have created a fallback testdaemon program which creates a >>> >> daemon process for the Stash Daemon to run. This is launched >>> >> automatically by the test suite if the test suite cannot find the >>> >> Stash Daemon running in kded. I just patched it so that it finds the >>> >> path to the testdaemon program correctly (it had the wrong path when >>> >> you tested it). It should pass the test cases now with no manual >>> >> invocation of the testdaemon process. >>> > >>> > Doesn't seem to work for me. >>> > >>> > https://paste.kde.org/ptnn5hhkt >>> > >>> > Cheers, >>> > >>> > Albert >>> >> >>> >> On Fri, Jun 9, 2017 at 1:47 AM, Albert Astals Cid wrote: >>> >> > El dijous, 8 de juny de 2017, a les 16:25:02 CEST, Arnav Dhamija va >>> > >>> > escriure: >>> >> >> Yes, I will file a sysadmin ticket for the same. Until I do so, could >>> >> >> you send me the output of the test suite in a screenshot or as plain >>> >> >> text? >>> >> >> >>> >> >> The ioslave works by storing a list of virtual files and folders in a >>> >> >> process running in the KDED, communicating with it over D-Bus. Hence, >>> >> >> some of the tests won't work unless a) the testdaemon process is >>> >> >> started >>> >> > >>> >> > Do you mean i have to manually start a process for the tests to >>> >> > succeed? >>> >> > >>> >> > If that is the case, that's not acceptable. >>> >> > >>> >> > Cheers, >>> >> > >>> >> > Albert >>> >> >> >>> >> >> or b) the Stash KIO slave watcher is running in KDED. Usually >>> >> >> it requires a restart of KDED and a kdeinit after installing the >>> >> >> ioslave to have the Stash daemon running in KDED. >>> >> >> >>> >> >> On Thu, Jun 8, 2017 at 3:42 AM, Albert Astals Cid >> wrote: >>> >> >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija >>> >> >> > va >>> >> >> > >>> >> >> > escriure: >>> >> >> >> Hi! >>> >> >> >> >>> >> >> >> I had made the kio-stash ioslave last year as part of my GSoC 2016 >>> >> >> >> Project. Now that most of the changes which I wished to make in >>> >> >> >> Dolphin relevant to the ioslave are part of master, I wish to ship >>> >> >> >> the >>> >> >> >> ioslave soon. >>> >> >> >> >>> >> >> >> The project is now in KDE review and is awaiting feedback. The link >>> >> >> >> for the same can be found here: >>> >> >> >> https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672a >>> >> >> >> c90 >>> >> >> >> 7b8 >>> >> >> >> >>> >> >> >> The source of the project can be found here: >>> >> >> >> https://cgit.kde.org/kio-stash.git/ >>> >> >> > >>> >> >> > Can you please get it covered by the CI? >>> >> >> > >>> >> >> > I have some of the tests failing but don't know if it is because my >>> >> >> > setup >>> >> >> > is a bit br
Re: Zanshin is in kdereview
On Mon, Jun 19, 2017 at 09:36:39PM +0200, Kevin Ottens wrote:
> Hello,
>
> On Monday, 12 June 2017 16:48:26 CEST Jonathan Riddell wrote:
> > On 10 June 2017 at 14:08, Kevin Ottens wrote:
> > >> You have a release script in scripts/release.sh, consider using
> > >> kde:releaseme as extracting translations can be quite faffy and
> > >> releaseme does all that for you.
> > >
> > > I tried that recently but didn't manage to get it to work at all. Failed
> > > with a backtrace leading to some obscure Ruby dependency and got stuck.
> > > Any guidance is welcome there, I'm especially interested because of the
> > > translation extraction bits which I do a bad job at since the
> > > beginning...
> > releaseme shouldn't need any external dependencies except Ruby so post
> > us the backtrace and I'll take a look
>
> After pulling again today it now works much better! :-)
>
> Looks like I just didn't clone at the right time.
>
> That said, there's something fishy with the signature:
> https://paste.kde.org/pgh6b1em7
releaseme doesn't do anything special with gpg, it just runs
gpg2 --armor --detach-sign -o #{sigfile} #{file}
So does gpg2 work for you signing a text file?
Jonathan
Re: Moving AtCore to Extragear
On 18 June 2017 at 13:48, Lays Rodrigues wrote: > Hey guys, good morning. =D > Any more comments on AtCore code? > How the moving to Extragear work? As discussed it should already be in kdereview, then it can go into extragear See README.md in kde:sysadmin/repo-metadata for how to move See https://techbase.kde.org/ReleasingExtragearSoftware for how to do releases Jonathan
Re: clazy is in kdereview
On 16 June 2017 at 15:24, Sérgio Martins wrote: > clazy is a clang plugin which allows clang to understand Qt semantics. > You get more than 50 Qt related compiler warnings, ranging from > unneeded memory allocations to misusage of API, including fix-its for > automatic refactoring. Looks very cool. I renamed the copyright file to make it consistent with other KDE repos and updated copyright info in man page as discussed. Jonathan
Re: kdereview - qtcurve
On 16 June 2017 at 16:07, Yichao Yu wrote: > QtCurve is now in kdereview with the intention of being in extragear/base You should set the stable branch to 1.9 in repo-metadata and ask translator admins to make a stable branch for translations Jonathan
who is authorised to move repos around?
I'm unclear who is authorised to move git repos around, e.g. from playground to kdereview to kde-extra It used to be only sysadmins which seems like a political burden on a tech team. Now anyone can edit repo-metadata. So can anyone move repos around as long as rules and conventions are followed? I wonder if it should be a task moved to a team such as the release team (but then that's not a well defined team). I'm asked because I was asked to review atcore being moved around https://phabricator.kde.org/D6318 Jonathan
Re: Kirigami in Frameworks
On 21 June 2017 at 15:00, Marco Martin wrote: > As there were no replies for quite a while, i assume there are no > particular objections. > > so, how to proceed? what needs to be doe to do the actual move? Does it comply with the policies (as much as they are relevant for QML)? https://community.kde.org/Frameworks/Policies Get David Faure to give his approval then see what the reponse to my "who is authorised to move repos around?" thead is. https://marc.info/?l=kde-core-devel&m=149806172721190&w=2 Jonathan
Re: Moving AtCore to Extragear
On Fri, Jun 23, 2017 at 08:22:39AM +1200, Ben Cooksley wrote: > On Fri, Jun 23, 2017 at 7:56 AM, Luigi Toscano > wrote: > > Albert Astals Cid ha scritto: > >> El diumenge, 18 de juny de 2017, a les 9:48:07 CEST, Lays Rodrigues va > >> escriure: > >>> Hey guys, good morning. =D > >>> Any more comments on AtCore code? > >>> How the moving to Extragear work? > >> > >> Are you planning to at least answer my last comments saying "we don't > >> really > >> care about that level of perfection"? (which is a fair position) > >> > > > > In addition to Albert's comment, I noticed now (still going through the > > backlog after vacation) that atcore use tr() for messages, but there is no > > Messages.sh file to extract the strings (which should be called atcore_qt, > > check the similar files in step or marble or in tier1 frameworks). > > > > Unfortunately the repository was already moved directly to extragear, and I > > expressed already my disagreement about this move with still open questions. > > I'm going to be reversing that move, as the repository hasn't cleared review. > Additionally, the commit is technically wrong and was committed while > I had noted objections on the review. I'm terribly sorry about this, I guess I got ahead of myself. The issue you pointed about updating the project path and deteling the repo-metadata entry in playground I did. Luigi brought up an issue about translations but that was after I had moved it. I see Albert has an outstanding question, Lays can you answer that? Jonathan
libqaccessibilityclient now in kdereview
libqaccessibilityclient is now in kdereview. It's in a git repo called libkdeaccessibilityclient but we filed a sysadmin request to rename it. We just released 0.2.0 in unstable (for some reason 0.1.1 was released in stable some years ago). What is it? Since it's hard to grasp all the bits related to accessibility, I'll try to explain what the lib is for. Most of the stack is part of Qt 5, so nothing to worry about, that's the part that lets applications expose their UI over DBus for AT-SPI, so they work nicely with assisitve tools (e.g. Orca). In accessibility language, the applications act as "servers" and the screen reader for example is a client. This library is for writing clients, so applications that are assistive, such as screen readers. It currently has two users: KMag and Simon. KMag can use it to follow the focus (e.g. when editing text, it can automatically magnify the part of the document where the cursor is. For Simon Listens, the use is to be able to let the user trigger menus and buttons by voice input.
Re: libqaccessibilityclient now in kdereview
Any progress or comment on the other issues raised? Jonathan On 26 July 2017 at 17:14, Frederik Gladhorn wrote: > Hi all, > > On onsdag 26. juli 2017 08.11.18 CEST Ben Cooksley wrote: >> On Wed, Jul 26, 2017 at 9:18 AM, Mario Fux wrote: >> > Am Dienstag, 25. Juli 2017, 14:55:42 CEST schrieb Albert Astals Cid: >> > >> > Morning Albert >> >> Hi Mario, >> >> >> El dimarts, 25 de juliol de 2017, a les 13:25:39 CEST, Jonathan Riddell >> >> va >> >> >> >> escriure: >> >> > libqaccessibilityclient is now in kdereview. It's in a git repo >> >> > called libkdeaccessibilityclient but we filed a sysadmin request to >> >> > rename it. >> >> > >> >> > We just released 0.2.0 in unstable (for some reason 0.1.1 was released >> >> > in stable some years ago). >> >> >> >> Do we really have to keep the Qt4 compatibility or can we kill it? >> > >> > Please keep it for now as the next Simon release (0.5.0 which is on its >> > way) is still Qt4 based. >> >> Simon is (for the moment at least) prohibited from depending on >> libqaccessibilityclient, because Extragear (as well as Plasma and >> Applications module) applications are not allowed to depend on code >> which is in Playground or KDE Review. > > It's indeed completely optional and I'm not sure if the code in Simon is ready > for prime time. Peter wrote it as an experiment (and it seems to more or less > work), but I'm not sure how stable it actually is. > > Cheers, > Frederik > > >> >> > Thx >> > Mario >> >> Cheers, >> Ben >> >> >> Cheers, >> >> >> >> Albert >> >> >> >> > What is it? >> >> > >> >> > Since it's hard to grasp all the bits related to accessibility, I'll >> >> > try >> >> > to >> >> > explain what the lib is for. >> >> > Most of the stack is part of Qt 5, so nothing to worry about, that's >> >> > the >> >> > part that lets applications expose their UI over DBus for AT-SPI, so >> >> > they >> >> > work nicely with assisitve tools (e.g. Orca). In accessibility >> >> > language, >> >> > the applications act as "servers" and the screen reader for example is >> >> > a >> >> > client. >> >> > >> >> > This library is for writing clients, so applications that are >> >> > assistive, >> >> > such as screen readers. It currently has two users: KMag and Simon. >> >> > KMag can use it to follow the focus (e.g. when editing text, it can >> >> > automatically magnify the part of the document where the cursor is. >> >> > >> >> > For Simon Listens, the use is to be able to let the user trigger menus >> >> > and >> >> > buttons by voice input. > >
Re: Latte Dock in review phase
Looks good from a brief look around I did from a packagers point of view (so not looking at the code). I'm unsure why it's both a plasmoid and a standalone binary, that seems superfluous. Maybe it's for use outwith Plasma. docs/ directory seems unused Green build in neon :) https://build.neon.kde.org/job/xenial_unstable_kde-extras_latte-dock/ Jonathan On 4 October 2017 at 22:00, Michail Vourlakos wrote: > Hello everyone, > > we decided to make Latte an active kde project and so now it is in review > phase. I believe the best place to be is extragear because we would like to > keep some independence for the first year concerning releases... > > What is Latte Dock? > > Latte is a project that is trying to provide a unified solution concering > docks and panels for the user. To achieve this it provides, > the Latte app, a Latte qml library, a Latte containment, a Latte plasmoid, a > Latte shell that uses plasma shell as base and 2 applets (a separator and a > specialized spacer) > > for more infos concerning the capabilities of the Latte suite you can find > at: > https://psifidotos.blogspot.nl/2017/04/latte-dock-v06-fresh-air.html > https://psifidotos.blogspot.nl/2017/08/latte-dock-v07-tornado-is-coming.html > > the project before entering the kde infrastructure could be found at: > https://github.com/psifidotos/Latte-Dock > > in review you can find our 0.7.1 version which is our stable version and the > plan is that after we succeed in the review phase to release a 0.7.2 version > only through kde infrastructure... > > regards, > michail
Fwd: Elisa Music Player is in kdereview
In the docs it says ' (NOTE: All documentation are licensed under the FDL, regardless of what license the application uses) --> ' but the docs are under CC-BY-SA 4.0. I guess this is from an old template, do you remember where the template is? Have you considered making upnp-player-qt a KDE project to get it more exposure? It could even be a Framework. Then again README.packagers says 'UPnP/DLNA via unreleased UPNPQT library is currently broken. Please consider not building it.' It might be worth noting that in the cmake output even if it's not found so people don't spend time looking for it. I found it needed these runtime bits which aren't listed in the README.packagers qml-module-qtqml-models2, qml-module-org-kde-kcm, qml-module-qtquick-controls, qml-module-qtquick-dialogs, qml-module-qtquick-layouts, qml-module-qtquick2, Do you have a GPG key published and able to sign tars? This seems to trip up a lot of developers at release time. Well done on a great new app! Jonathan On 5 February 2018 at 19:35, Matthieu Gallien wrote: > Hello, > > Elisa is now in kdereview and aiming for extragear/multimedia. We may (in > agreement with the module maintainer) move later to the Multimedia KDE > Applications module. > > It is a music player written with qml and a few KDE frameworks. It is > primarily intended to integrate with baloo but can also index music on its > own and open arbitrary files from command line or a file browser. > > We have worked on a vision to help clarify the what our intentions are: > > Elisa is a music player developed by the KDE community that strives to be > simple and nice to use. We also recognize that we need a flexible product to > account for the different workflows and use-cases of our users. > > We focus on a very good integration with the Plasma desktop of the KDE > community without compromising the support for other platforms (other Linux > desktop environments, Windows and Android). > > We are creating a reliable product that is a joy to use and respects our > users privacy. As such, we will prefer to support online services where users > are in control of their data. > > We also want to align our work with the goals that have been decided by the > whole KDE community. > > Best regards > > -- > Matthieu Gallien in the behalf of the Elisa team
Re: RKWard is in kdereview
Very nice It installs two desktop files which creates duplicate menu entries /usr/share/applications/org.kde.rkward-open.desktop /usr/share/applications/org.kde.rkward.desktop The .desktop files call it a "GUI for R" which is not a great description, everything in the menu is a GUI. I recommend "R Statistical Programming" or "IDE for R" maybe. I tidied up the files with the icon licence as they could easily be lost. It depends on WebKit which is not supported, could this be ported to WebEngine? It's uncommon having debian/ packaging directly in the source and there's also debian-official/ which could get confusing and out-of-sync and messy. I recommend moving them to another archive. Storing the packaging in KDE neon Git would be cool as we already have packaging for all the rest of KDE software. Using salsa.debian pkg-kde team would also make sense but would need different permissions. Either way we should get this into Neon, give me a ping to sort that out. Jonathan On Sat, 6 Oct 2018 at 14:47, Thomas Friedrichsmeier wrote: > > Hi! > > KDE.org has been our home for a almost four years, now (after over a > decade on sourceforge), but somehow I've kept procrastinating on the > final step: Today I'd like to ask you to start reviewing RKWard for > inclusion into exragear (coming from playground). > > > RKWard is an easy to use and easily extensible IDE/GUI for R (a > powerful language and environment for statistical computing, if you > did not know it, yet). It aims to combine the power of the > R-language with the ease of use of commercial statistics tools. > > RKWard is used productively on Linux/BSD, Mac, and Windows. > > We have quite a heavy code-base, and some of it dates back to the time > when KDE 3.0 was still fresh. I guess reviewing this will not be an > easy task, and honestly I have no idea where I would recommend you to > start. So please just ask whatever you need to know, and I'll try my > best to help you around. > > Looking forward to your feedback! > > Thomas Friedrichsmeier > for the RKWard team
Re: RKWard is in kdereview
I added it into Neon https://packaging.neon.kde.org/neon-packaging/rkward.git/ https://build.neon.kde.org/view/1%20release%20⛰/job/bionic_release_neon-packaging_rkward/ It's the norm for Debian packages to have their packaging kept separate from the upstream source including for PPAs, keeping them together is quite confusing. QGuiApplication should include ability for single instance application rather than having separate .desktop files for it. Jonathan On Wed, 10 Oct 2018 at 17:33, Thomas Friedrichsmeier wrote: > > On Wed, 10 Oct 2018 18:24:38 +0200 > meik michalke wrote: > > how would it affect our various PPAs if there was no debian/ > > directory in the sources? > > In fact, we'd have to keep the debian packaging somewhere, and "merge" > it into the sources while building (we do the same for translations in > the PPAs, so the procedure itself is pretty clear). But we only need the > "sloppy" variant of the packaging for this purpose (i.e. the one that > just works, without trying to keep up the latest debhelper > compatibility levels, and such; "debian" instead of "debian-official"). > > Regards > Thomas
Re: RKWard is in kdereview
On Fri, Oct 12, 2018 at 10:03:16PM +0200, Thomas Friedrichsmeier wrote: > Ok, will do. It may take me a while, though, as I'll have to be careful > not to break our automated builds on our Ubuntu PPAs (as pointed out by > Meik). But ideally, I'd also like to combine this step with handing > over our official debian packaging (i.e. the "debian-official" folder) > to the debian qt/kde-team. > > Is there any hope for that, or what can I do to make that happen? Talk to some folks on the team, maybe start with Scarlett (CCed) who is getting some good stuff into there. Jonathan
Re: RKWard is in kdereview
There's no appstream metainfo file nor product-screenshot https://community.kde.org/Guidelines_and_HOWTOs/AppStream Jonathan On Sat, 6 Oct 2018 at 14:47, Thomas Friedrichsmeier wrote: > > Hi! > > KDE.org has been our home for a almost four years, now (after over a > decade on sourceforge), but somehow I've kept procrastinating on the > final step: Today I'd like to ask you to start reviewing RKWard for > inclusion into exragear (coming from playground). > > > RKWard is an easy to use and easily extensible IDE/GUI for R (a > powerful language and environment for statistical computing, if you > did not know it, yet). It aims to combine the power of the > R-language with the ease of use of commercial statistics tools. > > RKWard is used productively on Linux/BSD, Mac, and Windows. > > We have quite a heavy code-base, and some of it dates back to the time > when KDE 3.0 was still fresh. I guess reviewing this will not be an > easy task, and honestly I have no idea where I would recommend you to > start. So please just ask whatever you need to know, and I'll try my > best to help you around. > > Looking forward to your feedback! > > Thomas Friedrichsmeier > for the RKWard team
Re: Move pulseaudio-qt to Extragear
nSeems to be all LGPL 2+3 or as approved by e.v. licence. I'd remove the COPYING file with the GPL text to avoid confusion. Building with QCH seems to need this file renamed to allow stuff to build with it https://packaging.neon.kde.org/extras/pulseaudio-qt.git/tree/debian/patches/qch-target-cmake.diff?h=Neon/unstable But the QCH cmake file is empty so I'm not sure it does anything anyway. Otherwise all good looking at the build we added to KDE neon https://build.neon.kde.org/job/bionic_unstable_extras_pulseaudio-qt/ kdeconnect now builds with the systemvolume plugin but I can't work out how to get it to do anything https://build.neon.kde.org/job/bionic_unstable_extras_kdeconnect/ Jonathan On Mon, 5 Nov 2018 at 19:09, Nicolas Fella wrote: > > Hi, > > together with David Rosca and Aleix Pol I have worked on extracting the > libpulse abstraction from plasma-pa into a library [0][1]. It is > currently optionally required by KDE Connect. plasma-pa and > libtaskmanager will use it at some point in the future. Long-term plan > is to move it to Frameworks, but until the required documentation and > testing is done I'd like to move it to Extragear and make an initial > release. > > Cheers > > Nicolas > > [0] https://phabricator.kde.org/T7994 > > [1] https://cgit.kde.org/pulseaudio-qt.git >
Re: Move pulseaudio-qt to Extragear
If the issues and and Alberts have discussed are dealt with then this can be moved to extragear and a release made. Let me know if you need any help. Jonathan On Wed, 28 Nov 2018 at 12:40, Nicolas Fella wrote: > > I've fixed the remaining clazy warnings. > > Cheers > > Nicolas > > On Mittwoch, 7. November 2018 00:48:31 CET Albert Astals Cid wrote: > > > > I proposed some small clazy fixes, but there's some more warnings that may > > make sense having a look over. > > > > https://paste.kde.org/p5lhjhosn > > > > Cheers, > > Albert > > > >
Re: libqaccessibilityclient now in kdereview
On Thu, 7 Mar 2019 at 05:20, Friedrich W. H. Kossebau wrote: > Soon it will be 2 years that libqaccessibilityclient entered kdereview, and I > just found it seems to be still in that state, at least by what repo-metadata > claims and given no emails to the thread which sonud like review done&over. > I came across it when compiling kmag myself, where the optional dep on this > exists. Thanks for your fixes. I just spoke to Frederik on IRC who says I can the beaurocracy forward so I've filed a sysadmin ticket to move to extragear/libs and I guess I'll make a 0.4.0 change once that happens and try to get it onto build.kde.org. Jonathan
KDE Review reviews
I've made a list of kdereview projects and their current status as I understand them and e-mailed the maintainers for updates https://community.kde.org/KDEReview (this is linked from the lifecycle wiki page). Feel free to help keep that page up to date. I moved kpeg and kdot to unmaintained as they haven't had any activity since we last discussed them in 2017. Jonathan
Re: KDE Review reviews
On Thu, 7 Mar 2019 at 23:38, Albert Astals Cid wrote: > > El dijous, 7 de març de 2019, a les 17:33:27 CET, Jonathan Riddell va > escriure: > > I've made a list of kdereview projects and their current status as I > > understand them and e-mailed the maintainers for updates > > Cool :) > > Do you think maybe it would have made more sense to do those update emails > here (in the original thread of emails) so they would also be public? In general yes but I thought today I'd try the personal touch since the public approach had stopped progressing, some progress has been made. Jonathan
Welcome Latte Dock to KDE
Latte is a dock based on plasma frameworks that provides an elegant and intuitive experience for your tasks and plasmoids. It animates its contents by using parabolic zoom effect and tries to be there only when it is needed. It's been part of KDE for a while but the incubation process stalled. With the creation of a new home wiki page https://community.kde.org/LatteDock and User wiki page https://userbase.kde.org/LatteDock/ I've been able to set the incubation to green. Jonathan
KDE Review passes
Welcome the following projects which passed kdereview process plasma-simplemenu now in selfrelease/extra and released on store.kde.org pulseaudio-qt now in selfrelease/extra and released on download.kde.org rust-qt-binding-generator now in selfrelease/extra plasma-redshift-control now in selfrelease/extra We really do need to sort out the terminology for extragear/extra/self-released things. Jontahan
Re: KDiff3 1.8 release.
Looks good from a quick compile and run. I take it you have no access to the obsolete sourceforge webpage? I see Debian has a 1.7 release, where is that available? Do you have any access to update https://www.linux-apps.com/content/show.php?content=9807 ? I'm adding this to KDE neon dev unstable edition. Eike is the Debian packaging managed in a repo somewhere? Are you interested in making it part of the KDE Qt Debian team? Jonathan On Sat, 16 Mar 2019 at 14:11, Michael Reeves wrote: > > Fixed now. > > On Thu, Mar 14, 2019, 4:31 AM Wolfgang Bauer wrote: >> >> The latest change >> (https://cgit.kde.org/kdiff3.git/commit/?id=638bd5a02893dde4a1927abd0c8a611b3b3ab6a1) >> unfortunately breaks the build here: >> >> /usr/lib/gcc/i586-suse-linux/8/../../../../i586-suse-linux/bin/ld: >> CMakeFiles/kdiff3part.dir/pdiff.cpp.o: in function >> `debugLineCheck(Diff3LineList&, int, e_SrcSelector)': >> /home/abuild/rpmbuild/BUILD/kdiff3-1.7.95git/src/pdiff.cpp:82: undefined >> reference to `kdeMain()' >> /usr/lib/gcc/i586-suse-linux/8/../../../../i586-suse-linux/bin/ld: >> /home/abuild/rpmbuild/BUILD/kdiff3-1.7.95git/src/pdiff.cpp:96: undefined >> reference to `kdeMain()' >> ... >> and so on. >> >> Kind Regards, >> Wolfgang >>
welcome plasma-active-window-control
Just passed kdereview and moved into extra/base is Plasma Active Window Control. Plasma Active Window Control is a plasma widget that you can embed in your panel to control your active window with e.g. close or maximise operations. Useful for decorationless window management. New maintainer is Chris Holland. Do say hello. Jonathan
Re: welcome plasma-active-window-control
On Sat, Mar 16, 2019 at 07:55:16PM +0100, Roman Gilg wrote: > On Sat, Mar 16, 2019 at 6:53 PM Jonathan Riddell wrote: > > > > Just passed kdereview and moved into extra/base is Plasma Active Window > > Control. > > > > Plasma Active Window Control is a plasma widget that you can embed in > > your panel to control your active window with e.g. close or maximise > > operations. Useful for decorationless window management. > > > > New maintainer is Chris Holland. Do say hello. > > > > Jonathan > > Hello, > > do you have a link with some more information? Sounds neat. Just the git repo and screenshot so far https://cgit.kde.org/plasma-active-window-control.git/ https://cdn.kde.org/screenshots/plasma-active-window-control/active-window-control.png Jonathan
Re: KDiff3 1.8 release.
Groovy got it added to Neon dev unstable edition https://build.neon.kde.org/job/bionic_unstable_forks_kdiff3/ I fixed the kcrash loading with it Jonathan On Sat, 16 Mar 2019 at 21:19, Michael Reeves wrote: > > > > On Sat, Mar 16, 2019, 1:14 PM Jonathan Riddell wrote: >> >> Looks good from a quick compile and run. >> >> I take it you have no access to the obsolete sourceforge webpage? >> >> I see Debian has a 1.7 release, where is that available? > > If it's truly 1.7 its based off a partial kf5 port that was never released. > Don't remember off hand who created. 1.7.90 would be an older version of my > code not officially released. >> >> >> Do you have any access to update >> https://www.linux-apps.com/content/show.php?content=9807 ? > > > No. > >> >> >> I'm adding this to KDE neon dev unstable edition. >> >> Eike is the Debian packaging managed in a repo somewhere? Are you >> interested in making it part of the KDE Qt Debian team? > > > Yes. > >> >> Jonathan >> >> >> >> On Sat, 16 Mar 2019 at 14:11, Michael Reeves wrote: >> > >> > Fixed now. >> > >> > On Thu, Mar 14, 2019, 4:31 AM Wolfgang Bauer wrote: >> >> >> >> The latest change >> >> (https://cgit.kde.org/kdiff3.git/commit/?id=638bd5a02893dde4a1927abd0c8a611b3b3ab6a1) >> >> unfortunately breaks the build here: >> >> >> >> /usr/lib/gcc/i586-suse-linux/8/../../../../i586-suse-linux/bin/ld: >> >> CMakeFiles/kdiff3part.dir/pdiff.cpp.o: in function >> >> `debugLineCheck(Diff3LineList&, int, e_SrcSelector)': >> >> /home/abuild/rpmbuild/BUILD/kdiff3-1.7.95git/src/pdiff.cpp:82: undefined >> >> reference to `kdeMain()' >> >> /usr/lib/gcc/i586-suse-linux/8/../../../../i586-suse-linux/bin/ld: >> >> /home/abuild/rpmbuild/BUILD/kdiff3-1.7.95git/src/pdiff.cpp:96: undefined >> >> reference to `kdeMain()' >> >> ... >> >> and so on. >> >> >> >> Kind Regards, >> >> Wolfgang >> >>
Re: Symmy in kde-review
I'm bumping this thread again to get a decision on symmy passing kdereview. The technical problems have been fixed. The question of whether it would be better to add to kgpg is open but as it has not been added to kgpg and nobody is planning to do so it's a moot point. So give symmy a final review if you wish else I'll put it into extragear. Jonathan On Sat, 25 Nov 2017 at 13:31, Elvis Angelaccio wrote: > > Hi, > symmy has been moved to kde-review for the usual review process. > > It's a tiny frontend for the symmetric encryption functionality of GPG. It > doesn't handle signing or public/private keys, as we already have kgpg or > kleopatra for that. > > Symmy can be useful if you have to send some sensitive file to someone, of > if you want to store it on some proprietary cloud service. > > It comes with a CLI application and plugins for GUI integration with > Dolphin/Plasma. > > I'd like to move it to either extragear-utils or kde-utils, if everything > looks good. > > Thanks, > Elvis
Re: Symmy in kde-review
This has now moved into extragear/utils. Jonathan On Sat, 25 Nov 2017 at 13:31, Elvis Angelaccio wrote: > > Hi, > symmy has been moved to kde-review for the usual review process. > > It's a tiny frontend for the symmetric encryption functionality of GPG. It > doesn't handle signing or public/private keys, as we already have kgpg or > kleopatra for that. > > Symmy can be useful if you have to send some sensitive file to someone, of > if you want to store it on some proprietary cloud service. > > It comes with a CLI application and plugins for GUI integration with > Dolphin/Plasma. > > I'd like to move it to either extragear-utils or kde-utils, if everything > looks good. > > Thanks, > Elvis
Re: [kde-core-devel] Extragear release files
On Fri, Apr 12, 2019 at 04:55:47PM -0400, Michael Reeves wrote: > Where do release files go after sys admin moves them? Where would they be > downloaded from? Moved to the place on master.kde.org where is used for download.kde.org. Packagers have an account on master.kde.org to be able to scp them off. Others will need to wait for you to ask sysadmin to make them public and they'll appear on download.kde.org. Jonathan
Welcome CuteHMI
Please welcome CuteHMI to KDE, it has now passed incubator into Playground description: CuteHMI is an open-source HMI (Human Machine Interface) software written in C++ and QML, using Qt libraries as a framework. https://community.kde.org/Incubator/Incubated_Projects placeholder website: https://cutehmi.kde.org/ matrix:#cutehmi:kde.org https://community.kde.org/File:Cutehmi.png https://cgit.kde.org/cutehmi.git/ Jonathan
Re: liquidshell in kdereview
I've now moved this to extragear/base as there did not seem to be any more political complaints and technical ones seemed fairly fixable. Jonathan On Mon, 15 Apr 2019 at 10:16, Martin Koller wrote: > On Sonntag, 14. April 2019 23:34:43 CEST Luca Beltrame wrote: > > Il giorno Sun, 14 Apr 2019 16:43:54 +0200 > > Martin Koller ha scritto: > > > > > The cmake file is the ultimate source for specifying what the > > > application depends on. Adding this somewhere else will easily get > > > > READMEs can be useful for packagers instead of manually watching the > > output of CMake or reading CMakelists.txt (fine for simpler projects, > > but not for large ones). > > since in this case we are talking about required software, > the packager will not get the app compiled. > I assume this will hit his attention. > I would understand that optional dependencies are different since the app > would build but not with all options. > > -- > Best regards/Schöne Grüße > > Martin > > () ascii ribbon campaign - against html e-mail > /\- against proprietary attachments > > > > >
Re: RKWard is in kdereview
I've now moved this back to playground/edu/rkward as there had not been movement on all the issues people had brought up and kdereview should only last a couple months at most. It would be great to see RKWard brought back through kdereview and driven to release soon as it looks like a worthy project. Jonathan On Sat, 6 Oct 2018 at 14:47, Thomas Friedrichsmeier < thomas.friedrichsme...@ruhr-uni-bochum.de> wrote: > Hi! > > KDE.org has been our home for a almost four years, now (after over a > decade on sourceforge), but somehow I've kept procrastinating on the > final step: Today I'd like to ask you to start reviewing RKWard for > inclusion into exragear (coming from playground). > > > RKWard is an easy to use and easily extensible IDE/GUI for R (a > powerful language and environment for statistical computing, if you > did not know it, yet). It aims to combine the power of the > R-language with the ease of use of commercial statistics tools. > > RKWard is used productively on Linux/BSD, Mac, and Windows. > > We have quite a heavy code-base, and some of it dates back to the time > when KDE 3.0 was still fresh. I guess reviewing this will not be an > easy task, and honestly I have no idea where I would recommend you to > start. So please just ask whatever you need to know, and I'll try my > best to help you around. > > Looking forward to your feedback! > > Thomas Friedrichsmeier > for the RKWard team >
KDE Applications discussion
There is a discussion about KDE Applications process happening on an untagged Phab work item https://phabricator.kde.org/T10812 Jonathan
ksnapshot to unmaintained
I'd like to propose moving ksnapshot to unmaintained, it's had no code commits since 2017 and still uses KDElibs4 and the functionality is replaced by Spectacle. Jonathan
krecipes to unmaintained
I'd like to propose moving krecipes to unmaintained. It still uses kdelibs4 and has had no feature commits since 2016. Jonathan
Re: ksnapshot to unmaintained
One would think so, but one would be wrong, at least on the labelling :) https://projects.kde.org/api/v1/projects/extragear/graphics Jonathan On Fri, 10 May 2019 at 00:00, Boudhayan Gupta wrote: > I thought it was already unmaintained as of the first release of Spectacle. > > On Fri, 10 May 2019 at 00:48, Albert Astals Cid wrote: > >> Weakly suggest emailing kde-graphics-devel mailing list about this. >> >> Cheers, >> Albert >> >> El divendres, 10 de maig de 2019, a les 0:09:29 CEST, Jonathan Riddell va >> escriure: >> > I'd like to propose moving ksnapshot to unmaintained, it's had no code >> > commits since 2017 and still uses KDElibs4 and the functionality is >> > replaced by Spectacle. >> > >> > Jonathan >> > >> >> >> >> >>
kaudiocreator to unmaintained
I'd like to propose moving kaudiocreator to unmaintained No commits since Mar 8 22:11:33 2017 No releases in KF5 time Obsolete technology
Move Simon to unmaintained
I'd like to suggest moving Simon to unmaintained. It's still using kdelibs4 No significant commits for a couple of years
kimtoy to unmaintained
I'd like to suggest moving kimtoy to unmtaintained Trivial bugs go unanswered https://bugs.kde.org/show_bug.cgi?id=391555 No significant commits since 2016 No releases Jonathan
Re: Move Simon to unmaintained
Mario seems to be the latest maintainer with cfeck and yourself also doing work on it. Jonathan On Tue, 14 May 2019 at 16:38, Luigi Toscano wrote: > On Tuesday, 14 May 2019 17:15:02 CEST Jonathan Riddell wrote: > > I'd like to suggest moving Simon to unmaintained. > > > > It's still using kdelibs4 > > > > No significant commits for a couple of years > > > > Simon has a specific story (KF5 port - did you contact the last > maintainers? > > > -- > Luigi > > >
Re: kaudiocreator to unmaintained
Do you plan to push this commit. Will you make releases? Jonathan On Tue, 14 May 2019 at 21:57, Kevin Ottens wrote: > Hello, > > On Tuesday, 14 May 2019 17:39:30 CEST Luigi Toscano wrote: > > On Tuesday, 14 May 2019 16:44:43 CEST Jonathan Riddell wrote: > > > I'd like to propose moving kaudiocreator to unmaintained > > > > > > No commits since Mar 8 22:11:33 2017 > > > > > > No releases in KF5 time > > > > > > Obsolete technology > > > > Copying also the last maintainer. > > In fact I have one local commit which I forgot to push... from Dec 2017. I > wanted to brush it up a bit and have it released again. Yes, I buy CDs and > rip > them to mp3 or flac. Call me old school. > > Regards. > -- > Kevin Ottens, http://ervin.ipsquad.net >
Re: Kdiff3 renovation
Seems like there's two releases been made, congrats. https://download.kde.org/stable/kdiff3/ There's been no announcement that I've seen, can you send one to the kde-apps-announce@ list? https://marc.info/?l=kde-announce-apps&r=1&b=201905&w=2 Jonathan On Thu, 9 May 2019 at 16:19, Michael Reeves wrote: > > Just a heads up kdiff3 is about to go through some major renovation. > Currently file processing is extremely in efficient. There are at least > three loops through the entirety of the data. Further more thee complete > copies are kept in memory. Changing this will require almost a complete > rewrite of the loading routines. These changes carry potential for breakage > in kdiff3's compassion routines. I will try to avoid this but this area of > kdiff3 is both complex and fragile. This is master only do to the extent of > changes required. >
Re: Review Request: plasma-thunderbolt
On Wed, May 15, 2019 at 03:27:07PM +0200, Daniel Vrátil wrote:
> plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM
> for Plasma. I initially submitted the code as a patch against plasma-desktop
> [0], where it got reviewed, but it was ultimately decided to better put it
> into a separate repository, since it's not just a KCM but also a library and
> a
> KDED module. I have backported all the changes from the Phabricator review
> back to the repository, so the code in the repo is identical to the one in
> the
> Phab review (minus buildsystem changes and a small build fix for clang).
>
> However, since this is still a new code, it must formally pass through
> kdereview before I can submit it into Plasma as a new module.
>
> Thus I'd kindly ask you to take one more look at the codebase [1] and let me
> know if there are any more issues to fix, or if we can proceed to include
> this
> in the next Plasma release.
Installing the bolt package on Debian/Ubuntu/KDE neon I have this file
/usr/lib/x86_64-linux-gnu/boltd
But it is not found by FindBolt.cmake
I need to add this to the search path ${LIB_INSTALL_DIR}
Looks great but I don't have anything Thunderbolt so it's just a white box :)
Jonathan
Re: kaudiocreator to unmaintained
On Tue, 21 May 2019 at 17:48, Kevin Ottens wrote: > > Will you make releases? > > I'd like it to be part of KDE Applications. Unlike Zanshin I'd rather have > this one tied to the Applications release cycle. That being said, it's > been > eons since I had anything in the regular applications collection. Could > someone refresh me on what it entails to "make release"? Back in the day > it > was fairly transparent, if that's still so low on work I can easily say > yes... > if not I'll have to evaluate. > Great, please work with Albert or whoever to get it into the KDE Applications bundle. One of the first issues I see is the screenshot needs updating, this can be done here https://cgit.kde.org/websites/product-screenshots.git/tree/README.md You may also want to update the metadata in the appstream .xml file, currently it generates this: http://apps.kde.org.uk/applications/unmaintained/org.kde.kaudiocreator Jonathan
Re: kaudiocreator to unmaintained
I've not heard of audex. It doesn't have appstream metadata and it's still in playground so it doesn't feature on my radar. Jonathan On Fri, 24 May 2019 at 16:10, Bernd Steinhauser wrote: > On 22/05/19 13:39, Jonathan Riddell wrote: > > On Tue, 21 May 2019 at 17:48, Kevin Ottens > <mailto:er...@kde.org>> wrote: > > > > > Will you make releases? > > > > I'd like it to be part of KDE Applications. Unlike Zanshin I'd > rather have > > this one tied to the Applications release cycle. That being said, > it's been > > eons since I had anything in the regular applications collection. > Could > > someone refresh me on what it entails to "make release"? Back in the > day it > > was fairly transparent, if that's still so low on work I can easily > say > > yes... > > if not I'll have to evaluate. > > > > > > Great, please work with Albert or whoever to get it into the KDE > Applications > > bundle. > > > > One of the first issues I see is the screenshot needs updating, this can > be > > done here > > https://cgit.kde.org/websites/product-screenshots.git/tree/README.md > > You may also want to update the metadata in the appstream .xml file, > currently > > it generates this: > > http://apps.kde.org.uk/applications/unmaintained/org.kde.kaudiocreator > > > > Jonathan > > > Did you guys have a look at audex? > Last time I looked at both audex and kaudiocreator, I found the former to > be in > a much better state. > That's also why I put in some effort to port it to kf5 (at the time > neither of > the two was ported). > > Right now the main issue with audex is that the cover fetching doesn't > work > (since Google removed a related API), but apart from that it works very > well. > > Of course, if you – for whatever reason – prefer kaudiocreator, feel free > to > continue with that one. > Just wanted to point out that audex exists as well. ;) > > Cheers, > Bernd >
konsole website
can we call this site dead? https://konsole.kde.org/ Updating the metadata e.g. http://apps.kde.org.uk/applications/system/org.kde.konsole Jonathan
Re: utils website
On Fri, 24 May 2019 at 18:49, Rolf Eike Beer wrote: > Am Freitag, 24. Mai 2019, 18:14:07 CEST schrieb Jonathan Riddell: > > Can we call https://utils.kde.org/ dead? > > > > I'm updating metadata for kde.org and it would be better to just have > one > > place to keep up to date > > http://apps.kde.org.uk/applications/utilities/ > > utils.kde.org has some more information, e.g. I have added an extra page > how > to set up kgpg to debug things. I'm not sure if the endless version lists > are > really of help, but we have them So if you can migrate some more > information over there, e.g. where to pick up the .po files and so on, I > could > imagine to accept. It would at least stop me forgetting to update the > release > version numbers 3 times a year. > Adding in version numbers into kde.org/applications means adding them into appstream data files and it's a change I hope to make to the release tooling sometime soon. If there's extra info needed for KGpg that should probably go on https://userbase.kde.org/KGpg rather than yet another website. Jonathan
Re: Maintainence status of Kooka?
On Tue, 28 May 2019 at 16:22, Jonathan Marten wrote: > Adriaan de Groot writes: > > Kooka had its last release in 2011, as a KDE3 application. However, > master is > > a KF5-based application, with version number 0.90 in CMakeLists.txt. Is > there > > any intention to do a release? (That's mostly a question for Jonathan) > We > > revived it in FreeBSD packaging, calling current master 0.61.296 (from > git > > describe), but it feels a little weird to ship packages of unreleased > > software. > > From my point of view (Kooka maintainer, not to be confused with > Jonathan Riddell), I'd be happy to make Kooka "released". As far as I > am aware it is fully ported to KF5 and has no major outstanding bugs or > issues. > > I'm assuming that this does not mean making it an official part of > Applications, although it could adopt their YY.MM version numbering > scheme for consitency. It would be better to be included in what used > to be called Extragear (now Self Released?). > > It can be done as Self Released or just added into Applications whichever you prefer. Since you say you won't find time for releases until later that suggets it might be easier to just get it into KDE Applications and take the burden off your hands but however you wish. If it's self released you can use whatever version number you like (the same for Applications although it's more tidy to use the Applications version). > I'll start to work through the review process checklist > (https://community.kde.org/ReleasingSoftware), and then try to submit > Kooka to kdereview - although that probably won't be able to be until > after the summer holidays. > It's best to start stuff like kdereview sooner rather than later since it takes at least 2 weeks. The time taken for a kdereview isn't much but the roundtrips needed for the conversations to happen can take ages. Jonathan
konqueror.org
Can you call konqueror.org website unmaintained? The screenshots are all from KDE 4 times. We can just make it forward to the new kde.org/applications page instead Jonathan
Re: Maintenance status of KMid?
I would call that unmaintained. I've marked it as unmaintained on the new kde.org/applications site. if you don't get a reply in a few days then just move it to unmaintained in repo-metadata and kill the translations. Jonathan On Thu, 30 May 2019 at 15:17, Shinjo Park wrote: > Hi, > > I'd llike to ask whether KMid is maintained or not: > - No release/significant commit since 2010 > - Already mentioned as "unmaintained" in a bug 359424 [1] > - Still not migrated to git/KF5 yet > > [1] https://bugs.kde.org/show_bug.cgi?id=359424 > > Best regards, > Shinjo > > >
Re: Maintenance status of KMid?
There seems to be no Git repository for kmid and infact it's not part of KDE but still on Sourceforge. Please file a sysadmin ticket asking for the bugs.kde.org product to be removed. Jonathan On Thu, 30 May 2019 at 15:17, Shinjo Park wrote: > Hi, > > I'd llike to ask whether KMid is maintained or not: > - No release/significant commit since 2010 > - Already mentioned as "unmaintained" in a bug 359424 [1] > - Still not migrated to git/KF5 yet > > [1] https://bugs.kde.org/show_bug.cgi?id=359424 > > Best regards, > Shinjo > > >
keurocalc status
keurocalc has been ported to KF5 but there seems to have been no release. Does anyone plan to make a release? Or should it go into KDE Applications? Or should it be marked as unmaintained? Jonathan
Re: konqueror.org
David and Stefano confirmed in private e-mail it was fine to switch it off for now so that's what I've requested sysadmin to do. Jonathan On Thu, 6 Jun 2019 at 09:45, Albert Vaca Cintora wrote: > Killing some satellite websites will ease the maintenance, though, so I'm > with Jonathan. The screenshots being so old seem a prof to me that its > being hard for us as a community to keep up with it. > > Albert > > On Sun, Jun 2, 2019, 12:34 Albert Astals Cid wrote: > >> El dissabte, 1 de juny de 2019, a les 13:07:41 CEST, Jonathan Riddell va >> escriure: >> > Can you call konqueror.org website unmaintained? The screenshots are >> all >> > from KDE 4 times. We can just make it forward to the new >> > kde.org/applications page instead >> >> Or just update the screenshots and all its contents are still valid and >> much more complete than whatever is there in kde.org/applications. >> >> Cheers, >> Albert >> >> > >> > Jonathan >> > >> >> >> >> >>
Re: keurocalc status
On Thu, 6 Jun 2019 at 07:15, Eric Bischoff wrote: > Le mercredi 5 juin 2019, 18:23:50 CEST Jonathan Riddell a écrit : > > keurocalc has been ported to KF5 but there seems to have been no release. > > Does anyone plan to make a release? Or should it go into KDE > Applications? > > Or should it be marked as unmaintained? > It is maintained (by me), but I don't know how to "make a release". I > would > need help on that. With some help, I'd be happy to do it. > The easiest way to get it released is to ask for it to be moved into KDE Applications and then that gets taken care of for you. Otherwise it's a case of following the page here https://community.kde.org/ReleasingSoftware Much of it can be eased with the releaseme scripts which does the branching and tarring and tagging for you. Let me know if you need help. Good luck with the surgery. Jonathan
Re: What means having an application in "KDE Applications"
On Fri, Jun 07, 2019 at 12:09:27AM +0200, Albert Astals Cid wrote: > Can we please discuss what being in KDE Applications is first? > > You're telling apps they can join KDE Applications if they want, so to you > it's just "release as a service". > > I disagree, to me it's a "we as a community vouch to try to maintain this to > the best of our ability/time". > > So [to me] adding more things to KDE Applications needs at least a vague > consensus that it's worth making that kind of promise. I think KDE should offer services to apps which want to be part of the apps bundled release along with making the tars such as recommending version number, promo, maybe helping out with packaging for Snaps and Flatpaks and Appimage if there's teams happy to do that. But just trying to get agreement on renaming the bundle shows to me that KDE isn't ready to take on much more of a role such as maintainance. I think the most KDE could offer is to say that everything in the bundle works as intended and once it bitrots enough that is no longer the case then it will be kicked out. I don't think worry that it can't be maintianed should be a barrier to including an app. Jonathan
Re: What means having an application in "KDE Applications"
On Sun, Jun 16, 2019 at 11:41:50PM +0200, Luigi Toscano wrote: > Jonathan Riddell ha scritto: > > On Fri, Jun 07, 2019 at 12:09:27AM +0200, Albert Astals Cid wrote: > >> Can we please discuss what being in KDE Applications is first? > >> > >> You're telling apps they can join KDE Applications if they want, so to you > >> it's just "release as a service". > >> > >> I disagree, to me it's a "we as a community vouch to try to maintain this > >> to the best of our ability/time". > >> > >> So [to me] adding more things to KDE Applications needs at least a vague > >> consensus that it's worth making that kind of promise. > > > > I think KDE should offer services to apps which want to be part of the > > apps bundled release along with making the tars such as recommending > > version number, promo, maybe helping out with packaging for Snaps and > > Flatpaks and Appimage if there's teams happy to do that. > > I think that you are conflating the "help with the release" with the need for > applications to be part of the bundle. > > My dream is an automated server-side tarball generation, in a way that > developers can simply ask to release from a specific tag and don't care about > uploading the file to the right place on the incoming ftp/ssh server. But that > service could exist independently from the bundle. Automating any app releases more would be great. But I tried to put much of it into a CI for Plasma once and got stuck because there are access needed stages that are hard to CI such as GPG signing tars, updating version numbers, gpg signing and pushing tags. Still there should be some scope for improvements there. Jonathan
Re: kaudiocreator to unmaintained
On Thu, Jun 20, 2019 at 08:25:22AM +0200, Kevin Ottens wrote: > Since I'd rather we have one project with a team size > 1 that two with a > team > size of 1, I'll retract my previous offer of reviving kaudiocreator and turn > my attention to audex instead. Hopefully we can get it out of playground and > into KDE Applications. I've moved kaudiocreator to unmainatained. Translators please do the necessary with translations. Jonathan
Re: Ruqola in KDE-review
Licence looks good :) Jonathan On Thu, 12 Sep 2019 at 08:20, laurent Montel wrote: > Hi, > I would like to move ruqola to extragear/network. > So I asked to sysadmin to move ruqola to kde-review (it was done). > > Ben told me that this period will start in 2 weeks. > > If you want to review it... :) > > Regards. > > -- > Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software > Engineer > KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 > 53, > www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent > software solutions > > >
Re: ELF Dissector in kdereview
The file src/3rdparty/treemap/treemap.cpp is GPL while the rest of the application is LGPL. This makes the whole application copyable under only the terms of the GPL. It would be good to have COPYING moved to COPYING.LIB and a GPL text put in COPYING. src/ui/org.kde.elf-dissector.appdata.xml should also be changed to be GPL-2.0-or-later I couldn't compile it, I get: [ 2%] Building CXX object src/lib/CMakeFiles/libelfdissector.dir/elf/elfdynamicentry.cpp.o cd /home/jr/src/elf-dissector/elf-dissector/build/src/lib && /usr/bin/c++ -DQT_CORE_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I/home/jr/src/elf-dissector/elf-dissector/build/src/lib -I/home/jr/src/elf-dissector/elf-dissector/src/lib -I/home/jr/src/elf-dissector/elf-dissector/build/src/lib/libelfdissector_autogen/include -I/home/jr/src/elf-dissector/elf-dissector/src -I/home/jr/src/elf-dissector/elf-dissector/src/3rdparty -I/home/jr/src/elf-dissector/elf-dissector/build -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/libiberty -isystem /usr/include/libdwarf -isystem /usr/include/capstone/.. -std=c++0x -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Wvla -Wdate-time -Wsuggest-override -Wlogical-op -g -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -std=gnu++14 -o CMakeFiles/libelfdissector.dir/elf/elfdynamicentry.cpp.o -c /home/jr/src/elf-dissector/elf-dissector/src/lib/elf/elfdynamicentry.cpp In file included from /usr/include/c++/7/bits/stl_algo.h:59:0, from /usr/include/c++/7/algorithm:62, from /usr/include/x86_64-linux-gnu/qt5/QtCore/qglobal.h:142, from /usr/include/x86_64-linux-gnu/qt5/QtCore/qmetatype.h:45, from /usr/include/x86_64-linux-gnu/qt5/QtCore/QMetaType:1, from /home/jr/src/elf-dissector/elf-dissector/src/lib/elf/elfsection.h:23, from /home/jr/src/elf-dissector/elf-dissector/src/lib/elf/elfarraysection.h:21, from /home/jr/src/elf-dissector/elf-dissector/src/lib/elf/elfdynamicsection.h:21, from /home/jr/src/elf-dissector/elf-dissector/src/lib/elf/elfdynamicentry.cpp:19: /usr/include/c++/7/cstdlib:75:15: fatal error: stdlib.h: No such file or directory #include_next ^~ compilation terminated. but I do have the file /usr/include/c++/7/stdlib.h Jonathan On Sat, 28 Sep 2019 at 12:03, Volker Krause wrote: > Hi, > > ELF Dissector has been moved to kdereview for the usual review process. > > https://phabricator.kde.org/source/elf-dissector/ > > ELF Dissector is a static analysis tool for ELF libraries and executables, > for > doing things like inspecting forward and backward dependencies (on a > library > or symbol level), identifying load-time performance bottlenecks such as > expensive static constructors or excessive relocations, or size profiling > of > ELF files. > > ELF Dissector has been living in playground for more than 6 years because > I > was sloppy following the right process. Since it's in active use by a > number > of people, is actively maintained and remains relevant and useful I think > it's > time to finally rectify this :) > > Regarding its final destination, extragear/sdk looks like the obvious > candidate, as its such a niche tool that being part of the KDE Application > bundle is probably hard to argue. Once KDE Applications and the "release > service" are sufficiently decoupled, I'd of course be more than happy to > have > it covered by the automatic release process. > > Regarding distribution, there is one annoying aspect, its dependency on > semi- > public binutils API for accessing the C++ symbol demangling AST. That > works on > conventional Linux distributions, but I failed to make it work as a > Flatpak > due to that. > > Regarding portability, this currently only builds on ELF-based systems, > although theoretically this could be useful on a Windows host used for > embedded Linux development too. It's not impossible to make this work > eventually I think, but it's probably quite some work. > > Thanks, > Volker
Re: ELF Dissector in kdereview
I'm getting a build failure for this on 32-bit arm https://build.neon.kde.org/job/bionic_unstable_neon-packaging_elf-dissector_bin_armhf/7/console disassembler.cpp:149:34: error: ‘print_insn_little_arm’ was not declared in this scope Is it expected to build on this architecture? It builds fine on 64 bit arm. Jonathan On Sun, 27 Oct 2019 at 09:27, Volker Krause wrote: > Thanks again for the feedback, this has now been moved to extragear/sdk. > > On Saturday, 28 September 2019 13:01:11 CET Volker Krause wrote: > > Hi, > > > > ELF Dissector has been moved to kdereview for the usual review process. > > > > https://phabricator.kde.org/source/elf-dissector/ > > > > ELF Dissector is a static analysis tool for ELF libraries and > executables, > > for doing things like inspecting forward and backward dependencies (on a > > library or symbol level), identifying load-time performance bottlenecks > > such as expensive static constructors or excessive relocations, or size > > profiling of ELF files. > > > > ELF Dissector has been living in playground for more than 6 years > because I > > was sloppy following the right process. Since it's in active use by a > number > > of people, is actively maintained and remains relevant and useful I think > > it's time to finally rectify this :) > > > > Regarding its final destination, extragear/sdk looks like the obvious > > candidate, as its such a niche tool that being part of the KDE > Application > > bundle is probably hard to argue. Once KDE Applications and the "release > > service" are sufficiently decoupled, I'd of course be more than happy to > > have it covered by the automatic release process. > > > > Regarding distribution, there is one annoying aspect, its dependency on > > semi- public binutils API for accessing the C++ symbol demangling AST. > That > > works on conventional Linux distributions, but I failed to make it work > as > > a Flatpak due to that. > > > > Regarding portability, this currently only builds on ELF-based systems, > > although theoretically this could be useful on a Windows host used for > > embedded Linux development too. It's not impossible to make this work > > eventually I think, but it's probably quite some work. > > > > Thanks, > > Volker > >
Re: ELF Dissector in kdereview
On Wed, 30 Oct 2019 at 10:02, Jonathan Riddell wrote:
> That seems to have worked, it's moved onto the next 32-bit error
>
>
> https://build.neon.kde.org/job/bionic_unstable_neon-packaging_elf-dissector_bin_armhf/8/console
>
> src/lib/disassmbler/disassembler.cpp:228:65: error: cannot convert ‘uint64_t*
> {aka long long unsigned int*}’ to ‘size_t* {aka unsigned int*}’ for argument
> ‘3’ to ‘bool cs_disasm_iter(csh, const uint8_t**, size_t*, uint64_t*,
> cs_insn*)’*00:00:46* if (!cs_disasm_iter(handle, &data, &size,
> &address, insn)) {*00:00:46*
> ^
>
>
>
I can probably get you access to our arm builder if that's useful
Jonathan
Re: KTrip in kdereview
There's a file called LICENSE with the text of the GPL 2. We usually call this COPYING in KDE. Some of the source code files are under the LGPL 2+ so there should be a copy of that licence too usually in a file called COPYING.LIB Jonathan On Tue, 29 Oct 2019 at 18:36, Nicolas Fella wrote: > Hi, > > KTrip (https://invent.kde.org/kde/ktrip) has been moved to kdereview. > > KTrip is a public transport assistant based on KPublicTransport targeted > towards Plasma Mobile and Android. Currently it supports querying journeys > between two locations as well as departures for a location but more > advanced > features are possible in the future. > > Nightly builds for Android are available on the binary factory (https:// > binary-factory.kde.org/view/Android/job/KTrip_android/). > > Destination would be extragear for now, but whatever comes out of KDE > Applications might make sense. > > Cheers > > Nico > > >
Re: ELF Dissector in kdereview
Yay it's green!
https://build.neon.kde.org/view/3%20unstable%20%E2%98%A3%20git%20master/job/bionic_unstable_neon-packaging_elf-dissector/
On Wed, 30 Oct 2019 at 17:30, Volker Krause wrote:
> This one probably even affects all 32bit builds with Capstone available,
> not
> just ARM. I've pushed a fix for this.
>
> Thanks!
> Volker
>
> On Wednesday, 30 October 2019 11:02:21 CET Jonathan Riddell wrote:
> > That seems to have worked, it's moved onto the next 32-bit error
> >
> >
> https://build.neon.kde.org/job/bionic_unstable_neon-packaging_elf-dissector_
> > bin_armhf/8/console
> >
> > src/lib/disassmbler/disassembler.cpp:228:65: error: cannot convert
> > ‘uint64_t* {aka long long unsigned int*}’ to ‘size_t* {aka unsigned
> > int*}’ for argument ‘3’ to ‘bool cs_disasm_iter(csh, const uint8_t**,
> > size_t*, uint64_t*, cs_insn*)’*00:00:46* if
> > (!cs_disasm_iter(handle, &data, &size, &address, insn)) {*00:00:46*
> > ^
> >
> > Jonathan
> >
> > On Tue, 29 Oct 2019 at 18:27, Volker Krause wrote:
> > > I haven't recently tested it on 32bit ARM, I pushed a possible fix
> using a
> > > similar approach that has been applied for x86 already. If that doesn't
> > > help I
> > > need to find a 32bit ARM setup again here to properly debug it.
> > >
> > > Regards,
> > > Volker
> > >
> > > On Tuesday, 29 October 2019 11:29:44 CET Jonathan Riddell wrote:
> > > > I'm getting a build failure for this on 32-bit arm
> > >
> > >
> https://build.neon.kde.org/job/bionic_unstable_neon-packaging_elf-dissecto
> > > r_>
> > > > bin_armhf/7/console
> > > >
> > > > disassembler.cpp:149:34: error: ‘print_insn_little_arm’ was not
> > > > declared in this scope
> > > >
> > > > Is it expected to build on this architecture? It builds fine on 64
> bit
> > >
> > > arm.
> > >
> > > > Jonathan
> > > >
> > > > On Sun, 27 Oct 2019 at 09:27, Volker Krause wrote:
> > > > > Thanks again for the feedback, this has now been moved to
> > >
> > > extragear/sdk.
> > >
> > > > > On Saturday, 28 September 2019 13:01:11 CET Volker Krause wrote:
> > > > > > Hi,
> > > > > >
> > > > > > ELF Dissector has been moved to kdereview for the usual review
> > >
> > > process.
> > >
> > > > > > https://phabricator.kde.org/source/elf-dissector/
> > > > > >
> > > > > > ELF Dissector is a static analysis tool for ELF libraries and
> > > > >
> > > > > executables,
> > > > >
> > > > > > for doing things like inspecting forward and backward
> dependencies
> > >
> > > (on a
> > >
> > > > > > library or symbol level), identifying load-time performance
> > >
> > > bottlenecks
> > >
> > > > > > such as expensive static constructors or excessive relocations,
> or
> > >
> > > size
> > >
> > > > > > profiling of ELF files.
> > > > > >
> > > > > > ELF Dissector has been living in playground for more than 6 years
> > > > >
> > > > > because I
> > > > >
> > > > > > was sloppy following the right process. Since it's in active use
> by
> > > > > > a
> > > > >
> > > > > number
> > > > >
> > > > > > of people, is actively maintained and remains relevant and
> useful I
> > > > > > think
> > > > > > it's time to finally rectify this :)
> > > > > >
> > > > > > Regarding its final destination, extragear/sdk looks like the
> > > > > > obvious
> > > > > > candidate, as its such a niche tool that being part of the KDE
> > > > >
> > > > > Application
> > > > >
> > > > > > bundle is probably hard to argue. Once KDE Applications and the
> > >
> > > "release
> > >
> > > > > > service" are sufficiently decoupled, I'd of course be more than
> > >
> > > happy to
> > >
> > > > > > have it covered by the automatic release process.
> > > > > >
> > > > > > Regarding distribution, there is one annoying aspect, its
> dependency
> > >
> > > on
> > >
> > > > > > semi- public binutils API for accessing the C++ symbol demangling
> > >
> > > AST.
> > >
> > > > > That
> > > > >
> > > > > > works on conventional Linux distributions, but I failed to make
> it
> > >
> > > work
> > >
> > > > > as
> > > > >
> > > > > > a Flatpak due to that.
> > > > > >
> > > > > > Regarding portability, this currently only builds on ELF-based
> > >
> > > systems,
> > >
> > > > > > although theoretically this could be useful on a Windows host
> used
> > >
> > > for
> > >
> > > > > > embedded Linux development too. It's not impossible to make this
> > > > > > work
> > > > > > eventually I think, but it's probably quite some work.
> > > > > >
> > > > > > Thanks,
> > > > > > Volker
>
>
Re: KIOFuse in kdereview
This compiles for me but there's no install rule so nothing gets installed,my ioslaves are unfused Jonathan
Re: plasma-nano and plasma-phone-components are now in kdereview
On Sat, 9 Nov 2019 at 07:10, Christophe Giboudeaux wrote: > On Friday, November 8, 2019 10:36:39 AM CET Alexander Potashev wrote: > > пт, 8 нояб. 2019 г. в 10:10, Bhushan Shah : > > > Hello! > > > > > > plasma-nano: https://invent.kde.org/kde/plasma-nano > > > COPYING.LIB contains the LGPL 2.1 license. The LGPL code in this repo is > LGPL-2.0-or-later > > > > plasma-phone-components: > > > https://invent.kde.org/kde/plasma-phone-components > > You also need the LGPL-2.0-or-later license in this repo. > More an aside but I never tend to bother with worrying about the difference between LGPL 2.0 and 2.1 since it's essentially just a rename. It would be cleaner to update the files to say LGPL 2.1 which is what's recommended by the licence policy https://community.kde.org/Policies/Licensing_Policy Great to see someone else care about licence review but :) Jonathan
Re: KTimeTracker in kdereview
Licensing looks good :) Jonathan On Tue, 19 Nov 2019 at 04:20, Alexander Potashev wrote: > Hi, > > KTimeTracker [1] has been moved to kdereview. > > KTimeTracker is a time tracker desktop application which is well > suited for tracking labor time you spend on a specific > project/feature/customer. > > Its latest release was made on 2015-07-01 as part of KDE PIM 4.14.10. > Since then I ported KTimeTracker to Qt5/KF5, did a lot of refactoring > and reworked some dialogs. The major changes since 4.14.10 are listed > in [2]. > > KDE CI is set up at [3]. > > The project is currently in playground-pim, destination would be > extragear-pim. > > > [1] https://cgit.kde.org/ktimetracker.git > [2] https://cgit.kde.org/ktimetracker.git/tree/ChangeLog.md > [3] https://build.kde.org/job/Extragear/job/ktimetracker/ > > -- > Alexander Potashev >
Re: KDE Itinerary in kdereview
Looking good It's more common to name COPYING as COPYING.LIB when it is the LGPL In the appdata file org.kde.itinerary.desktop it's better to use an id without the .desktop on the end since that's unnecessary And it's missing the launchpable tag org.kde.$NAME.desktop recommended, see https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable The wiki page should maybe be named after the app not the library https://community.kde.org/KDE_PIM/KItinerary Jonathan On Sun, 8 Dec 2019 at 12:16, Volker Krause wrote: > Hi, > > KDE Itinerary has been moved to kdereview: > > Code: https://invent.kde.org/kde/itinerary > Workboard: https://phabricator.kde.org/project/board/280/query/all/ > > KDE Itinerary is a Kirigami-based mobile application for managing your > itinerary as a timeline, including access to your travel documents, > tickets > and boarding passes, real-time updates for train connections, weather > forecast > along your trip, etc. > > Its destination for now is probably extragear/pim, but becoming part of > the > release service eventually would be desirable. > > There are binary factory nightly builds for Android and Flatpak for easy > testing. It can import travel documents directly, but for the optimal > experience this is best used together with the KMail Itinerary plug-in and > a > Nextcloud/DavDroid calendar or KDE Connect. > > Thanks, > Volker
Re: plasma-nano and plasma-phone-components are now in kdereview
I've moved these into kde/workspace now for release with Plasma 5.18 (as non LTS) Jonathan On Fri, 8 Nov 2019 at 07:09, Bhushan Shah wrote: > Hello! > > plasma-nano: https://invent.kde.org/kde/plasma-nano > plasma-phone-components: > https://invent.kde.org/kde/plasma-phone-components > > Two repos have been moved to kdereview, with final intended destinition > being kde/workspace. > > plasma-nano is a minimal shell package which other shell package can > extend, while plasma-phone-components is a shell package, look and feel > and several other components which makes Plasma Mobile. > > Thanks > -- > Bhushan Shah > http://blog.bshah.in > IRC Nick : bshah on Freenode > GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D >
Re: CuteHMI in kdereview
The licencing looks a little unclear because the LICENSE file says LGPL 3 but there are some files which are GPL 3. At least the GPL 3 text should be in the top directory the README.md explain what it applies to. For bonus points a full LICENSES/ directory and SPDX descriptions in each file is a major win (this is a new practice we are moving to for KDE Frameworks which makes it much easier to understand licencing but as yet not many projects have moved to it). Jonathan On Thu, 6 Feb 2020 at 20:22, Michal Policht wrote: > Hello there, > > CuteHMI (https://cutehmi.kde.org/) has been moved to kdereview. > > CuteHMI is meant to be a set of tools and components that help one to > create QML-based HMI/SCADA software. > > The project has been started few years ago, because I couldn't find any > open-source, QML-based HMI/SCADA framework I could put my things into. > > Regards > > Michal Policht > > >
Re: CuteHMI in kdereview
I've moved cuteHMI back to playaround pending review of build system, translation integration and getting some more readable introduction to the project. Jonathan On Sun, 16 Feb 2020 at 22:07, Albert Astals Cid wrote: > El dijous, 13 de febrer de 2020, a les 11:00:27 CET, Michal Policht va > escriure: > > Yeah, I neglected translations a bit... > > Time to stop :) > > > I am going to implement adequate > > Qbs module for extracting translations. > > No, that's not how it works. You need to use Messages.sh like the rest of > us. > > Fortunately for you Yuri commited something already. > > Now, you need to figure out how to actually load and use those > translations. > > To a regular project i would just suggest to use ecm_create_qm_loader like > everyone else does, but since sadly you are using an unsupported build > system, you're on your own. > > Cheers, > Albert > > >
Re: Kup in KDE Review
This looks great. I think the other comments have covered the main issues so I'll just make a cheeky feature request and suggest it gets the ability to upload to cloud storage since I would guess that's the main way to do backups these days. Talking to Nextcloud or gdrive or AWS directly would make it much more useful to have. Jonathan On Mon, 6 Apr 2020 at 21:01, Simon Persson wrote: > Hello! > > > Please help to review kup. > > It is a backup scheduler tightly integrated with plasma (has system > setting kcm, systray plasmoid, kioslave). It supports saving backups > either with bup or with rsync. > > It has been developed outside of KDE for many years and only now is > being incubated. > > I am unsure if it should end up in extragear or some release service > bundle. Perhaps people have an opinion on this? > > https://invent.kde.org/kde/kup > > > Thanks, > > Simon > >
