Review of Codevis (ie - Making Codevis a KDE Project)

2023-08-17 Thread Tomaz Canabrava
Hello Fellow KDE Devs,

I'm here, formally asking for a review of the Codevis project, to move
forward and make it a part of kdesdk.

Currently we are using parts of KWdigetsAddons as a submodule
Most things that are related to buildsystems will be moved to craft /
kdesrc-build as soon as possible, right now we rely in conan for windows
and mac, plus a hand-written build script that downloads and builds llvm
for those platforms.

Things that I know that are out of KDE Accordance:
- Translation System (uses Qt's tr() system)
- Settings System (it uses my own configuration parser that resembles QML)
- Folder naming specification (follows the lakosian naming specification)
- CI used is based on Gitlab, but fails on KDE

The current repository of Codevis is:
https://invent.kde.org/tcanabrava/codevis

The KDE developers on this project are me, tarcisio fischer (that presented
Codevis on Akademy), and Richard Dale.

Best regards,
Tomaz


Re: Review of Codevis (ie - Making Codevis a KDE Project)

2023-08-17 Thread Tomaz Canabrava
(Another thing to add, it is currently on Qt5 but we plan to move it to Qt6
as soon as possible, and as soon as we have a working CI on windows, mac
and linux on KDE infrastructure)


On Thu, Aug 17, 2023 at 11:18 AM Tomaz Canabrava  wrote:

> Hello Fellow KDE Devs,
>
> I'm here, formally asking for a review of the Codevis project, to move
> forward and make it a part of kdesdk.
>
> Currently we are using parts of KWdigetsAddons as a submodule
> Most things that are related to buildsystems will be moved to craft /
> kdesrc-build as soon as possible, right now we rely in conan for windows
> and mac, plus a hand-written build script that downloads and builds llvm
> for those platforms.
>
> Things that I know that are out of KDE Accordance:
> - Translation System (uses Qt's tr() system)
> - Settings System (it uses my own configuration parser that resembles QML)
> - Folder naming specification (follows the lakosian naming specification)
> - CI used is based on Gitlab, but fails on KDE
>
> The current repository of Codevis is:
> https://invent.kde.org/tcanabrava/codevis
>
> The KDE developers on this project are me, tarcisio fischer (that
> presented Codevis on Akademy), and Richard Dale.
>
> Best regards,
> Tomaz
>


Re: Review of Codevis (ie - Making Codevis a KDE Project)

2023-08-17 Thread Ben Cooksley
On Thu, Aug 17, 2023 at 9:20 PM Tomaz Canabrava  wrote:

> (Another thing to add, it is currently on Qt5 but we plan to move it to
> Qt6 as soon as possible, and as soon as we have a working CI on windows,
> mac and linux on KDE infrastructure)
>
>
> On Thu, Aug 17, 2023 at 11:18 AM Tomaz Canabrava 
> wrote:
>
>> Hello Fellow KDE Devs,
>>
>> I'm here, formally asking for a review of the Codevis project, to move
>> forward and make it a part of kdesdk.
>>
>> Currently we are using parts of KWdigetsAddons as a submodule
>> Most things that are related to buildsystems will be moved to craft /
>> kdesrc-build as soon as possible, right now we rely in conan for windows
>> and mac, plus a hand-written build script that downloads and builds llvm
>> for those platforms.
>>
>> Things that I know that are out of KDE Accordance:
>> - Translation System (uses Qt's tr() system)
>> - Settings System (it uses my own configuration parser that resembles QML)
>> - Folder naming specification (follows the lakosian naming specification)
>> - CI used is based on Gitlab, but fails on KDE
>>
>
For your CI items here:

On Linux, we don't provide non-Docker workers, and Docker-in-Docker is not
permitted for security reasons (as it essentially means you are root on the
runner).
You'll need to adjust the job to give Gitlab the name of the image you need
to run under - usage of the provided images at
invent.kde.org/sysadmin/ci-images is preferred.

Due to the ageing out of CentOS 7 we're currently in the process of
migrating towards SLES15 based images for our Appimage builds.

For Windows, we also don't provide non-Docker workers, and we only allow
the use of blessed images we provide (in invent.kde.org/sysadmin/ci-images).
It looks like you are doing quite a bit of stand up work in your custom
build script though, so please consider whether one of the images we
already provide is suitable for your purposes in terms of dependencies
provided (I believe LLVM may already be available in the -qt515 and -qt65
images)

Assuming your project is a regular CMake project though you might want to
consider starting by adding the regular KDE CI jobs to the project though
and seeing how they go (see the templates at
invent.kde.org/sysadmin/ci-utilities)


>> The current repository of Codevis is:
>> https://invent.kde.org/tcanabrava/codevis
>>
>> The KDE developers on this project are me, tarcisio fischer (that
>> presented Codevis on Akademy), and Richard Dale.
>>
>> Best regards,
>> Tomaz
>>
>
Cheers,
Ben


Re: Review of Codevis (ie - Making Codevis a KDE Project)

2023-08-17 Thread Tomaz Canabrava
Ben,

Thanks so much for all the hints, I'm adapting the CI now.

Best,
Tomaz


On Thu, Aug 17, 2023 at 11:46 AM Ben Cooksley  wrote:

> On Thu, Aug 17, 2023 at 9:20 PM Tomaz Canabrava 
> wrote:
>
>> (Another thing to add, it is currently on Qt5 but we plan to move it to
>> Qt6 as soon as possible, and as soon as we have a working CI on windows,
>> mac and linux on KDE infrastructure)
>>
>>
>> On Thu, Aug 17, 2023 at 11:18 AM Tomaz Canabrava 
>> wrote:
>>
>>> Hello Fellow KDE Devs,
>>>
>>> I'm here, formally asking for a review of the Codevis project, to move
>>> forward and make it a part of kdesdk.
>>>
>>> Currently we are using parts of KWdigetsAddons as a submodule
>>> Most things that are related to buildsystems will be moved to craft /
>>> kdesrc-build as soon as possible, right now we rely in conan for windows
>>> and mac, plus a hand-written build script that downloads and builds llvm
>>> for those platforms.
>>>
>>> Things that I know that are out of KDE Accordance:
>>> - Translation System (uses Qt's tr() system)
>>> - Settings System (it uses my own configuration parser that resembles
>>> QML)
>>> - Folder naming specification (follows the lakosian naming specification)
>>> - CI used is based on Gitlab, but fails on KDE
>>>
>>
> For your CI items here:
>
> On Linux, we don't provide non-Docker workers, and Docker-in-Docker is not
> permitted for security reasons (as it essentially means you are root on the
> runner).
> You'll need to adjust the job to give Gitlab the name of the image you
> need to run under - usage of the provided images at
> invent.kde.org/sysadmin/ci-images is preferred.
>
> Due to the ageing out of CentOS 7 we're currently in the process of
> migrating towards SLES15 based images for our Appimage builds.
>
> For Windows, we also don't provide non-Docker workers, and we only allow
> the use of blessed images we provide (in invent.kde.org/sysadmin/ci-images
> ).
> It looks like you are doing quite a bit of stand up work in your custom
> build script though, so please consider whether one of the images we
> already provide is suitable for your purposes in terms of dependencies
> provided (I believe LLVM may already be available in the -qt515 and -qt65
> images)
>
> Assuming your project is a regular CMake project though you might want to
> consider starting by adding the regular KDE CI jobs to the project though
> and seeing how they go (see the templates at
> invent.kde.org/sysadmin/ci-utilities)
>
>
>>> The current repository of Codevis is:
>>> https://invent.kde.org/tcanabrava/codevis
>>>
>>> The KDE developers on this project are me, tarcisio fischer (that
>>> presented Codevis on Akademy), and Richard Dale.
>>>
>>> Best regards,
>>> Tomaz
>>>
>>
> Cheers,
> Ben
>


Re: Review of Codevis (ie - Making Codevis a KDE Project)

2023-08-17 Thread Carl Schwan
On Thursday, August 17, 2023 11:18:24 AM CEST Tomaz Canabrava wrote:
> Hello Fellow KDE Devs,
> 
> I'm here, formally asking for a review of the Codevis project, to move
> forward and make it a part of kdesdk.

Very cool project, I was amazed by the presentation of it from tarcisio at 
Akademy.

> Currently we are using parts of KWdigetsAddons as a submodule
> Most things that are related to buildsystems will be moved to craft /
> kdesrc-build as soon as possible, right now we rely in conan for windows
> and mac, plus a hand-written build script that downloads and builds llvm
> for those platforms.
> 
> Things that I know that are out of KDE Accordance:
> - Translation System (uses Qt's tr() system)

This isn't an issue and we have other KDE projects using the tr() system. But 
if you want to port to ki18n, it's best to do it now since you don't seems to 
have any translations yet.

> - Settings System (it uses my own configuration parser that resembles QML)

Yeah probably best to use kconfigxt or make your configuration parser part of 
kconfigxt next gen ;)

> - Folder naming specification (follows the lakosian naming specification)

I don't think we have any folder (and file) naming specification in kde, or at 
least if we have one, it varies a lot between projects.

> - CI used is based on Gitlab, but fails on KDE

When trying to build it on my laptop it failed, due to the requirement of 
clang 16. This might also be an issue with the kde ci on tumbleweed.

> The current repository of Codevis is:
> https://invent.kde.org/tcanabrava/codevis
> 
> The KDE developers on this project are me, tarcisio fischer (that presented
> Codevis on Akademy), and Richard Dale.
> 
> Best regards,
> Tomaz



signature.asc
Description: This is a digitally signed message part.


Re: Review of Codevis (ie - Making Codevis a KDE Project)

2023-08-17 Thread Tomaz Canabrava
On Thu, 17 Aug 2023 at 18:29 Carl Schwan  wrote:

> On Thursday, August 17, 2023 11:18:24 AM CEST Tomaz Canabrava wrote:
> > Hello Fellow KDE Devs,
> >
> > I'm here, formally asking for a review of the Codevis project, to move
> > forward and make it a part of kdesdk.
>
> Very cool project, I was amazed by the presentation of it from tarcisio at
> Akademy.
>
> > Currently we are using parts of KWdigetsAddons as a submodule
> > Most things that are related to buildsystems will be moved to craft /
> > kdesrc-build as soon as possible, right now we rely in conan for windows
> > and mac, plus a hand-written build script that downloads and builds llvm
> > for those platforms.
> >
> > Things that I know that are out of KDE Accordance:
> > - Translation System (uses Qt's tr() system)
>
> This isn't an issue and we have other KDE projects using the tr() system.
> But
> if you want to port to ki18n, it's best to do it now since you don't seems
> to
> have any translations yet.
>
> > - Settings System (it uses my own configuration parser that resembles
> QML)
>
> Yeah probably best to use kconfigxt or make your configuration parser part
> of
> kconfigxt next gen ;)
>
> > - Folder naming specification (follows the lakosian naming specification)
>
> I don't think we have any folder (and file) naming specification in kde,
> or at
> least if we have one, it varies a lot between projects.
>
> > - CI used is based on Gitlab, but fails on KDE
>
> When trying to build it on my laptop it failed, due to the requirement of
> clang 16. This might also be an issue with the kde ci on tumbleweed.


Carl,

There’s no requirement for clang16 (I build with 15, tarcisio builds with
14, the previous ci had 13, I believe)

Mind if you share the build logs?

Best




>
> > The current repository of Codevis is:
> > https://invent.kde.org/tcanabrava/codevis
> >
> > The KDE developers on this project are me, tarcisio fischer (that
> presented
> > Codevis on Akademy), and Richard Dale.
> >
> > Best regards,
> > Tomaz
>
>


KDE Frameworks 5.109.0 released

2023-08-17 Thread David Faure
17th August 2023. KDE today announces the release of KDE Frameworks 5.109.0.

KDE Frameworks are 83 addon libraries to Qt which provide a wide
variety of commonly needed functionality in mature, peer reviewed and well
tested libraries with friendly licensing terms. For an introduction see
https://kde.org/products/frameworks/


Baloo

  Document uses and abuses of Baloo::IndexerConfig
  [BalooSearch] Add sort order option
  [Codecs] Make encode/decode methods static, cleanup
  [TermGeneratorTest] Extend phrase coverage
  [AdvancedQueryParserTest] Extend phrase coverage
  [SearchStore] Move private helpers to anonymous namespace
  [BasicIndexingJob] Ignore filename based mimetype for empty files (bug 420339)
  Reduce filesystem dependencies in more tests
  [DocumentUrlDbTest] Remove file system dependencies from test
  [DocumentUrlDb] Split document addition and file tree creation
  [Transaction] Use DocumentUrlDB::contains
  [DocumentUrlDB] Add `contains` method
  Remove proxy for obsolete org.kde.baloo interface
  [Transaction] Remove Transaction::exec convenience method

Extra CMake Modules

  KDEInstallDirs: fix description of KXMLGUIDIR & LOCALEDIR
  KDEGitCommitHooks: Allow passing in of custom scripts (bug 472361)
  qml-plasmoid techbase.kde.org/Projects/Plasma does not exist

KArchive

  Support reading file sizes from ZIP64 extended fields

KCoreAddons

  kurlmimedata: limit amount of in-flight FDs for portal submission (bug 472716)
  kurlmimedata: don't portal symlinks (bug 464225)
  KSignalHandler: possibility to register signal handler as early as possible

KCrash

  On windows, look for drkonqi.exe

KDESU

  SuProcess: Disable echo in the PTY before starting sudo (bug 452532)
  PtyProcess: Allow calling enableLocalEcho before PTY creation

KDE GUI Addons

  fix google-maps-geo-handler

KHolidays #

  Update Swedish holidays

KIconThemes

  Do not automatically set breeze as the fallback theme on Android

KImageFormats

  psd: Fix UB type punning
  Treat 3-channel MCH images as CMY images

KIO

  Use switcheroo-control to find discrete GPUs (bug 449106)
  file: preserve mode on put (bug 471539)
  KFileWidget: Use targetUrl to extract urls, better handle absolute urls cases 
(bug 459485)

Kirigami

  Change Instantiator to Repeater in NavigationTabBar (bug 467860)
  Avatar: Always use uppercase initials

KJS

  setitimer(, NULL, ) is not supported

KPackage Framework

  KPackageTool: Show deprecation warning when metadata.desktop file is used

KPeople

  QML plugin: use KPeople namespace meta object, instead of duplicating

KRunner

  runnerpython cgit.kde.org does not exist

KTextEditor

  completion: Fix only start chars of items are matched
  Fix chaotic up/down cursor movement in Block Selection Mode
  Fix backspace behavior for empty lines with cursor beyond line’s end (block 
selection mode)

Plasma Framework

  dataengine: do not emit removal signals while iterators are open (bug 446531)

QQC2StyleBridge

  Don't create Sonnet.Settings if not needed

Syntax Highlighting

  Hare language syntax highlighting

Security information

The released code has been GPG-signed using the following key:
pub rsa2048/58D0EE648A48B3BB 2016-09-05 David Faure 
Primary key fingerprint: 53E6 B47B 45CE A3E0 D5B7  4577 58D0 EE64 8A48 B3BB

https://kde.org/announcements/frameworks/5/5.109.0

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5


signature.asc
Description: This is a digitally signed message part.