[krita] [Bug 390299] Artifacts when opening a kra file with drop shadow in a group (Krita 4.0.0-beta1.1.appimage)

2018-02-16 Thread tkp
https://bugs.kde.org/show_bug.cgi?id=390299

tkp  changed:

   What|Removed |Added

 CC||k...@tokiop.com

--- Comment #3 from tkp  ---
Created attachment 110714
  --> https://bugs.kde.org/attachment.cgi?id=110714&action=edit
Kra file with drop shadow on group layer

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 390299] Artifacts when opening a kra file with drop shadow in a group (Krita 4.0.0-beta1.1.appimage)

2018-02-16 Thread tkp
https://bugs.kde.org/show_bug.cgi?id=390299

--- Comment #4 from tkp  ---
Indeed, thanks for the review and appimage !

Unfortunately it is not fixed on my side : you file opens correctly, but the
bug still seem to be here :

1. open bla.kra : no artifacts (neither in Krita 3.3.3)
2. put the drop shadow effect on Layer5 (group layer) instead of Layer3
3. save and re-open, artifacts are visible in both 3.3.3 and latest appimage

The attached modified bla2.kra file attached should show the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 398528] New: Transparent tiff file layer above fill layer makes it render black

2018-09-11 Thread tkp
https://bugs.kde.org/show_bug.cgi?id=398528

Bug ID: 398528
   Summary: Transparent tiff file layer above fill layer makes it
render black
   Product: krita
   Version: 4.1.1
  Platform: Debian testing
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Layer Stack
  Assignee: krita-bugs-n...@kde.org
  Reporter: k...@tokiop.com
  Target Milestone: ---

Created attachment 114911
  --> https://bugs.kde.org/attachment.cgi?id=114911&action=edit
Simple example tiff file layer makes fill layer render black

Hi !

while debugging a old 3.3 file which renders black, I came across a curious
minimal example.

Fill layers seem to render as black if there is a transparent tiff loaded as
file layer above it.

Can anyone reproduce with attached file ?

- open the file, it renders a violet fill above the transparent tiff
- move "File layer TIFF" above "Fill layer"
- save, close and reload file
- the violet fill is now rendered black

- move "File layer TIFF" under "Fill layer"
- save, close and reload file
- the violet fill is violet again

With the png file-layer, the behaviour does not seem to appear.

Thanks for this great software !

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 398528] Transparent tiff file layer above fill layer makes it render black

2018-09-12 Thread tkp
https://bugs.kde.org/show_bug.cgi?id=398528

--- Comment #2 from tkp  ---
Thanks for the test and clues ! Is a build not showing the issue available
somewhere or I should try to build from source ?

The issue is still visible in these nightly :

-
https://binary-factory.kde.org/job/Krita_Stable_Appimage_Build/lastSuccessfulBuild/artifact/krita-4.1.1-cdd99ca-x86_64.appimage

-
https://binary-factory.kde.org/job/Krita_Nightly_Appimage_Build/lastSuccessfulBuild/artifact/krita-4.2.0-pre-alpha-41c6768-x86_64.appimage

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 398528] Transparent tiff file layer above fill layer makes it render black

2018-09-12 Thread tkp
https://bugs.kde.org/show_bug.cgi?id=398528

--- Comment #6 from tkp  ---
Created attachment 114916
  --> https://bugs.kde.org/attachment.cgi?id=114916&action=edit
4.2.0-pre-alpha-41c6768-x86_64 capture displaying the issue

Strange, the issue seem to still be visible in
krita-4.2.0-pre-alpha-41c6768-x86_64.appimage on my side.

In my tests it is visible on all 4.x versions, not in 3.3.3.
The test file was created in 4.1.1.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 398528] Transparent tiff file layer above fill layer makes it render black

2018-09-13 Thread tkp
https://bugs.kde.org/show_bug.cgi?id=398528

--- Comment #7 from tkp  ---
Correction : krita-4.0.4-x86_64.appimage doesn't display the issue on my side.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 398740] New: Updating fileLayer path from script result in invalid path

2018-09-16 Thread tkp
https://bugs.kde.org/show_bug.cgi?id=398740

Bug ID: 398740
   Summary: Updating fileLayer path from script result in invalid
path
   Product: krita
   Version: 4.1.1
  Platform: Debian testing
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Scripting
  Assignee: krita-bugs-n...@kde.org
  Reporter: k...@tokiop.com
  Target Milestone: ---

Created attachment 115026
  --> https://bugs.kde.org/attachment.cgi?id=115026&action=edit
file layers setProperties test files

Hi,


1. Original potential bug using 4.0.4
-

fileLayer.setProperties() seem to prepend the old filename without extension
before the new path.

  # display nodes current path :
  print("node path : ",node.path())
  # node path :
/home/user/file-layers-setProperties/file-layers/file-layer-1.png

  # update file layer path :
  node.setProperties(node.path().replace("file-layer-1", "file-layer-2"),
"None")
  print("node path : ",node.path())
  # node path : 
file-layer-1/../file-layers-setProperties/file-layers/file-layer-2.png

  # Expected : file-layers/file-layer-2.png
  #   or :
/home/user/file-layers-setProperties/file-layers/file-layer-2.png


2. Evolution using krita 4.1.1 (error message)
--

Was using a trick based on previous observations to update the path using 4.0.4
(see attached script/file), but Krita 4.1.1 now displays an additional error :

  Krita has encountered an internal error:
  SAFE ASSERT (krita): "QFile::exists(path())" in file
/home/appimage/workspace/Krita_Stable_Appimage_Build/krita/libs/ui/kis_file_layer.cpp,
line 80
  Please report a bug to developers!

  Press Ignore to try to continue.
  Press Abort to see developers information (all unsaved data will be lost)

In the attached zip, a test file, test script and dummy filelayers. Using
4.0.4, no error message is displayed. On both versions, the layer is updated
after save/reload.

To reproduce on my setup :

1. Open filelayer-setProperties-411.kra
2. Tools > Scripting > Scripter : run test.py
3. should print explanation about the trick and update the path
4. create-delete an empty layer if krita didn't detect the edit
5. save file : Krita displays an error message, click "Ignore"
6. close and re-open the file : the layer should be updated (red)

- tested not using the trick under 4.1.1 but the setProperties behaviour is the
same as in 4.0.4
- tested placing the fileLayer source files next to the .kra vs in a subfolder,
but doesn't seem to help


Am I misusing the method / arguments ?
Anyone able to reproduce ?

Bonus question : is there an function to force-reload a fileLayer source file
from python ? For now it seem required to save/close/reopen to display the new
one.


Thanks for any clues, have a nice day !

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 398740] Updating fileLayer path from script result in invalid path

2018-09-17 Thread tkp
https://bugs.kde.org/show_bug.cgi?id=398740

--- Comment #4 from tkp  ---
Hi Dmitry,

thanks a lot for your quick fix and advice, will check with the nightly build
tomorrow !

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 398740] Updating fileLayer path from script result in invalid path

2018-09-17 Thread tkp
https://bugs.kde.org/show_bug.cgi?id=398740

--- Comment #5 from tkp  ---
It is fixed on my system too, and after using setProperties the file layer
image is automatically reloaded. Awesome ! Thanks again Dmitry !

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 398788] New: Layer Style projection plane Error on save

2018-09-18 Thread tkp
https://bugs.kde.org/show_bug.cgi?id=398788

Bug ID: 398788
   Summary: Layer Style projection plane Error on save
   Product: krita
   Version: nightly build (please specify the git hash!)
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: layer styles
  Assignee: krita-bugs-n...@kde.org
  Reporter: k...@tokiop.com
  Target Milestone: ---

Created attachment 115063
  --> https://bugs.kde.org/attachment.cgi?id=115063&action=edit
Simplified file triggering the error

Hi,

using Krita nightly-8ec26ec, saving an old file created with Krita 3.3 triggers
this error on save :

  Krita has encountered an internal error:
  SAFE ASSERT (krita): "rhs.m_d->layerStyleProjectionPlane" in file
/home/appimage/workspace/Krita_Nightly_Appimage_Build/krita/libs/image/kis_layer.cc,
line 265
  Please report a bug to developers!

  Press Ignore to try to continue.
  Press Abort to see developers information (all unsaved data will be lost)

Could not re-create a problematic file with latest Krita. The attached file is
a simplified version of the original 3.3 file.

As the message suggest, it seems to be linked to layer styles :
- all the error seem triggered by group layers with no styles
- those which had a style but disabled don't seem to trigger
- creating a new group layer with no style don't trigger the error
- enabling layer style + a style, and then disabling, seem to "cure" a
problematic layer

So indeed it looks like these group layers have problematic data in their
style.

Not sure if retro-compatibility with 3.3 files is a goal, and it's easy to
"repair" a file, but maybe something worth a check anyway ?

Have a nice day !

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 398788] Layer Style projection plane Error on save

2018-09-18 Thread tkp
https://bugs.kde.org/show_bug.cgi?id=398788

--- Comment #3 from tkp  ---
Fix confirmed, thanks Dmitry, a present in each daily ! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 398528] Transparent tiff file layer above fill layer makes it render black

2018-09-26 Thread tkp
https://bugs.kde.org/show_bug.cgi?id=398528

--- Comment #8 from tkp  ---
Issue is still present for me using latest nightly
(krita-4.2.0-pre-alpha-e94e365-x86_64.appimage).

I use the following script as a workaround to fix the layers after opening :

def resetFillLayers(parent):
  for node in parent.childNodes():
if node.type() == "filllayer":
node.setGenerator(node.generatorName(), node.filterConfig())
resetFillLayers(node)

resetFillLayers(Krita.instance().activeDocument().rootNode())

-- 
You are receiving this mail because:
You are watching all bug changes.