[konsole] [Bug 364779] konsole becomes unresponsive when creating a new tab with removed directory

2016-08-13 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364779

--- Comment #5 from Thiago Macieira  ---
It's not forkfd. That has nothing to do with directories. The backtrace doesn't
even show it.

Can anyone show me what the child process is doing? A backtrace would help, but
an strace even more.

-- 
You are receiving this mail because:
You are watching all bug changes.


[konsole] [Bug 364779] konsole becomes unresponsive when creating a new tab with removed directory

2016-08-13 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364779

--- Comment #6 from Thiago Macieira  ---
I see the forkfd_wait now. Since I can't see anything obviously wrong with the
QProcess code either, I'm going to guess this is caused by the process failing
to start too quickly.

But there's a unit for QProcess for this exact condition and it's passing.

-- 
You are receiving this mail because:
You are watching all bug changes.


[konsole] [Bug 364779] konsole becomes unresponsive when creating a new tab with removed directory

2016-08-13 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364779

--- Comment #7 from Thiago Macieira  ---
Ok, I could reproduce this locally and I've got an strace:

This is forkfd creating the child process:
115218 clone(child_stack=NULL,
flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD,
child_tidptr=0x7fd10015bc10) = 115247
115247 set_robust_list(0x7fd10015bc20, 24 
115218 write(28, "*\0\0\0\0\0\0\0", 8 
115247 <... set_robust_list resumed> )  = 0
115218 <... write resumed> )= 8
115218 close(28)= 0
115247 read(28, "*\0\0\0\0\0\0\0", 8)   = 8

The sequence of reads and writes synchronise parent and child, so we're sure
that the entries in the forkfd global is fine.

The child process exits and the parent reads the error message from chdir:
115247 exit_group(-1)   = ?
115218 write(6, "\1\0\0\0\0\0\0\0", 8)  = 8
115218 pselect6(25, [24], NULL, NULL, {30, 0}, {NULL, 8}) = 1 (in [24], left
{29, 93180})
115218 write(6, "\1\0\0\0\0\0\0\0", 8)  = 8
115218 read(24, "N\0o\0 \0s\0u\0c\0h\0 \0f\0i\0l\0e\0 \0o\0r\0 \0"..., 1024) =
50
115218 write(6, "\1\0\0\0\0\0\0\0", 8)  = 8
115218 close(24)= 0

Note how you can tell which version of Qt this is from the strace :-)

The code above is in QProcess (QProcessPrivate::_q_startupNotification and
QProcessPrivate::processStarted). As a result, the QProcess change state to
QProcess::NotRunning and emits error() with QProcess::FailedToStart.

Immediately after this, something weird happens:
115218 rt_sigaction(SIGCHLD, {SIG_DFL, [], SA_RESTORER|SA_RESTART,
0x7fd0ffa019f0}, {0x7fd0fbfac190, [], SA_RESTORER|SA_NOCLDSTOP,
0x7fd0ffa019f0}, 8) = 0
115218 clone( 
115247 +++ exited with 255 +++
115218 <... clone resumed> child_stack=NULL,
flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD,
child_tidptr=0x7fd10015bc10) = ? ERESTARTNOINTR (To be restarted)
115218 --- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED, si_pid=115247,
si_uid=1000, si_status=255, si_utime=0, si_stime=0} ---
115218 clone(child_stack=NULL,
flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD,
child_tidptr=0x7fd10015bc10) = 115249
115249 set_robust_list(0x7fd10015bc20, 24) = 0
115218 wait4(115249,  
115249 dup2(13, 0)  = 0
115249 dup2(13, 1)  = 1
115249 execve("/usr/lib/utempter/utempter", ["/usr/lib/utempter/utempter",
"del"], [/* 119 vars */]) = 0

The parent process replaces the SIGCHLD handler: I can tell it's not forkfd
because it's missing the SA_NOCLDSTOP flag. Immediately thereafter, the child
process that failed to chdir() exits and its SIGCHLD is notified. But forkfd's
signal handler was never called, so it never writes to the pipe.

The bug is not in forkfd. It's in konsole for replacing the signal handler at
the most inopportune moment. sigaction() is NOT async-signal-safe. DO NOT call
it if there's a chance that the signal you're looking for will be delivered at
that exact time.

After all of this happens, utempter exits and the signal handler is restored:
115249 exit_group(1)= ?
115249 +++ exited with 1 +++
115218 <... wait4 resumed> [{WIFEXITED(s) && WEXITSTATUS(s) == 1}], 0, NULL) =
115249
115218 --- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED, si_pid=115249,
si_uid=1000, si_status=1, si_utime=0, si_stime=0} ---
115218 rt_sigaction(SIGCHLD, {0x7fd0fbfac190, [], SA_RESTORER|SA_NOCLDSTOP,
0x7fd0ffa019f0}, NULL, 8) = 0
115218 read(26,  

Note the presence of SA_NOCLDSTOP. That read() never returns, so it's the same
as the backtrace, stuck inside QProcessPrivate::waitForDeadChild. Conclusion:
starting utempter was done as a response to QProcess changing state or emitting
the error() signal. It's not a thread issue, it's just Konsole doing the one
thing that it shouldn't have done in response to a failure to start: replace
the SIGCHLD handler.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 323273] Address completion in the composer scrolls back to top when new results come in

2016-09-24 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=323273

Thiago Macieira  changed:

   What|Removed |Added

 Status|NEEDSINFO   |CONFIRMED
 Ever confirmed|0   |1
 Resolution|WAITINGFORINFO  |---

--- Comment #2 from Thiago Macieira  ---
Confirming it on KMail 5.3.0, Frameworks 5.26.0, Qt 5.6.1, on OpenSUSE
Tumbleweed.

As late as last week, I sent an email to someone who wasn't the intended target
because the list populated someone else's address where I had selected.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 95733] KMail should always encode as base64 any non text/* and non message/* MIME part

2016-09-24 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=95733

Thiago Macieira  changed:

   What|Removed |Added

 CC||thi...@kde.org
 Status|NEEDSINFO   |CONFIRMED
 Resolution|WAITINGFORINFO  |---

--- Comment #25 from Thiago Macieira  ---
Changing back to Confirmed, as this can still be reproduced with KMail 5.3,
Frameworks 5.26. I've just sent myself an email with the PDF from attachment
8788 and the sent email had:

--nextPart1803533.O5pIifQRu1
Content-Disposition: attachment; filename="kmailtest-full.pdf"
Content-Transfer-Encoding: quoted-printable
Content-Type: application/pdf; name="kmailtest-full.pdf"

So it did detect as application/pdf (not text/*) and still sent as quoted
printable.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 290317] KMail sometimes shows only a spinning wheel for a folder, no contents

2016-09-24 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=290317

--- Comment #7 from Thiago Macieira  ---
Not reopening, there is a similar bug but it has different behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 264274] Next Unread (+) sometimes doesn't unselect previous email

2016-09-24 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=264274

Thiago Macieira  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |CONFIRMED

--- Comment #2 from Thiago Macieira  ---
Still happens, KMail 5.3, Frameworks 5.26.

-- 
You are receiving this mail because:
You are watching all bug changes.


[Akonadi] [Bug 260007] Many D-Bus signals emitted whenever mailbox content or state changes

2016-09-24 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=260007

Thiago Macieira  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WORKSFORME

--- Comment #3 from Thiago Macieira  ---
Problem seems to be fone

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kded] [Bug 360408] Another deadlock with Qt 5.6 git

2016-03-11 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=360408

--- Comment #3 from Thiago Macieira  ---
Might be https://bugreports.qt.io/browse/QTBUG-51676

-- 
You are receiving this mail because:
You are watching all bug changes.


[KScreen] [Bug 354437] [regression/4] KScreen does not remember multiple monitor configuration

2015-12-22 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354437

--- Comment #3 from Thiago Macieira  ---
(In reply to Martin Kostolný from comment #2)
> I think this is fixed for Plasma 5.5.1, KF 5.17.
> @Thiago Macieira: can you confirm that?

Will answer when 5.5.1 drops in OpenSUSE Tumbleweed (currently 5.4.3).

-- 
You are receiving this mail because:
You are watching all bug changes.

[KScreen] [Bug 354437] [regression/4] KScreen does not remember multiple monitor configuration

2015-12-23 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354437

--- Comment #6 from Thiago Macieira  ---
(In reply to Maciej Mrozowski from comment #4)
> Remember multi-monitor config is minor problem here, detecting screens
> whenever they change is more pressing. kscreen somewhat cannot catch up with
> output device hot-plug events. I noticed runnig 'xrandr' tool (without
> arguments, just in console) actally triggers kscreen to get notified about
> monitors being reconnected (otherwise hot-plug events seem to be ignored in
> my case). I heard someone blaming Qt for that..

That used to happen with KDE 4 kscreen too and is not its fault. Running xrandr
without arguments causes the video driver (i915, usually) to re-scan the
outputs and thus find that you've connected something. It shouldn't be and
isn't needed. It's not kscreen's fault and it should not cause frequent
polling.

-- 
You are receiving this mail because:
You are watching all bug changes.


[KScreen] [Bug 357392] Attaching of 2nd monitor not detected

2016-04-25 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357392

Thiago Macieira  changed:

   What|Removed |Added

 CC||thi...@kde.org

--- Comment #1 from Thiago Macieira  ---
Cannot confirm. KScreen always detects the new monitor (Intel GPU).

-- 
You are receiving this mail because:
You are watching all bug changes.


[KScreen] [Bug 357611] kscreen floods .xsession-errors with messages

2016-04-25 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357611

Thiago Macieira  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||thi...@kde.org

--- Comment #5 from Thiago Macieira  ---
Confirmed.

-- 
You are receiving this mail because:
You are watching all bug changes.


[KScreen] [Bug 354437] [regression/4] KScreen does not remember multiple monitor configuration

2016-04-25 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354437

--- Comment #11 from Thiago Macieira  ---
Repeating: kscreen remembers the configuration but fails to apply it

[338791.653] kded5(1707 1707): kscreen: starting external backend launcher for
""
[338791.721] kded5(1707 1707): kscreen.kded:resetDisplaySwitch()
[338791.721] kded5(1707 1707): kscreen.kded:outputConnectedChanged():
"HDMI1"
[338791.721] kded5(1707 1707): kscreen.kded:Calculating config ID for
KScreen::Config(0x194cfc0)
[338791.721] kded5(1707 1707): kscreen.kded:Part of the Id: 
"8f1a4a6b5eec2d11cb59060b47b3610a"
[338791.721] kded5(1707 1707): kscreen.kded:Part of the Id: 
"181be8d8ae9f70f1d85e8defd31b0fe6"
[338791.721] kded5(1707 1707): kscreen.kded:Config ID:
"bfb8a9b9e97ddc88f50a9be628232c7e"
[338791.721] kded5(1707 1707): kscreen.kded:Change detected
[338791.732] kded5(1707 1707): kscreen.kded:Applying config
[338791.732] kded5(1707 1707): kscreen.kded:Calculating config ID for
KScreen::Config(0x194cfc0)
[338791.732] kded5(1707 1707): kscreen.kded:Part of the Id: 
"8f1a4a6b5eec2d11cb59060b47b3610a"
[338791.732] kded5(1707 1707): kscreen.kded:Part of the Id: 
"181be8d8ae9f70f1d85e8defd31b0fe6"
[338791.732] kded5(1707 1707): kscreen.kded:Config ID:
"bfb8a9b9e97ddc88f50a9be628232c7e"
[338791.732] kded5(1707 1707): kscreen.kded:Calculating config ID for
KScreen::Config(0x194cfc0)
[338791.732] kded5(1707 1707): kscreen.kded:Part of the Id: 
"8f1a4a6b5eec2d11cb59060b47b3610a"
[338791.732] kded5(1707 1707): kscreen.kded:Part of the Id: 
"181be8d8ae9f70f1d85e8defd31b0fe6"
[338791.732] kded5(1707 1707): kscreen.kded:Config ID:
"bfb8a9b9e97ddc88f50a9be628232c7e"
[338791.732] kded5(1707 1707): kscreen.kded:Applying known config
"bfb8a9b9e97ddc88f50a9be628232c7e"
[338791.732] kded5(1707 1707): kscreen.kded:Finding a mode for QSize(1920,
1080) @ 60.001
[338791.732] kded5(1707 1707): kscreen.kded:Found:  "72"  
QSize(1920, 1080) @ 60.001
[338791.733] kded5(1707 1707): kscreen.kded:Finding a mode for QSize(1920,
1080) @ 60
[338791.733] kded5(1707 1707): kscreen.kded:Found:  "384"  
QSize(1920, 1080) @ 60
[338791.733] kded5(1707 1707): kscreen.kded:doApplyConfig()
[338791.733] kded5(1707 1707): kscreen.kded:Monitor for changes:  false

It says it applied the config, but the screen configuration did not change.

-- 
You are receiving this mail because:
You are watching all bug changes.


[KScreen] [Bug 357392] Attaching of 2nd monitor not detected

2016-04-25 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357392

--- Comment #3 from Thiago Macieira  ---
kscreen 5.6.2, but same with older versions.

-- 
You are receiving this mail because:
You are watching all bug changes.


[KScreen] [Bug 357611] kscreen floods .xsession-errors with messages

2016-04-25 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357611

--- Comment #7 from Thiago Macieira  ---
5.6.2 here and it's still producing debugging output.

-- 
You are receiving this mail because:
You are watching all bug changes.


[KScreen] [Bug 354437] [regression/4] KScreen does not remember multiple monitor configuration

2016-04-26 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354437

--- Comment #12 from Thiago Macieira  ---
Actually, I just noticed that I misdiagnosed the problem.

The problem is that kscreen5 keeps a single configuration file for both my 45"
Samsung TV and my 23" Samsung monitor. The kded4 module was able to tell the
difference.

-- 
You are receiving this mail because:
You are watching all bug changes.


[KScreen] [Bug 357611] kscreen floods .xsession-errors with messages

2016-05-04 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357611

--- Comment #9 from Thiago Macieira  ---
There are still a lot of messages, but nowhere as many as before. I don't think
I should call this a flood anymore.

Messages are like:

[   312.010] kded5(1693 1693): kscreen: starting external backend launcher for
""
[   312.011] plasmashell(1748 1748): kscreen:   starting external backend
launcher for ""
[   312.013] kwin(1728 1728):   QXcbConnection: XCB error: 3 (BadWindow),
sequence: 63480, resource id: 20971528, major code: 18 (ChangeProperty), minor
code: 0
[   312.024] kded5(1693 1693): kscreen.kded:Change detected
[   312.310] kded5(1693 1693): kscreen.kded:Saving current config to file
[   312.310] kded5(1693 1693): kscreen.kded:Calculating config ID for
KScreen::Config(0x26b1740)
[   312.310] kded5(1693 1693): kscreen.kded:Part of the Id: 
"8f1a4a6b5eec2d11cb59060b47b3610a"
[   312.310] kded5(1693 1693): kscreen.kded:Config ID:
"b0002e5da0363ca4c838e70f9a3faa6c"
[   312.310] kded5(1693 1693): kscreen.kded:Config saved on: 
"/home/thiago/.local/share/kscreen/b0002e5da0363ca4c838e70f9a3faa6c"

It happens in bursts. It might be due to a faulty connection...

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 356950] [Regression][15.12.0] Empty message when viewing encrypted message in preview pane without auto-decrypt.

2016-02-24 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356950

Thiago Macieira  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||thi...@kde.org
 Ever confirmed|0   |1

--- Comment #3 from Thiago Macieira  ---
Confirming (reproducible in kmail 5.1.1).

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 356950] [Regression][15.12.0] Empty message when viewing encrypted message in preview pane without auto-decrypt.

2016-02-26 Thread Thiago Macieira via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356950

Thiago Macieira  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Thiago Macieira  ---
Confirmed fixed in KMail 5.1.2

-- 
You are receiving this mail because:
You are watching all bug changes.