[kdevelop] [Bug 435235] When pasting file using Projects tool view, "File Already Exists" window cannot be interacted with

2022-02-23 Thread Igor Grkavac
https://bugs.kde.org/show_bug.cgi?id=435235

Igor Grkavac  changed:

   What|Removed |Added

 CC||grkavac.i...@gmail.com

--- Comment #5 from Igor Grkavac  ---
Hi all,

The issue is happening due to the blocking calls of KJobs exec() functions that
are called every time a Cut/Copy/Paste function is called. 
The explanation for this behavior can be seen here:
https://invent.kde.org/frameworks/kcoreaddons/-/blob/master/src/lib/jobs/kjob.h#L268

The complete solution would be to abandon synchronous calls and connect signals
and slots that wait for the Paste process to finish.

I managed to create a working solution for Cut action just to confirm it is
doable, however, there is still a lot of refactoring left as a lot of different
parts must be changed (ProjectManagerViewPlugin, CutCopyPasteHelper,
AbstractFileManagerPlugin, ...) so, if anyone starts working on this, they will
probably have a lot of code to write/change.

I will continue on this work and if any maintainer confirms this is a good
strategy I will create a PR when I'm done.

Kind regards,
Igor Grkavac

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 445872] kde default template for kirigami app (c++) throws errors at opening of project

2022-02-25 Thread Igor Grkavac
https://bugs.kde.org/show_bug.cgi?id=445872

Igor Grkavac  changed:

   What|Removed |Added

 CC||grkavac.i...@gmail.com

--- Comment #4 from Igor Grkavac  ---
Hi,

Did You manage to build the app after that errors?

You didn't specify the KDevelop version You are using. I tested on 5.7.211202
and I don't get these errors. I get an error that "testappconfig.h" is missing
but after building, the error disappears.

Can You build the Kirigami default app from the terminal, or from KDevelop?

Kind regards

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 373440] konsole --new-tab opens window instead

2021-07-20 Thread Igor Grkavac
https://bugs.kde.org/show_bug.cgi?id=373440

Igor Grkavac  changed:

   What|Removed |Added

 CC||grkavac.i...@gmail.com

--- Comment #45 from Igor Grkavac  ---
Hello,

I checked this issue and I think it can be divided into 2 parts:

1. The first problem seems to be this line (which ironically says "Don't
touch"):

https://invent.kde.org/utilities/konsole/-/blob/fb69c183c672dff1d8e5e95d187622980255827c/src/main.cpp#L146

As it is preventing using a single process if 'multiple' is selected in
options.

Removing Konsole::KonsoleSettings::useSingleInstance() should be enough.

2. The second problem is that this is working only if konsole is launched with
"--new-tab". If konsole is launched with no arguments, calling "konsole
--new-tab" from within will open a new window. If "konsole --new-tab" is
launched first, every additional "konsole --new-tab" will open a new tab. I am
still not sure why is this happening.

However, there is another thing that I noticed:

A new tab is opened only on the initial konsole. So, if you open a konsole and
run --new-tab a few times and open additional konsole, doing "konsole
--new-tab" will add a tab to the previous konsole, not the current one.

I guess that it is another issue due to a workaround that is just looking for
the first non-nullptr window, but that should be checked on another ticket.

I will update if I find anything regarding the second problem why it is
happening.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 373440] konsole --new-tab opens window instead

2021-07-29 Thread Igor Grkavac
https://bugs.kde.org/show_bug.cgi?id=373440

--- Comment #46 from Igor Grkavac  ---
Hello,

After pulling the latest commits on master, I can confirm that removing 

Konsole::KonsoleSettings::useSingleInstance()

that I mentioned in my previous comment, I can get a new tab inside the same
window on the first start. 

Can anyone from the commiters on the "DON'T TOUCH" part of the code:

https://invent.kde.org/utilities/konsole/-/blob/fb69c183c672dff1d8e5e95d187622980255827c/src/main.cpp#L146

confirm the usage as I am not familiar with why is that checked along with the
problematic options that enforce to create a new process? 

If the useSingleInstance cannot be deleted, then it would need an additional
flag just for the "--new-tab" option that will force a single process, not
checking if useSingleInstance is enabled or not.

Hope someone can help with this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 419654] Arrow keys do not work in default windows switcher

2020-08-13 Thread Igor Grkavac
https://bugs.kde.org/show_bug.cgi?id=419654

Igor Grkavac  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/kwin/commit/3450adf5d122
   ||5bc82a3cec6f759fcb9469038b9
   ||0
 Resolution|--- |FIXED

--- Comment #5 from Igor Grkavac  ---
Git commit 3450adf5d1225bc82a3cec6f759fcb9469038b90 by Igor Grkavac.
Committed on 12/08/2020 at 17:56.
Pushed by davidedmundson into branch 'master'.

[tabbox] Fix for Window Switcher

Loop thought the list of modes twice to complete the logic.

M  +1-1tabbox/tabbox.cpp

https://invent.kde.org/plasma/kwin/commit/3450adf5d1225bc82a3cec6f759fcb9469038b90

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 448251] KDevelop runs make with wrong number of jobs

2022-01-13 Thread Igor Grkavac
https://bugs.kde.org/show_bug.cgi?id=448251

Igor Grkavac  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
   Version Fixed In||5.8.220400
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/kdev
   ||elop/kdevelop/commit/9d2ee1
   ||99b78376a0066d99e5802465ca7
   ||153e482

--- Comment #2 from Igor Grkavac  ---
Git commit 9d2ee199b78376a0066d99e5802465ca7153e482 by Igor Grkavac.
Committed on 12/01/2022 at 17:12.
Pushed by igorkushnir into branch 'master'.

makebuilder: Change default number of jobs from 2 to 1

Default NumberOfJobs in makejob.cpp (1) and makebuilderconfig.kcfg (2)
is different. Kdevelop already tries to find the optimal number of threads
if NumberOfJobs field is not overridden. The current default makes
it impossible to override a number of jobs to 2 as NumberOfJobs will
switch to 1 due to makejob.cpp.
FIXED-IN: 5.8.220400

M  +1-1plugins/makebuilder/makebuilderconfig.kcfg

https://invent.kde.org/kdevelop/kdevelop/commit/9d2ee199b78376a0066d99e5802465ca7153e482

-- 
You are receiving this mail because:
You are watching all bug changes.