[Haruna] [Bug 466803] New: Haruna doesn't open .TS videos on startup

2023-03-03 Thread Arthur Kasimov
https://bugs.kde.org/show_bug.cgi?id=466803

Bug ID: 466803
   Summary: Haruna doesn't open .TS videos on startup
Classification: Applications
   Product: Haruna
   Version: 0.10.3
  Platform: Archlinux
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: generic
  Assignee: georgefb...@gmail.com
  Reporter: kodemeis...@outlook.com
  Target Milestone: ---

SUMMARY
Haruna doesn't play any .TS videos if I open them from a file manager or supply
them via command line. No picture, no sound. It basically acts as if no videos
were opened at all. However, it does play .TS files well when I use "Open File"
from the app itself.

STEPS TO REPRODUCE
1. Download any .TS file, e.g. from https://filesamples.com/formats/ts
2. Try to open the downloaded file via command line: haruna
~/Videos/sample_1280x720_surfing_with_audio.ts

OBSERVED RESULT
Video is not loaded and played.

EXPECTED RESULT
Playback should start upon startup.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux / KDE Plasma on X11
KDE Plasma Version: 5.27.2
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
This doesn't seem to be related to https://bugs.kde.org/show_bug.cgi?id=464963
I tried different filenames without fancy characters - no luck. The latest
version from master also has the same issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Haruna] [Bug 456482] hardware decoding doesn't work

2023-03-03 Thread Arthur Kasimov
https://bugs.kde.org/show_bug.cgi?id=456482

Arthur Kasimov  changed:

   What|Removed |Added

 CC||kodemeis...@outlook.com

--- Comment #16 from Arthur Kasimov  ---
Just wanted to note that QT_XCB_GL_INTEGRATION="xcb_egl" works perfectly for me
on discrete graphics (AMD Radeon RX 6700 XT). Without this variable, Haruna
falls back to suboptimal "vaapi-copy" driver instead of proper "vaapi".

-- 
You are receiving this mail because:
You are watching all bug changes.

[Haruna] [Bug 485720] Freezes completely when opening a video

2024-04-18 Thread Arthur Kasimov
https://bugs.kde.org/show_bug.cgi?id=485720

Arthur Kasimov  changed:

   What|Removed |Added

 CC||kodemeis...@outlook.com

--- Comment #1 from Arthur Kasimov  ---
I have the same issue. After updating to MPV 0.38 all videos are played in a
separate MPV window that appears above the main Haruna window. It seems like
QML <=> MPV integration is broken. Downgrading to MPV 0.37 fixes the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 417326] The cursor is drawn one pixel off its expected Y-coordinate

2020-11-04 Thread Arthur Kasimov
https://bugs.kde.org/show_bug.cgi?id=417326

--- Comment #7 from Arthur Kasimov  ---
Hi Justin, I can still reproduce the issue using the latest git master. It is
not very noticeable though. There is just 1-pixel gap after all, so I used to
live with it :)

Looking at the code, character classes were recently moved to new
terminalDisplay directory. Nevertheless, the cursor adjustment code that
produces a gap is still there - in TerminalPainter::drawCursor.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 417326] New: The cursor is drawn one pixel off its expected Y-coordinate

2020-02-09 Thread Arthur Kasimov
https://bugs.kde.org/show_bug.cgi?id=417326

Bug ID: 417326
   Summary: The cursor is drawn one pixel off its expected
Y-coordinate
   Product: konsole
   Version: master
  Platform: Archlinux Packages
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: konsole-de...@kde.org
  Reporter: kodemeis...@outlook.com
  Target Milestone: ---

Created attachment 125775
  --> https://bugs.kde.org/attachment.cgi?id=125775&action=edit
Screenshot of gap 1

When Konsole draws the cursor, it always shifts down cursor Y position by one
pixel. Usually it is not noticeable but in some applications, e.g. Vim, it
produces an annoying gap on highlighted background.

For example, when you search a text in Vim, it highlights all occurrences of
that text in a file. When you place the cursor over the highlighted text, a
small but noticeable gap appears. Another example is highlighting of matching
parentheses which reveals the same gap. Please check the attached screenshots.

The adjustment of cursor position is located in TerminalDisplay::drawCursor:

// shift rectangle top down one pixel to leave some space
// between top and bottom
QRectF cursorRect = rect.adjusted(0, 1, 0, 0);

Not sure whether this adjustment is still useful for some purposes or not. 
Shouldn't we simply remove it?

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 417326] The cursor is drawn one pixel off its expected Y-coordinate

2020-02-09 Thread Arthur Kasimov
https://bugs.kde.org/show_bug.cgi?id=417326

--- Comment #1 from Arthur Kasimov  ---
Created attachment 125776
  --> https://bugs.kde.org/attachment.cgi?id=125776&action=edit
Screenshot of gap 2

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 417326] The cursor is drawn one pixel off its expected Y-coordinate

2020-02-09 Thread Arthur Kasimov
https://bugs.kde.org/show_bug.cgi?id=417326

--- Comment #2 from Arthur Kasimov  ---
Created attachment 125777
  --> https://bugs.kde.org/attachment.cgi?id=125777&action=edit
Remove adjustment of the cursor rectangle to avoid unwanted gaps

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 417326] The cursor is drawn one pixel off its expected Y-coordinate

2020-02-10 Thread Arthur Kasimov
https://bugs.kde.org/show_bug.cgi?id=417326

--- Comment #4 from Arthur Kasimov  ---
Indeed, the comment to the code says it is intentional but the result looks
buggy. In most other terminal emulators the cursor height is the same as line
height without any gaps.

I checked further and seems like this code was added while fixing another bug
https://bugs.kde.org/show_bug.cgi?id=343283

The last commenter also wonders why the cursor is shifted down by one pixel.
Seems like it was just an arbitrary choice without a clear reason. I believe it
would be better to remove the gap and draw the cursor just like other terminal
emulators do.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 407915] The "Custom character color" option is required in "Cursor" tab

2020-02-11 Thread Arthur Kasimov
https://bugs.kde.org/show_bug.cgi?id=407915

Arthur Kasimov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/kde/
   ||konsole/commit/a7f23d216e80
   ||20020e9061b058a44d48b39f9f0
   ||8
   Version Fixed In||20.04
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from Arthur Kasimov  ---
Git commit a7f23d216e8020020e9061b058a44d48b39f9f08 by Arthur Kasimov.
Committed on 10/02/2020 at 20:57.
Pushed by hindenburg into branch 'master'.

Add an option to set the custom color of text under the cursor

Current version of Konsole allows to select the custom color of the
cursor (Settings -> Edit Current Profile -> Appearance -> Cursor ->
Custom cursor color). This works well for I-Beam and Underline cursor
shapes. But for block-shaped cursors the text under the cursor is often
hard to read, e.g. bright text under the bright cursor or dark text
under the dark cursor.

This patch adds an ability to select the custom color of the character
under the cursor. The character uses this color only when the cursor
shape is Block and Konsole window is focused. Otherwise the character
uses its foreground color as usual.
FIXED-IN: 20.04

M  +72   -31   src/EditProfileAppearancePage.ui
M  +11   -6src/EditProfileDialog.cpp
M  +1-0src/EditProfileDialog.h
M  +3-1src/Profile.cpp
M  +12   -1src/Profile.h
M  +23   -17   src/TerminalDisplay.cpp
M  +21   -2src/TerminalDisplay.h
M  +2-0src/autotests/ProfileTest.cpp

https://invent.kde.org/kde/konsole/commit/a7f23d216e8020020e9061b058a44d48b39f9f08

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 407915] The "Custom character color" option is required in "Cursor" tab

2020-02-11 Thread Arthur Kasimov
https://bugs.kde.org/show_bug.cgi?id=407915

Arthur Kasimov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://commits.kde.org/kon
   |konsole/commit/a7f23d216e80 |sole/a7f23d216e8020020e9061
   |20020e9061b058a44d48b39f9f0 |b058a44d48b39f9f08
   |8   |

--- Comment #4 from Arthur Kasimov  ---
Git commit a7f23d216e8020020e9061b058a44d48b39f9f08 by Arthur Kasimov.
Committed on 10/02/2020 at 20:57.
Pushed by scmsync into branch 'master'.

Add an option to set the custom color of text under the cursor

Current version of Konsole allows to select the custom color of the
cursor (Settings -> Edit Current Profile -> Appearance -> Cursor ->
Custom cursor color). This works well for I-Beam and Underline cursor
shapes. But for block-shaped cursors the text under the cursor is often
hard to read, e.g. bright text under the bright cursor or dark text
under the dark cursor.

This patch adds an ability to select the custom color of the character
under the cursor. The character uses this color only when the cursor
shape is Block and Konsole window is focused. Otherwise the character
uses its foreground color as usual.
FIXED-IN: 20.04

M  +72   -31   src/EditProfileAppearancePage.ui
M  +11   -6src/EditProfileDialog.cpp
M  +1-0src/EditProfileDialog.h
M  +3-1src/Profile.cpp
M  +12   -1src/Profile.h
M  +23   -17   src/TerminalDisplay.cpp
M  +21   -2src/TerminalDisplay.h
M  +2-0src/autotests/ProfileTest.cpp

https://commits.kde.org/konsole/a7f23d216e8020020e9061b058a44d48b39f9f08

-- 
You are receiving this mail because:
You are watching all bug changes.