[frameworks-kio] [Bug 385492] Dolphin and KIO confirmation settings are not in sync

2018-07-09 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=385492

Алексей Шилин  changed:

   What|Removed |Added

 CC||kdelibs-b...@kde.org
   Assignee|dolphin-bugs-n...@kde.org   |fa...@kde.org
Version|17.08.1 |unspecified
  Component|general |general
Product|dolphin |frameworks-kio

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 385492] Dolphin and KIO confirmation settings are not in sync

2018-07-09 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=385492

Алексей Шилин  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||5.48
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kio
   ||/7d15dad5e427132758db178e45
   ||a6e4b7b5daeb0f

--- Comment #3 from Алексей Шилин  ---
Git commit 7d15dad5e427132758db178e45a6e4b7b5daeb0f by Алексей Шилин.
Committed on 09/07/2018 at 10:35.
Pushed by aleksejshilin into branch 'master'.

Don't show confirmation dialog for Trash action by default

Summary:
Dolphin and KIO default confirmation settings were not in sync: the former
defaults to not showing the dialog while the latter used to default to the
opposite.

This change resolves the inconsistency by adjusting KIO defaults.
FIXED-IN: 5.48

Test Plan:
  1. Create a new user account and log into it.
  2. Open Dolphin.
  3. Create a text file and hit Del. The confirmation dialog should *not*
 appear.
  4. Check that permanent deletion (Shift+Del) and emptying the Trash still
 show the confirmation dialog.

Reviewers: dfaure, #frameworks, #dolphin, ngraham

Reviewed By: dfaure, #dolphin, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D13921

M  +6-3src/widgets/jobuidelegate.cpp

https://commits.kde.org/kio/7d15dad5e427132758db178e45a6e4b7b5daeb0f

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 380287] Breadcrumb drop-down items are sometimes accidentally activated

2018-02-23 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=380287

Алексей Шилин  changed:

   What|Removed |Added

   Assignee|dolphin-bugs-n...@kde.org   |fa...@kde.org
Product|dolphin |frameworks-kio
 CC||kdelibs-b...@kde.org
  Component|bars: location  |general

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 380287] Breadcrumb drop-down items are sometimes accidentally activated

2018-02-23 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=380287

--- Comment #2 from Алексей Шилин  ---
(In reply to Nate Graham from comment #1)
> Didn't you submit a patch for this?

I did. You've even tested it. :)

I originally (incorrectly) reported the bug against Dolphin, and now I just
reassigned it to KIO so that FIXED-IN tag works.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 380287] Breadcrumb drop-down items are sometimes accidentally activated

2018-02-23 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=380287

Алексей Шилин  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kio
   ||/4a6a3b81bedca043bbe2c620ce
   ||a296f9f69e5eea
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||5.44

--- Comment #4 from Алексей Шилин  ---
Git commit 4a6a3b81bedca043bbe2c620cea296f9f69e5eea by Алексей Шилин.
Committed on 23/02/2018 at 17:42.
Pushed by aleksejshilin into branch 'master'.

Fix unintentional breadcrumb menu item activation

Summary:
Since breadcrumb menu is opened on mouse press, it may receive
the corresponding mouse release event which may unintentionally
activate the random item which happens to be under mouse pointer.

This commit makes the menu ignore the first mouse release event
unless the pointer was moved. It fixes the issue and still allows
'Press mouse button' -> 'Move to an item' -> 'Release the button'
usage scenario.
FIXED-IN: 5.44

Reviewers: #frameworks, dfaure

Reviewed By: dfaure

Subscribers: broulik, ngraham

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D8958

M  +30   -6src/filewidgets/kurlnavigatormenu.cpp
M  +5-0src/filewidgets/kurlnavigatormenu_p.h

https://commits.kde.org/kio/4a6a3b81bedca043bbe2c620cea296f9f69e5eea

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio] [Bug 374907] No warning for insufficient space on target when copying

2018-03-04 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=374907

Алексей Шилин  changed:

   What|Removed |Added

 CC||rootl...@mail.ru

--- Comment #1 from Алексей Шилин  ---
(In reply to Saurav Sengupta from comment #0)
> the notification of copying finished that is shown is exactly the same as the 
> one for a complete, successful copy operation

Can't reproduce in current git master. The notification says that copying
failed, and there's also an error message in Dolphin window saying that disk is
full.

> I have experienced this with KIO version 5.28.0 using Dolphin 16.04.3 on 
> Plasma 5.8.5, but I could not find the KIO version on the list of versions 
> available for this bug report.

That's because it's old KDE4-era KIO. The new one is frameworks-kio.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 392765] Tooltips over window decoration buttons do not appear delayed

2018-04-22 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=392765

Алексей Шилин  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||5.13
  Latest Commit||https://commits.kde.org/kwi
   ||n/5a14b6a6a2a95d9ddf20aed62
   ||6854dae13553c12
 Resolution|--- |FIXED

--- Comment #2 from Алексей Шилин  ---
Git commit 5a14b6a6a2a95d9ddf20aed626854dae13553c12 by Алексей Шилин.
Committed on 22/04/2018 at 20:44.
Pushed by aleksejshilin into branch 'master'.

Improve tooltips behavior

Summary:
Window buttons tooltips used to appear on hover immediately. As
the result, they mostly appeared when not needed e.g. when user
was closing a window, or when the mouse pointer slightly touched
a button while being moved elsewhere.

This commit changes the tooltips behavior to WakeUp-FallAsleep
approach used by Widgets.
FIXED-IN: 5.13

Reviewers: #kwin, graesslin, broulik, #plasma

Reviewed By: #kwin, graesslin, #plasma

Subscribers: zzag, broulik, kwin, hein

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D12404

M  +16   -2decorations/decoratedclient.cpp
M  +6-0decorations/decoratedclient.h

https://commits.kde.org/kwin/5a14b6a6a2a95d9ddf20aed626854dae13553c12

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 360066] on reboot kate opens a lot of empty instances of itself

2018-04-02 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=360066

Алексей Шилин  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kat
   ||e/0a73e00e6dd78e0ad00c79e7e
   ||0a3caf71bf4f549
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||18.04

--- Comment #6 from Алексей Шилин  ---
Git commit 0a73e00e6dd78e0ad00c79e7e0a3caf71bf4f549 by Алексей Шилин.
Committed on 02/04/2018 at 16:10.
Pushed by aleksejshilin into branch 'Applications/18.04'.

Don't restart the blocking process on session restore

Summary:
All blocking Kate processes were restarted on session restore which
led to launching (possibly) multiple redundant instances.

This change asks the session manager to not restart such processes.

Note: QObject::connect() is used here because the session manager
can't be accessed directly according to the documentation [1]:

In Qt, session management requests for action are handled by
the two signals QGuiApplication::commitDataRequest() and
QGuiApplication::saveStateRequest(). Both provide a reference
to a QSessionManager object as argument. The session manager
can only be accessed in slots invoked by these signals.

 [1] http://doc.qt.io/qt-5/qsessionmanager.html#details
FIXED-IN: 18.04

Test Plan:
  0. Make sure that Plasma is configured to restore previous session
 on startup.
  1. Open Dolphin and create 'test1' and 'test2' text files.
  2. Open 'test1' in Kate from Dolphin.
  3. Open 'test2' in the already running Kate instance from Dolphin.
  4. Log out and back in. Check that there are no redundant Kate
 instances running.

Reviewers: #kate, dhaumann

Reviewed By: #kate, dhaumann

Subscribers: ngraham, dhaumann

Tags: #kate

Differential Revision: https://phabricator.kde.org/D11818

M  +12   -0kate/main.cpp

https://commits.kde.org/kate/0a73e00e6dd78e0ad00c79e7e0a3caf71bf4f549

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 380287] New: Breadcrumb drop-down items are sometimes accidentally activated

2017-05-28 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=380287

Bug ID: 380287
   Summary: Breadcrumb drop-down items are sometimes accidentally
activated
   Product: dolphin
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: bars: location
  Assignee: dolphin-bugs-n...@kde.org
  Reporter: rootl...@mail.ru
  Target Milestone: ---

Dear developers,

Breadcrumb drop-down items get unexpectedly activated when the list is big
enough.

Steps to reproduce:

 1. Open Dolphin and navigate to /usr/share/doc/dolphin/.
 2. Move Dolphin window to right-bottom screen corner.
 3. Open doc's breadcrumb.

Expected result:

 * Current directory remains /usr/share/doc/dolphin.

Actual result:

 * Current directory changes to some other doc's subfolder.

I guess, drop-down list placement is what causes the issue: when it's big
enough to not fit vertically (i.e. when Dolphin's window is small and is at the
bottom of the screen, and there are a lot of items in the drop-down), it is
moved up, and as a result becomes under mouse pointer, catches e.g. LMB Release
event and changes current directory to whichever happens to be under mouse
pointer.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 256561] Katepart scrolls per paragraph rather than what is set globally (e.g. 3 lines)

2017-10-16 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=256561

Алексей Шилин  changed:

   What|Removed |Added

 CC||rootl...@mail.ru

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 385947] New: First task's initial tooltip size is broken

2017-10-19 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=385947

Bug ID: 385947
   Summary: First task's initial tooltip size is broken
   Product: plasmashell
   Version: 5.11.1
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Task Manager
  Assignee: h...@kde.org
  Reporter: rootl...@mail.ru
CC: plasma-b...@kde.org
  Target Milestone: 1.0

Created attachment 108454
  --> https://bugs.kde.org/attachment.cgi?id=108454&action=edit
Screenshot which illustrates the issue

Hi,

Initial tooltip size for the first task in the task manager is broken (see the
attached screenshot).

Steps to reproduce the issue:

 1. Do a fresh login into Plasma desktop.

 2. Open a few windows *without touching the task manager* i.e. from the main
menu or the desktop.

 3. Hover the mouse over the first task in the task manager.

The issue persists until one hovers the mouse over any task other than the
first one.

I've also noticed that the incorrect tooltip size corresponds to the overall
number of tasks in the task manager, so the bug is probably somewhere in the
TasksModel in the org.kde.taskmanager module, which erroneously returns all
tasks instead of the selected group's ones; given that it stops doing so after
one hovers a different task, the bug is probably caused by an uninialized
variable somewhere. It's just a wild guess though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 371249] Buttons are aligned incorrectly on logout screen with russian language

2017-10-21 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=371249

--- Comment #6 from Алексей Шилин  ---
(In reply to Christoph Feck from comment #5)
> Алексей, could you submit the patch using
> https://phabricator.kde.org/differential/diff/create/ for review? Use Plasma
> group as reviewers.

Done.

https://phabricator.kde.org/D8397

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 311597] the save bar resizes the window beyond measure after exiting the fullscreen mode

2017-09-11 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=311597

Алексей Шилин  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|UNCONFIRMED

--- Comment #2 from Алексей Шилин  ---
(In reply to Nate Graham from comment #1)
> I'm not able to reproduce this in Gwenview 17..11.70. Looks fixed.

Unfortunately, I have just successfully reproduced the issue in Gwenview
17.11.70. The steps are pretty much the same:

  1. Switch to Russian locale (it contains localization strings which are
longer than the English ones, so the issue is more visible there).

  2. Open an image in Gwenview.

  3. Switch to fullscreen mode.

  4. Rotate the image, switch to the next one, rotate it too.

  5. Exit the fullscreen mode.

I've attached two screenshots: before switching to fullscreen mode, and after
completing the steps above and return from fullscreen mode. The window got
resized to 1623x801 from its original size and thus went beyond the screen.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 311597] the save bar resizes the window beyond measure after exiting the fullscreen mode

2017-09-11 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=311597

--- Comment #3 from Алексей Шилин  ---
Created attachment 107799
  --> https://bugs.kde.org/attachment.cgi?id=107799&action=edit
Gwenview screenshot before switching to the fullscreen mode

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 311597] the save bar resizes the window beyond measure after exiting the fullscreen mode

2017-09-11 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=311597

--- Comment #4 from Алексей Шилин  ---
Created attachment 107800
  --> https://bugs.kde.org/attachment.cgi?id=107800&action=edit
Gwenview screenshot after switching back from the fullscreen mode

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 364677] Dolphin hangs during sftp url access

2017-10-03 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=364677

Алексей Шилин  changed:

   What|Removed |Added

 CC||rootl...@mail.ru

--- Comment #7 from Алексей Шилин  ---
Same here. I'm using version 16.08.3, but also tested 17.08.1, and the bug
still exists.

Also, the dolphin process, which is used to open the sftp:/ URL, most of the
time doesn't quit when its window is closed and remains running until I kill it
(or all its sftp.so KIO processes) manually.

Neither of these happens with other KDE Applications and sftp:/ URLs, so it's
clearly Dolphin's fault.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 385336] New: Minimap doesn't display cyrillic characters

2017-10-03 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=385336

Bug ID: 385336
   Summary: Minimap doesn't display cyrillic characters
   Product: kate
   Version: Git
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: part
  Assignee: kwrite-bugs-n...@kde.org
  Reporter: rootl...@mail.ru
  Target Milestone: ---

Created attachment 108149
  --> https://bugs.kde.org/attachment.cgi?id=108149&action=edit
Screenshot illustrating the cyrillic characters display issue in Kate minimap

Hi,

Kate part minimap doesn't display cyrillic (and probably other non-latin)
characters. See the attached screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 371249] Buttons are aligned incorrectly on logout screen with russian language

2017-10-04 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=371249

Алексей Шилин  changed:

   What|Removed |Added

 CC||rootl...@mail.ru

--- Comment #1 from Алексей Шилин  ---
I can confirm this bug.

Indeed, it's caused by QML Layout alignment being Qt.AlignVCenter by default,
and becomes visible when LogoutButton text label splits into several rows.

A trivial one-liner fixes the issue (see the attachments).

P.S. I guess, this bug should have been reported against Product: plasmashell /
Component: Look & Feel package.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 371249] Buttons are aligned incorrectly on logout screen with russian language

2017-10-04 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=371249

--- Comment #2 from Алексей Шилин  ---
Created attachment 108166
  --> https://bugs.kde.org/attachment.cgi?id=108166&action=edit
Logout screen buttons alignment before applying the proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 371249] Buttons are aligned incorrectly on logout screen with russian language

2017-10-04 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=371249

--- Comment #3 from Алексей Шилин  ---
Created attachment 108167
  --> https://bugs.kde.org/attachment.cgi?id=108167&action=edit
Proposed patch which fixes logout screen buttons alignment

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 371249] Buttons are aligned incorrectly on logout screen with russian language

2017-10-04 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=371249

--- Comment #4 from Алексей Шилин  ---
Created attachment 108168
  --> https://bugs.kde.org/attachment.cgi?id=108168&action=edit
Logout screen buttons alignment after applying the proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 385472] New: Incorrect indentation in nested 'if' statements

2017-10-07 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=385472

Bug ID: 385472
   Summary: Incorrect indentation in nested 'if' statements
   Product: frameworks-ktexteditor
   Version: 5.38.0
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kwrite-bugs-n...@kde.org
  Reporter: rootl...@mail.ru
  Target Milestone: ---

Hi,

In the following C code the last 'else' is indented incorrectly:

int f()
{
if (1)
if (1)
f();
else
f();
else <-- Should be one indentation level lower

The same is true for JavaScript (and hence QML):

function f() {
if (true)
if (true)
f();
else
f();
else

Other languages were not tested.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 385492] New: Dolphin and KIO confirmation settings are not in sync

2017-10-08 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=385492

Bug ID: 385492
   Summary: Dolphin and KIO confirmation settings are not in sync
   Product: dolphin
   Version: 17.08.1
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: dolphin-bugs-n...@kde.org
  Reporter: rootl...@mail.ru
CC: elvis.angelac...@kde.org
  Target Milestone: ---

Hi,

There is a 'ConfirmTrash' configuration option which has different default
values in Dolphin and in KIO: the former defaults to asking for confirmation
when items are moved to trash, while the latter defaults to the opposite [1].
This leads to a weird behavior when the corresponding configuration file
doesn't exist (i.e. when user hasn't modified any of these settings yet):
Dolphin has its 'Ask for confirmation when: Moving files or folders to trash'
option unchecked, but actually *does* ask for confirmation (and other
applications like Gwenview etc., too); however, after user modifies a
completely unrelated Dolphin setting (disables the Trash size limit, for
example), this behavior unexpectedly changes to no confirmation (because
Dolphin creates the configuration file with its own defaults).

 [1] https://github.com/KDE/kio/blob/master/src/widgets/jobuidelegate.cpp#L203

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 385493] New: Number of processes is not updated when not on the 'Process Table' tab

2017-10-08 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=385493

Bug ID: 385493
   Summary: Number of processes is not updated when not on the
'Process Table' tab
   Product: ksysguard
   Version: 5.11.0
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: ksysguard
  Assignee: ksysguard-b...@kde.org
  Reporter: rootl...@mail.ru
  Target Milestone: ---

Hi,

When not on the 'Process Table' tab, the number of processes in the status bar
is not updated.

For example, when the application starts with the 'System Load' tab active by
default, the number of processes remains 0 until one switches to the 'Process
Table' tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 385492] Dolphin and KIO confirmation settings are not in sync

2017-10-08 Thread Алексей Шилин
https://bugs.kde.org/show_bug.cgi?id=385492

--- Comment #1 from Алексей Шилин  ---
(In reply to Алексей Шилин from comment #0)
> There is a 'ConfirmTrash' configuration option which has different default
> values in Dolphin and in KIO: the former defaults to asking for confirmation
> when items are moved to trash, while the latter defaults to the opposite

There is a typo: it should have been 'the former defaults to *not* asking for
confirmation when items are moved to trash, while the latter defaults to the
opposite'.

-- 
You are receiving this mail because:
You are watching all bug changes.