[GitHub] maven-surefire issue #166: Support filtering of tests from Base Class (TestN...

2017-12-11 Thread krmahadevan
Github user krmahadevan commented on the issue:

https://github.com/apache/maven-surefire/pull/166
  
@Tibor17 - Looks like a lot of things changed. Now after rebasing off of 
master, I dont even get IntelliJ to recognize the test classes that I added. So 
not sure what is going on there. 

With respect to the formatting, I have tried importing into the IDE and 
applying it. But not sure if its actually changing the format.

I had a lot of time at my hand when I raised this PR back in October, but 
now I am currently tied up with a lot of stuff at work. So I am not sure when I 
am gonna get to this. 


---


[GitHub] maven-surefire issue #166: Support filtering of tests from Base Class (TestN...

2017-12-13 Thread krmahadevan
Github user krmahadevan commented on the issue:

https://github.com/apache/maven-surefire/pull/166
  
@Tibor17 - I am not sure why it failed. I can't seem to tie down my changes 
to this failure.


---


[GitHub] maven-surefire pull request #166: Support filtering of tests from Base Class...

2017-12-14 Thread krmahadevan
Github user krmahadevan closed the pull request at:

https://github.com/apache/maven-surefire/pull/166


---


[GitHub] maven-surefire issue #166: Support filtering of tests from Base Class (TestN...

2017-12-14 Thread krmahadevan
Github user krmahadevan commented on the issue:

https://github.com/apache/maven-surefire/pull/166
  
Changeset has been merged as part of 
https://github.com/apache/maven-surefire/commit/39acb98a94242149b5a8374a9619eb06f6b3cb6d

Closing this PR. 

@Tibor17 thanks for helping me with this PR.


---