[jira] [Created] (MJLINK-83) Allow adding multiple launchers to a jlink'ed image

2024-03-23 Thread Peter Hull (Jira)
Peter Hull created MJLINK-83:


 Summary: Allow adding multiple launchers to a jlink'ed image
 Key: MJLINK-83
 URL: https://issues.apache.org/jira/browse/MJLINK-83
 Project: Maven JLink Plugin
  Issue Type: Improvement
Affects Versions: 3.2.0
 Environment: (applies to all platforms)
Reporter: Peter Hull


The {{jlink}} command line tool allows the {{--launcher}} argument to be 
specified multiple times to create multiple launcher scripts in the image. 
However the maven plugin only passes on one {{}} element from its 
configuration section to the tool. If multiple are specified, the last one 
takes precedence. I would like to improve this so the plugin will pass multiple 
launcher specs on to the {{jlink}} tool. I suggest the config should look like:
{noformat}
command=module/main{noformat}
(as before, for backward compatibility and the common case where there is only 
one)

or

 
{noformat}

 command1=module1/main1
 command2=module2/main2
 ...

{noformat}
 

where {{}} can contain zero or more {{}} elements with the 
same syntax as the existing element.

One remaining question - what do do if the config specifies both  
{{}} and {{}} - combine the two or signal an error?

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MJLINK-83) Allow adding multiple launchers to a jlink'ed image

2024-03-23 Thread Peter Hull (Jira)


[ 
https://issues.apache.org/jira/browse/MJLINK-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830039#comment-17830039
 ] 

Peter Hull commented on MJLINK-83:
--

I have implemented this myself as it was a very small change

[https://github.com/pedro-w/maven-jlink-plugin/commit/195eac10f5146da37128ba5d26b631b32eba818d]

I can submit as a PR if this is deemed useful

> Allow adding multiple launchers to a jlink'ed image
> ---
>
> Key: MJLINK-83
> URL: https://issues.apache.org/jira/browse/MJLINK-83
> Project: Maven JLink Plugin
>  Issue Type: Improvement
>Affects Versions: 3.2.0
> Environment: (applies to all platforms)
>Reporter: Peter Hull
>Priority: Minor
>
> The {{jlink}} command line tool allows the {{--launcher}} argument to be 
> specified multiple times to create multiple launcher scripts in the image. 
> However the maven plugin only passes on one {{}} element from its 
> configuration section to the tool. If multiple are specified, the last one 
> takes precedence. I would like to improve this so the plugin will pass 
> multiple launcher specs on to the {{jlink}} tool. I suggest the config should 
> look like:
> {noformat}
> command=module/main{noformat}
> (as before, for backward compatibility and the common case where there is 
> only one)
> or
>  
> {noformat}
> 
>  command1=module1/main1
>  command2=module2/main2
>  ...
> 
> {noformat}
>  
> where {{}} can contain zero or more {{}} elements with 
> the same syntax as the existing element.
> One remaining question - what do do if the config specifies both  
> {{}} and {{}} - combine the two or signal an error?
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MPIR-471) NoSuchMethodError when running from mvn site

2024-11-20 Thread Peter Hull (Jira)
Peter Hull created MPIR-471:
---

 Summary: NoSuchMethodError when running from mvn site
 Key: MPIR-471
 URL: https://issues.apache.org/jira/browse/MPIR-471
 Project: Maven Project Info Reports Plugin
  Issue Type: Bug
  Components: plugins
Affects Versions: 3.8.0, 3.7.0
 Environment: Windows 11 professional, JDK21, Apache Maven 3.9.9
Reporter: Peter Hull
 Attachments: modified-pom.xml, original-pom.xml

If I run {{mvn site }}I get an error which looks like it comes from this plugin.
{noformat}
[INFO] Generating "Maven Coordinates" report --- 
maven-project-info-reports-plugin:3.8.0:dependency-info
[WARNING] An issue has occurred with 
maven-project-info-reports-plugin:3.8.0:dependency-info report, skipping 
LinkageError 'void org.apache.maven.doxia.sink.Sink.verbatim()', please report 
an issue to Maven dev team.
java.lang.NoSuchMethodError: 'void org.apache.maven.doxia.sink.Sink.verbatim()'
    at org.apache.maven.reporting.AbstractMavenReportRenderer.verbatimText 
(AbstractMavenReportRenderer.java:346)
    at 
org.apache.maven.report.projectinfo.DependencyInformationReport$DependencyInformationRenderer.renderDependencyInfo
 (DependencyInformationReport.java:217)
 {noformat}
I've got a minimal pom.xml which will do this (attached)

I can prevent the error by adding to that POM:
{noformat}



org.apache.maven.plugins
maven-project-info-reports-plugin
3.6.2



{noformat}
I'm not a maven expert but happy to provide more info as required.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPIR-471) NoSuchMethodError when running from mvn site

2024-11-20 Thread Peter Hull (Jira)


[ 
https://issues.apache.org/jira/browse/MPIR-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899731#comment-17899731
 ] 

Peter Hull commented on MPIR-471:
-

Thanks for the swift resolution. To help anyone else, this needs to be done in 
the  section and not (as I originally tried) in the  section.

This worked for me
{noformat}
    
        
            
                org.apache.maven.plugins
                maven-site-plugin
                3.21.0
            

        
    {noformat}

> NoSuchMethodError when running from mvn site
> 
>
> Key: MPIR-471
> URL: https://issues.apache.org/jira/browse/MPIR-471
> Project: Maven Project Info Reports Plugin
>  Issue Type: Bug
>  Components: plugins
>Affects Versions: 3.7.0, 3.8.0
> Environment: Windows 11 professional, JDK21, Apache Maven 3.9.9
>Reporter: Peter Hull
>Priority: Major
> Attachments: modified-pom.xml, original-pom.xml
>
>
> If I run {{mvn site }}I get an error which looks like it comes from this 
> plugin.
> {noformat}
> [INFO] Generating "Maven Coordinates" report --- 
> maven-project-info-reports-plugin:3.8.0:dependency-info
> [WARNING] An issue has occurred with 
> maven-project-info-reports-plugin:3.8.0:dependency-info report, skipping 
> LinkageError 'void org.apache.maven.doxia.sink.Sink.verbatim()', please 
> report an issue to Maven dev team.
> java.lang.NoSuchMethodError: 'void 
> org.apache.maven.doxia.sink.Sink.verbatim()'
>     at org.apache.maven.reporting.AbstractMavenReportRenderer.verbatimText 
> (AbstractMavenReportRenderer.java:346)
>     at 
> org.apache.maven.report.projectinfo.DependencyInformationReport$DependencyInformationRenderer.renderDependencyInfo
>  (DependencyInformationReport.java:217)
>  {noformat}
> I've got a minimal pom.xml which will do this (attached)
> I can prevent the error by adding to that POM:
> {noformat}
> 
> 
> 
> org.apache.maven.plugins
> maven-project-info-reports-plugin
> 3.6.2
> 
> 
> 
> {noformat}
> I'm not a maven expert but happy to provide more info as required.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)