[jira] Created: (MNG-4648) Aa a user I would like to see better error reporting from DefaultPluginRealmCache#pluginHashCode method

2010-04-27 Thread Ivica Loncar (JIRA)
Aa a user I would like to see better error reporting from 
DefaultPluginRealmCache#pluginHashCode method
---

 Key: MNG-4648
 URL: http://jira.codehaus.org/browse/MNG-4648
 Project: Maven 2 & 3
  Issue Type: Improvement
  Components: Settings
Reporter: Ivica Loncar
Priority: Minor


As a user i would like to see better error reporting from 
DefaultPluginRealmCache#pluginHashCode method

Currently it calculates hash value based on a dependency metadata, but if I 
omit version it fails with NullPointer exception.

It would be more user friendly to validate metadata prior to calculating hash 
value and to display more meaningful error to the end user.

Test scenario:
 - configure plugin and create dependencies
 - add dependency but DO NOT specify version
 - run maven such that plugin is invoked
maven will fail without reporting which dependency doesn't have version

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Created: (DOXIA-396) validation message is lost for the end user

2010-06-12 Thread Ivica Loncar (JIRA)
validation message is lost for the end user
---

 Key: DOXIA-396
 URL: http://jira.codehaus.org/browse/DOXIA-396
 Project: Maven Doxia
  Issue Type: Bug
  Components: Book
Affects Versions: 1.1.3
 Environment: windows, mvn2, mvn3
Reporter: Ivica Loncar


When doxia validates invalid configuration file (for example chapter id is 
missing) validator adds correct message ("Each chapter has to have an id." ) to 
the list of errors.
Unfortunately this helpful message is lost for the end user and all she sees is:

{noformat}
[ERROR] Failed to execute goal 
org.apache.maven.doxia:doxia-maven-plugin:1.1.3:render-books (default-cli) on 
project XYZ
: Error while generating book in format 'pdf'. Invalid book descriptor. -> 
[Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.doxia:doxia-maven-plugin:1.1.3:render-books
(default-cli) on project B24ZiiscB2GDocumentation: Error while generating book 
in format 'pdf'.
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:570)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:317)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:247)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:104)
at 
org.sonatype.maven.shell.maven.MavenSystemImpl$MavenRuntimeImpl.doExecute(MavenSystemImpl.java:476)
at 
org.sonatype.maven.shell.maven.MavenSystemImpl$MavenRuntimeImpl.execute(MavenSystemImpl.java:252)
at 
org.sonatype.maven.shell.commands.maven.MavenCommand.execute(MavenCommand.java:425)
at 
org.sonatype.gshell.execute.CommandExecutorImpl.execute(CommandExecutorImpl.java:175)
at 
org.sonatype.gshell.parser.impl.visitor.ExecutingVisitor.visit(ExecutingVisitor.java:95)
at 
org.sonatype.gshell.parser.impl.ASTExpression.jjtAccept(ASTExpression.java:18)
at 
org.sonatype.gshell.parser.impl.SimpleNode.childrenAccept(SimpleNode.java:65)
at 
org.sonatype.gshell.parser.impl.visitor.ExecutingVisitor.visit(ExecutingVisitor.java:75)
at 
org.sonatype.gshell.parser.impl.ASTCommandLine.jjtAccept(ASTCommandLine.java:18)
at 
org.sonatype.gshell.parser.CommandLineParserImpl$1.execute(CommandLineParserImpl.java:68)
at 
org.sonatype.gshell.execute.CommandExecutorImpl.execute(CommandExecutorImpl.java:91)
at org.sonatype.gshell.shell.ShellImpl.execute(ShellImpl.java:215)
at org.sonatype.gshell.shell.ShellImpl$1$1.doExecute(ShellImpl.java:246)
at org.sonatype.gshell.console.ConsoleTask.execute(ConsoleTask.java:108)
at org.sonatype.gshell.console.Console.work(Console.java:198)
at org.sonatype.gshell.console.Console.run(Console.java:135)
at org.sonatype.gshell.shell.ShellImpl.run(ShellImpl.java:293)
at org.sonatype.gshell.MainSupport.boot(MainSupport.java:279)
at org.sonatype.maven.shell.Main.main(Main.java:67)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.sonatype.gshell.launcher.Launcher.launch(Launcher.java:76)
at org.sonatype.gshell.launcher.Launcher.run(Launcher.java:48)
at org.sonatype.gshell.launcher.Launcher.main(Launcher.java:39)
Caused by: org.apache.maven.plugin.MojoExecutionException: Error while 
generating book in format 'pdf'.
at 
org.apache.maven.doxia.plugin.DoxiaRenderBooksMojo.execute(DoxiaRenderBooksMojo.java:270)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:105)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:562)
... 29 more
Caused by: org.apache.maven.doxia.book.InvalidBookDescriptorException: Invalid 
book descriptor.
at 
org.apache.maven.doxia.book.DefaultBookDoxia.renderBook(DefaultBookDoxia.java:100)
at 
org.apache.maven.doxia.plugin.DoxiaRenderBooksMojo.execute(DoxiaRenderBooksMojo.java:265)
... 31 more
{noformat}

Example of invalid configuration:

{code:xml}

http://maven.apache.org/BOOK/1.0.0"; 
xmlns:xsi="htt//www.w3.org/2001/XMLSchema-instance" >
  B2GServiceBook
  Ivica Loncar
  B2G servis
  

  Uvod
  

  Uvod
  b2g/uvod.apt

  

  

{code}

The validation failure message is most helpful and it should be presented to 
the user.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more

[jira] (MDEP-271) Allow for an empty prefix on dependency:build-classpath

2013-09-25 Thread Ivica Loncar (JIRA)

 [ 
https://jira.codehaus.org/browse/MDEP-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivica Loncar updated MDEP-271:
--

Attachment: MDEP-271.diff

Takes into account prefix and file separator properties.

Additionally, introduce useAbsolutePaths property. 

IMPORTANT: Introduction of new property will NOT break existing projects that 
rely on previous beahaviour (where outputAbsoluteArtifactFilename was set to 
false, but full path was returned). Otherwise we could reuse existing property 
and break existing builds.


> Allow for an empty prefix on dependency:build-classpath
> ---
>
> Key: MDEP-271
> URL: https://jira.codehaus.org/browse/MDEP-271
> Project: Maven Dependency Plugin
>  Issue Type: Improvement
>  Components: build-classpath
>Affects Versions: 2.1
>Reporter: Andreas Sewe
> Attachments: MDEP-271.diff
>
>
> At the moment it is impossible to configure an *empty* prefix (classpath 
> should contain just the artifact filenames, no paths) with 
> {{dependency:build-classpath}}. Using an empty {{}} is the same as a 
> non-existent {{}}; all paths within the classpath are w.r.t. to the 
> local repository (the default configuration). Setting {{mdep.prefix}} to an 
> empty string as a workaround doesn't work either; you still get a leading 
> slash for a path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MDEP-271) Allow for an empty prefix on dependency:build-classpath

2013-09-25 Thread Ivica Loncar (JIRA)

[ 
https://jira.codehaus.org/browse/MDEP-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=333261#comment-333261
 ] 

Ivica Loncar commented on MDEP-271:
---

This allows us to create Ignore-Scanning-Archives MANIFEST.MF header  used by 
some containers (IBM websphere?):

{code}

org.apache.maven.plugins
maven-dependency-plugin
2.8




build-classpath


generate-resources


false

was.ignorescan.archives

runtime
, 





{code}

{code}

org.apache.maven.plugins
maven-war-plugin
2.1.1




true



${project.version}

org.springframework.ejb.interceptor, 
org.springframework, com.google, hr.ispcard, 
hr.pbzcard

${was.ignorescan.archives}




{code}


In order to make m2e happy:

{code}




org.eclipse.m2e

lifecycle-mapping
1.0.0








org.apache.maven.plugins

maven-dependency-plugin

[2.8,)



build-classpath








false












{code}


> Allow for an empty prefix on dependency:build-classpath
> ---
>
> Key: MDEP-271
> URL: https://jira.codehaus.org/browse/MDEP-271
> Project: Maven Dependency Plugin
>  Issue Type: Improvement
>  Components: build-classpath
>Affects Versions: 2.1
>Reporter: Andreas Sewe
> Attachments: MDEP-271.diff
>
>
> At the moment it is impossible to configure an *empty* prefix (classpath 
> should contain just the artifact filenames, no paths) with 
> {{dependency:build-classpath}}. Using an empty {{}} is the same as a 
> non-existent {{}}; all paths within the classpath are w.r.t. to the 
> local repository (the default configuration). Setting {{mdep.prefix}} to an 

[jira] (MDEP-271) Allow for an empty prefix on dependency:build-classpath

2013-09-25 Thread Ivica Loncar (JIRA)

[ 
https://jira.codehaus.org/browse/MDEP-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=333261#comment-333261
 ] 

Ivica Loncar edited comment on MDEP-271 at 9/25/13 6:36 AM:


This allows us to create Ignore-Scanning-Archives MANIFEST.MF header  used by 
some containers (IBM websphere?):

{code}

org.apache.maven.plugins
maven-dependency-plugin
2.8




build-classpath


generate-resources


false

was.ignorescan.archives

runtime
, 





{code}

{code}

org.apache.maven.plugins
maven-war-plugin
2.1.1




true



${project.version}

org.springframework.ejb.interceptor, 
org.springframework, com.google, hr.ispcard, 
hr.pbzcard

${was.ignorescan.archives}




{code}


In order to make m2e happy:

{code}




org.eclipse.m2e

lifecycle-mapping
1.0.0








org.apache.maven.plugins

maven-dependency-plugin

[2.8,)



build-classpath








false












{code}


The result should be MANIFEST.MF that has entries like:
{code}
Build-Jdk: 1.7.0_07
Ignore-Scanning-Archives: xmlpull-1.1.3.1.jar,xpp3_min-1.1.4c.jar,disp
 laytag-1.2.jar,cglib-2.2.2.jar,drools-core-5.2.1.Final.jar,jquery-1.1
 0.2.jar,spring-security-config-3.1.3.RELEASE.jar,xstream-1.4.2.jar,sp
{code}


  was (Author: iloncar):
This allows us to create Ignore-Scanning-Archives MANIFEST.MF header  used 
by some containers (IBM websphere?):

{code}

org.apache.maven.plugins
maven-dependency-plugin
2.8