[jira] Created: (SCM-606) UnsupportedOperationException on blame GIT
UnsupportedOperationException on blame GIT
--
Key: SCM-606
URL: http://jira.codehaus.org/browse/SCM-606
Project: Maven SCM
Issue Type: Wish
Components: maven-scm-provider-git
Affects Versions: 1.4
Reporter: Fabien Bousquet
Priority: Minor
Attachments: GitBlame_UnsupportedOperationException.patch
Sometimes, running the blame command for GIT return an error for exit code. In
this case, Maven SCM throw an
UnsupportedOperationException :
{code}
Caused by: java.lang.UnsupportedOperationException
at
org.apache.maven.scm.provider.git.gitexe.command.blame.GitBlameCommand.executeBlameCommand(GitBlameCommand.java:46)
etc...
{code}
Is it possible to have the same way that others providers (SVN or TFS for
example) which is to return a
result (with a success to false) ?
In other word replace :
{code}
throw new UnsupportedOperationException();
{code}
by :
{code}
return new BlameScmResult(cl.toString(), "The git command failed.",
stderr.getOutput(), false);
{code}
Another reason is that we do not know that this UnsupportedOperationException
may be raised because is
a RuntimeException.
A similar problem : http://jira.codehaus.org/browse/SONARPLUGINS-618
Do you agree with that ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-606) UnsupportedOperationException on blame GIT
[
http://jira.codehaus.org/browse/SCM-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=255640#action_255640
]
Fabien Bousquet commented on SCM-606:
-
This feature (blame for gitexe) is already implemented (See
{code}org.apache.maven.scm.provider.git.gitexe.command.blame.GitBlameCommand{code})
. I use it already and it is operational.
Is what I'm wrong?
> UnsupportedOperationException on blame GIT
> --
>
> Key: SCM-606
> URL: http://jira.codehaus.org/browse/SCM-606
> Project: Maven SCM
> Issue Type: Wish
> Components: maven-scm-provider-git
>Affects Versions: 1.4
>Reporter: Fabien Bousquet
>Assignee: Mark Struberg
>Priority: Minor
> Attachments: GitBlame_UnsupportedOperationException.patch
>
>
> Sometimes, running the blame command for GIT return an error for exit code.
> In this case, Maven SCM throw an
> UnsupportedOperationException :
> {code}
> Caused by: java.lang.UnsupportedOperationException
> at
> org.apache.maven.scm.provider.git.gitexe.command.blame.GitBlameCommand.executeBlameCommand(GitBlameCommand.java:46)
> etc...
> {code}
> Is it possible to have the same way that others providers (SVN or TFS for
> example) which is to return a
> result (with a success to false) ?
> In other word replace :
> {code}
> throw new UnsupportedOperationException();
> {code}
> by :
> {code}
> return new BlameScmResult(cl.toString(), "The git command failed.",
> stderr.getOutput(), false);
> {code}
> Another reason is that we do not know that this UnsupportedOperationException
> may be raised because is
> a RuntimeException.
> A similar problem : http://jira.codehaus.org/browse/SONARPLUGINS-618
> Do you agree with that ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-606) UnsupportedOperationException on blame GIT
[
http://jira.codehaus.org/browse/SCM-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=255691#action_255691
]
Fabien Bousquet commented on SCM-606:
-
My configurations tested :
* git-1.7.3 on Windows Vista
* git-1.7.4 on Windows Vista
* git-1.7.0.4 on a Linux
For these configurations, blame output is split on tabulator character.
I test on GitHub projects.
> UnsupportedOperationException on blame GIT
> --
>
> Key: SCM-606
> URL: http://jira.codehaus.org/browse/SCM-606
> Project: Maven SCM
> Issue Type: Wish
> Components: maven-scm-provider-git
>Affects Versions: 1.4
>Reporter: Fabien Bousquet
>Assignee: Mark Struberg
>Priority: Minor
> Attachments: GitBlame_UnsupportedOperationException.patch
>
>
> Sometimes, running the blame command for GIT return an error for exit code.
> In this case, Maven SCM throw an
> UnsupportedOperationException :
> {code}
> Caused by: java.lang.UnsupportedOperationException
> at
> org.apache.maven.scm.provider.git.gitexe.command.blame.GitBlameCommand.executeBlameCommand(GitBlameCommand.java:46)
> etc...
> {code}
> Is it possible to have the same way that others providers (SVN or TFS for
> example) which is to return a
> result (with a success to false) ?
> In other word replace :
> {code}
> throw new UnsupportedOperationException();
> {code}
> by :
> {code}
> return new BlameScmResult(cl.toString(), "The git command failed.",
> stderr.getOutput(), false);
> {code}
> Another reason is that we do not know that this UnsupportedOperationException
> may be raised because is
> a RuntimeException.
> A similar problem : http://jira.codehaus.org/browse/SONARPLUGINS-618
> Do you agree with that ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-606) UnsupportedOperationException on blame GIT
[
http://jira.codehaus.org/browse/SCM-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=255767#action_255767
]
Fabien Bousquet commented on SCM-606:
-
Thanks !!!
I can't review now. So I will review and test tomorrow.
For difference between author and commiter, I don't understand. What is this
difference ?
For my case, I want the last developer which has modified the line (for each
line).
> UnsupportedOperationException on blame GIT
> --
>
> Key: SCM-606
> URL: http://jira.codehaus.org/browse/SCM-606
> Project: Maven SCM
> Issue Type: Wish
> Components: maven-scm-provider-git
>Affects Versions: 1.4
>Reporter: Fabien Bousquet
>Assignee: Mark Struberg
>Priority: Minor
> Attachments: GitBlame_UnsupportedOperationException.patch
>
>
> Sometimes, running the blame command for GIT return an error for exit code.
> In this case, Maven SCM throw an
> UnsupportedOperationException :
> {code}
> Caused by: java.lang.UnsupportedOperationException
> at
> org.apache.maven.scm.provider.git.gitexe.command.blame.GitBlameCommand.executeBlameCommand(GitBlameCommand.java:46)
> etc...
> {code}
> Is it possible to have the same way that others providers (SVN or TFS for
> example) which is to return a
> result (with a success to false) ?
> In other word replace :
> {code}
> throw new UnsupportedOperationException();
> {code}
> by :
> {code}
> return new BlameScmResult(cl.toString(), "The git command failed.",
> stderr.getOutput(), false);
> {code}
> Another reason is that we do not know that this UnsupportedOperationException
> may be raised because is
> a RuntimeException.
> A similar problem : http://jira.codehaus.org/browse/SONARPLUGINS-618
> Do you agree with that ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SCM-606) UnsupportedOperationException on blame GIT
[
http://jira.codehaus.org/browse/SCM-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabien Bousquet updated SCM-606:
Attachment: SCM606_bis.patch
> UnsupportedOperationException on blame GIT
> --
>
> Key: SCM-606
> URL: http://jira.codehaus.org/browse/SCM-606
> Project: Maven SCM
> Issue Type: Wish
> Components: maven-scm-provider-git
>Affects Versions: 1.4
>Reporter: Fabien Bousquet
>Assignee: Mark Struberg
>Priority: Minor
> Attachments: GitBlame_UnsupportedOperationException.patch,
> SCM606_bis.patch
>
>
> Sometimes, running the blame command for GIT return an error for exit code.
> In this case, Maven SCM throw an
> UnsupportedOperationException :
> {code}
> Caused by: java.lang.UnsupportedOperationException
> at
> org.apache.maven.scm.provider.git.gitexe.command.blame.GitBlameCommand.executeBlameCommand(GitBlameCommand.java:46)
> etc...
> {code}
> Is it possible to have the same way that others providers (SVN or TFS for
> example) which is to return a
> result (with a success to false) ?
> In other word replace :
> {code}
> throw new UnsupportedOperationException();
> {code}
> by :
> {code}
> return new BlameScmResult(cl.toString(), "The git command failed.",
> stderr.getOutput(), false);
> {code}
> Another reason is that we do not know that this UnsupportedOperationException
> may be raised because is
> a RuntimeException.
> A similar problem : http://jira.codehaus.org/browse/SONARPLUGINS-618
> Do you agree with that ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-606) UnsupportedOperationException on blame GIT
[
http://jira.codehaus.org/browse/SCM-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=255820#action_255820
]
Fabien Bousquet commented on SCM-606:
-
I have a problem with date and author which may be falses.
The header line (author, commitor etc...) is followed by the following
information at least once for *each commit* (See
http://www.kernel.org/pub/software/scm/git/docs/git-blame.html).
So when a release have already listed in blame output, date and author can be
falses.
I propose a patch which stores release informations (author and date) and uses
it when possible.
Mark, Could you review ?
> UnsupportedOperationException on blame GIT
> --
>
> Key: SCM-606
> URL: http://jira.codehaus.org/browse/SCM-606
> Project: Maven SCM
> Issue Type: Wish
> Components: maven-scm-provider-git
>Affects Versions: 1.4
>Reporter: Fabien Bousquet
>Assignee: Mark Struberg
>Priority: Minor
> Attachments: GitBlame_UnsupportedOperationException.patch
>
>
> Sometimes, running the blame command for GIT return an error for exit code.
> In this case, Maven SCM throw an
> UnsupportedOperationException :
> {code}
> Caused by: java.lang.UnsupportedOperationException
> at
> org.apache.maven.scm.provider.git.gitexe.command.blame.GitBlameCommand.executeBlameCommand(GitBlameCommand.java:46)
> etc...
> {code}
> Is it possible to have the same way that others providers (SVN or TFS for
> example) which is to return a
> result (with a success to false) ?
> In other word replace :
> {code}
> throw new UnsupportedOperationException();
> {code}
> by :
> {code}
> return new BlameScmResult(cl.toString(), "The git command failed.",
> stderr.getOutput(), false);
> {code}
> Another reason is that we do not know that this UnsupportedOperationException
> may be raised because is
> a RuntimeException.
> A similar problem : http://jira.codehaus.org/browse/SONARPLUGINS-618
> Do you agree with that ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-606) UnsupportedOperationException on blame GIT
[
http://jira.codehaus.org/browse/SCM-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=255935#action_255935
]
Fabien Bousquet commented on SCM-606:
-
I added an assert in test in SCM606_bis.patch for show the bug.
For test on git-blame.out, on line 27 (of source file), it's :
{code}
e670863b2b03e158c59f34af1fee20f91b2bd852 27 26 4
import org.apache.maven.scm.ScmVersion;
{code}
The author+committer infos are NOT repeated because of "followed by the
following information at least once for each commit".
So, I agree with you when 'reuse' the info above, but when this information is
not repeated, these informations (commiter and release date) must be retrieve
in the previous blames lines.
> UnsupportedOperationException on blame GIT
> --
>
> Key: SCM-606
> URL: http://jira.codehaus.org/browse/SCM-606
> Project: Maven SCM
> Issue Type: Wish
> Components: maven-scm-provider-git
>Affects Versions: 1.4
>Reporter: Fabien Bousquet
>Assignee: Mark Struberg
>Priority: Minor
> Fix For: 1.5
>
> Attachments: GitBlame_UnsupportedOperationException.patch,
> SCM606_bis.patch
>
>
> Sometimes, running the blame command for GIT return an error for exit code.
> In this case, Maven SCM throw an
> UnsupportedOperationException :
> {code}
> Caused by: java.lang.UnsupportedOperationException
> at
> org.apache.maven.scm.provider.git.gitexe.command.blame.GitBlameCommand.executeBlameCommand(GitBlameCommand.java:46)
> etc...
> {code}
> Is it possible to have the same way that others providers (SVN or TFS for
> example) which is to return a
> result (with a success to false) ?
> In other word replace :
> {code}
> throw new UnsupportedOperationException();
> {code}
> by :
> {code}
> return new BlameScmResult(cl.toString(), "The git command failed.",
> stderr.getOutput(), false);
> {code}
> Another reason is that we do not know that this UnsupportedOperationException
> may be raised because is
> a RuntimeException.
> A similar problem : http://jira.codehaus.org/browse/SONARPLUGINS-618
> Do you agree with that ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-606) UnsupportedOperationException on blame GIT
[
http://jira.codehaus.org/browse/SCM-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=256795#action_256795
]
Fabien Bousquet commented on SCM-606:
-
Thanks Mark for this fix !
> UnsupportedOperationException on blame GIT
> --
>
> Key: SCM-606
> URL: http://jira.codehaus.org/browse/SCM-606
> Project: Maven SCM
> Issue Type: Wish
> Components: maven-scm-provider-git
>Affects Versions: 1.4
>Reporter: Fabien Bousquet
>Assignee: Mark Struberg
>Priority: Minor
> Fix For: 1.5
>
> Attachments: GitBlame_UnsupportedOperationException.patch,
> SCM606_bis.patch
>
>
> Sometimes, running the blame command for GIT return an error for exit code.
> In this case, Maven SCM throw an
> UnsupportedOperationException :
> {code}
> Caused by: java.lang.UnsupportedOperationException
> at
> org.apache.maven.scm.provider.git.gitexe.command.blame.GitBlameCommand.executeBlameCommand(GitBlameCommand.java:46)
> etc...
> {code}
> Is it possible to have the same way that others providers (SVN or TFS for
> example) which is to return a
> result (with a success to false) ?
> In other word replace :
> {code}
> throw new UnsupportedOperationException();
> {code}
> by :
> {code}
> return new BlameScmResult(cl.toString(), "The git command failed.",
> stderr.getOutput(), false);
> {code}
> Another reason is that we do not know that this UnsupportedOperationException
> may be raised because is
> a RuntimeException.
> A similar problem : http://jira.codehaus.org/browse/SONARPLUGINS-618
> Do you agree with that ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
