[jira] [Commented] (MEAR-217) Snapshot dependencies are not deleted from skinny WARs
[ https://issues.apache.org/jira/browse/MEAR-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15741559#comment-15741559 ] Fabian Schlier commented on MEAR-217: - Not that active here... My patch was provided over one year ago and was not integrated yet... > Snapshot dependencies are not deleted from skinny WARs > -- > > Key: MEAR-217 > URL: https://issues.apache.org/jira/browse/MEAR-217 > Project: Maven Ear Plugin > Issue Type: Bug >Reporter: Tamás Baráth > Fix For: more-investigation > > Attachments: jar-sample-one-1.0-20150825.210557-91.jar, > maven-ear-plugin.patch, test-project.zip > > > EAR plugin doesn't delete snapshot dependencies from skinny WARs if Maven has > downloaded that dependencies from a remote repository. The EAR contains the > files in library bundle directory and in WEB-INF/lib folder of the WARs as > well. > When snapshots are installed to local repository with 'mvn install' command, > the plugin works fine. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MEAR-217) Snapshot dependencies are not deleted from skinny WARs
[ https://issues.apache.org/jira/browse/MEAR-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745254#comment-15745254 ] Fabian Schlier commented on MEAR-217: - I think the patch is older than the GIT repo ;-) I submitted a PR, hopefully this works: https://github.com/apache/maven-plugins/pull/100 > Snapshot dependencies are not deleted from skinny WARs > -- > > Key: MEAR-217 > URL: https://issues.apache.org/jira/browse/MEAR-217 > Project: Maven Ear Plugin > Issue Type: Bug >Reporter: Tamás Baráth > Fix For: more-investigation > > Attachments: jar-sample-one-1.0-20150825.210557-91.jar, > maven-ear-plugin.patch, test-project.zip > > > EAR plugin doesn't delete snapshot dependencies from skinny WARs if Maven has > downloaded that dependencies from a remote repository. The EAR contains the > files in library bundle directory and in WEB-INF/lib folder of the WARs as > well. > When snapshots are installed to local repository with 'mvn install' command, > the plugin works fine. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MJAVADOC-362) aggregate-jar: javadoc build on multi-module maven project in parent pom does not aggreate classpath
[
https://issues.apache.org/jira/browse/MJAVADOC-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Schlier updated MJAVADOC-362:
Attachment: fix-reactor-dependencies-problem.patch
Patch which at least adds the already resolved dependencies to the classpath.
> aggregate-jar: javadoc build on multi-module maven project in parent pom does
> not aggreate classpath
>
>
> Key: MJAVADOC-362
> URL: https://issues.apache.org/jira/browse/MJAVADOC-362
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 2.9
> Environment: Ubuntu 12.04/quantal 64-bit
>Reporter: Thomas Pasch
> Attachments: fix-reactor-dependencies-problem.patch
>
>
> When building aggregated javadocs for a multi-module maven project in parent
> pom, maven-javadoc-plugin does not aggreate classpath. Maybe this is the same
> problem as reported as MJAVADOC-116 .
> You can see the the problem at https://bitbucket.org/nuclos/nuclos-api (git
> repository, branch master, commits *before*
> 2bda1542282a7bac52d0c929c51a4a0546583bcb).
> With commit 2bda1542282a7bac52d0c929c51a4a0546583bcb, I fixed the problem by
> hard-wiring the needed dependency into the parent pom (well, this is really a
> HACK).
> This is the actual output in the error case:
> {noformat}[...]
> Generating
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/target/apidocs/constant-values.html...
> Generating
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/target/apidocs/serialized-form.html...
> 134 warnings
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Nuclos API FAILURE [23.216s]
> [INFO] nuclos-rigid-api .. SKIPPED
> [INFO] nuclos-common-api . SKIPPED
> [INFO] nuclos-server-api . SKIPPED
> [INFO] nuclos-client-api . SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 23.380s
> [INFO] Finished at: Tue Mar 19 15:15:13 CET 2013
> [INFO] Final Memory: 15M/981M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:2.9:aggregate-jar
> (aggregate-jar) on project nuclos-api: MavenReportException: Error while
> creating archive:
> [ERROR] Exit code: 1 -
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/nuclos-common-api/src/main/java/org/nuclos/api/service/UserSettingsService.java:19:
> package javax.annotation.security does not exist
> [ERROR] import javax.annotation.security.RolesAllowed;
> [ERROR] ^
> [ERROR]
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/nuclos-common-api/src/main/java/org/nuclos/api/service/UserSettingsService.java:31:
> cannot find symbol
> [ERROR] symbol : class RolesAllowed
> [ERROR] location: interface org.nuclos.api.service.UserSettingsService
> [ERROR] @RolesAllowed("Login")
> [ERROR] ^
> [ERROR]
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/nuclos-common-api/src/main/java/org/nuclos/api/service/UserSettingsService.java:39:
> cannot find symbol
> [ERROR] symbol : class RolesAllowed
> [ERROR] location: interface org.nuclos.api.service.UserSettingsService
> [ERROR] @RolesAllowed("Login")
> [ERROR] ^
> [ERROR] javadoc: warning - Error fetching URL:
> http://commons.apache.org/lang/api-release/package-list
> [ERROR] javadoc: warning - Error fetching URL:
> http://commons.apache.org/collections/api-release/package-list
> [ERROR] javadoc: warning - Error fetching URL:
> http://commons.apache.org/dbcp/api-1.4/package-list
> [ERROR] javadoc: warning - Error fetching URL:
> http://commons.apache.org/codec/api-release/package-list
> [ERROR]
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/nuclos-common-api/src/main/java/org/nuclos/api/statemodel/State.java:12:
> warning - Tag @link: reference not found: StatemodelProvider
> [ERROR] java.lang.ClassCastException: com.sun.tools.javadoc.ClassDocImpl
> cannot be cast to com.sun.javadoc.AnnotationTypeDoc
> [ERROR] at
> com.sun.tools.javadoc.AnnotationDescImpl.annotationType(AnnotationDescImpl.java:46)
> [ERROR] at
> com.sun.tools.doclets.internal.toolkit.util.Util.isDeprecated(Util.java:811)
> [ERROR] at
> com.sun.tools.doclets.formats.html.SubWriterHolderWriter.printIndexComment(SubWriterHolderWriter.java:101)
> [ERROR] at
> com.sun.tools.doclets.formats.html.SubWriterHolderWriter.printSummaryLinkComment(SubWriterHolderWriter.java:137)
> [ERROR] at
> com.sun.tools.doclets.formats.html.A
[jira] [Comment Edited] (MJAVADOC-362) aggregate-jar: javadoc build on multi-module maven project in parent pom does not aggreate classpath
[
https://issues.apache.org/jira/browse/MJAVADOC-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644166#comment-14644166
]
Fabian Schlier edited comment on MJAVADOC-362 at 7/28/15 10:05 AM:
---
I created a patch which at least adds the already resolved dependencies to the
classpath.
If there are only reactor artifacty missing, all other resolved artifacts are
added to the classpath. There is no dependency resolution for the reactor
artifacts, but assuming that they are included as submodules by this aggregate
step, their dependencies will be added either.
This will not work if the aggregate steps runs in a lower position of a multi
layer pom inheritance structure and some of the referred artifacts or outside
of the current inheritance branch.
was (Author: fschlier):
Patch which at least adds the already resolved dependencies to the classpath.
> aggregate-jar: javadoc build on multi-module maven project in parent pom does
> not aggreate classpath
>
>
> Key: MJAVADOC-362
> URL: https://issues.apache.org/jira/browse/MJAVADOC-362
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 2.9
> Environment: Ubuntu 12.04/quantal 64-bit
>Reporter: Thomas Pasch
> Attachments: fix-reactor-dependencies-problem.patch
>
>
> When building aggregated javadocs for a multi-module maven project in parent
> pom, maven-javadoc-plugin does not aggreate classpath. Maybe this is the same
> problem as reported as MJAVADOC-116 .
> You can see the the problem at https://bitbucket.org/nuclos/nuclos-api (git
> repository, branch master, commits *before*
> 2bda1542282a7bac52d0c929c51a4a0546583bcb).
> With commit 2bda1542282a7bac52d0c929c51a4a0546583bcb, I fixed the problem by
> hard-wiring the needed dependency into the parent pom (well, this is really a
> HACK).
> This is the actual output in the error case:
> {noformat}[...]
> Generating
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/target/apidocs/constant-values.html...
> Generating
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/target/apidocs/serialized-form.html...
> 134 warnings
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Nuclos API FAILURE [23.216s]
> [INFO] nuclos-rigid-api .. SKIPPED
> [INFO] nuclos-common-api . SKIPPED
> [INFO] nuclos-server-api . SKIPPED
> [INFO] nuclos-client-api . SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 23.380s
> [INFO] Finished at: Tue Mar 19 15:15:13 CET 2013
> [INFO] Final Memory: 15M/981M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:2.9:aggregate-jar
> (aggregate-jar) on project nuclos-api: MavenReportException: Error while
> creating archive:
> [ERROR] Exit code: 1 -
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/nuclos-common-api/src/main/java/org/nuclos/api/service/UserSettingsService.java:19:
> package javax.annotation.security does not exist
> [ERROR] import javax.annotation.security.RolesAllowed;
> [ERROR] ^
> [ERROR]
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/nuclos-common-api/src/main/java/org/nuclos/api/service/UserSettingsService.java:31:
> cannot find symbol
> [ERROR] symbol : class RolesAllowed
> [ERROR] location: interface org.nuclos.api.service.UserSettingsService
> [ERROR] @RolesAllowed("Login")
> [ERROR] ^
> [ERROR]
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/nuclos-common-api/src/main/java/org/nuclos/api/service/UserSettingsService.java:39:
> cannot find symbol
> [ERROR] symbol : class RolesAllowed
> [ERROR] location: interface org.nuclos.api.service.UserSettingsService
> [ERROR] @RolesAllowed("Login")
> [ERROR] ^
> [ERROR] javadoc: warning - Error fetching URL:
> http://commons.apache.org/lang/api-release/package-list
> [ERROR] javadoc: warning - Error fetching URL:
> http://commons.apache.org/collections/api-release/package-list
> [ERROR] javadoc: warning - Error fetching URL:
> http://commons.apache.org/dbcp/api-1.4/package-list
> [ERROR] javadoc: warning - Error fetching URL:
> http://commons.apache.org/codec/api-release/package-list
> [ERROR]
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/nuclos-common-api/src/main/java/org/nuclos/api/statemodel/State.java:12:
> warning - Tag @link: reference not found: S
[jira] [Comment Edited] (MJAVADOC-362) aggregate-jar: javadoc build on multi-module maven project in parent pom does not aggreate classpath
[
https://issues.apache.org/jira/browse/MJAVADOC-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644166#comment-14644166
]
Fabian Schlier edited comment on MJAVADOC-362 at 7/28/15 10:06 AM:
---
I created a patch which at least adds the already resolved dependencies to the
classpath.
If there are only reactor artifact missing, all other resolved artifacts are
added to the classpath. There is no dependency resolution for the reactor
artifacts, but assuming that they are included as submodules by this aggregate
step, their dependencies will be added either.
This will not work if the aggregate steps runs in a lower position of a multi
layer pom inheritance structure and some of the referred artifacts or outside
of the current inheritance branch.
was (Author: fschlier):
I created a patch which at least adds the already resolved dependencies to the
classpath.
If there are only reactor artifacty missing, all other resolved artifacts are
added to the classpath. There is no dependency resolution for the reactor
artifacts, but assuming that they are included as submodules by this aggregate
step, their dependencies will be added either.
This will not work if the aggregate steps runs in a lower position of a multi
layer pom inheritance structure and some of the referred artifacts or outside
of the current inheritance branch.
> aggregate-jar: javadoc build on multi-module maven project in parent pom does
> not aggreate classpath
>
>
> Key: MJAVADOC-362
> URL: https://issues.apache.org/jira/browse/MJAVADOC-362
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 2.9
> Environment: Ubuntu 12.04/quantal 64-bit
>Reporter: Thomas Pasch
> Attachments: fix-reactor-dependencies-problem.patch
>
>
> When building aggregated javadocs for a multi-module maven project in parent
> pom, maven-javadoc-plugin does not aggreate classpath. Maybe this is the same
> problem as reported as MJAVADOC-116 .
> You can see the the problem at https://bitbucket.org/nuclos/nuclos-api (git
> repository, branch master, commits *before*
> 2bda1542282a7bac52d0c929c51a4a0546583bcb).
> With commit 2bda1542282a7bac52d0c929c51a4a0546583bcb, I fixed the problem by
> hard-wiring the needed dependency into the parent pom (well, this is really a
> HACK).
> This is the actual output in the error case:
> {noformat}[...]
> Generating
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/target/apidocs/constant-values.html...
> Generating
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/target/apidocs/serialized-form.html...
> 134 warnings
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Nuclos API FAILURE [23.216s]
> [INFO] nuclos-rigid-api .. SKIPPED
> [INFO] nuclos-common-api . SKIPPED
> [INFO] nuclos-server-api . SKIPPED
> [INFO] nuclos-client-api . SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 23.380s
> [INFO] Finished at: Tue Mar 19 15:15:13 CET 2013
> [INFO] Final Memory: 15M/981M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:2.9:aggregate-jar
> (aggregate-jar) on project nuclos-api: MavenReportException: Error while
> creating archive:
> [ERROR] Exit code: 1 -
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/nuclos-common-api/src/main/java/org/nuclos/api/service/UserSettingsService.java:19:
> package javax.annotation.security does not exist
> [ERROR] import javax.annotation.security.RolesAllowed;
> [ERROR] ^
> [ERROR]
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/nuclos-common-api/src/main/java/org/nuclos/api/service/UserSettingsService.java:31:
> cannot find symbol
> [ERROR] symbol : class RolesAllowed
> [ERROR] location: interface org.nuclos.api.service.UserSettingsService
> [ERROR] @RolesAllowed("Login")
> [ERROR] ^
> [ERROR]
> /var/lib/jenkins/jobs/nuclos-api-trunk/workspace/nuclos-common-api/src/main/java/org/nuclos/api/service/UserSettingsService.java:39:
> cannot find symbol
> [ERROR] symbol : class RolesAllowed
> [ERROR] location: interface org.nuclos.api.service.UserSettingsService
> [ERROR] @RolesAllowed("Login")
> [ERROR] ^
> [ERROR] javadoc: warning - Error fetching URL:
> http://commons.apache.org/lang/api-release/package-list
> [ERROR] javadoc: wa
[jira] [Commented] (MEAR-217) Snapshot dependencies are not deleted from skinny WARs
[
https://issues.apache.org/jira/browse/MEAR-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711145#comment-14711145
]
Fabian Schlier commented on MEAR-217:
-
Hi,
we encountered the same issue and isolated the faulty code causing the problem.
WIthin EarMojo the artifacts to be deleted are located via a check that calls
{code:title=EarMojo.java changeManifestClasspath() Line 827 |borderStyle=solid}
File artifact = new File(new File(workDirectory, module.getLibDir()),
jm.getOriginalBundleFileName());
{code}
and is the file is found, it is deleted. To solve issues with
timestamped/non-timestamped artifacts the file location check process should be
done twice, to allow the configured {{fileNameMapping}}/{{useBaseVersions}} to
be encountered. Code should look like this:
{code:title=EarMojo.java changeManifestClasspath()|borderStyle=solid}
File artifact = new File(new File(workDirectory, module.getLibDir()),
jm.getOriginalBundleFileName());
if (!artifact.exists())
{
// Check if we find the file when using configured naming policy
artifact = new File(new File(workDirectory, module.getLibDir()),
jm.getBundleFileName());
}
if (artifact.exists())
{
getLog().debug(" -> Artifact to delete: " + artifact);
if (!(artifact.delete()))
{
getLog().error("Could not delete '" + artifact + "'");
}
}
{code}
This would add some more flexibility for more complex scenarios.
Cheers,
Fabian
> Snapshot dependencies are not deleted from skinny WARs
> --
>
> Key: MEAR-217
> URL: https://issues.apache.org/jira/browse/MEAR-217
> Project: Maven Ear Plugin
> Issue Type: Bug
>Reporter: Tamás Baráth
> Fix For: more-investigation
>
> Attachments: test-project.zip
>
>
> EAR plugin doesn't delete snapshot dependencies from skinny WARs if Maven has
> downloaded that dependencies from a remote repository. The EAR contains the
> files in library bundle directory and in WEB-INF/lib folder of the WARs as
> well.
> When snapshots are installed to local repository with 'mvn install' command,
> the plugin works fine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MEAR-217) Snapshot dependencies are not deleted from skinny WARs
[
https://issues.apache.org/jira/browse/MEAR-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Schlier updated MEAR-217:
Attachment: maven-ear-plugin.patch
jar-sample-one-1.0-20150825.210557-91.jar
The patch including a IT (which was a bit tricky to build). The binary jar
needed is added separate and needs to be placed in
{{src/test/resources/m2snapshots/eartest/jar-sample-one/1.0-SNAPSHOT}}
> Snapshot dependencies are not deleted from skinny WARs
> --
>
> Key: MEAR-217
> URL: https://issues.apache.org/jira/browse/MEAR-217
> Project: Maven Ear Plugin
> Issue Type: Bug
>Reporter: Tamás Baráth
> Fix For: more-investigation
>
> Attachments: jar-sample-one-1.0-20150825.210557-91.jar,
> maven-ear-plugin.patch, test-project.zip
>
>
> EAR plugin doesn't delete snapshot dependencies from skinny WARs if Maven has
> downloaded that dependencies from a remote repository. The EAR contains the
> files in library bundle directory and in WEB-INF/lib folder of the WARs as
> well.
> When snapshots are installed to local repository with 'mvn install' command,
> the plugin works fine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (MEAR-217) Snapshot dependencies are not deleted from skinny WARs
[
https://issues.apache.org/jira/browse/MEAR-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713640#comment-14713640
]
Fabian Schlier edited comment on MEAR-217 at 8/26/15 3:16 PM:
--
The patch ({{maven-ear-plugin.patch}}) including a IT (which was a bit tricky
to build). The binary jar ({{jar-sample-one-1.0-20150825.210557-91.jar}})
needed is added separate and needs to be placed in
{{src/test/resources/m2snapshots/eartest/jar-sample-one/1.0-SNAPSHOT}}
was (Author: fschlier):
The patch ({{maven-ear-plugin.patch}}) including a IT (which was a bit tricky
to build). The binary jar needed is added separate and needs to be placed in
{{src/test/resources/m2snapshots/eartest/jar-sample-one/1.0-SNAPSHOT}}
> Snapshot dependencies are not deleted from skinny WARs
> --
>
> Key: MEAR-217
> URL: https://issues.apache.org/jira/browse/MEAR-217
> Project: Maven Ear Plugin
> Issue Type: Bug
>Reporter: Tamás Baráth
> Fix For: more-investigation
>
> Attachments: jar-sample-one-1.0-20150825.210557-91.jar,
> maven-ear-plugin.patch, test-project.zip
>
>
> EAR plugin doesn't delete snapshot dependencies from skinny WARs if Maven has
> downloaded that dependencies from a remote repository. The EAR contains the
> files in library bundle directory and in WEB-INF/lib folder of the WARs as
> well.
> When snapshots are installed to local repository with 'mvn install' command,
> the plugin works fine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (MEAR-217) Snapshot dependencies are not deleted from skinny WARs
[
https://issues.apache.org/jira/browse/MEAR-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713640#comment-14713640
]
Fabian Schlier edited comment on MEAR-217 at 8/26/15 3:15 PM:
--
The patch ({{maven-ear-plugin.patch}}) including a IT (which was a bit tricky
to build). The binary jar needed is added separate and needs to be placed in
{{src/test/resources/m2snapshots/eartest/jar-sample-one/1.0-SNAPSHOT}}
was (Author: fschlier):
The patch including a IT (which was a bit tricky to build). The binary jar
needed is added separate and needs to be placed in
{{src/test/resources/m2snapshots/eartest/jar-sample-one/1.0-SNAPSHOT}}
> Snapshot dependencies are not deleted from skinny WARs
> --
>
> Key: MEAR-217
> URL: https://issues.apache.org/jira/browse/MEAR-217
> Project: Maven Ear Plugin
> Issue Type: Bug
>Reporter: Tamás Baráth
> Fix For: more-investigation
>
> Attachments: jar-sample-one-1.0-20150825.210557-91.jar,
> maven-ear-plugin.patch, test-project.zip
>
>
> EAR plugin doesn't delete snapshot dependencies from skinny WARs if Maven has
> downloaded that dependencies from a remote repository. The EAR contains the
> files in library bundle directory and in WEB-INF/lib folder of the WARs as
> well.
> When snapshots are installed to local repository with 'mvn install' command,
> the plugin works fine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
